[INFO] crate ai 0.1.0 is already in cache [INFO] extracting crate ai 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/ai/0.1.0 [INFO] extracting crate ai 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ai/0.1.0 [INFO] validating manifest of ai-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ai-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ai-0.1.0 [INFO] finished frobbing ai-0.1.0 [INFO] frobbed toml for ai-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/ai/0.1.0/Cargo.toml [INFO] started frobbing ai-0.1.0 [INFO] finished frobbing ai-0.1.0 [INFO] frobbed toml for ai-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ai/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ai-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/ai/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] fbd43f2ba56db83c68b66be1bd967cc3978fbc9032549357ec3f79466e763b73 [INFO] running `"docker" "start" "-a" "fbd43f2ba56db83c68b66be1bd967cc3978fbc9032549357ec3f79466e763b73"` [INFO] [stderr] Checking ai v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/chromosome.rs:39:9 [INFO] [stderr] | [INFO] [stderr] 39 | fitness [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/chromosome.rs:38:23 [INFO] [stderr] | [INFO] [stderr] 38 | let fitness = 0.5f32 - ((mant - 0.5f32) / (1f32 + (0.001f32 * xy * xy))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `chromosome::Chromosome` [INFO] [stderr] --> src/chromosome.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | / pub fn new() -> Chromosome { [INFO] [stderr] 16 | | let mut rng = rand::thread_rng(); [INFO] [stderr] 17 | | let mut vec : Vec = Vec::new(); [INFO] [stderr] 18 | | for _ in 0..44 { [INFO] [stderr] ... | [INFO] [stderr] 21 | | Chromosome {genes: vec} [INFO] [stderr] 22 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 8 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/chromosome.rs:27:64 [INFO] [stderr] | [INFO] [stderr] 27 | let x: i32 = self.genes[0..22].iter().map(|x| x.pow(2)).fold(0i32, |sum, x| sum + x) -11i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `.sum()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_fold)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/chromosome.rs:28:65 [INFO] [stderr] | [INFO] [stderr] 28 | let y: i32 = self.genes[22..44].iter().map(|y| y.pow(2)).fold(0i32, |sum, y| sum + y) -11i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `.sum()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/chromosome.rs:55:22 [INFO] [stderr] | [INFO] [stderr] 55 | fn cross_over(indv1: &Vec, indv2: &Vec) -> Vec { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[i32]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/chromosome.rs:55:40 [INFO] [stderr] | [INFO] [stderr] 55 | fn cross_over(indv1: &Vec, indv2: &Vec) -> Vec { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[i32]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/chromosome.rs:39:9 [INFO] [stderr] | [INFO] [stderr] 39 | fitness [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/chromosome.rs:38:23 [INFO] [stderr] | [INFO] [stderr] 38 | let fitness = 0.5f32 - ((mant - 0.5f32) / (1f32 + (0.001f32 * xy * xy))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: value assigned to `new_indv` is never read [INFO] [stderr] --> src/chromosome.rs:139:17 [INFO] [stderr] | [INFO] [stderr] 139 | let mut new_indv = Vec::new(); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_assignments)] on by default [INFO] [stderr] [INFO] [stderr] warning: value assigned to `new_indv` is never read [INFO] [stderr] --> src/chromosome.rs:149:17 [INFO] [stderr] | [INFO] [stderr] 149 | let mut new_indv = Vec::new(); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/chromosome.rs:103:13 [INFO] [stderr] | [INFO] [stderr] 103 | let mut individual = Chromosome::new(); [INFO] [stderr] | ----^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `chromosome::Chromosome` [INFO] [stderr] --> src/chromosome.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | / pub fn new() -> Chromosome { [INFO] [stderr] 16 | | let mut rng = rand::thread_rng(); [INFO] [stderr] 17 | | let mut vec : Vec = Vec::new(); [INFO] [stderr] 18 | | for _ in 0..44 { [INFO] [stderr] ... | [INFO] [stderr] 21 | | Chromosome {genes: vec} [INFO] [stderr] 22 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 8 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/chromosome.rs:27:64 [INFO] [stderr] | [INFO] [stderr] 27 | let x: i32 = self.genes[0..22].iter().map(|x| x.pow(2)).fold(0i32, |sum, x| sum + x) -11i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `.sum()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_fold)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/chromosome.rs:28:65 [INFO] [stderr] | [INFO] [stderr] 28 | let y: i32 = self.genes[22..44].iter().map(|y| y.pow(2)).fold(0i32, |sum, y| sum + y) -11i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `.sum()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/chromosome.rs:55:22 [INFO] [stderr] | [INFO] [stderr] 55 | fn cross_over(indv1: &Vec, indv2: &Vec) -> Vec { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[i32]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/chromosome.rs:55:40 [INFO] [stderr] | [INFO] [stderr] 55 | fn cross_over(indv1: &Vec, indv2: &Vec) -> Vec { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[i32]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.21s [INFO] running `"docker" "inspect" "fbd43f2ba56db83c68b66be1bd967cc3978fbc9032549357ec3f79466e763b73"` [INFO] running `"docker" "rm" "-f" "fbd43f2ba56db83c68b66be1bd967cc3978fbc9032549357ec3f79466e763b73"` [INFO] [stdout] fbd43f2ba56db83c68b66be1bd967cc3978fbc9032549357ec3f79466e763b73