[INFO] crate agnes 0.2.0 is already in cache [INFO] extracting crate agnes 0.2.0 into work/ex/clippy-test-run/sources/stable/reg/agnes/0.2.0 [INFO] extracting crate agnes 0.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/agnes/0.2.0 [INFO] validating manifest of agnes-0.2.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of agnes-0.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing agnes-0.2.0 [INFO] removed 1 missing examples [INFO] finished frobbing agnes-0.2.0 [INFO] frobbed toml for agnes-0.2.0 written to work/ex/clippy-test-run/sources/stable/reg/agnes/0.2.0/Cargo.toml [INFO] started frobbing agnes-0.2.0 [INFO] removed 1 missing examples [INFO] finished frobbing agnes-0.2.0 [INFO] frobbed toml for agnes-0.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/agnes/0.2.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting agnes-0.2.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/agnes/0.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 7d686aced902cfeb976af6375137b7373f54675128ecbeadbb7b287a5c94bdfc [INFO] running `"docker" "start" "-a" "7d686aced902cfeb976af6375137b7373f54675128ecbeadbb7b287a5c94bdfc"` [INFO] [stderr] Checking mashup v0.1.9 [INFO] [stderr] Checking csv-sniffer v0.1.1 [INFO] [stderr] Checking agnes v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: lint name `map_clone` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/view.rs:520:32 [INFO] [stderr] | [INFO] [stderr] 520 | #[allow(unknown_lints, map_clone)] [INFO] [stderr] | ^^^^^^^^^ help: change it to: `clippy::map_clone` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `map_clone` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/view.rs:520:32 [INFO] [stderr] | [INFO] [stderr] 520 | #[allow(unknown_lints, map_clone)] [INFO] [stderr] | ^^^^^^^^^ help: change it to: `clippy::map_clone` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `map_clone` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/view.rs:520:32 [INFO] [stderr] | [INFO] [stderr] 520 | #[allow(unknown_lints, map_clone)] [INFO] [stderr] | ^^^^^^^^^ help: change it to: `clippy::map_clone` [INFO] [stderr] [INFO] [stderr] warning: lint name `map_clone` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/view.rs:520:32 [INFO] [stderr] | [INFO] [stderr] 520 | #[allow(unknown_lints, map_clone)] [INFO] [stderr] | ^^^^^^^^^ help: change it to: `clippy::map_clone` [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/apply/stats.rs:774:61 [INFO] [stderr] | [INFO] [stderr] 774 | assert!((dv.field::("Foo").unwrap().var() - 38.049048).abs() < 1e-6); [INFO] [stderr] | ^^^^^^^^^ help: consider: `38.049_048` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/apply/stats.rs:775:63 [INFO] [stderr] | [INFO] [stderr] 775 | assert!((dv.field::("Foo").unwrap().stdev() - 6.168391).abs() < 1e-6); [INFO] [stderr] | ^^^^^^^^ help: consider: `6.168_391` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/apply/stats.rs:776:62 [INFO] [stderr] | [INFO] [stderr] 776 | assert!((dv.field::("Foo").unwrap().varp() - 32.613469).abs() < 1e-6); [INFO] [stderr] | ^^^^^^^^^ help: consider: `32.613_469` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/apply/stats.rs:777:64 [INFO] [stderr] | [INFO] [stderr] 777 | assert!((dv.field::("Foo").unwrap().stdevp() - 5.710820).abs() < 1e-6); [INFO] [stderr] | ^^^^^^^^ help: consider: `5.710_820` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/apply/stats.rs:778:62 [INFO] [stderr] | [INFO] [stderr] 778 | assert!((dv.field::("Foo").unwrap().mean() - 1.271429).abs() < 1e-6); [INFO] [stderr] | ^^^^^^^^ help: consider: `1.271_429` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/view_stats.rs:145:80 [INFO] [stderr] | [INFO] [stderr] 145 | assert!((vs1.fields[0].mean.clone().unwrap().parse::().unwrap() - 5.714286).abs() [INFO] [stderr] | ^^^^^^^^ help: consider: `5.714_286` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/view_stats.rs:147:81 [INFO] [stderr] | [INFO] [stderr] 147 | assert!((vs1.fields[0].stdev.clone().unwrap().parse::().unwrap() - 3.683942).abs() [INFO] [stderr] | ^^^^^^^^ help: consider: `3.683_942` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/view_stats.rs:172:81 [INFO] [stderr] | [INFO] [stderr] 172 | assert!((vs2.fields[0].mean.clone().unwrap().parse::().unwrap() - -1.857143).abs() [INFO] [stderr] | ^^^^^^^^ help: consider: `1.857_143` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/view_stats.rs:174:81 [INFO] [stderr] | [INFO] [stderr] 174 | assert!((vs2.fields[0].stdev.clone().unwrap().parse::().unwrap() - 15.004761).abs() [INFO] [stderr] | ^^^^^^^^^ help: consider: `15.004_761` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/view_stats.rs:180:80 [INFO] [stderr] | [INFO] [stderr] 180 | assert!((vs2.fields[1].mean.clone().unwrap().parse::().unwrap() - 0.571429).abs() [INFO] [stderr] | ^^^^^^^^ help: consider: `0.571_429` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/view_stats.rs:182:81 [INFO] [stderr] | [INFO] [stderr] 182 | assert!((vs2.fields[1].stdev.clone().unwrap().parse::().unwrap() - 0.534522).abs() [INFO] [stderr] | ^^^^^^^^ help: consider: `0.534_522` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/view_stats.rs:188:80 [INFO] [stderr] | [INFO] [stderr] 188 | assert!((vs2.fields[2].mean.clone().unwrap().parse::().unwrap() - 34.0857143).abs() [INFO] [stderr] | ^^^^^^^^^^ help: consider: `34.085_714_3` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/view_stats.rs:190:82 [INFO] [stderr] | [INFO] [stderr] 190 | assert!((vs2.fields[2].stdev.clone().unwrap().parse::().unwrap() - 35.070948).abs() [INFO] [stderr] | ^^^^^^^^^ help: consider: `35.070_948` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: Try not to call a closure in the expression where it is declared. [INFO] [stderr] --> src/data_types.rs:80:57 [INFO] [stderr] | [INFO] [stderr] 80 | map![@continue($elems.tail)($($output)*.prepend(($($f0)*)(&$elems.head))) $([$($f)*])*] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/unique.rs:135:33 [INFO] [stderr] | [INFO] [stderr] 135 | let dv_unique_indices = composite_unique_indices![ [INFO] [stderr] | _________________________________- [INFO] [stderr] 136 | | dv, [INFO] [stderr] 137 | | ["DeptId"](u64), [INFO] [stderr] 138 | | ["DidTraining"](bool), [INFO] [stderr] 139 | | ].unwrap(); [INFO] [stderr] | |_________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_call [INFO] [stderr] [INFO] [stderr] warning: Try not to call a closure in the expression where it is declared. [INFO] [stderr] --> src/data_types.rs:80:57 [INFO] [stderr] | [INFO] [stderr] 80 | map![@continue($elems.tail)($($output)*.prepend(($($f0)*)(&$elems.head))) $([$($f)*])*] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/unique.rs:135:33 [INFO] [stderr] | [INFO] [stderr] 135 | let dv_unique_indices = composite_unique_indices![ [INFO] [stderr] | _________________________________- [INFO] [stderr] 136 | | dv, [INFO] [stderr] 137 | | ["DeptId"](u64), [INFO] [stderr] 138 | | ["DidTraining"](bool), [INFO] [stderr] 139 | | ].unwrap(); [INFO] [stderr] | |_________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_call [INFO] [stderr] [INFO] [stderr] warning: Try not to call a closure in the expression where it is declared. [INFO] [stderr] --> src/data_types.rs:80:57 [INFO] [stderr] | [INFO] [stderr] 80 | map![@continue($elems.tail)($($output)*.prepend(($($f0)*)(&$elems.head))) $([$($f)*])*] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/unique.rs:143:25 [INFO] [stderr] | [INFO] [stderr] 143 | let dv_unique = composite_unique![ [INFO] [stderr] | _________________________- [INFO] [stderr] 144 | | dv, [INFO] [stderr] 145 | | ["DeptId"](u64), [INFO] [stderr] 146 | | ["DidTraining"](bool), [INFO] [stderr] 147 | | ].unwrap(); [INFO] [stderr] | |_________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_call [INFO] [stderr] [INFO] [stderr] warning: Try not to call a closure in the expression where it is declared. [INFO] [stderr] --> src/data_types.rs:80:57 [INFO] [stderr] | [INFO] [stderr] 80 | map![@continue($elems.tail)($($output)*.prepend(($($f0)*)(&$elems.head))) $([$($f)*])*] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/unique.rs:143:25 [INFO] [stderr] | [INFO] [stderr] 143 | let dv_unique = composite_unique![ [INFO] [stderr] | _________________________- [INFO] [stderr] 144 | | dv, [INFO] [stderr] 145 | | ["DeptId"](u64), [INFO] [stderr] 146 | | ["DidTraining"](bool), [INFO] [stderr] 147 | | ].unwrap(); [INFO] [stderr] | |_________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_call [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of right operand [INFO] [stderr] --> src/ops/scalar_op.rs:498:27 [INFO] [stderr] | [INFO] [stderr] 498 | let computed_dv = &dv.field("Foo").unwrap() + &4u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^----- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `4u64` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/ops/scalar_op.rs:506:27 [INFO] [stderr] | [INFO] [stderr] 506 | let computed_dv = dv.field::("Foo").unwrap() + &4u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^----- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `4u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of left operand [INFO] [stderr] --> src/ops/scalar_op.rs:517:27 [INFO] [stderr] | [INFO] [stderr] 517 | let computed_dv = &4u64 + &dv.field::("Foo").unwrap(); [INFO] [stderr] | -----^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: use the left value directly: `4u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of left operand [INFO] [stderr] --> src/ops/scalar_op.rs:525:27 [INFO] [stderr] | [INFO] [stderr] 525 | let computed_dv = &4u64 + dv.field::("Foo").unwrap(); [INFO] [stderr] | -----^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: use the left value directly: `4u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 26 [INFO] [stderr] --> src/view.rs:680:5 [INFO] [stderr] | [INFO] [stderr] 680 | / fn subview() { [INFO] [stderr] 681 | | let ds = sample_emp_table(); [INFO] [stderr] 682 | | let dv: DataView = ds.into(); [INFO] [stderr] 683 | | assert_eq!(dv.frames[0].store_ref_count(), 1); [INFO] [stderr] ... | [INFO] [stderr] 721 | | assert_eq!(subdv4.nfields(), 1); [INFO] [stderr] 722 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/view.rs:904:13 [INFO] [stderr] | [INFO] [stderr] 904 | Err(_) => { panic!["wrong error when calling tmap() with incorrect type"]; }, [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/apply/stats.rs:641:9 [INFO] [stderr] | [INFO] [stderr] 641 | assert_eq!(dv.field::("Foo").unwrap().sum(), -8.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/apply/stats.rs:641:9 [INFO] [stderr] | [INFO] [stderr] 641 | assert_eq!(dv.field::("Foo").unwrap().sum(), -8.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/apply/stats.rs:653:9 [INFO] [stderr] | [INFO] [stderr] 653 | assert_eq!(dv.field::("Foo").unwrap().mean(), 4.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/apply/stats.rs:653:9 [INFO] [stderr] | [INFO] [stderr] 653 | assert_eq!(dv.field::("Foo").unwrap().mean(), 4.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/apply/stats.rs:662:9 [INFO] [stderr] | [INFO] [stderr] 662 | assert_eq!(dv.field::("Foo").unwrap().mean(), -4.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/apply/stats.rs:662:9 [INFO] [stderr] | [INFO] [stderr] 662 | assert_eq!(dv.field::("Foo").unwrap().mean(), -4.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/apply/stats.rs:671:9 [INFO] [stderr] | [INFO] [stderr] 671 | assert_eq!(dv.field::("Foo").unwrap().mean(), 0.75); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/apply/stats.rs:671:9 [INFO] [stderr] | [INFO] [stderr] 671 | assert_eq!(dv.field::("Foo").unwrap().mean(), 0.75); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/apply/stats.rs:680:9 [INFO] [stderr] | [INFO] [stderr] 680 | assert_eq!(dv.field::("Foo").unwrap().mean(), -4.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/apply/stats.rs:680:9 [INFO] [stderr] | [INFO] [stderr] 680 | assert_eq!(dv.field::("Foo").unwrap().mean(), -4.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/apply/stats.rs:719:9 [INFO] [stderr] | [INFO] [stderr] 719 | assert_eq!(dv.field::("Foo").unwrap().min(), -9.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/apply/stats.rs:719:9 [INFO] [stderr] | [INFO] [stderr] 719 | assert_eq!(dv.field::("Foo").unwrap().min(), -9.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/apply/stats.rs:758:9 [INFO] [stderr] | [INFO] [stderr] 758 | assert_eq!(dv.field::("Foo").unwrap().max(), 0.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/apply/stats.rs:758:9 [INFO] [stderr] | [INFO] [stderr] 758 | assert_eq!(dv.field::("Foo").unwrap().max(), 0.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/apply/stats.rs:779:9 [INFO] [stderr] | [INFO] [stderr] 779 | assert_eq!(dv.field::("Foo").unwrap().sum(), 8.9); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/apply/stats.rs:779:9 [INFO] [stderr] | [INFO] [stderr] 779 | assert_eq!(dv.field::("Foo").unwrap().sum(), 8.9); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/select.rs:111:13 [INFO] [stderr] | [INFO] [stderr] 111 | Err(_) => { panic!["wrong error when calling field() with incorrect type"]; }, [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 36 [INFO] [stderr] --> src/view_stats.rs:131:5 [INFO] [stderr] | [INFO] [stderr] 131 | / fn view_stats_display() { [INFO] [stderr] 132 | | let dv1: DataView = sample_emp_table().into(); [INFO] [stderr] 133 | | let vs1 = dv1.view_stats().unwrap(); [INFO] [stderr] 134 | | println!("{}", vs1); [INFO] [stderr] ... | [INFO] [stderr] 193 | | [INFO] [stderr] 194 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/test_utils.rs:144:57 [INFO] [stderr] | [INFO] [stderr] 144 | assert!(left.field(ident).unwrap().iter().all(|val| { [INFO] [stderr] | _________________________________________________________^ [INFO] [stderr] 145 | | match val { [INFO] [stderr] 146 | | Value::Exists(val) => f(val), [INFO] [stderr] 147 | | Value::Na => false [INFO] [stderr] 148 | | } [INFO] [stderr] 149 | | })); [INFO] [stderr] | |_____^ [INFO] [stderr] ... [INFO] [stderr] 194 | impl_test_helpers!(unsigned; u64); [INFO] [stderr] | ---------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::block_in_if_condition_stmt)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/test_utils.rs:144:57 [INFO] [stderr] | [INFO] [stderr] 144 | assert!(left.field(ident).unwrap().iter().all(|val| { [INFO] [stderr] | _________________________________________________________^ [INFO] [stderr] 145 | | match val { [INFO] [stderr] 146 | | Value::Exists(val) => f(val), [INFO] [stderr] 147 | | Value::Na => false [INFO] [stderr] 148 | | } [INFO] [stderr] 149 | | })); [INFO] [stderr] | |_____^ [INFO] [stderr] ... [INFO] [stderr] 195 | impl_test_helpers!(signed; i64); [INFO] [stderr] | ---------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/test_utils.rs:144:57 [INFO] [stderr] | [INFO] [stderr] 144 | assert!(left.field(ident).unwrap().iter().all(|val| { [INFO] [stderr] | _________________________________________________________^ [INFO] [stderr] 145 | | match val { [INFO] [stderr] 146 | | Value::Exists(val) => f(val), [INFO] [stderr] 147 | | Value::Na => false [INFO] [stderr] 148 | | } [INFO] [stderr] 149 | | })); [INFO] [stderr] | |_____^ [INFO] [stderr] ... [INFO] [stderr] 196 | impl_test_helpers!(text; String); [INFO] [stderr] | ------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/test_utils.rs:144:57 [INFO] [stderr] | [INFO] [stderr] 144 | assert!(left.field(ident).unwrap().iter().all(|val| { [INFO] [stderr] | _________________________________________________________^ [INFO] [stderr] 145 | | match val { [INFO] [stderr] 146 | | Value::Exists(val) => f(val), [INFO] [stderr] 147 | | Value::Na => false [INFO] [stderr] 148 | | } [INFO] [stderr] 149 | | })); [INFO] [stderr] | |_____^ [INFO] [stderr] ... [INFO] [stderr] 197 | impl_test_helpers!(boolean; bool); [INFO] [stderr] | ----------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/test_utils.rs:144:57 [INFO] [stderr] | [INFO] [stderr] 144 | assert!(left.field(ident).unwrap().iter().all(|val| { [INFO] [stderr] | _________________________________________________________^ [INFO] [stderr] 145 | | match val { [INFO] [stderr] 146 | | Value::Exists(val) => f(val), [INFO] [stderr] 147 | | Value::Na => false [INFO] [stderr] 148 | | } [INFO] [stderr] 149 | | })); [INFO] [stderr] | |_____^ [INFO] [stderr] ... [INFO] [stderr] 203 | impl_assert_vec_eq_and_pred!(f64); [INFO] [stderr] | ---------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/test_gen_data.rs:43:22 [INFO] [stderr] | [INFO] [stderr] 43 | .map(|value| Value::Exists(value)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Value::Exists` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/test_gen_data.rs:46:35 [INFO] [stderr] | [INFO] [stderr] 46 | store.add_data_vec(ident, data.into()).expect("failure adding data while generating"); [INFO] [stderr] | ^^^^^^^^^^^ help: consider removing `.into()`: `data` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/test_gen_data.rs:64:22 [INFO] [stderr] | [INFO] [stderr] 64 | .map(|value| Value::Exists(value)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Value::Exists` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/test_gen_data.rs:67:35 [INFO] [stderr] | [INFO] [stderr] 67 | store.add_data_vec(ident, data.into()).expect("failure adding data while generating"); [INFO] [stderr] | ^^^^^^^^^^^ help: consider removing `.into()`: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/test_gen_data.rs:84:22 [INFO] [stderr] | [INFO] [stderr] 84 | .map(|value| Value::Exists(value)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Value::Exists` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/test_gen_data.rs:87:35 [INFO] [stderr] | [INFO] [stderr] 87 | store.add_data_vec(ident, data.into()).expect("failure adding data while generating"); [INFO] [stderr] | ^^^^^^^^^^^ help: consider removing `.into()`: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/test_gen_data.rs:118:22 [INFO] [stderr] | [INFO] [stderr] 118 | .map(|value| Value::Exists(value)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Value::Exists` [INFO] [stderr] ... [INFO] [stderr] 127 | impl_uniform_generate_into![u64 i64 f64]; [INFO] [stderr] | ----------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/test_gen_data.rs:158:18 [INFO] [stderr] | [INFO] [stderr] 158 | .map(|value| Value::Exists(value)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Value::Exists` [INFO] [stderr] ... [INFO] [stderr] 167 | impl_uniform_choice_generate_into![u64 i64 String bool f64]; [INFO] [stderr] | ------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/test_gen_data.rs:244:22 [INFO] [stderr] | [INFO] [stderr] 244 | for i in 0..8 { seed_bytes[i] = bytes[i]; } [INFO] [stderr] | ^^^^ help: try replacing the loop by: `seed_bytes[..8].clone_from_slice(&bytes[..8])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::manual_memcpy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] error: aborting due to 8 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `agnes`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "7d686aced902cfeb976af6375137b7373f54675128ecbeadbb7b287a5c94bdfc"` [INFO] running `"docker" "rm" "-f" "7d686aced902cfeb976af6375137b7373f54675128ecbeadbb7b287a5c94bdfc"` [INFO] [stdout] 7d686aced902cfeb976af6375137b7373f54675128ecbeadbb7b287a5c94bdfc