[INFO] crate aflak_cake 0.0.3 is already in cache
[INFO] extracting crate aflak_cake 0.0.3 into work/ex/clippy-test-run/sources/stable/reg/aflak_cake/0.0.3
[INFO] extracting crate aflak_cake 0.0.3 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/aflak_cake/0.0.3
[INFO] validating manifest of aflak_cake-0.0.3 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of aflak_cake-0.0.3 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing aflak_cake-0.0.3
[INFO] finished frobbing aflak_cake-0.0.3
[INFO] frobbed toml for aflak_cake-0.0.3 written to work/ex/clippy-test-run/sources/stable/reg/aflak_cake/0.0.3/Cargo.toml
[INFO] started frobbing aflak_cake-0.0.3
[INFO] finished frobbing aflak_cake-0.0.3
[INFO] frobbed toml for aflak_cake-0.0.3 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/aflak_cake/0.0.3/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting aflak_cake-0.0.3 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/aflak_cake/0.0.3:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 7e47922c93088da8e30bb4c0d959ebfb3f92dd355fa5b746c7ff7129f927854e
[INFO] running `"docker" "start" "-a" "7e47922c93088da8e30bb4c0d959ebfb3f92dd355fa5b746c7ff7129f927854e"`
[INFO] [stderr]     Checking ron v0.2.2
[INFO] [stderr]     Checking aflak_cake v0.0.3 (/opt/crater/workdir)
[INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead
[INFO] [stderr]    --> src/dst/mod.rs:214:13
[INFO] [stderr]     |
[INFO] [stderr] 214 |             write!(f, "{:?}\n", output_id)?;
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::write_with_newline)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead
[INFO] [stderr]    --> src/dst/mod.rs:218:17
[INFO] [stderr]     |
[INFO] [stderr] 218 |                 write!(f, "{}*\n", pad(1))?;
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead
[INFO] [stderr]    --> src/dst/mod.rs:233:13
[INFO] [stderr]     |
[INFO] [stderr] 233 |             write!(f, "{}{}\n", pad(depth), t.name)?;
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead
[INFO] [stderr]    --> src/dst/mod.rs:238:21
[INFO] [stderr]     |
[INFO] [stderr] 238 |                     write!(f, "\n")?;
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead
[INFO] [stderr]    --> src/dst/mod.rs:241:21
[INFO] [stderr]     |
[INFO] [stderr] 241 |                     write!(f, " (no node)\n")?;
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead
[INFO] [stderr]    --> src/dst/mod.rs:246:13
[INFO] [stderr]     |
[INFO] [stderr] 246 |             write!(f, "{}(missing node)\n", pad(depth))
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]    --> src/dst/mod.rs:252:23
[INFO] [stderr]     |
[INFO] [stderr] 252 |     const SEPARATOR: &'static str = "\\_ ";
[INFO] [stderr]     |                      -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]    --> src/dst/mod.rs:253:20
[INFO] [stderr]     |
[INFO] [stderr] 253 |     const PADDER: &'static str = "    ";
[INFO] [stderr]     |                   -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead
[INFO] [stderr]    --> src/dst/mod.rs:214:13
[INFO] [stderr]     |
[INFO] [stderr] 214 |             write!(f, "{:?}\n", output_id)?;
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::write_with_newline)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead
[INFO] [stderr]    --> src/dst/mod.rs:218:17
[INFO] [stderr]     |
[INFO] [stderr] 218 |                 write!(f, "{}*\n", pad(1))?;
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead
[INFO] [stderr]    --> src/dst/mod.rs:233:13
[INFO] [stderr]     |
[INFO] [stderr] 233 |             write!(f, "{}{}\n", pad(depth), t.name)?;
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead
[INFO] [stderr]    --> src/dst/mod.rs:238:21
[INFO] [stderr]     |
[INFO] [stderr] 238 |                     write!(f, "\n")?;
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead
[INFO] [stderr]    --> src/dst/mod.rs:241:21
[INFO] [stderr]     |
[INFO] [stderr] 241 |                     write!(f, " (no node)\n")?;
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead
[INFO] [stderr]    --> src/dst/mod.rs:246:13
[INFO] [stderr]     |
[INFO] [stderr] 246 |             write!(f, "{}(missing node)\n", pad(depth))
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `dst::DST<'t, T, E>`
[INFO] [stderr]   --> src/dst/build.rs:41:5
[INFO] [stderr]    |
[INFO] [stderr] 41 | /     pub fn new() -> Self {
[INFO] [stderr] 42 | |         Self {
[INFO] [stderr] 43 | |             transforms: HashMap::new(),
[INFO] [stderr] 44 | |             edges: HashMap::new(),
[INFO] [stderr] ...  |
[INFO] [stderr] 47 | |         }
[INFO] [stderr] 48 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 30 | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/dst/build.rs:51:38
[INFO] [stderr]    |
[INFO] [stderr] 51 |     pub fn get_transform(&self, idx: &TransformIdx) -> Option<&Transformation<T, E>> {
[INFO] [stderr]    |                                      ^^^^^^^^^^^^^ help: consider passing by value instead: `TransformIdx`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/dst/build.rs:57:46
[INFO] [stderr]    |
[INFO] [stderr] 57 |     pub fn get_transform_mut(&mut self, idx: &TransformIdx) -> Option<&mut Transformation<T, E>> {
[INFO] [stderr]    |                                              ^^^^^^^^^^^^^ help: consider passing by value instead: `TransformIdx`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/dst/build.rs:64:47
[INFO] [stderr]    |
[INFO] [stderr] 64 |     pub fn get_default_inputs(&mut self, idx: &TransformIdx) -> Option<&[Option<T>]> {
[INFO] [stderr]    |                                               ^^^^^^^^^^^^^ help: consider passing by value instead: `TransformIdx`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/dst/build.rs:71:51
[INFO] [stderr]    |
[INFO] [stderr] 71 |     pub fn get_default_inputs_mut(&mut self, idx: &TransformIdx) -> Option<&mut [Option<T>]> {
[INFO] [stderr]    |                                                   ^^^^^^^^^^^^^ help: consider passing by value instead: `TransformIdx`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/dst/build.rs:77:9
[INFO] [stderr]    |
[INFO] [stderr] 77 | /         match idx {
[INFO] [stderr] 78 | |             &NodeId::Transform(ref t_idx) => self.get_transform(t_idx).map(Node::Transform),
[INFO] [stderr] 79 | |             &NodeId::Output(ref output_id) => self
[INFO] [stderr] 80 | |                 .outputs
[INFO] [stderr] 81 | |                 .get(output_id)
[INFO] [stderr] 82 | |                 .map(|some_output| Node::Output(some_output.as_ref())),
[INFO] [stderr] 83 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 77 |         match *idx {
[INFO] [stderr] 78 |             NodeId::Transform(ref t_idx) => self.get_transform(t_idx).map(Node::Transform),
[INFO] [stderr] 79 |             NodeId::Output(ref output_id) => self
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/dst/build.rs:94:14
[INFO] [stderr]    |
[INFO] [stderr] 94 |         idx: &TransformIdx,
[INFO] [stderr]    |              ^^^^^^^^^^^^^ help: consider passing by value instead: `TransformIdx`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/dst/build.rs:122:59
[INFO] [stderr]     |
[INFO] [stderr] 122 |     pub(crate) fn outputs_of_transformation(&self, t_idx: &TransformIdx) -> Option<Vec<Output>> {
[INFO] [stderr]     |                                                           ^^^^^^^^^^^^^ help: consider passing by value instead: `TransformIdx`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] error: this `if` has identical blocks
[INFO] [stderr]    --> src/dst/build.rs:134:17
[INFO] [stderr]     |
[INFO] [stderr] 134 | /                 {
[INFO] [stderr] 135 | |                     outputs.push(output)
[INFO] [stderr] 136 | |                 }
[INFO] [stderr]     | |_________________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[deny(clippy::if_same_then_else)] on by default
[INFO] [stderr] note: same as this
[INFO] [stderr]    --> src/dst/build.rs:127:53
[INFO] [stderr]     |
[INFO] [stderr] 127 |                   if self.edges.contains_key(&output) {
[INFO] [stderr]     |  _____________________________________________________^
[INFO] [stderr] 128 | |                     outputs.push(output)
[INFO] [stderr] 129 | |                 } else if self
[INFO] [stderr]     | |_________________^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else
[INFO] [stderr] 
[INFO] [stderr] warning: called `is_some()` after searching an `Iterator` with find. This is more succinctly expressed by calling `any()`.
[INFO] [stderr]    --> src/dst/build.rs:129:27
[INFO] [stderr]     |
[INFO] [stderr] 129 |                   } else if self
[INFO] [stderr]     |  ___________________________^
[INFO] [stderr] 130 | |                     .outputs
[INFO] [stderr] 131 | |                     .values()
[INFO] [stderr] 132 | |                     .find(|&val| &Some(output) == val)
[INFO] [stderr] 133 | |                     .is_some()
[INFO] [stderr]     | |______________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::search_is_some)] on by default
[INFO] [stderr]     = note: replace `find(|&val| &Some(output) == val).is_some()` with `any(|&val| &Some(output) == val)`
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#search_is_some
[INFO] [stderr] 
[INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions
[INFO] [stderr]    --> src/dst/build.rs:161:10
[INFO] [stderr]     |
[INFO] [stderr] 161 |     ) -> Option<(Bow<Transformation<T, E>>, Vec<Option<T>>)> {
[INFO] [stderr]     |          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::type_complexity)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/dst/build.rs:160:16
[INFO] [stderr]     |
[INFO] [stderr] 160 |         t_idx: &TransformIdx,
[INFO] [stderr]     |                ^^^^^^^^^^^^^ help: consider passing by value instead: `TransformIdx`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]    --> src/dst/build.rs:167:35
[INFO] [stderr]     |
[INFO] [stderr] 167 |                     .map(|inputs| inputs.map(|i| *i).collect::<Vec<_>>())
[INFO] [stderr]     |                                   ^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `inputs.cloned()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::map_clone)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] 
[INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap`
[INFO] [stderr]    --> src/dst/build.rs:230:13
[INFO] [stderr]     |
[INFO] [stderr] 230 | /             if !self.edges.contains_key(&output) {
[INFO] [stderr] 231 | |                 self.edges.insert(output, InputList::new(vec![input]));
[INFO] [stderr] 232 | |             } else {
[INFO] [stderr] 233 | |                 let inputs = self.edges.get_mut(&output).unwrap();
[INFO] [stderr] 234 | |                 inputs.push(input);
[INFO] [stderr] 235 | |             }
[INFO] [stderr]     | |_____________^ help: consider using: `self.edges.entry(output)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::map_entry)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]   --> src/dst/compute.rs:64:32
[INFO] [stderr]    |
[INFO] [stderr] 64 |                 result.map_err(|err| DSTError::InnerComputeError(err))
[INFO] [stderr]    |                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `DSTError::InnerComputeError`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_closure)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/dst/compute.rs:72:38
[INFO] [stderr]    |
[INFO] [stderr] 72 |     pub fn compute(&self, output_id: &OutputId) -> Result<T, DSTError<E>> {
[INFO] [stderr]    |                                      ^^^^^^^^^ help: consider passing by value instead: `OutputId`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]   --> src/dst/compute.rs:95:27
[INFO] [stderr]    |
[INFO] [stderr] 95 |             .map(|inputs| inputs.map(|input| *input))
[INFO] [stderr]    |                           ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `inputs.cloned()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/dst/compute.rs:111:9
[INFO] [stderr]     |
[INFO] [stderr] 111 | /         match node_id {
[INFO] [stderr] 112 | |             &NodeId::Output(ref output_id) => {
[INFO] [stderr] 113 | |                 let output = {
[INFO] [stderr] 114 | |                     if let Some(Some(output)) = self.outputs.get(output_id) {
[INFO] [stderr] ...   |
[INFO] [stderr] 128 | |             }
[INFO] [stderr] 129 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 111 |         match *node_id {
[INFO] [stderr] 112 |             NodeId::Output(ref output_id) => {
[INFO] [stderr] 113 |                 let output = {
[INFO] [stderr] 114 |                     if let Some(Some(output)) = self.outputs.get(output_id) {
[INFO] [stderr] 115 |                         *output
[INFO] [stderr] 116 |                     } else {
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/dst/node.rs:31:9
[INFO] [stderr]    |
[INFO] [stderr] 31 | /         match self {
[INFO] [stderr] 32 | |             &Node::Transform(t) => Cow::Borrowed(t.name),
[INFO] [stderr] 33 | |             &Node::Output(_) => {
[INFO] [stderr] 34 | |                 if let NodeId::Output(output_id) = id {
[INFO] [stderr] ...  |
[INFO] [stderr] 40 | |             }
[INFO] [stderr] 41 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 31 |         match *self {
[INFO] [stderr] 32 |             Node::Transform(t) => Cow::Borrowed(t.name),
[INFO] [stderr] 33 |             Node::Output(_) => {
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/dst/node.rs:46:9
[INFO] [stderr]    |
[INFO] [stderr] 46 | /         match self {
[INFO] [stderr] 47 | |             &Node::Transform(t) => t.input.as_slice(),
[INFO] [stderr] 48 | |             &Node::Output(_) => &[(OUTPUT_NODE_SLOT, None)],
[INFO] [stderr] 49 | |         }.iter()
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 46 |         match *self {
[INFO] [stderr] 47 |             Node::Transform(t) => t.input.as_slice(),
[INFO] [stderr] 48 |             Node::Output(_) => &[(OUTPUT_NODE_SLOT, None)],
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/dst/node.rs:55:9
[INFO] [stderr]    |
[INFO] [stderr] 55 | /         match self {
[INFO] [stderr] 56 | |             &Node::Transform(t) => t.input.as_slice(),
[INFO] [stderr] 57 | |             &Node::Output(_) => &[(OUTPUT_NODE_SLOT, None)],
[INFO] [stderr] 58 | |         }.iter()
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 55 |         match *self {
[INFO] [stderr] 56 |             Node::Transform(t) => t.input.as_slice(),
[INFO] [stderr] 57 |             Node::Output(_) => &[(OUTPUT_NODE_SLOT, None)],
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/dst/node.rs:64:9
[INFO] [stderr]    |
[INFO] [stderr] 64 | /         match self {
[INFO] [stderr] 65 | |             &Node::Transform(t) => t.input.len(),
[INFO] [stderr] 66 | |             &Node::Output(_) => 1,
[INFO] [stderr] 67 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 64 |         match *self {
[INFO] [stderr] 65 |             Node::Transform(t) => t.input.len(),
[INFO] [stderr] 66 |             Node::Output(_) => 1,
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/dst/node.rs:73:9
[INFO] [stderr]    |
[INFO] [stderr] 73 | /         match self {
[INFO] [stderr] 74 | |             &Node::Transform(t) => t.output.iter(),
[INFO] [stderr] 75 | |             &Node::Output(_) => OUTPUT_NODE_SLOTS.iter(),
[INFO] [stderr] 76 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 73 |         match *self {
[INFO] [stderr] 74 |             Node::Transform(t) => t.output.iter(),
[INFO] [stderr] 75 |             Node::Output(_) => OUTPUT_NODE_SLOTS.iter(),
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/dst/node.rs:81:9
[INFO] [stderr]    |
[INFO] [stderr] 81 | /         match self {
[INFO] [stderr] 82 | |             &Node::Transform(t) => t.output.len(),
[INFO] [stderr] 83 | |             &Node::Output(_) => 0,
[INFO] [stderr] 84 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 81 |         match *self {
[INFO] [stderr] 82 |             Node::Transform(t) => t.output.len(),
[INFO] [stderr] 83 |             Node::Output(_) => 0,
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/dst/mod.rs:184:15
[INFO] [stderr]     |
[INFO] [stderr] 184 |     pub fn id(&self) -> usize {
[INFO] [stderr]     |               ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/dst/mod.rs:193:15
[INFO] [stderr]     |
[INFO] [stderr] 193 |     pub fn id(&self) -> usize {
[INFO] [stderr]     |               ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: called `.iter().nth()` on a Vec. Calling `.get()` is both faster and more readable
[INFO] [stderr]   --> src/export.rs:81:37
[INFO] [stderr]    |
[INFO] [stderr] 81 |                   let first_variant = constants
[INFO] [stderr]    |  _____________________________________^
[INFO] [stderr] 82 | |                     .iter()
[INFO] [stderr] 83 | |                     .nth(0)
[INFO] [stderr]    | |___________________________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::iter_nth)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_nth
[INFO] [stderr] 
[INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions
[INFO] [stderr]   --> src/transform.rs:18:14
[INFO] [stderr]    |
[INFO] [stderr] 18 |     Function(fn(Vec<Cow<T>>) -> Vec<Result<T, E>>),
[INFO] [stderr]    |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/transform.rs:26:9
[INFO] [stderr]    |
[INFO] [stderr] 26 | /         match self {
[INFO] [stderr] 27 | |             &Algorithm::Function(ref fun) => write!(f, "Function({:p})", fun),
[INFO] [stderr] 28 | |             &Algorithm::Constant(ref vec) => write!(f, "Constant({:?})", vec),
[INFO] [stderr] 29 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 26 |         match *self {
[INFO] [stderr] 27 |             Algorithm::Function(ref fun) => write!(f, "Function({:p})", fun),
[INFO] [stderr] 28 |             Algorithm::Constant(ref vec) => write!(f, "Constant({:?})", vec),
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/transform.rs:154:25
[INFO] [stderr]     |
[INFO] [stderr] 154 |                   output: match self.algorithm {
[INFO] [stderr]     |  _________________________^
[INFO] [stderr] 155 | |                     &Algorithm::Function(f) => f(self.input).into_iter(),
[INFO] [stderr] 156 | |                     &Algorithm::Constant(ref c) => c
[INFO] [stderr] 157 | |                         .clone()
[INFO] [stderr] ...   |
[INFO] [stderr] 161 | |                         .into_iter(),
[INFO] [stderr] 162 | |                 },
[INFO] [stderr]     | |_________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 154 |                 output: match *self.algorithm {
[INFO] [stderr] 155 |                     Algorithm::Function(f) => f(self.input).into_iter(),
[INFO] [stderr] 156 |                     Algorithm::Constant(ref c) => c
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to previous error
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `aflak_cake`.
[INFO] [stderr] warning: build failed, waiting for other jobs to finish...
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]    --> src/dst/mod.rs:252:23
[INFO] [stderr]     |
[INFO] [stderr] 252 |     const SEPARATOR: &'static str = "\\_ ";
[INFO] [stderr]     |                      -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]    --> src/dst/mod.rs:253:20
[INFO] [stderr]     |
[INFO] [stderr] 253 |     const PADDER: &'static str = "    ";
[INFO] [stderr]     |                   -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `dst::DST<'t, T, E>`
[INFO] [stderr]   --> src/dst/build.rs:41:5
[INFO] [stderr]    |
[INFO] [stderr] 41 | /     pub fn new() -> Self {
[INFO] [stderr] 42 | |         Self {
[INFO] [stderr] 43 | |             transforms: HashMap::new(),
[INFO] [stderr] 44 | |             edges: HashMap::new(),
[INFO] [stderr] ...  |
[INFO] [stderr] 47 | |         }
[INFO] [stderr] 48 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 30 | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/dst/build.rs:51:38
[INFO] [stderr]    |
[INFO] [stderr] 51 |     pub fn get_transform(&self, idx: &TransformIdx) -> Option<&Transformation<T, E>> {
[INFO] [stderr]    |                                      ^^^^^^^^^^^^^ help: consider passing by value instead: `TransformIdx`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/dst/build.rs:57:46
[INFO] [stderr]    |
[INFO] [stderr] 57 |     pub fn get_transform_mut(&mut self, idx: &TransformIdx) -> Option<&mut Transformation<T, E>> {
[INFO] [stderr]    |                                              ^^^^^^^^^^^^^ help: consider passing by value instead: `TransformIdx`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/dst/build.rs:64:47
[INFO] [stderr]    |
[INFO] [stderr] 64 |     pub fn get_default_inputs(&mut self, idx: &TransformIdx) -> Option<&[Option<T>]> {
[INFO] [stderr]    |                                               ^^^^^^^^^^^^^ help: consider passing by value instead: `TransformIdx`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/dst/build.rs:71:51
[INFO] [stderr]    |
[INFO] [stderr] 71 |     pub fn get_default_inputs_mut(&mut self, idx: &TransformIdx) -> Option<&mut [Option<T>]> {
[INFO] [stderr]    |                                                   ^^^^^^^^^^^^^ help: consider passing by value instead: `TransformIdx`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/dst/build.rs:77:9
[INFO] [stderr]    |
[INFO] [stderr] 77 | /         match idx {
[INFO] [stderr] 78 | |             &NodeId::Transform(ref t_idx) => self.get_transform(t_idx).map(Node::Transform),
[INFO] [stderr] 79 | |             &NodeId::Output(ref output_id) => self
[INFO] [stderr] 80 | |                 .outputs
[INFO] [stderr] 81 | |                 .get(output_id)
[INFO] [stderr] 82 | |                 .map(|some_output| Node::Output(some_output.as_ref())),
[INFO] [stderr] 83 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 77 |         match *idx {
[INFO] [stderr] 78 |             NodeId::Transform(ref t_idx) => self.get_transform(t_idx).map(Node::Transform),
[INFO] [stderr] 79 |             NodeId::Output(ref output_id) => self
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/dst/build.rs:94:14
[INFO] [stderr]    |
[INFO] [stderr] 94 |         idx: &TransformIdx,
[INFO] [stderr]    |              ^^^^^^^^^^^^^ help: consider passing by value instead: `TransformIdx`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/dst/build.rs:122:59
[INFO] [stderr]     |
[INFO] [stderr] 122 |     pub(crate) fn outputs_of_transformation(&self, t_idx: &TransformIdx) -> Option<Vec<Output>> {
[INFO] [stderr]     |                                                           ^^^^^^^^^^^^^ help: consider passing by value instead: `TransformIdx`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] error: this `if` has identical blocks
[INFO] [stderr]    --> src/dst/build.rs:134:17
[INFO] [stderr]     |
[INFO] [stderr] 134 | /                 {
[INFO] [stderr] 135 | |                     outputs.push(output)
[INFO] [stderr] 136 | |                 }
[INFO] [stderr]     | |_________________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[deny(clippy::if_same_then_else)] on by default
[INFO] [stderr] note: same as this
[INFO] [stderr]    --> src/dst/build.rs:127:53
[INFO] [stderr]     |
[INFO] [stderr] 127 |                   if self.edges.contains_key(&output) {
[INFO] [stderr]     |  _____________________________________________________^
[INFO] [stderr] 128 | |                     outputs.push(output)
[INFO] [stderr] 129 | |                 } else if self
[INFO] [stderr]     | |_________________^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else
[INFO] [stderr] 
[INFO] [stderr] warning: called `is_some()` after searching an `Iterator` with find. This is more succinctly expressed by calling `any()`.
[INFO] [stderr]    --> src/dst/build.rs:129:27
[INFO] [stderr]     |
[INFO] [stderr] 129 |                   } else if self
[INFO] [stderr]     |  ___________________________^
[INFO] [stderr] 130 | |                     .outputs
[INFO] [stderr] 131 | |                     .values()
[INFO] [stderr] 132 | |                     .find(|&val| &Some(output) == val)
[INFO] [stderr] 133 | |                     .is_some()
[INFO] [stderr]     | |______________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::search_is_some)] on by default
[INFO] [stderr]     = note: replace `find(|&val| &Some(output) == val).is_some()` with `any(|&val| &Some(output) == val)`
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#search_is_some
[INFO] [stderr] 
[INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions
[INFO] [stderr]    --> src/dst/build.rs:161:10
[INFO] [stderr]     |
[INFO] [stderr] 161 |     ) -> Option<(Bow<Transformation<T, E>>, Vec<Option<T>>)> {
[INFO] [stderr]     |          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::type_complexity)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/dst/build.rs:160:16
[INFO] [stderr]     |
[INFO] [stderr] 160 |         t_idx: &TransformIdx,
[INFO] [stderr]     |                ^^^^^^^^^^^^^ help: consider passing by value instead: `TransformIdx`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]    --> src/dst/build.rs:167:35
[INFO] [stderr]     |
[INFO] [stderr] 167 |                     .map(|inputs| inputs.map(|i| *i).collect::<Vec<_>>())
[INFO] [stderr]     |                                   ^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `inputs.cloned()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::map_clone)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] 
[INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap`
[INFO] [stderr]    --> src/dst/build.rs:230:13
[INFO] [stderr]     |
[INFO] [stderr] 230 | /             if !self.edges.contains_key(&output) {
[INFO] [stderr] 231 | |                 self.edges.insert(output, InputList::new(vec![input]));
[INFO] [stderr] 232 | |             } else {
[INFO] [stderr] 233 | |                 let inputs = self.edges.get_mut(&output).unwrap();
[INFO] [stderr] 234 | |                 inputs.push(input);
[INFO] [stderr] 235 | |             }
[INFO] [stderr]     | |_____________^ help: consider using: `self.edges.entry(output)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::map_entry)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]   --> src/dst/compute.rs:64:32
[INFO] [stderr]    |
[INFO] [stderr] 64 |                 result.map_err(|err| DSTError::InnerComputeError(err))
[INFO] [stderr]    |                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `DSTError::InnerComputeError`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_closure)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/dst/compute.rs:72:38
[INFO] [stderr]    |
[INFO] [stderr] 72 |     pub fn compute(&self, output_id: &OutputId) -> Result<T, DSTError<E>> {
[INFO] [stderr]    |                                      ^^^^^^^^^ help: consider passing by value instead: `OutputId`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]   --> src/dst/compute.rs:95:27
[INFO] [stderr]    |
[INFO] [stderr] 95 |             .map(|inputs| inputs.map(|input| *input))
[INFO] [stderr]    |                           ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `inputs.cloned()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/dst/compute.rs:111:9
[INFO] [stderr]     |
[INFO] [stderr] 111 | /         match node_id {
[INFO] [stderr] 112 | |             &NodeId::Output(ref output_id) => {
[INFO] [stderr] 113 | |                 let output = {
[INFO] [stderr] 114 | |                     if let Some(Some(output)) = self.outputs.get(output_id) {
[INFO] [stderr] ...   |
[INFO] [stderr] 128 | |             }
[INFO] [stderr] 129 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 111 |         match *node_id {
[INFO] [stderr] 112 |             NodeId::Output(ref output_id) => {
[INFO] [stderr] 113 |                 let output = {
[INFO] [stderr] 114 |                     if let Some(Some(output)) = self.outputs.get(output_id) {
[INFO] [stderr] 115 |                         *output
[INFO] [stderr] 116 |                     } else {
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/dst/node.rs:31:9
[INFO] [stderr]    |
[INFO] [stderr] 31 | /         match self {
[INFO] [stderr] 32 | |             &Node::Transform(t) => Cow::Borrowed(t.name),
[INFO] [stderr] 33 | |             &Node::Output(_) => {
[INFO] [stderr] 34 | |                 if let NodeId::Output(output_id) = id {
[INFO] [stderr] ...  |
[INFO] [stderr] 40 | |             }
[INFO] [stderr] 41 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 31 |         match *self {
[INFO] [stderr] 32 |             Node::Transform(t) => Cow::Borrowed(t.name),
[INFO] [stderr] 33 |             Node::Output(_) => {
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/dst/node.rs:46:9
[INFO] [stderr]    |
[INFO] [stderr] 46 | /         match self {
[INFO] [stderr] 47 | |             &Node::Transform(t) => t.input.as_slice(),
[INFO] [stderr] 48 | |             &Node::Output(_) => &[(OUTPUT_NODE_SLOT, None)],
[INFO] [stderr] 49 | |         }.iter()
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 46 |         match *self {
[INFO] [stderr] 47 |             Node::Transform(t) => t.input.as_slice(),
[INFO] [stderr] 48 |             Node::Output(_) => &[(OUTPUT_NODE_SLOT, None)],
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/dst/node.rs:55:9
[INFO] [stderr]    |
[INFO] [stderr] 55 | /         match self {
[INFO] [stderr] 56 | |             &Node::Transform(t) => t.input.as_slice(),
[INFO] [stderr] 57 | |             &Node::Output(_) => &[(OUTPUT_NODE_SLOT, None)],
[INFO] [stderr] 58 | |         }.iter()
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 55 |         match *self {
[INFO] [stderr] 56 |             Node::Transform(t) => t.input.as_slice(),
[INFO] [stderr] 57 |             Node::Output(_) => &[(OUTPUT_NODE_SLOT, None)],
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/dst/node.rs:64:9
[INFO] [stderr]    |
[INFO] [stderr] 64 | /         match self {
[INFO] [stderr] 65 | |             &Node::Transform(t) => t.input.len(),
[INFO] [stderr] 66 | |             &Node::Output(_) => 1,
[INFO] [stderr] 67 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 64 |         match *self {
[INFO] [stderr] 65 |             Node::Transform(t) => t.input.len(),
[INFO] [stderr] 66 |             Node::Output(_) => 1,
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/dst/node.rs:73:9
[INFO] [stderr]    |
[INFO] [stderr] 73 | /         match self {
[INFO] [stderr] 74 | |             &Node::Transform(t) => t.output.iter(),
[INFO] [stderr] 75 | |             &Node::Output(_) => OUTPUT_NODE_SLOTS.iter(),
[INFO] [stderr] 76 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 73 |         match *self {
[INFO] [stderr] 74 |             Node::Transform(t) => t.output.iter(),
[INFO] [stderr] 75 |             Node::Output(_) => OUTPUT_NODE_SLOTS.iter(),
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/dst/node.rs:81:9
[INFO] [stderr]    |
[INFO] [stderr] 81 | /         match self {
[INFO] [stderr] 82 | |             &Node::Transform(t) => t.output.len(),
[INFO] [stderr] 83 | |             &Node::Output(_) => 0,
[INFO] [stderr] 84 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 81 |         match *self {
[INFO] [stderr] 82 |             Node::Transform(t) => t.output.len(),
[INFO] [stderr] 83 |             Node::Output(_) => 0,
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/dst/mod.rs:184:15
[INFO] [stderr]     |
[INFO] [stderr] 184 |     pub fn id(&self) -> usize {
[INFO] [stderr]     |               ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/dst/mod.rs:193:15
[INFO] [stderr]     |
[INFO] [stderr] 193 |     pub fn id(&self) -> usize {
[INFO] [stderr]     |               ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: called `.iter().nth()` on a Vec. Calling `.get()` is both faster and more readable
[INFO] [stderr]   --> src/export.rs:81:37
[INFO] [stderr]    |
[INFO] [stderr] 81 |                   let first_variant = constants
[INFO] [stderr]    |  _____________________________________^
[INFO] [stderr] 82 | |                     .iter()
[INFO] [stderr] 83 | |                     .nth(0)
[INFO] [stderr]    | |___________________________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::iter_nth)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_nth
[INFO] [stderr] 
[INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions
[INFO] [stderr]   --> src/transform.rs:18:14
[INFO] [stderr]    |
[INFO] [stderr] 18 |     Function(fn(Vec<Cow<T>>) -> Vec<Result<T, E>>),
[INFO] [stderr]    |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/transform.rs:26:9
[INFO] [stderr]    |
[INFO] [stderr] 26 | /         match self {
[INFO] [stderr] 27 | |             &Algorithm::Function(ref fun) => write!(f, "Function({:p})", fun),
[INFO] [stderr] 28 | |             &Algorithm::Constant(ref vec) => write!(f, "Constant({:?})", vec),
[INFO] [stderr] 29 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 26 |         match *self {
[INFO] [stderr] 27 |             Algorithm::Function(ref fun) => write!(f, "Function({:p})", fun),
[INFO] [stderr] 28 |             Algorithm::Constant(ref vec) => write!(f, "Constant({:?})", vec),
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/transform.rs:154:25
[INFO] [stderr]     |
[INFO] [stderr] 154 |                   output: match self.algorithm {
[INFO] [stderr]     |  _________________________^
[INFO] [stderr] 155 | |                     &Algorithm::Function(f) => f(self.input).into_iter(),
[INFO] [stderr] 156 | |                     &Algorithm::Constant(ref c) => c
[INFO] [stderr] 157 | |                         .clone()
[INFO] [stderr] ...   |
[INFO] [stderr] 161 | |                         .into_iter(),
[INFO] [stderr] 162 | |                 },
[INFO] [stderr]     | |_________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 154 |                 output: match *self.algorithm {
[INFO] [stderr] 155 |                     Algorithm::Function(f) => f(self.input).into_iter(),
[INFO] [stderr] 156 |                     Algorithm::Constant(ref c) => c
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to previous error
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `aflak_cake`.
[INFO] [stderr] 
[INFO] [stderr] To learn more, run the command again with --verbose.
[INFO] running `"docker" "inspect" "7e47922c93088da8e30bb4c0d959ebfb3f92dd355fa5b746c7ff7129f927854e"`
[INFO] running `"docker" "rm" "-f" "7e47922c93088da8e30bb4c0d959ebfb3f92dd355fa5b746c7ff7129f927854e"`
[INFO] [stdout] 7e47922c93088da8e30bb4c0d959ebfb3f92dd355fa5b746c7ff7129f927854e