[INFO] crate af_packet 0.3.0 is already in cache [INFO] extracting crate af_packet 0.3.0 into work/ex/clippy-test-run/sources/stable/reg/af_packet/0.3.0 [INFO] extracting crate af_packet 0.3.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/af_packet/0.3.0 [INFO] validating manifest of af_packet-0.3.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of af_packet-0.3.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing af_packet-0.3.0 [INFO] finished frobbing af_packet-0.3.0 [INFO] frobbed toml for af_packet-0.3.0 written to work/ex/clippy-test-run/sources/stable/reg/af_packet/0.3.0/Cargo.toml [INFO] started frobbing af_packet-0.3.0 [INFO] finished frobbing af_packet-0.3.0 [INFO] frobbed toml for af_packet-0.3.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/af_packet/0.3.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting af_packet-0.3.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/af_packet/0.3.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d7a46091a3056457f23ff30a8a95bfdc3df53450d74f4cd5f71843d5ae27ad79 [INFO] running `"docker" "start" "-a" "d7a46091a3056457f23ff30a8a95bfdc3df53450d74f4cd5f71843d5ae27ad79"` [INFO] [stderr] Checking af_packet v0.3.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rx.rs:269:13 [INFO] [stderr] | [INFO] [stderr] 269 | block_desc: block_desc, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `block_desc` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rx.rs:269:13 [INFO] [stderr] | [INFO] [stderr] 269 | block_desc: block_desc, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `block_desc` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/tpacket3.rs:100:26 [INFO] [stderr] | [INFO] [stderr] 100 | tp_frame_nr: 160000, [INFO] [stderr] | ^^^^^^ help: consider: `160_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/tpacket3.rs:100:26 [INFO] [stderr] | [INFO] [stderr] 100 | tp_frame_nr: 160000, [INFO] [stderr] | ^^^^^^ help: consider: `160_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a pointer [INFO] [stderr] --> src/rx.rs:228:33 [INFO] [stderr] | [INFO] [stderr] 228 | let addr_ptr = unsafe { mem::transmute::<*mut sockaddr_ll, *mut sockaddr>(&mut sa) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut sa as *mut libc::sockaddr_ll as *mut libc::sockaddr` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_transmute)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/socket.rs:42:26 [INFO] [stderr] | [INFO] [stderr] 42 | c_short::from_be((self.data[0] as c_short) << 8 | (self.data[1] as c_short)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i16::from(self.data[0])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/socket.rs:42:59 [INFO] [stderr] | [INFO] [stderr] 42 | c_short::from_be((self.data[0] as c_short) << 8 | (self.data[1] as c_short)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i16::from(self.data[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/socket.rs:97:57 [INFO] [stderr] | [INFO] [stderr] 97 | let fd = unsafe { socket(socket_type, SOCK_RAW, (ETH_P_ALL as u16).to_be() as i32) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from((ETH_P_ALL as u16).to_be())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/socket.rs:148:55 [INFO] [stderr] | [INFO] [stderr] 148 | pub fn getsockopt(&mut self, opt: c_int, opt_val: &*mut c_void) -> io::Result<()> { [INFO] [stderr] | ^^^^^^^^^^^^ help: consider passing by value instead: `*mut c_void` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/socket.rs:153:51 [INFO] [stderr] | [INFO] [stderr] 153 | pub fn get_sock_opt(fd: i32, opt: c_int, opt_val: &*mut c_void) -> io::Result<()> { [INFO] [stderr] | ^^^^^^^^^^^^ help: consider passing by value instead: `*mut c_void` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a pointer [INFO] [stderr] --> src/tx.rs:32:33 [INFO] [stderr] | [INFO] [stderr] 32 | let addr_ptr = unsafe { mem::transmute::<*mut sockaddr_ll, *mut sockaddr>(&mut sa) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut sa as *mut libc::sockaddr_ll as *mut libc::sockaddr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a pointer [INFO] [stderr] --> src/rx.rs:228:33 [INFO] [stderr] | [INFO] [stderr] 228 | let addr_ptr = unsafe { mem::transmute::<*mut sockaddr_ll, *mut sockaddr>(&mut sa) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut sa as *mut libc::sockaddr_ll as *mut libc::sockaddr` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_transmute)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/socket.rs:42:26 [INFO] [stderr] | [INFO] [stderr] 42 | c_short::from_be((self.data[0] as c_short) << 8 | (self.data[1] as c_short)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i16::from(self.data[0])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/socket.rs:42:59 [INFO] [stderr] | [INFO] [stderr] 42 | c_short::from_be((self.data[0] as c_short) << 8 | (self.data[1] as c_short)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i16::from(self.data[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/socket.rs:97:57 [INFO] [stderr] | [INFO] [stderr] 97 | let fd = unsafe { socket(socket_type, SOCK_RAW, (ETH_P_ALL as u16).to_be() as i32) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from((ETH_P_ALL as u16).to_be())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/socket.rs:148:55 [INFO] [stderr] | [INFO] [stderr] 148 | pub fn getsockopt(&mut self, opt: c_int, opt_val: &*mut c_void) -> io::Result<()> { [INFO] [stderr] | ^^^^^^^^^^^^ help: consider passing by value instead: `*mut c_void` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/socket.rs:153:51 [INFO] [stderr] | [INFO] [stderr] 153 | pub fn get_sock_opt(fd: i32, opt: c_int, opt_val: &*mut c_void) -> io::Result<()> { [INFO] [stderr] | ^^^^^^^^^^^^ help: consider passing by value instead: `*mut c_void` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a pointer [INFO] [stderr] --> src/tx.rs:32:33 [INFO] [stderr] | [INFO] [stderr] 32 | let addr_ptr = unsafe { mem::transmute::<*mut sockaddr_ll, *mut sockaddr>(&mut sa) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut sa as *mut libc::sockaddr_ll as *mut libc::sockaddr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.26s [INFO] running `"docker" "inspect" "d7a46091a3056457f23ff30a8a95bfdc3df53450d74f4cd5f71843d5ae27ad79"` [INFO] running `"docker" "rm" "-f" "d7a46091a3056457f23ff30a8a95bfdc3df53450d74f4cd5f71843d5ae27ad79"` [INFO] [stdout] d7a46091a3056457f23ff30a8a95bfdc3df53450d74f4cd5f71843d5ae27ad79