[INFO] crate aerospike 0.3.0 is already in cache [INFO] extracting crate aerospike 0.3.0 into work/ex/clippy-test-run/sources/stable/reg/aerospike/0.3.0 [INFO] extracting crate aerospike 0.3.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/aerospike/0.3.0 [INFO] validating manifest of aerospike-0.3.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of aerospike-0.3.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing aerospike-0.3.0 [INFO] finished frobbing aerospike-0.3.0 [INFO] frobbed toml for aerospike-0.3.0 written to work/ex/clippy-test-run/sources/stable/reg/aerospike/0.3.0/Cargo.toml [INFO] started frobbing aerospike-0.3.0 [INFO] finished frobbing aerospike-0.3.0 [INFO] frobbed toml for aerospike-0.3.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/aerospike/0.3.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting aerospike-0.3.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/aerospike/0.3.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 4c03829cdfe1fda606124e72643caf479d41ad981f9c71f1ff9b235c0b2a877f [INFO] running `"docker" "start" "-a" "4c03829cdfe1fda606124e72643caf479d41ad981f9c71f1ff9b235c0b2a877f"` [INFO] [stderr] Checking aerospike v0.3.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin.rs:33:13 [INFO] [stderr] | [INFO] [stderr] 33 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/batch/batch_read.rs:36:13 [INFO] [stderr] | [INFO] [stderr] 36 | key: key, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `key` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/batch/batch_read.rs:37:13 [INFO] [stderr] | [INFO] [stderr] 37 | bins: bins, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `bins` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/batch/batch_executor.rs:41:13 [INFO] [stderr] | [INFO] [stderr] 41 | cluster: cluster, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `cluster` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/batch/batch_executor.rs:42:13 [INFO] [stderr] | [INFO] [stderr] 42 | thread_pool: thread_pool, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `thread_pool` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client.rs:109:13 [INFO] [stderr] | [INFO] [stderr] 109 | cluster: cluster, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `cluster` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client.rs:110:13 [INFO] [stderr] | [INFO] [stderr] 110 | thread_pool: thread_pool, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `thread_pool` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cluster/partition.rs:33:13 [INFO] [stderr] | [INFO] [stderr] 33 | namespace: namespace, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `namespace` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cluster/partition.rs:34:13 [INFO] [stderr] | [INFO] [stderr] 34 | partition_id: partition_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `partition_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/commands/info_command.rs:48:22 [INFO] [stderr] | [INFO] [stderr] 48 | Ok(Message { buf: buf }) [INFO] [stderr] | ^^^^^^^^ help: replace it with: `buf` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/commands/single_command.rs:38:13 [INFO] [stderr] | [INFO] [stderr] 38 | key: key, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `key` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/commands/single_command.rs:39:13 [INFO] [stderr] | [INFO] [stderr] 39 | partition: partition, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `partition` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/commands/read_command.rs:44:13 [INFO] [stderr] | [INFO] [stderr] 44 | bins: bins, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `bins` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/commands/read_command.rs:45:13 [INFO] [stderr] | [INFO] [stderr] 45 | policy: policy, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `policy` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/commands/write_command.rs:46:13 [INFO] [stderr] | [INFO] [stderr] 46 | bins: bins, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `bins` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/commands/write_command.rs:47:13 [INFO] [stderr] | [INFO] [stderr] 47 | policy: policy, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `policy` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/commands/write_command.rs:48:13 [INFO] [stderr] | [INFO] [stderr] 48 | operation: operation, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `operation` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/commands/delete_command.rs:37:13 [INFO] [stderr] | [INFO] [stderr] 37 | policy: policy, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `policy` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/commands/touch_command.rs:36:13 [INFO] [stderr] | [INFO] [stderr] 36 | policy: policy, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `policy` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/commands/exists_command.rs:37:13 [INFO] [stderr] | [INFO] [stderr] 37 | policy: policy, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `policy` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/commands/operate_command.rs:42:13 [INFO] [stderr] | [INFO] [stderr] 42 | policy: policy, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `policy` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/commands/operate_command.rs:43:13 [INFO] [stderr] | [INFO] [stderr] 43 | operations: operations, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `operations` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/commands/execute_udf_command.rs:47:13 [INFO] [stderr] | [INFO] [stderr] 47 | policy: policy, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `policy` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/commands/execute_udf_command.rs:48:13 [INFO] [stderr] | [INFO] [stderr] 48 | package_name: package_name, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `package_name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/commands/execute_udf_command.rs:49:13 [INFO] [stderr] | [INFO] [stderr] 49 | function_name: function_name, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `function_name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/commands/execute_udf_command.rs:50:13 [INFO] [stderr] | [INFO] [stderr] 50 | args: args, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `args` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/commands/stream_command.rs:48:13 [INFO] [stderr] | [INFO] [stderr] 48 | node: node, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `node` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/commands/stream_command.rs:49:13 [INFO] [stderr] | [INFO] [stderr] 49 | recordset: recordset, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `recordset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/commands/stream_command.rs:174:13 [INFO] [stderr] | [INFO] [stderr] 174 | namespace: namespace, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `namespace` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/commands/stream_command.rs:175:13 [INFO] [stderr] | [INFO] [stderr] 175 | set_name: set_name, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `set_name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/commands/stream_command.rs:177:13 [INFO] [stderr] | [INFO] [stderr] 177 | digest: digest, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `digest` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/commands/scan_command.rs:46:13 [INFO] [stderr] | [INFO] [stderr] 46 | policy: policy, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `policy` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/commands/scan_command.rs:47:13 [INFO] [stderr] | [INFO] [stderr] 47 | namespace: namespace, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `namespace` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/commands/scan_command.rs:48:13 [INFO] [stderr] | [INFO] [stderr] 48 | set_name: set_name, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `set_name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/commands/scan_command.rs:49:13 [INFO] [stderr] | [INFO] [stderr] 49 | bins: bins, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `bins` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/commands/query_command.rs:41:13 [INFO] [stderr] | [INFO] [stderr] 41 | policy: policy, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `policy` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/commands/query_command.rs:42:13 [INFO] [stderr] | [INFO] [stderr] 42 | statement: statement, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `statement` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/commands/batch_read_command.rs:52:13 [INFO] [stderr] | [INFO] [stderr] 52 | policy: policy, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `policy` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/commands/batch_read_command.rs:53:13 [INFO] [stderr] | [INFO] [stderr] 53 | node: node, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `node` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/commands/batch_read_command.rs:54:13 [INFO] [stderr] | [INFO] [stderr] 54 | batch_reads: batch_reads, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `batch_reads` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/commands/batch_read_command.rs:55:13 [INFO] [stderr] | [INFO] [stderr] 55 | offsets: offsets, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `offsets` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/commands/batch_read_command.rs:211:13 [INFO] [stderr] | [INFO] [stderr] 211 | record: record, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `record` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/net/host.rs:39:13 [INFO] [stderr] | [INFO] [stderr] 39 | port: port, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `port` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/net/connection_pool.rs:56:13 [INFO] [stderr] | [INFO] [stderr] 56 | capacity: capacity, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `capacity` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/net/connection_pool.rs:57:13 [INFO] [stderr] | [INFO] [stderr] 57 | host: host, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `host` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/net/connection_pool.rs:58:13 [INFO] [stderr] | [INFO] [stderr] 58 | policy: policy, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `policy` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/net/connection_pool.rs:146:13 [INFO] [stderr] | [INFO] [stderr] 146 | num_queues: num_queues, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `num_queues` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/net/connection_pool.rs:147:13 [INFO] [stderr] | [INFO] [stderr] 147 | queues: queues, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `queues` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/net/parser.rs:30:13 [INFO] [stderr] | [INFO] [stderr] 30 | default_port: default_port, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `default_port` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/operations/maps.rs:138:13 [INFO] [stderr] | [INFO] [stderr] 138 | order: order, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `order` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/operations/maps.rs:139:13 [INFO] [stderr] | [INFO] [stderr] 139 | write_mode: write_mode, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `write_mode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/operations/maps.rs:219:9 [INFO] [stderr] | [INFO] [stderr] 219 | args: args, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `args` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/operations/maps.rs:244:9 [INFO] [stderr] | [INFO] [stderr] 244 | args: args, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `args` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/operations/maps.rs:273:9 [INFO] [stderr] | [INFO] [stderr] 273 | args: args, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `args` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/operations/maps.rs:302:9 [INFO] [stderr] | [INFO] [stderr] 302 | args: args, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `args` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/operations/maps.rs:386:9 [INFO] [stderr] | [INFO] [stderr] 386 | args: args, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `args` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/operations/maps.rs:456:9 [INFO] [stderr] | [INFO] [stderr] 456 | args: args, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `args` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/operations/maps.rs:622:9 [INFO] [stderr] | [INFO] [stderr] 622 | args: args, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `args` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/operations/maps.rs:671:9 [INFO] [stderr] | [INFO] [stderr] 671 | args: args, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `args` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/query/filter.rs:61:13 [INFO] [stderr] | [INFO] [stderr] 61 | collection_index_type: collection_index_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `collection_index_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/query/filter.rs:62:13 [INFO] [stderr] | [INFO] [stderr] 62 | value_particle_type: value_particle_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `value_particle_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/query/filter.rs:63:13 [INFO] [stderr] | [INFO] [stderr] 63 | begin: begin, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `begin` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/query/filter.rs:64:13 [INFO] [stderr] | [INFO] [stderr] 64 | end: end, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `end` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/query/statement.rs:69:13 [INFO] [stderr] | [INFO] [stderr] 69 | bins: bins, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `bins` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/record.rs:55:13 [INFO] [stderr] | [INFO] [stderr] 55 | key: key, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `key` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/record.rs:56:13 [INFO] [stderr] | [INFO] [stderr] 56 | bins: bins, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `bins` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/record.rs:57:13 [INFO] [stderr] | [INFO] [stderr] 57 | generation: generation, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `generation` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/record.rs:58:13 [INFO] [stderr] | [INFO] [stderr] 58 | expiration: expiration, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `expiration` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin.rs:33:13 [INFO] [stderr] | [INFO] [stderr] 33 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/batch/batch_read.rs:36:13 [INFO] [stderr] | [INFO] [stderr] 36 | key: key, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `key` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/batch/batch_read.rs:37:13 [INFO] [stderr] | [INFO] [stderr] 37 | bins: bins, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `bins` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/batch/batch_executor.rs:41:13 [INFO] [stderr] | [INFO] [stderr] 41 | cluster: cluster, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `cluster` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/batch/batch_executor.rs:42:13 [INFO] [stderr] | [INFO] [stderr] 42 | thread_pool: thread_pool, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `thread_pool` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client.rs:109:13 [INFO] [stderr] | [INFO] [stderr] 109 | cluster: cluster, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `cluster` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client.rs:110:13 [INFO] [stderr] | [INFO] [stderr] 110 | thread_pool: thread_pool, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `thread_pool` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cluster/partition.rs:33:13 [INFO] [stderr] | [INFO] [stderr] 33 | namespace: namespace, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `namespace` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cluster/partition.rs:34:13 [INFO] [stderr] | [INFO] [stderr] 34 | partition_id: partition_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `partition_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/commands/info_command.rs:48:22 [INFO] [stderr] | [INFO] [stderr] 48 | Ok(Message { buf: buf }) [INFO] [stderr] | ^^^^^^^^ help: replace it with: `buf` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/commands/single_command.rs:38:13 [INFO] [stderr] | [INFO] [stderr] 38 | key: key, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `key` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/commands/single_command.rs:39:13 [INFO] [stderr] | [INFO] [stderr] 39 | partition: partition, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `partition` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/commands/read_command.rs:44:13 [INFO] [stderr] | [INFO] [stderr] 44 | bins: bins, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `bins` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/commands/read_command.rs:45:13 [INFO] [stderr] | [INFO] [stderr] 45 | policy: policy, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `policy` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/commands/write_command.rs:46:13 [INFO] [stderr] | [INFO] [stderr] 46 | bins: bins, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `bins` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/commands/write_command.rs:47:13 [INFO] [stderr] | [INFO] [stderr] 47 | policy: policy, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `policy` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/commands/write_command.rs:48:13 [INFO] [stderr] | [INFO] [stderr] 48 | operation: operation, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `operation` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/commands/delete_command.rs:37:13 [INFO] [stderr] | [INFO] [stderr] 37 | policy: policy, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `policy` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/commands/touch_command.rs:36:13 [INFO] [stderr] | [INFO] [stderr] 36 | policy: policy, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `policy` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/commands/exists_command.rs:37:13 [INFO] [stderr] | [INFO] [stderr] 37 | policy: policy, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `policy` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/commands/operate_command.rs:42:13 [INFO] [stderr] | [INFO] [stderr] 42 | policy: policy, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `policy` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/commands/operate_command.rs:43:13 [INFO] [stderr] | [INFO] [stderr] 43 | operations: operations, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `operations` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/commands/execute_udf_command.rs:47:13 [INFO] [stderr] | [INFO] [stderr] 47 | policy: policy, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `policy` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/commands/execute_udf_command.rs:48:13 [INFO] [stderr] | [INFO] [stderr] 48 | package_name: package_name, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `package_name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/commands/execute_udf_command.rs:49:13 [INFO] [stderr] | [INFO] [stderr] 49 | function_name: function_name, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `function_name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/commands/execute_udf_command.rs:50:13 [INFO] [stderr] | [INFO] [stderr] 50 | args: args, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `args` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/commands/stream_command.rs:48:13 [INFO] [stderr] | [INFO] [stderr] 48 | node: node, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `node` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/commands/stream_command.rs:49:13 [INFO] [stderr] | [INFO] [stderr] 49 | recordset: recordset, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `recordset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/commands/stream_command.rs:174:13 [INFO] [stderr] | [INFO] [stderr] 174 | namespace: namespace, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `namespace` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/commands/stream_command.rs:175:13 [INFO] [stderr] | [INFO] [stderr] 175 | set_name: set_name, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `set_name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/commands/stream_command.rs:177:13 [INFO] [stderr] | [INFO] [stderr] 177 | digest: digest, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `digest` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/commands/scan_command.rs:46:13 [INFO] [stderr] | [INFO] [stderr] 46 | policy: policy, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `policy` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/commands/scan_command.rs:47:13 [INFO] [stderr] | [INFO] [stderr] 47 | namespace: namespace, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `namespace` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/commands/scan_command.rs:48:13 [INFO] [stderr] | [INFO] [stderr] 48 | set_name: set_name, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `set_name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/commands/scan_command.rs:49:13 [INFO] [stderr] | [INFO] [stderr] 49 | bins: bins, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `bins` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/commands/query_command.rs:41:13 [INFO] [stderr] | [INFO] [stderr] 41 | policy: policy, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `policy` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/commands/query_command.rs:42:13 [INFO] [stderr] | [INFO] [stderr] 42 | statement: statement, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `statement` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/commands/batch_read_command.rs:52:13 [INFO] [stderr] | [INFO] [stderr] 52 | policy: policy, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `policy` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/commands/batch_read_command.rs:53:13 [INFO] [stderr] | [INFO] [stderr] 53 | node: node, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `node` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/commands/batch_read_command.rs:54:13 [INFO] [stderr] | [INFO] [stderr] 54 | batch_reads: batch_reads, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `batch_reads` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/commands/batch_read_command.rs:55:13 [INFO] [stderr] | [INFO] [stderr] 55 | offsets: offsets, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `offsets` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/commands/batch_read_command.rs:211:13 [INFO] [stderr] | [INFO] [stderr] 211 | record: record, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `record` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/net/host.rs:39:13 [INFO] [stderr] | [INFO] [stderr] 39 | port: port, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `port` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/net/connection_pool.rs:56:13 [INFO] [stderr] | [INFO] [stderr] 56 | capacity: capacity, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `capacity` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/net/connection_pool.rs:57:13 [INFO] [stderr] | [INFO] [stderr] 57 | host: host, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `host` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/net/connection_pool.rs:58:13 [INFO] [stderr] | [INFO] [stderr] 58 | policy: policy, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `policy` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/net/connection_pool.rs:146:13 [INFO] [stderr] | [INFO] [stderr] 146 | num_queues: num_queues, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `num_queues` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/net/connection_pool.rs:147:13 [INFO] [stderr] | [INFO] [stderr] 147 | queues: queues, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `queues` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/net/parser.rs:30:13 [INFO] [stderr] | [INFO] [stderr] 30 | default_port: default_port, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `default_port` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/operations/maps.rs:138:13 [INFO] [stderr] | [INFO] [stderr] 138 | order: order, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `order` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/operations/maps.rs:139:13 [INFO] [stderr] | [INFO] [stderr] 139 | write_mode: write_mode, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `write_mode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/operations/maps.rs:219:9 [INFO] [stderr] | [INFO] [stderr] 219 | args: args, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `args` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/operations/maps.rs:244:9 [INFO] [stderr] | [INFO] [stderr] 244 | args: args, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `args` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/operations/maps.rs:273:9 [INFO] [stderr] | [INFO] [stderr] 273 | args: args, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `args` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/operations/maps.rs:302:9 [INFO] [stderr] | [INFO] [stderr] 302 | args: args, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `args` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/operations/maps.rs:386:9 [INFO] [stderr] | [INFO] [stderr] 386 | args: args, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `args` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/operations/maps.rs:456:9 [INFO] [stderr] | [INFO] [stderr] 456 | args: args, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `args` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/operations/maps.rs:622:9 [INFO] [stderr] | [INFO] [stderr] 622 | args: args, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `args` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/operations/maps.rs:671:9 [INFO] [stderr] | [INFO] [stderr] 671 | args: args, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `args` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/query/filter.rs:61:13 [INFO] [stderr] | [INFO] [stderr] 61 | collection_index_type: collection_index_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `collection_index_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/query/filter.rs:62:13 [INFO] [stderr] | [INFO] [stderr] 62 | value_particle_type: value_particle_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `value_particle_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/query/filter.rs:63:13 [INFO] [stderr] | [INFO] [stderr] 63 | begin: begin, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `begin` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/query/filter.rs:64:13 [INFO] [stderr] | [INFO] [stderr] 64 | end: end, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `end` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/query/statement.rs:69:13 [INFO] [stderr] | [INFO] [stderr] 69 | bins: bins, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `bins` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/record.rs:55:13 [INFO] [stderr] | [INFO] [stderr] 55 | key: key, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `key` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/record.rs:56:13 [INFO] [stderr] | [INFO] [stderr] 56 | bins: bins, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `bins` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/record.rs:57:13 [INFO] [stderr] | [INFO] [stderr] 57 | generation: generation, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `generation` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/record.rs:58:13 [INFO] [stderr] | [INFO] [stderr] 58 | expiration: expiration, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `expiration` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/cluster/partition_tokenizer.rs:30:23 [INFO] [stderr] | [INFO] [stderr] 30 | const REPLICAS_NAME: &'static str = "replicas-master"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/commands/single_command.rs:52:35 [INFO] [stderr] | [INFO] [stderr] 52 | let receive_size = ((sz & 0xFFFFFFFFFFFF) - header_length) as usize; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider: `0xFFFF_FFFF_FFFF` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/commands/read_command.rs:87:25 [INFO] [stderr] | [INFO] [stderr] 87 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/commands/read_command.rs:93:29 [INFO] [stderr] | [INFO] [stderr] 93 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/commands/read_command.rs:137:35 [INFO] [stderr] | [INFO] [stderr] 137 | let receive_size = ((sz & 0xFFFFFFFFFFFF) - header_length as u64) as usize; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider: `0xFFFF_FFFF_FFFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/commands/buffer.rs:1140:27 [INFO] [stderr] | [INFO] [stderr] 1140 | let size = size & 0xFFFFFFFFFFFF; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider: `0xFFFF_FFFF_FFFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/msgpack/decoder.rs:127:13 [INFO] [stderr] | [INFO] [stderr] 127 | return Ok(Value::from(try!(unpack_blob(buf, count as usize)))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Value::from(try!(unpack_blob(buf, count as usize))))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/msgpack/decoder.rs:131:13 [INFO] [stderr] | [INFO] [stderr] 131 | return Ok(Value::from(try!(unpack_blob(buf, count as usize)))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Value::from(try!(unpack_blob(buf, count as usize))))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/msgpack/decoder.rs:135:13 [INFO] [stderr] | [INFO] [stderr] 135 | return Ok(Value::from(try!(unpack_blob(buf, count as usize)))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Value::from(try!(unpack_blob(buf, count as usize))))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/policy/expiration.rs:18:32 [INFO] [stderr] | [INFO] [stderr] 18 | const NAMESPACE_DEFAULT: u32 = 0x00000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/policy/expiration.rs:19:27 [INFO] [stderr] | [INFO] [stderr] 19 | const NEVER_EXPIRE: u32 = 0xFFFFFFFF; // -1 as i32 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xFFFF_FFFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/policy/expiration.rs:20:26 [INFO] [stderr] | [INFO] [stderr] 20 | const DONT_UPDATE: u32 = 0xFFFFFFFE; // -2 as i32 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xFFFF_FFFE` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/policy/read_policy.rs:31:58 [INFO] [stderr] | [INFO] [stderr] 31 | sleep_between_retries: Some(Duration::new(0, 500000000)), [INFO] [stderr] | ^^^^^^^^^ help: consider: `500_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/record.rs:25:76 [INFO] [stderr] | [INFO] [stderr] 25 | pub static ref CITRUSLEAF_EPOCH: SystemTime = UNIX_EPOCH + Duration::new(1262304000, 0); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_262_304_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/value.rs:718:25 [INFO] [stderr] | [INFO] [stderr] 718 | Value::UInt(9223372036854775808).as_string(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `9_223_372_036_854_775_808` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/key.rs:215:38 [INFO] [stderr] | [INFO] [stderr] 215 | digest!(str_repeat!('+', 100000)), [INFO] [stderr] | ^^^^^^ help: consider: `100_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/key.rs:257:37 [INFO] [stderr] | [INFO] [stderr] 257 | digest!(vec!['+' as u8; 100000]), [INFO] [stderr] | ^^^^^^ help: consider: `100_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/cluster/partition_tokenizer.rs:30:23 [INFO] [stderr] | [INFO] [stderr] 30 | const REPLICAS_NAME: &'static str = "replicas-master"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/commands/single_command.rs:52:35 [INFO] [stderr] | [INFO] [stderr] 52 | let receive_size = ((sz & 0xFFFFFFFFFFFF) - header_length) as usize; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider: `0xFFFF_FFFF_FFFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/commands/read_command.rs:87:25 [INFO] [stderr] | [INFO] [stderr] 87 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/commands/read_command.rs:93:29 [INFO] [stderr] | [INFO] [stderr] 93 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/commands/read_command.rs:137:35 [INFO] [stderr] | [INFO] [stderr] 137 | let receive_size = ((sz & 0xFFFFFFFFFFFF) - header_length as u64) as usize; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider: `0xFFFF_FFFF_FFFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/commands/buffer.rs:1140:27 [INFO] [stderr] | [INFO] [stderr] 1140 | let size = size & 0xFFFFFFFFFFFF; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider: `0xFFFF_FFFF_FFFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/msgpack/decoder.rs:127:13 [INFO] [stderr] | [INFO] [stderr] 127 | return Ok(Value::from(try!(unpack_blob(buf, count as usize)))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Value::from(try!(unpack_blob(buf, count as usize))))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/msgpack/decoder.rs:131:13 [INFO] [stderr] | [INFO] [stderr] 131 | return Ok(Value::from(try!(unpack_blob(buf, count as usize)))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Value::from(try!(unpack_blob(buf, count as usize))))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/msgpack/decoder.rs:135:13 [INFO] [stderr] | [INFO] [stderr] 135 | return Ok(Value::from(try!(unpack_blob(buf, count as usize)))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Value::from(try!(unpack_blob(buf, count as usize))))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/policy/expiration.rs:18:32 [INFO] [stderr] | [INFO] [stderr] 18 | const NAMESPACE_DEFAULT: u32 = 0x00000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/policy/expiration.rs:19:27 [INFO] [stderr] | [INFO] [stderr] 19 | const NEVER_EXPIRE: u32 = 0xFFFFFFFF; // -1 as i32 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xFFFF_FFFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/policy/expiration.rs:20:26 [INFO] [stderr] | [INFO] [stderr] 20 | const DONT_UPDATE: u32 = 0xFFFFFFFE; // -2 as i32 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xFFFF_FFFE` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/policy/read_policy.rs:31:58 [INFO] [stderr] | [INFO] [stderr] 31 | sleep_between_retries: Some(Duration::new(0, 500000000)), [INFO] [stderr] | ^^^^^^^^^ help: consider: `500_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/record.rs:25:76 [INFO] [stderr] | [INFO] [stderr] 25 | pub static ref CITRUSLEAF_EPOCH: SystemTime = UNIX_EPOCH + Duration::new(1262304000, 0); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_262_304_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/record.rs:120:59 [INFO] [stderr] | [INFO] [stderr] 120 | let record = Record::new(None, HashMap::new(), 0, 0x0d00d21c); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0d00_d21c` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: transmute from a `u64` to a `f64` [INFO] [stderr] --> src/value.rs:51:46 [INFO] [stderr] | [INFO] [stderr] 51 | FloatValue::F64(val) => unsafe { mem::transmute(val) }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider using: `f64::from_bits(val)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_int_to_float)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_int_to_float [INFO] [stderr] [INFO] [stderr] warning: transmute from a `u64` to a `f64` [INFO] [stderr] --> src/value.rs:63:46 [INFO] [stderr] | [INFO] [stderr] 63 | FloatValue::F64(val) => unsafe { mem::transmute(val) }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider using: `f64::from_bits(val)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_int_to_float [INFO] [stderr] [INFO] [stderr] warning: transmute from a `u32` to a `f32` [INFO] [stderr] --> src/value.rs:91:46 [INFO] [stderr] | [INFO] [stderr] 91 | FloatValue::F32(val) => unsafe { mem::transmute(val) }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider using: `f32::from_bits(val)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_int_to_float [INFO] [stderr] [INFO] [stderr] warning: transmute from a `u32` to a `f32` [INFO] [stderr] --> src/value.rs:92:46 [INFO] [stderr] | [INFO] [stderr] 92 | FloatValue::F64(val) => unsafe { mem::transmute(val as u32) }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `f32::from_bits(val as u32)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_int_to_float [INFO] [stderr] [INFO] [stderr] warning: transmute from a `u32` to a `f32` [INFO] [stderr] --> src/value.rs:100:46 [INFO] [stderr] | [INFO] [stderr] 100 | FloatValue::F32(val) => unsafe { mem::transmute(val) }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider using: `f32::from_bits(val)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_int_to_float [INFO] [stderr] [INFO] [stderr] warning: transmute from a `u32` to a `f32` [INFO] [stderr] --> src/value.rs:101:46 [INFO] [stderr] | [INFO] [stderr] 101 | FloatValue::F64(val) => unsafe { mem::transmute(val as u32) }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `f32::from_bits(val as u32)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_int_to_float [INFO] [stderr] [INFO] [stderr] warning: transmute from a `u32` to a `f32` [INFO] [stderr] --> src/value.rs:130:41 [INFO] [stderr] | [INFO] [stderr] 130 | let val: f32 = unsafe { mem::transmute(val) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider using: `f32::from_bits(val)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_int_to_float [INFO] [stderr] [INFO] [stderr] warning: transmute from a `u64` to a `f64` [INFO] [stderr] --> src/value.rs:134:41 [INFO] [stderr] | [INFO] [stderr] 134 | let val: f64 = unsafe { mem::transmute(val) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider using: `f64::from_bits(val)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_int_to_float [INFO] [stderr] [INFO] [stderr] error: you are implementing `Hash` explicitly but have derived `PartialEq` [INFO] [stderr] --> src/value.rs:191:1 [INFO] [stderr] | [INFO] [stderr] 191 | / impl Hash for Value { [INFO] [stderr] 192 | | fn hash(&self, state: &mut H) { [INFO] [stderr] 193 | | match *self { [INFO] [stderr] 194 | | Value::Nil => { [INFO] [stderr] ... | [INFO] [stderr] 209 | | } [INFO] [stderr] 210 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::derive_hash_xor_eq)] on by default [INFO] [stderr] note: `PartialEq` implemented here [INFO] [stderr] --> src/value.rs:142:24 [INFO] [stderr] | [INFO] [stderr] 142 | #[derive(Debug, Clone, PartialEq, Eq)] [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_hash_xor_eq [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/value.rs:413:20 [INFO] [stderr] | [INFO] [stderr] 413 | Value::Int(val as i64) [INFO] [stderr] | ^^^^^^^^^^ help: try: `i64::from(val)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/value.rs:419:20 [INFO] [stderr] | [INFO] [stderr] 419 | Value::Int(val as i64) [INFO] [stderr] | ^^^^^^^^^^ help: try: `i64::from(val)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/value.rs:425:20 [INFO] [stderr] | [INFO] [stderr] 425 | Value::Int(val as i64) [INFO] [stderr] | ^^^^^^^^^^ help: try: `i64::from(val)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/value.rs:431:20 [INFO] [stderr] | [INFO] [stderr] 431 | Value::Int(val as i64) [INFO] [stderr] | ^^^^^^^^^^ help: try: `i64::from(val)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/value.rs:437:20 [INFO] [stderr] | [INFO] [stderr] 437 | Value::Int(val as i64) [INFO] [stderr] | ^^^^^^^^^^ help: try: `i64::from(val)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/value.rs:443:20 [INFO] [stderr] | [INFO] [stderr] 443 | Value::Int(val as i64) [INFO] [stderr] | ^^^^^^^^^^ help: try: `i64::from(val)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/value.rs:473:20 [INFO] [stderr] | [INFO] [stderr] 473 | Value::Int(*val as i64) [INFO] [stderr] | ^^^^^^^^^^^ help: try: `i64::from(*val)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/value.rs:479:20 [INFO] [stderr] | [INFO] [stderr] 479 | Value::Int(*val as i64) [INFO] [stderr] | ^^^^^^^^^^^ help: try: `i64::from(*val)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/value.rs:485:20 [INFO] [stderr] | [INFO] [stderr] 485 | Value::Int(*val as i64) [INFO] [stderr] | ^^^^^^^^^^^ help: try: `i64::from(*val)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/value.rs:491:20 [INFO] [stderr] | [INFO] [stderr] 491 | Value::Int(*val as i64) [INFO] [stderr] | ^^^^^^^^^^^ help: try: `i64::from(*val)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/value.rs:497:20 [INFO] [stderr] | [INFO] [stderr] 497 | Value::Int(*val as i64) [INFO] [stderr] | ^^^^^^^^^^^ help: try: `i64::from(*val)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/value.rs:503:20 [INFO] [stderr] | [INFO] [stderr] 503 | Value::Int(*val as i64) [INFO] [stderr] | ^^^^^^^^^^^ help: try: `i64::from(*val)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/batch/batch_executor.rs:98:22 [INFO] [stderr] | [INFO] [stderr] 98 | batch_reads: &Vec>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: change this to: `&[BatchRead<'a>]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*mut std::vec::Vec`) to a reference type (`&mut std::vec::Vec`) [INFO] [stderr] --> src/batch/batch_executor.rs:147:18 [INFO] [stderr] | [INFO] [stderr] 147 | unsafe { transmute::<*mut Vec, &mut Vec>(self.value.get()).get_mut(idx) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut *self.value.get()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_ptr_to_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/client.rs:857:5 [INFO] [stderr] | [INFO] [stderr] 857 | / pub fn create_complex_index( [INFO] [stderr] 858 | | &self, [INFO] [stderr] 859 | | policy: &WritePolicy, [INFO] [stderr] 860 | | namespace: &str, [INFO] [stderr] ... | [INFO] [stderr] 877 | | .chain_err(|| "Error creating index") [INFO] [stderr] 878 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/client.rs:904:9 [INFO] [stderr] | [INFO] [stderr] 904 | / for v in response.values() { [INFO] [stderr] 905 | | if v.to_uppercase() == "OK" { [INFO] [stderr] 906 | | return Ok(()); [INFO] [stderr] 907 | | } else if v.starts_with("FAIL:") { [INFO] [stderr] ... | [INFO] [stderr] 912 | | } [INFO] [stderr] 913 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::never_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] warning: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)` [INFO] [stderr] --> src/client.rs:908:30 [INFO] [stderr] | [INFO] [stderr] 908 | let result = v.split(':').skip(1).next().unwrap().parse::()?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::iter_skip_next)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_skip_next [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/cluster/node_validator.rs:60:13 [INFO] [stderr] | [INFO] [stderr] 60 | for ref alias in self.aliases() { [INFO] [stderr] | ^^^^^^^^^ -------------- help: try: `let alias = &self.aliases();` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/commands/single_command.rs:51:29 [INFO] [stderr] | [INFO] [stderr] 51 | let header_length = try!(conn.buffer.read_u8(None)) as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 51 | let header_length = i64::from(match $ expr { [INFO] [stderr] 52 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result [INFO] [stderr] 53 | :: Err ( err ) => { [INFO] [stderr] 54 | return $ crate :: result :: Result :: Err ( [INFO] [stderr] 55 | $ crate :: convert :: From :: from ( err ) ) } }); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/commands/read_command.rs:137:53 [INFO] [stderr] | [INFO] [stderr] 137 | let receive_size = ((sz & 0xFFFFFFFFFFFF) - header_length as u64) as usize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(header_length)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `match $ expr { [INFO] [stderr] $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result [INFO] [stderr] :: Err ( err ) => { [INFO] [stderr] return $ crate :: result :: Result :: Err ( [INFO] [stderr] $ crate :: convert :: From :: from ( err ) ) } }` [INFO] [stderr] --> src/commands/write_command.rs:89:44 [INFO] [stderr] | [INFO] [stderr] 89 | let result_code = ResultCode::from(try!(conn.buffer.read_u8(Some(13))) & 0xFF); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `match $ expr { [INFO] [stderr] $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result [INFO] [stderr] :: Err ( err ) => { [INFO] [stderr] return $ crate :: result :: Result :: Err ( [INFO] [stderr] $ crate :: convert :: From :: from ( err ) ) } }` [INFO] [stderr] --> src/commands/delete_command.rs:76:44 [INFO] [stderr] | [INFO] [stderr] 76 | let result_code = ResultCode::from(try!(conn.buffer.read_u8(Some(13))) & 0xFF); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `match $ expr { [INFO] [stderr] $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result [INFO] [stderr] :: Err ( err ) => { [INFO] [stderr] return $ crate :: result :: Result :: Err ( [INFO] [stderr] $ crate :: convert :: From :: from ( err ) ) } }` [INFO] [stderr] --> src/commands/touch_command.rs:72:44 [INFO] [stderr] | [INFO] [stderr] 72 | let result_code = ResultCode::from(try!(conn.buffer.read_u8(Some(13))) & 0xFF); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `match $ expr { [INFO] [stderr] $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result [INFO] [stderr] :: Err ( err ) => { [INFO] [stderr] return $ crate :: result :: Result :: Err ( [INFO] [stderr] $ crate :: convert :: From :: from ( err ) ) } }` [INFO] [stderr] --> src/commands/exists_command.rs:76:44 [INFO] [stderr] | [INFO] [stderr] 76 | let result_code = ResultCode::from(try!(conn.buffer.read_u8(Some(13))) & 0xFF); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `match $ expr { [INFO] [stderr] $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result [INFO] [stderr] :: Err ( err ) => { [INFO] [stderr] return $ crate :: result :: Result :: Err ( [INFO] [stderr] $ crate :: convert :: From :: from ( err ) ) } }` [INFO] [stderr] --> src/commands/stream_command.rs:56:44 [INFO] [stderr] | [INFO] [stderr] 56 | let result_code = ResultCode::from(try!(conn.buffer.read_u8(Some(5))) & 0xFF); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/commands/buffer.rs:143:56 [INFO] [stderr] | [INFO] [stderr] 143 | let size = ((self.data_offset - 8) as i64) | (((CL_MSG_VERSION as i64) << 56) as i64) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(CL_MSG_VERSION)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/commands/buffer.rs:144:16 [INFO] [stderr] | [INFO] [stderr] 144 | | ((AS_MSG_TYPE as i64) << 48); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(AS_MSG_TYPE)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/commands/buffer.rs:231:21 [INFO] [stderr] | [INFO] [stderr] 231 | pub fn set_read<'a>(&mut self, policy: &ReadPolicy, key: &Key, bins: &Bins) -> Result<()> { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/commands/buffer.rs:232:9 [INFO] [stderr] | [INFO] [stderr] 232 | / match bins { [INFO] [stderr] 233 | | &Bins::None => self.set_read_header(policy, key), [INFO] [stderr] 234 | | &Bins::All => self.set_read_for_key_only(policy, key), [INFO] [stderr] 235 | | &Bins::Some(ref bin_names) => { [INFO] [stderr] ... | [INFO] [stderr] 250 | | } [INFO] [stderr] 251 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 232 | match *bins { [INFO] [stderr] 233 | Bins::None => self.set_read_header(policy, key), [INFO] [stderr] 234 | Bins::All => self.set_read_for_key_only(policy, key), [INFO] [stderr] 235 | Bins::Some(ref bin_names) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/commands/buffer.rs:303:21 [INFO] [stderr] | [INFO] [stderr] 303 | / if let &Bins::Some(ref bin_names) = batch_read.bins { [INFO] [stderr] 304 | | for name in bin_names { [INFO] [stderr] 305 | | self.estimate_operation_size_for_bin_name(&name)?; [INFO] [stderr] 306 | | } [INFO] [stderr] 307 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 303 | if let Bins::Some(ref bin_names) = *batch_read.bins { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/commands/buffer.rs:344:21 [INFO] [stderr] | [INFO] [stderr] 344 | / match batch_read.bins { [INFO] [stderr] 345 | | &Bins::None => { [INFO] [stderr] 346 | | self.write_u8(INFO1_READ | INFO1_NOBINDATA)?; [INFO] [stderr] 347 | | self.write_u16(field_count)?; [INFO] [stderr] ... | [INFO] [stderr] 374 | | } [INFO] [stderr] 375 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 344 | match *batch_read.bins { [INFO] [stderr] 345 | Bins::None => { [INFO] [stderr] 346 | self.write_u8(INFO1_READ | INFO1_NOBINDATA)?; [INFO] [stderr] 347 | self.write_u16(field_count)?; [INFO] [stderr] 348 | self.write_u16(0)?; [INFO] [stderr] 349 | self.write_field_string(&key.namespace, FieldType::Namespace)?; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 34 [INFO] [stderr] --> src/commands/buffer.rs:580:5 [INFO] [stderr] | [INFO] [stderr] 580 | / pub fn set_query( [INFO] [stderr] 581 | | &mut self, [INFO] [stderr] 582 | | policy: &QueryPolicy, [INFO] [stderr] 583 | | statement: &Statement, [INFO] [stderr] ... | [INFO] [stderr] 769 | | self.end() [INFO] [stderr] 770 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: Calling `subsec_millis()` is more concise than this calculation [INFO] [stderr] --> src/commands/buffer.rs:1290:50 [INFO] [stderr] | [INFO] [stderr] 1290 | (val.as_secs() * 1_000) as i32 + (val.subsec_nanos() / 1_000_000) as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `val.subsec_millis()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::duration_subsec)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#duration_subsec [INFO] [stderr] [INFO] [stderr] warning: transmute from a `u64` to a `f64` [INFO] [stderr] --> src/value.rs:51:46 [INFO] [stderr] | [INFO] [stderr] 51 | FloatValue::F64(val) => unsafe { mem::transmute(val) }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider using: `f64::from_bits(val)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_int_to_float)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_int_to_float [INFO] [stderr] [INFO] [stderr] warning: transmute from a `u64` to a `f64` [INFO] [stderr] --> src/value.rs:63:46 [INFO] [stderr] | [INFO] [stderr] 63 | FloatValue::F64(val) => unsafe { mem::transmute(val) }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider using: `f64::from_bits(val)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_int_to_float [INFO] [stderr] [INFO] [stderr] warning: transmute from a `u32` to a `f32` [INFO] [stderr] --> src/value.rs:91:46 [INFO] [stderr] | [INFO] [stderr] 91 | FloatValue::F32(val) => unsafe { mem::transmute(val) }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider using: `f32::from_bits(val)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_int_to_float [INFO] [stderr] [INFO] [stderr] warning: transmute from a `u32` to a `f32` [INFO] [stderr] --> src/value.rs:92:46 [INFO] [stderr] | [INFO] [stderr] 92 | FloatValue::F64(val) => unsafe { mem::transmute(val as u32) }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `f32::from_bits(val as u32)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_int_to_float [INFO] [stderr] [INFO] [stderr] warning: transmute from a `u32` to a `f32` [INFO] [stderr] --> src/value.rs:100:46 [INFO] [stderr] | [INFO] [stderr] 100 | FloatValue::F32(val) => unsafe { mem::transmute(val) }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider using: `f32::from_bits(val)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_int_to_float [INFO] [stderr] [INFO] [stderr] warning: transmute from a `u32` to a `f32` [INFO] [stderr] --> src/value.rs:101:46 [INFO] [stderr] | [INFO] [stderr] 101 | FloatValue::F64(val) => unsafe { mem::transmute(val as u32) }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `f32::from_bits(val as u32)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_int_to_float [INFO] [stderr] [INFO] [stderr] warning: transmute from a `u32` to a `f32` [INFO] [stderr] --> src/value.rs:130:41 [INFO] [stderr] | [INFO] [stderr] 130 | let val: f32 = unsafe { mem::transmute(val) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider using: `f32::from_bits(val)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_int_to_float [INFO] [stderr] [INFO] [stderr] warning: transmute from a `u64` to a `f64` [INFO] [stderr] --> src/value.rs:134:41 [INFO] [stderr] | [INFO] [stderr] 134 | let val: f64 = unsafe { mem::transmute(val) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider using: `f64::from_bits(val)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_int_to_float [INFO] [stderr] [INFO] [stderr] error: you are implementing `Hash` explicitly but have derived `PartialEq` [INFO] [stderr] --> src/value.rs:191:1 [INFO] [stderr] | [INFO] [stderr] 191 | / impl Hash for Value { [INFO] [stderr] 192 | | fn hash(&self, state: &mut H) { [INFO] [stderr] 193 | | match *self { [INFO] [stderr] 194 | | Value::Nil => { [INFO] [stderr] ... | [INFO] [stderr] 209 | | } [INFO] [stderr] 210 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::derive_hash_xor_eq)] on by default [INFO] [stderr] note: `PartialEq` implemented here [INFO] [stderr] --> src/value.rs:142:24 [INFO] [stderr] | [INFO] [stderr] 142 | #[derive(Debug, Clone, PartialEq, Eq)] [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_hash_xor_eq [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/msgpack/encoder.rs:216:38 [INFO] [stderr] | [INFO] [stderr] 216 | val if val >= 2 ^ 7 && val < i8::MAX as i64 => pack_byte(buf, MSGPACK_MARKER_I8, val as u8), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `i64::from(i8::MAX)` [INFO] [stderr] warning: casting i8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/value.rs:413:20 [INFO] [stderr] | [INFO] [stderr] 413 | Value::Int(val as i64) [INFO] [stderr] | ^^^^^^^^^^ help: try: `i64::from(val)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/value.rs:419:20 [INFO] [stderr] | [INFO] [stderr] 419 | Value::Int(val as i64) [INFO] [stderr] | ^^^^^^^^^^ help: try: `i64::from(val)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/value.rs:425:20 [INFO] [stderr] | [INFO] [stderr] 425 | Value::Int(val as i64) [INFO] [stderr] | ^^^^^^^^^^ help: try: `i64::from(val)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/value.rs:431:20 [INFO] [stderr] | [INFO] [stderr] 431 | Value::Int(val as i64) [INFO] [stderr] | ^^^^^^^^^^ help: try: `i64::from(val)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/value.rs:437:20 [INFO] [stderr] | [INFO] [stderr] 437 | Value::Int(val as i64) [INFO] [stderr] | ^^^^^^^^^^ help: try: `i64::from(val)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/value.rs:443:20 [INFO] [stderr] | [INFO] [stderr] 443 | Value::Int(val as i64) [INFO] [stderr] | ^^^^^^^^^^ help: try: `i64::from(val)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/value.rs:473:20 [INFO] [stderr] | [INFO] [stderr] 473 | Value::Int(*val as i64) [INFO] [stderr] | ^^^^^^^^^^^ help: try: `i64::from(*val)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/value.rs:479:20 [INFO] [stderr] | [INFO] [stderr] 479 | Value::Int(*val as i64) [INFO] [stderr] | ^^^^^^^^^^^ help: try: `i64::from(*val)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/value.rs:485:20 [INFO] [stderr] | [INFO] [stderr] 485 | Value::Int(*val as i64) [INFO] [stderr] | ^^^^^^^^^^^ help: try: `i64::from(*val)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/value.rs:491:20 [INFO] [stderr] | [INFO] [stderr] 491 | Value::Int(*val as i64) [INFO] [stderr] | ^^^^^^^^^^^ help: try: `i64::from(*val)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/value.rs:497:20 [INFO] [stderr] | [INFO] [stderr] 497 | Value::Int(*val as i64) [INFO] [stderr] | ^^^^^^^^^^^ help: try: `i64::from(*val)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/value.rs:503:20 [INFO] [stderr] | [INFO] [stderr] 503 | Value::Int(*val as i64) [INFO] [stderr] | ^^^^^^^^^^^ help: try: `i64::from(*val)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/msgpack/encoder.rs:217:23 [INFO] [stderr] | [INFO] [stderr] 217 | val if val >= i8::MAX as i64 && val < i16::MAX as i64 => { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `i64::from(i8::MAX)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/msgpack/encoder.rs:217:47 [INFO] [stderr] | [INFO] [stderr] 217 | val if val >= i8::MAX as i64 && val < i16::MAX as i64 => { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `i64::from(i16::MAX)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/msgpack/encoder.rs:220:23 [INFO] [stderr] | [INFO] [stderr] 220 | val if val >= i16::MAX as i64 && val < i32::MAX as i64 => { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `i64::from(i16::MAX)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/msgpack/encoder.rs:220:48 [INFO] [stderr] | [INFO] [stderr] 220 | val if val >= i16::MAX as i64 && val < i32::MAX as i64 => { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `i64::from(i32::MAX)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/msgpack/encoder.rs:223:23 [INFO] [stderr] | [INFO] [stderr] 223 | val if val >= i32::MAX as i64 => pack_i64(buf, MSGPACK_MARKER_I32, val), [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `i64::from(i32::MAX)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/msgpack/encoder.rs:229:23 [INFO] [stderr] | [INFO] [stderr] 229 | val if val >= i8::MIN as i64 && val < -32 => pack_byte(buf, MSGPACK_MARKER_NI8, val as u8), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `i64::from(i8::MIN)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/msgpack/encoder.rs:230:23 [INFO] [stderr] | [INFO] [stderr] 230 | val if val >= i16::MIN as i64 && val < i8::MIN as i64 => { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `i64::from(i16::MIN)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/msgpack/encoder.rs:230:48 [INFO] [stderr] | [INFO] [stderr] 230 | val if val >= i16::MIN as i64 && val < i8::MIN as i64 => { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `i64::from(i8::MIN)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/msgpack/encoder.rs:233:23 [INFO] [stderr] | [INFO] [stderr] 233 | val if val >= i32::MIN as i64 && val < i16::MIN as i64 => { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `i64::from(i32::MIN)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/msgpack/encoder.rs:233:48 [INFO] [stderr] | [INFO] [stderr] 233 | val if val >= i32::MIN as i64 && val < i16::MIN as i64 => { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `i64::from(i16::MIN)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/msgpack/encoder.rs:236:22 [INFO] [stderr] | [INFO] [stderr] 236 | val if val < i32::MIN as i64 => pack_i64(buf, MSGPACK_MARKER_NI64, val), [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `i64::from(i32::MIN)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: approximate value of `f{32, 64}::consts::PI` found. Consider using it directly [INFO] [stderr] --> src/value.rs:722:32 [INFO] [stderr] | [INFO] [stderr] 722 | assert_eq!(Value::from(3.1416).as_string(), String::from("3.1416")); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::approx_constant)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#approx_constant [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `match $ expr { [INFO] [stderr] $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result [INFO] [stderr] :: Err ( err ) => { [INFO] [stderr] return $ crate :: result :: Result :: Err ( [INFO] [stderr] $ crate :: convert :: From :: from ( err ) ) } }` [INFO] [stderr] --> src/msgpack/decoder.rs:29:21 [INFO] [stderr] | [INFO] [stderr] 29 | let ltype: u8 = try!(buf.read_u8(None)) & 0xff; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `match $ expr { [INFO] [stderr] $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result [INFO] [stderr] :: Err ( err ) => { [INFO] [stderr] return $ crate :: result :: Result :: Err ( [INFO] [stderr] $ crate :: convert :: From :: from ( err ) ) } }` [INFO] [stderr] --> src/msgpack/decoder.rs:46:21 [INFO] [stderr] | [INFO] [stderr] 46 | let ltype: u8 = try!(buf.read_u8(None)) & 0xff; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 30 [INFO] [stderr] --> src/key.rs:123:5 [INFO] [stderr] | [INFO] [stderr] 123 | / fn int_keys() { [INFO] [stderr] 124 | | assert_eq!(digest!(0), "93d943aae37b017ad7e011b0c1d2e2143c2fb37d"); [INFO] [stderr] 125 | | assert_eq!(digest!(-1), "22116d253745e29fc63fdf760b6e26f7e197e01d"); [INFO] [stderr] 126 | | [INFO] [stderr] ... | [INFO] [stderr] 188 | | ); [INFO] [stderr] 189 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/msgpack/decoder.rs:127:23 [INFO] [stderr] | [INFO] [stderr] 127 | return Ok(Value::from(try!(unpack_blob(buf, count as usize)))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `Value::from()`: `try!(unpack_blob(buf, count as usize))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/msgpack/decoder.rs:131:23 [INFO] [stderr] | [INFO] [stderr] 131 | return Ok(Value::from(try!(unpack_blob(buf, count as usize)))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `Value::from()`: `try!(unpack_blob(buf, count as usize))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/msgpack/decoder.rs:135:23 [INFO] [stderr] | [INFO] [stderr] 135 | return Ok(Value::from(try!(unpack_blob(buf, count as usize)))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `Value::from()`: `try!(unpack_blob(buf, count as usize))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/msgpack/decoder.rs:197:16 [INFO] [stderr] | [INFO] [stderr] 197 | Ok(Value::from(try!(unpack_blob(buf, count as usize)))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `Value::from()`: `try!(unpack_blob(buf, count as usize))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/msgpack/decoder.rs:201:16 [INFO] [stderr] | [INFO] [stderr] 201 | Ok(Value::from(try!(unpack_blob(buf, count as usize)))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `Value::from()`: `try!(unpack_blob(buf, count as usize))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/msgpack/decoder.rs:205:16 [INFO] [stderr] | [INFO] [stderr] 205 | Ok(Value::from(try!(unpack_blob(buf, count as usize)))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `Value::from()`: `try!(unpack_blob(buf, count as usize))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/msgpack/decoder.rs:224:25 [INFO] [stderr] | [INFO] [stderr] 224 | let value = obj_type as i16 - 0xe0 - 32; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `i16::from(obj_type)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/key.rs:119:47 [INFO] [stderr] | [INFO] [stderr] 119 | ($c:expr, $n:expr) => (str::from_utf8(&vec![$c as u8; $n]).unwrap()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[$c as u8; 1]` [INFO] [stderr] ... [INFO] [stderr] 195 | digest!(str_repeat!('s', 1)), [INFO] [stderr] | ------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_vec)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/key.rs:119:47 [INFO] [stderr] | [INFO] [stderr] 119 | ($c:expr, $n:expr) => (str::from_utf8(&vec![$c as u8; $n]).unwrap()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[$c as u8; 10]` [INFO] [stderr] ... [INFO] [stderr] 199 | digest!(str_repeat!('a', 10)), [INFO] [stderr] | -------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/key.rs:119:47 [INFO] [stderr] | [INFO] [stderr] 119 | ($c:expr, $n:expr) => (str::from_utf8(&vec![$c as u8; $n]).unwrap()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[$c as u8; 100]` [INFO] [stderr] ... [INFO] [stderr] 203 | digest!(str_repeat!('m', 100)), [INFO] [stderr] | --------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/key.rs:119:47 [INFO] [stderr] | [INFO] [stderr] 119 | ($c:expr, $n:expr) => (str::from_utf8(&vec![$c as u8; $n]).unwrap()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[$c as u8; 1000]` [INFO] [stderr] ... [INFO] [stderr] 207 | digest!(str_repeat!('t', 1000)), [INFO] [stderr] | ---------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/key.rs:119:47 [INFO] [stderr] | [INFO] [stderr] 119 | ($c:expr, $n:expr) => (str::from_utf8(&vec![$c as u8; $n]).unwrap()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[$c as u8; 10000]` [INFO] [stderr] ... [INFO] [stderr] 211 | digest!(str_repeat!('-', 10000)), [INFO] [stderr] | ----------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/key.rs:119:47 [INFO] [stderr] | [INFO] [stderr] 119 | ($c:expr, $n:expr) => (str::from_utf8(&vec![$c as u8; $n]).unwrap()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[$c as u8; 100000]` [INFO] [stderr] ... [INFO] [stderr] 215 | digest!(str_repeat!('+', 100000)), [INFO] [stderr] | ------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/key.rs:237:26 [INFO] [stderr] | [INFO] [stderr] 237 | digest!(vec!['s' as u8; 1]), [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::char_lit_as_u8)] on by default [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b's' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/key.rs:241:26 [INFO] [stderr] | [INFO] [stderr] 241 | digest!(vec!['a' as u8; 10]), [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'a' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/key.rs:245:26 [INFO] [stderr] | [INFO] [stderr] 245 | digest!(vec!['m' as u8; 100]), [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'm' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/key.rs:249:26 [INFO] [stderr] | [INFO] [stderr] 249 | digest!(vec!['t' as u8; 1000]), [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b't' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/key.rs:253:26 [INFO] [stderr] | [INFO] [stderr] 253 | digest!(vec!['-' as u8; 10000]), [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'-' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/key.rs:257:26 [INFO] [stderr] | [INFO] [stderr] 257 | digest!(vec!['+' as u8; 100000]), [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'+' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] error: approximate value of `f{32, 64}::consts::PI` found. Consider using it directly [INFO] [stderr] --> src/key.rs:265:37 [INFO] [stderr] | [INFO] [stderr] 265 | as_key!("namespace", "set", 3.1415); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#approx_constant [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/batch/batch_executor.rs:98:22 [INFO] [stderr] | [INFO] [stderr] 98 | batch_reads: &Vec>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: change this to: `&[BatchRead<'a>]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/operations/lists.rs:55:13 [INFO] [stderr] | [INFO] [stderr] 55 | assert!(values.len() > 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!values.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/operations/lists.rs:85:13 [INFO] [stderr] | [INFO] [stderr] 85 | assert!(values.len() > 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!values.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*mut std::vec::Vec`) to a reference type (`&mut std::vec::Vec`) [INFO] [stderr] --> src/batch/batch_executor.rs:147:18 [INFO] [stderr] | [INFO] [stderr] 147 | unsafe { transmute::<*mut Vec, &mut Vec>(self.value.get()).get_mut(idx) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut *self.value.get()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_ptr_to_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] [INFO] [stderr] warning: parameter of type `HashMap` should be generalized over different hashers [INFO] [stderr] --> src/operations/maps.rs:236:16 [INFO] [stderr] | [INFO] [stderr] 236 | items: &'a HashMap, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::implicit_hasher)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 233 | pub fn put_items<'a, S: ::std::hash::BuildHasher>( [INFO] [stderr] 234 | policy: &'a MapPolicy, [INFO] [stderr] 235 | bin: &'a str, [INFO] [stderr] 236 | items: &'a HashMap, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/client.rs:857:5 [INFO] [stderr] | [INFO] [stderr] 857 | / pub fn create_complex_index( [INFO] [stderr] 858 | | &self, [INFO] [stderr] 859 | | policy: &WritePolicy, [INFO] [stderr] 860 | | namespace: &str, [INFO] [stderr] ... | [INFO] [stderr] 877 | | .chain_err(|| "Error creating index") [INFO] [stderr] 878 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/client.rs:904:9 [INFO] [stderr] | [INFO] [stderr] 904 | / for v in response.values() { [INFO] [stderr] 905 | | if v.to_uppercase() == "OK" { [INFO] [stderr] 906 | | return Ok(()); [INFO] [stderr] 907 | | } else if v.starts_with("FAIL:") { [INFO] [stderr] ... | [INFO] [stderr] 912 | | } [INFO] [stderr] 913 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::never_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] warning: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)` [INFO] [stderr] --> src/client.rs:908:30 [INFO] [stderr] | [INFO] [stderr] 908 | let result = v.split(':').skip(1).next().unwrap().parse::()?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::iter_skip_next)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_skip_next [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/cluster/node_validator.rs:60:13 [INFO] [stderr] | [INFO] [stderr] 60 | for ref alias in self.aliases() { [INFO] [stderr] | ^^^^^^^^^ -------------- help: try: `let alias = &self.aliases();` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/record.rs:68:68 [INFO] [stderr] | [INFO] [stderr] 68 | let expiration = *CITRUSLEAF_EPOCH + Duration::new(secs_since_epoch as u64, 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(secs_since_epoch)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `aerospike`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/commands/single_command.rs:51:29 [INFO] [stderr] | [INFO] [stderr] 51 | let header_length = try!(conn.buffer.read_u8(None)) as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 51 | let header_length = i64::from(match $ expr { [INFO] [stderr] 52 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result [INFO] [stderr] 53 | :: Err ( err ) => { [INFO] [stderr] 54 | return $ crate :: result :: Result :: Err ( [INFO] [stderr] 55 | $ crate :: convert :: From :: from ( err ) ) } }); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/commands/read_command.rs:137:53 [INFO] [stderr] | [INFO] [stderr] 137 | let receive_size = ((sz & 0xFFFFFFFFFFFF) - header_length as u64) as usize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(header_length)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `match $ expr { [INFO] [stderr] $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result [INFO] [stderr] :: Err ( err ) => { [INFO] [stderr] return $ crate :: result :: Result :: Err ( [INFO] [stderr] $ crate :: convert :: From :: from ( err ) ) } }` [INFO] [stderr] --> src/commands/write_command.rs:89:44 [INFO] [stderr] | [INFO] [stderr] 89 | let result_code = ResultCode::from(try!(conn.buffer.read_u8(Some(13))) & 0xFF); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `match $ expr { [INFO] [stderr] $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result [INFO] [stderr] :: Err ( err ) => { [INFO] [stderr] return $ crate :: result :: Result :: Err ( [INFO] [stderr] $ crate :: convert :: From :: from ( err ) ) } }` [INFO] [stderr] --> src/commands/delete_command.rs:76:44 [INFO] [stderr] | [INFO] [stderr] 76 | let result_code = ResultCode::from(try!(conn.buffer.read_u8(Some(13))) & 0xFF); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `match $ expr { [INFO] [stderr] $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result [INFO] [stderr] :: Err ( err ) => { [INFO] [stderr] return $ crate :: result :: Result :: Err ( [INFO] [stderr] $ crate :: convert :: From :: from ( err ) ) } }` [INFO] [stderr] --> src/commands/touch_command.rs:72:44 [INFO] [stderr] | [INFO] [stderr] 72 | let result_code = ResultCode::from(try!(conn.buffer.read_u8(Some(13))) & 0xFF); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `match $ expr { [INFO] [stderr] $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result [INFO] [stderr] :: Err ( err ) => { [INFO] [stderr] return $ crate :: result :: Result :: Err ( [INFO] [stderr] $ crate :: convert :: From :: from ( err ) ) } }` [INFO] [stderr] --> src/commands/exists_command.rs:76:44 [INFO] [stderr] | [INFO] [stderr] 76 | let result_code = ResultCode::from(try!(conn.buffer.read_u8(Some(13))) & 0xFF); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `match $ expr { [INFO] [stderr] $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result [INFO] [stderr] :: Err ( err ) => { [INFO] [stderr] return $ crate :: result :: Result :: Err ( [INFO] [stderr] $ crate :: convert :: From :: from ( err ) ) } }` [INFO] [stderr] --> src/commands/stream_command.rs:56:44 [INFO] [stderr] | [INFO] [stderr] 56 | let result_code = ResultCode::from(try!(conn.buffer.read_u8(Some(5))) & 0xFF); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/commands/buffer.rs:143:56 [INFO] [stderr] | [INFO] [stderr] 143 | let size = ((self.data_offset - 8) as i64) | (((CL_MSG_VERSION as i64) << 56) as i64) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(CL_MSG_VERSION)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/commands/buffer.rs:144:16 [INFO] [stderr] | [INFO] [stderr] 144 | | ((AS_MSG_TYPE as i64) << 48); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(AS_MSG_TYPE)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/commands/buffer.rs:231:21 [INFO] [stderr] | [INFO] [stderr] 231 | pub fn set_read<'a>(&mut self, policy: &ReadPolicy, key: &Key, bins: &Bins) -> Result<()> { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/commands/buffer.rs:232:9 [INFO] [stderr] | [INFO] [stderr] 232 | / match bins { [INFO] [stderr] 233 | | &Bins::None => self.set_read_header(policy, key), [INFO] [stderr] 234 | | &Bins::All => self.set_read_for_key_only(policy, key), [INFO] [stderr] 235 | | &Bins::Some(ref bin_names) => { [INFO] [stderr] ... | [INFO] [stderr] 250 | | } [INFO] [stderr] 251 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 232 | match *bins { [INFO] [stderr] 233 | Bins::None => self.set_read_header(policy, key), [INFO] [stderr] 234 | Bins::All => self.set_read_for_key_only(policy, key), [INFO] [stderr] 235 | Bins::Some(ref bin_names) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/commands/buffer.rs:303:21 [INFO] [stderr] | [INFO] [stderr] 303 | / if let &Bins::Some(ref bin_names) = batch_read.bins { [INFO] [stderr] 304 | | for name in bin_names { [INFO] [stderr] 305 | | self.estimate_operation_size_for_bin_name(&name)?; [INFO] [stderr] 306 | | } [INFO] [stderr] 307 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 303 | if let Bins::Some(ref bin_names) = *batch_read.bins { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/commands/buffer.rs:344:21 [INFO] [stderr] | [INFO] [stderr] 344 | / match batch_read.bins { [INFO] [stderr] 345 | | &Bins::None => { [INFO] [stderr] 346 | | self.write_u8(INFO1_READ | INFO1_NOBINDATA)?; [INFO] [stderr] 347 | | self.write_u16(field_count)?; [INFO] [stderr] ... | [INFO] [stderr] 374 | | } [INFO] [stderr] 375 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 344 | match *batch_read.bins { [INFO] [stderr] 345 | Bins::None => { [INFO] [stderr] 346 | self.write_u8(INFO1_READ | INFO1_NOBINDATA)?; [INFO] [stderr] 347 | self.write_u16(field_count)?; [INFO] [stderr] 348 | self.write_u16(0)?; [INFO] [stderr] 349 | self.write_field_string(&key.namespace, FieldType::Namespace)?; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 34 [INFO] [stderr] --> src/commands/buffer.rs:580:5 [INFO] [stderr] | [INFO] [stderr] 580 | / pub fn set_query( [INFO] [stderr] 581 | | &mut self, [INFO] [stderr] 582 | | policy: &QueryPolicy, [INFO] [stderr] 583 | | statement: &Statement, [INFO] [stderr] ... | [INFO] [stderr] 769 | | self.end() [INFO] [stderr] 770 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: Calling `subsec_millis()` is more concise than this calculation [INFO] [stderr] --> src/commands/buffer.rs:1290:50 [INFO] [stderr] | [INFO] [stderr] 1290 | (val.as_secs() * 1_000) as i32 + (val.subsec_nanos() / 1_000_000) as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `val.subsec_millis()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::duration_subsec)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#duration_subsec [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/msgpack/encoder.rs:216:38 [INFO] [stderr] | [INFO] [stderr] 216 | val if val >= 2 ^ 7 && val < i8::MAX as i64 => pack_byte(buf, MSGPACK_MARKER_I8, val as u8), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `i64::from(i8::MAX)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/msgpack/encoder.rs:217:23 [INFO] [stderr] | [INFO] [stderr] 217 | val if val >= i8::MAX as i64 && val < i16::MAX as i64 => { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `i64::from(i8::MAX)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/msgpack/encoder.rs:217:47 [INFO] [stderr] | [INFO] [stderr] 217 | val if val >= i8::MAX as i64 && val < i16::MAX as i64 => { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `i64::from(i16::MAX)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/msgpack/encoder.rs:220:23 [INFO] [stderr] | [INFO] [stderr] 220 | val if val >= i16::MAX as i64 && val < i32::MAX as i64 => { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `i64::from(i16::MAX)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/msgpack/encoder.rs:220:48 [INFO] [stderr] | [INFO] [stderr] 220 | val if val >= i16::MAX as i64 && val < i32::MAX as i64 => { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `i64::from(i32::MAX)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/msgpack/encoder.rs:223:23 [INFO] [stderr] | [INFO] [stderr] 223 | val if val >= i32::MAX as i64 => pack_i64(buf, MSGPACK_MARKER_I32, val), [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `i64::from(i32::MAX)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/msgpack/encoder.rs:229:23 [INFO] [stderr] | [INFO] [stderr] 229 | val if val >= i8::MIN as i64 && val < -32 => pack_byte(buf, MSGPACK_MARKER_NI8, val as u8), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `i64::from(i8::MIN)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/msgpack/encoder.rs:230:23 [INFO] [stderr] | [INFO] [stderr] 230 | val if val >= i16::MIN as i64 && val < i8::MIN as i64 => { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `i64::from(i16::MIN)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/msgpack/encoder.rs:230:48 [INFO] [stderr] | [INFO] [stderr] 230 | val if val >= i16::MIN as i64 && val < i8::MIN as i64 => { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `i64::from(i8::MIN)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/msgpack/encoder.rs:233:23 [INFO] [stderr] | [INFO] [stderr] 233 | val if val >= i32::MIN as i64 && val < i16::MIN as i64 => { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `i64::from(i32::MIN)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/msgpack/encoder.rs:233:48 [INFO] [stderr] | [INFO] [stderr] 233 | val if val >= i32::MIN as i64 && val < i16::MIN as i64 => { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `i64::from(i16::MIN)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/msgpack/encoder.rs:236:22 [INFO] [stderr] | [INFO] [stderr] 236 | val if val < i32::MIN as i64 => pack_i64(buf, MSGPACK_MARKER_NI64, val), [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `i64::from(i32::MIN)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `match $ expr { [INFO] [stderr] $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result [INFO] [stderr] :: Err ( err ) => { [INFO] [stderr] return $ crate :: result :: Result :: Err ( [INFO] [stderr] $ crate :: convert :: From :: from ( err ) ) } }` [INFO] [stderr] --> src/msgpack/decoder.rs:29:21 [INFO] [stderr] | [INFO] [stderr] 29 | let ltype: u8 = try!(buf.read_u8(None)) & 0xff; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `match $ expr { [INFO] [stderr] $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result [INFO] [stderr] :: Err ( err ) => { [INFO] [stderr] return $ crate :: result :: Result :: Err ( [INFO] [stderr] $ crate :: convert :: From :: from ( err ) ) } }` [INFO] [stderr] --> src/msgpack/decoder.rs:46:21 [INFO] [stderr] | [INFO] [stderr] 46 | let ltype: u8 = try!(buf.read_u8(None)) & 0xff; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/msgpack/decoder.rs:127:23 [INFO] [stderr] | [INFO] [stderr] 127 | return Ok(Value::from(try!(unpack_blob(buf, count as usize)))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `Value::from()`: `try!(unpack_blob(buf, count as usize))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/msgpack/decoder.rs:131:23 [INFO] [stderr] | [INFO] [stderr] 131 | return Ok(Value::from(try!(unpack_blob(buf, count as usize)))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `Value::from()`: `try!(unpack_blob(buf, count as usize))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/msgpack/decoder.rs:135:23 [INFO] [stderr] | [INFO] [stderr] 135 | return Ok(Value::from(try!(unpack_blob(buf, count as usize)))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `Value::from()`: `try!(unpack_blob(buf, count as usize))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/msgpack/decoder.rs:197:16 [INFO] [stderr] | [INFO] [stderr] 197 | Ok(Value::from(try!(unpack_blob(buf, count as usize)))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `Value::from()`: `try!(unpack_blob(buf, count as usize))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/msgpack/decoder.rs:201:16 [INFO] [stderr] | [INFO] [stderr] 201 | Ok(Value::from(try!(unpack_blob(buf, count as usize)))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `Value::from()`: `try!(unpack_blob(buf, count as usize))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/msgpack/decoder.rs:205:16 [INFO] [stderr] | [INFO] [stderr] 205 | Ok(Value::from(try!(unpack_blob(buf, count as usize)))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `Value::from()`: `try!(unpack_blob(buf, count as usize))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/msgpack/decoder.rs:224:25 [INFO] [stderr] | [INFO] [stderr] 224 | let value = obj_type as i16 - 0xe0 - 32; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `i16::from(obj_type)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/operations/lists.rs:55:13 [INFO] [stderr] | [INFO] [stderr] 55 | assert!(values.len() > 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!values.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/operations/lists.rs:85:13 [INFO] [stderr] | [INFO] [stderr] 85 | assert!(values.len() > 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!values.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: parameter of type `HashMap` should be generalized over different hashers [INFO] [stderr] --> src/operations/maps.rs:236:16 [INFO] [stderr] | [INFO] [stderr] 236 | items: &'a HashMap, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::implicit_hasher)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 233 | pub fn put_items<'a, S: ::std::hash::BuildHasher>( [INFO] [stderr] 234 | policy: &'a MapPolicy, [INFO] [stderr] 235 | bin: &'a str, [INFO] [stderr] 236 | items: &'a HashMap, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/query/filter.rs:162:27 [INFO] [stderr] | [INFO] [stderr] 162 | let lat = as_val!($lat as f64); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f64::from(1)` [INFO] [stderr] ... [INFO] [stderr] 220 | let geo_filter = as_within_radius!("bin1", 1, 3, 7); [INFO] [stderr] | ---------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/query/filter.rs:163:27 [INFO] [stderr] | [INFO] [stderr] 163 | let lng = as_val!($lng as f64); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f64::from(3)` [INFO] [stderr] ... [INFO] [stderr] 220 | let geo_filter = as_within_radius!("bin1", 1, 3, 7); [INFO] [stderr] | ---------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/query/filter.rs:164:30 [INFO] [stderr] | [INFO] [stderr] 164 | let radius = as_val!($radius as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(7)` [INFO] [stderr] ... [INFO] [stderr] 220 | let geo_filter = as_within_radius!("bin1", 1, 3, 7); [INFO] [stderr] | ---------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/query/filter.rs:173:27 [INFO] [stderr] | [INFO] [stderr] 173 | let lat = as_val!($lat as f64); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f64::from(1)` [INFO] [stderr] ... [INFO] [stderr] 223 | let geo_filter = as_within_radius!("bin1", 1, 3, 7, CollectionIndexType::List); [INFO] [stderr] | ------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/query/filter.rs:174:27 [INFO] [stderr] | [INFO] [stderr] 174 | let lng = as_val!($lng as f64); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f64::from(3)` [INFO] [stderr] ... [INFO] [stderr] 223 | let geo_filter = as_within_radius!("bin1", 1, 3, 7, CollectionIndexType::List); [INFO] [stderr] | ------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/query/filter.rs:175:30 [INFO] [stderr] | [INFO] [stderr] 175 | let radius = as_val!($radius as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(7)` [INFO] [stderr] ... [INFO] [stderr] 223 | let geo_filter = as_within_radius!("bin1", 1, 3, 7, CollectionIndexType::List); [INFO] [stderr] | ------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/record.rs:68:68 [INFO] [stderr] | [INFO] [stderr] 68 | let expiration = *CITRUSLEAF_EPOCH + Duration::new(secs_since_epoch as u64, 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(secs_since_epoch)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: aborting due to 4 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `aerospike`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "4c03829cdfe1fda606124e72643caf479d41ad981f9c71f1ff9b235c0b2a877f"` [INFO] running `"docker" "rm" "-f" "4c03829cdfe1fda606124e72643caf479d41ad981f9c71f1ff9b235c0b2a877f"` [INFO] [stdout] 4c03829cdfe1fda606124e72643caf479d41ad981f9c71f1ff9b235c0b2a877f