[INFO] crate adi_speaker 0.0.1 is already in cache [INFO] extracting crate adi_speaker 0.0.1 into work/ex/clippy-test-run/sources/stable/reg/adi_speaker/0.0.1 [INFO] extracting crate adi_speaker 0.0.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/adi_speaker/0.0.1 [INFO] validating manifest of adi_speaker-0.0.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of adi_speaker-0.0.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing adi_speaker-0.0.1 [INFO] finished frobbing adi_speaker-0.0.1 [INFO] frobbed toml for adi_speaker-0.0.1 written to work/ex/clippy-test-run/sources/stable/reg/adi_speaker/0.0.1/Cargo.toml [INFO] started frobbing adi_speaker-0.0.1 [INFO] finished frobbing adi_speaker-0.0.1 [INFO] frobbed toml for adi_speaker-0.0.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/adi_speaker/0.0.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting adi_speaker-0.0.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/adi_speaker/0.0.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 6fae0329f4d22a156069a9af43226ab2ba34fafe07562429d4a96db86cee8654 [INFO] running `"docker" "start" "-a" "6fae0329f4d22a156069a9af43226ab2ba34fafe07562429d4a96db86cee8654"` [INFO] [stderr] Checking adi_speaker v0.0.1 (/opt/crater/workdir) [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/alsa/mod.rs:22:1 [INFO] [stderr] | [INFO] [stderr] 22 | mod alsa; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/alsa/mod.rs:22:1 [INFO] [stderr] | [INFO] [stderr] 22 | mod alsa; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: unsequenced read of a variable [INFO] [stderr] --> src/lib.rs:69:24 [INFO] [stderr] | [INFO] [stderr] 69 | }, pcm), vec![0i16; speaker_max_latency]) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::eval_order_dependence)] on by default [INFO] [stderr] note: whether read occurs before this write depends on evaluation order [INFO] [stderr] --> src/lib.rs:60:5 [INFO] [stderr] | [INFO] [stderr] 60 | speaker_max_latency [INFO] [stderr] | _________________^ [INFO] [stderr] 61 | | = hwp.get_period_size(&CONTEXT).unwrap() [INFO] [stderr] 62 | | as usize * 2; [INFO] [stderr] | |____________________________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eval_order_dependence [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/lib.rs:100:65 [INFO] [stderr] | [INFO] [stderr] 100 | if self.speaker.1.writei(&CONTEXT, buffer).unwrap_or_else(|_| { [INFO] [stderr] | _______________________________________________________________________^ [INFO] [stderr] 101 | | 0 [INFO] [stderr] 102 | | }) != buffer.len() [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::block_in_if_condition_stmt)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/lib.rs:110:66 [INFO] [stderr] | [INFO] [stderr] 110 | if self.speaker.1.writei(&CONTEXT, buffer).unwrap_or_else(|_| { [INFO] [stderr] | ___________________________________________________________________________^ [INFO] [stderr] 111 | | 0 [INFO] [stderr] 112 | | }) != buffer.len() { [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] [INFO] [stderr] warning: unsequenced read of a variable [INFO] [stderr] --> src/lib.rs:69:24 [INFO] [stderr] | [INFO] [stderr] 69 | }, pcm), vec![0i16; speaker_max_latency]) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::eval_order_dependence)] on by default [INFO] [stderr] note: whether read occurs before this write depends on evaluation order [INFO] [stderr] --> src/lib.rs:60:5 [INFO] [stderr] | [INFO] [stderr] 60 | speaker_max_latency [INFO] [stderr] | _________________^ [INFO] [stderr] 61 | | = hwp.get_period_size(&CONTEXT).unwrap() [INFO] [stderr] 62 | | as usize * 2; [INFO] [stderr] | |____________________________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eval_order_dependence [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/lib.rs:100:65 [INFO] [stderr] | [INFO] [stderr] 100 | if self.speaker.1.writei(&CONTEXT, buffer).unwrap_or_else(|_| { [INFO] [stderr] | _______________________________________________________________________^ [INFO] [stderr] 101 | | 0 [INFO] [stderr] 102 | | }) != buffer.len() [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::block_in_if_condition_stmt)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/lib.rs:110:66 [INFO] [stderr] | [INFO] [stderr] 110 | if self.speaker.1.writei(&CONTEXT, buffer).unwrap_or_else(|_| { [INFO] [stderr] | ___________________________________________________________________________^ [INFO] [stderr] 111 | | 0 [INFO] [stderr] 112 | | }) != buffer.len() { [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.48s [INFO] running `"docker" "inspect" "6fae0329f4d22a156069a9af43226ab2ba34fafe07562429d4a96db86cee8654"` [INFO] running `"docker" "rm" "-f" "6fae0329f4d22a156069a9af43226ab2ba34fafe07562429d4a96db86cee8654"` [INFO] [stdout] 6fae0329f4d22a156069a9af43226ab2ba34fafe07562429d4a96db86cee8654