[INFO] crate adi_gpu_vulkan 0.11.0 is already in cache [INFO] extracting crate adi_gpu_vulkan 0.11.0 into work/ex/clippy-test-run/sources/stable/reg/adi_gpu_vulkan/0.11.0 [INFO] extracting crate adi_gpu_vulkan 0.11.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/adi_gpu_vulkan/0.11.0 [INFO] validating manifest of adi_gpu_vulkan-0.11.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of adi_gpu_vulkan-0.11.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing adi_gpu_vulkan-0.11.0 [INFO] finished frobbing adi_gpu_vulkan-0.11.0 [INFO] frobbed toml for adi_gpu_vulkan-0.11.0 written to work/ex/clippy-test-run/sources/stable/reg/adi_gpu_vulkan/0.11.0/Cargo.toml [INFO] started frobbing adi_gpu_vulkan-0.11.0 [INFO] finished frobbing adi_gpu_vulkan-0.11.0 [INFO] frobbed toml for adi_gpu_vulkan-0.11.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/adi_gpu_vulkan/0.11.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting adi_gpu_vulkan-0.11.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/adi_gpu_vulkan/0.11.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 27d4eb2f838ab689a40f5a9fd0187c46aca1659b510a429a3e080554540e0ce6 [INFO] running `"docker" "start" "-a" "27d4eb2f838ab689a40f5a9fd0187c46aca1659b510a429a3e080554540e0ce6"` [INFO] [stderr] Checking adi_gpu_vulkan v0.11.0 (/opt/crater/workdir) [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/renderer/mod.rs:223:3 [INFO] [stderr] | [INFO] [stderr] 223 | 0x00000006 /* visible|coherent */, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0006` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/renderer/mod.rs:1081:41 [INFO] [stderr] | [INFO] [stderr] 1081 | pub fn fog(&mut self, fog: (f32, f32)) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/renderer/mod.rs:1095:21 [INFO] [stderr] | [INFO] [stderr] 1095 | fn drop(&mut self) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/lib.rs:66:45 [INFO] [stderr] | [INFO] [stderr] 66 | fn fog(&mut self, fog: Option<(f32, f32)>) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/lib.rs:165:39 [INFO] [stderr] | [INFO] [stderr] 165 | fn resize(&mut self, wh: (u16, u16)) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/renderer/mod.rs:223:3 [INFO] [stderr] | [INFO] [stderr] 223 | 0x00000006 /* visible|coherent */, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0006` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/renderer/mod.rs:1081:41 [INFO] [stderr] | [INFO] [stderr] 1081 | pub fn fog(&mut self, fog: (f32, f32)) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/renderer/mod.rs:1095:21 [INFO] [stderr] | [INFO] [stderr] 1095 | fn drop(&mut self) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/lib.rs:66:45 [INFO] [stderr] | [INFO] [stderr] 66 | fn fog(&mut self, fog: Option<(f32, f32)>) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/lib.rs:165:39 [INFO] [stderr] | [INFO] [stderr] 165 | fn resize(&mut self, wh: (u16, u16)) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/renderer/ffi.rs:44:7 [INFO] [stderr] | [INFO] [stderr] 44 | *(mapped.offset((i * pitch + j * 4 + k) [INFO] [stderr] | ______________________^ [INFO] [stderr] 45 | | as isize)) [INFO] [stderr] | |______________________________________^ help: try: `mapped.add((i * pitch + j * 4 + k))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_offset_with_cast)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: The function/method `::new` doesn't need a mutable reference [INFO] [stderr] --> src/renderer/mod.rs:217:3 [INFO] [stderr] | [INFO] [stderr] 217 | &mut vw.connection, width as u32, height as u32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/renderer/mod.rs:217:23 [INFO] [stderr] | [INFO] [stderr] 217 | &mut vw.connection, width as u32, height as u32, [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u32::from(width)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/renderer/mod.rs:217:37 [INFO] [stderr] | [INFO] [stderr] 217 | &mut vw.connection, width as u32, height as u32, [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: The function/method `::new` doesn't need a mutable reference [INFO] [stderr] --> src/renderer/mod.rs:235:4 [INFO] [stderr] | [INFO] [stderr] 235 | &mut vw.connection, width as u32, height as u32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/renderer/mod.rs:235:24 [INFO] [stderr] | [INFO] [stderr] 235 | &mut vw.connection, width as u32, height as u32, [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u32::from(width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/renderer/mod.rs:235:38 [INFO] [stderr] | [INFO] [stderr] 235 | &mut vw.connection, width as u32, height as u32, [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: The function/method `ffi::copy_memory_pitched` doesn't need a mutable reference [INFO] [stderr] --> src/renderer/mod.rs:252:27 [INFO] [stderr] | [INFO] [stderr] 252 | ffi::copy_memory_pitched(&mut vw.connection, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `asi_vulkan::copy_image` doesn't need a mutable reference [INFO] [stderr] --> src/renderer/mod.rs:265:27 [INFO] [stderr] | [INFO] [stderr] 265 | asi_vulkan::copy_image(&mut vw.connection, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `asi_vulkan::get_buffering` doesn't need a mutable reference [INFO] [stderr] --> src/renderer/mod.rs:304:30 [INFO] [stderr] | [INFO] [stderr] 304 | asi_vulkan::get_buffering(&mut connection) [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `::new` doesn't need a mutable reference [INFO] [stderr] --> src/renderer/mod.rs:386:4 [INFO] [stderr] | [INFO] [stderr] 386 | &mut vw.connection, include_bytes!( [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `::new` doesn't need a mutable reference [INFO] [stderr] --> src/renderer/mod.rs:389:4 [INFO] [stderr] | [INFO] [stderr] 389 | &mut vw.connection, include_bytes!( [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `::new` doesn't need a mutable reference [INFO] [stderr] --> src/renderer/mod.rs:392:4 [INFO] [stderr] | [INFO] [stderr] 392 | &mut vw.connection, include_bytes!( [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `::new` doesn't need a mutable reference [INFO] [stderr] --> src/renderer/mod.rs:395:4 [INFO] [stderr] | [INFO] [stderr] 395 | &mut vw.connection, include_bytes!( [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `::new` doesn't need a mutable reference [INFO] [stderr] --> src/renderer/mod.rs:398:4 [INFO] [stderr] | [INFO] [stderr] 398 | &mut vw.connection, include_bytes!( [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `::new` doesn't need a mutable reference [INFO] [stderr] --> src/renderer/mod.rs:401:4 [INFO] [stderr] | [INFO] [stderr] 401 | &mut vw.connection, include_bytes!( [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `::new` doesn't need a mutable reference [INFO] [stderr] --> src/renderer/mod.rs:404:4 [INFO] [stderr] | [INFO] [stderr] 404 | &mut vw.connection, include_bytes!( [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `::new` doesn't need a mutable reference [INFO] [stderr] --> src/renderer/mod.rs:407:4 [INFO] [stderr] | [INFO] [stderr] 407 | &mut vw.connection, include_bytes!( [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `::new` doesn't need a mutable reference [INFO] [stderr] --> src/renderer/mod.rs:410:4 [INFO] [stderr] | [INFO] [stderr] 410 | &mut vw.connection, include_bytes!( [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `::new` doesn't need a mutable reference [INFO] [stderr] --> src/renderer/mod.rs:413:4 [INFO] [stderr] | [INFO] [stderr] 413 | &mut vw.connection, include_bytes!( [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `::new` doesn't need a mutable reference [INFO] [stderr] --> src/renderer/mod.rs:416:4 [INFO] [stderr] | [INFO] [stderr] 416 | &mut vw.connection, include_bytes!( [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `::new` doesn't need a mutable reference [INFO] [stderr] --> src/renderer/mod.rs:419:4 [INFO] [stderr] | [INFO] [stderr] 419 | &mut vw.connection, include_bytes!( [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `asi_vulkan::vw_camera_new` doesn't need a mutable reference [INFO] [stderr] --> src/renderer/mod.rs:454:30 [INFO] [stderr] | [INFO] [stderr] 454 | asi_vulkan::vw_camera_new(&mut vw.connection, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/renderer/mod.rs:576:13 [INFO] [stderr] | [INFO] [stderr] 576 | self.ar = size.0 as f32 / size.1 as f32; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f32::from(size.0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/renderer/mod.rs:576:29 [INFO] [stderr] | [INFO] [stderr] 576 | self.ar = size.0 as f32 / size.1 as f32; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f32::from(size.1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/renderer/mod.rs:669:2 [INFO] [stderr] | [INFO] [stderr] 669 | pub fn textured(&mut self, model: usize, mat4: Transform, [INFO] [stderr] | _____^ [INFO] [stderr] 670 | | texture: usize, texcoords: usize, alpha: bool, [INFO] [stderr] 671 | | fog: bool, camera: bool) -> ShapeHandle [INFO] [stderr] 672 | | { [INFO] [stderr] ... | [INFO] [stderr] 726 | | } [INFO] [stderr] 727 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/renderer/mod.rs:840:2 [INFO] [stderr] | [INFO] [stderr] 840 | pub fn faded(&mut self, model: usize, mat4: Transform, texture: usize, [INFO] [stderr] | _____^ [INFO] [stderr] 841 | | texcoords: usize, fade_factor: f32, fog: bool, [INFO] [stderr] 842 | | camera: bool) -> ShapeHandle [INFO] [stderr] 843 | | { [INFO] [stderr] ... | [INFO] [stderr] 889 | | } [INFO] [stderr] 890 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (9/7) [INFO] [stderr] --> src/renderer/mod.rs:892:2 [INFO] [stderr] | [INFO] [stderr] 892 | pub fn tinted(&mut self, model: usize, mat4: Transform, [INFO] [stderr] | _____^ [INFO] [stderr] 893 | | texture: usize, texcoords: usize, color: [f32; 4], [INFO] [stderr] 894 | | alpha: bool, fog: bool, camera: bool) [INFO] [stderr] 895 | | -> ShapeHandle [INFO] [stderr] ... | [INFO] [stderr] 951 | | } [INFO] [stderr] 952 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (9/7) [INFO] [stderr] --> src/renderer/mod.rs:954:2 [INFO] [stderr] | [INFO] [stderr] 954 | pub fn complex(&mut self, model: usize, mat4: Transform, [INFO] [stderr] | _____^ [INFO] [stderr] 955 | | texture: usize, texcoords: usize, colors: usize, alpha: bool, [INFO] [stderr] 956 | | fog: bool, camera: bool) -> ShapeHandle [INFO] [stderr] 957 | | { [INFO] [stderr] ... | [INFO] [stderr] 1013 | | } [INFO] [stderr] 1014 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/renderer/ffi.rs:44:7 [INFO] [stderr] | [INFO] [stderr] 44 | *(mapped.offset((i * pitch + j * 4 + k) [INFO] [stderr] | ______________________^ [INFO] [stderr] 45 | | as isize)) [INFO] [stderr] | |______________________________________^ help: try: `mapped.add((i * pitch + j * 4 + k))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_offset_with_cast)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: The function/method `::new` doesn't need a mutable reference [INFO] [stderr] --> src/renderer/mod.rs:217:3 [INFO] [stderr] | [INFO] [stderr] 217 | &mut vw.connection, width as u32, height as u32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/renderer/mod.rs:217:23 [INFO] [stderr] | [INFO] [stderr] 217 | &mut vw.connection, width as u32, height as u32, [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u32::from(width)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/renderer/mod.rs:217:37 [INFO] [stderr] | [INFO] [stderr] 217 | &mut vw.connection, width as u32, height as u32, [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: The function/method `::new` doesn't need a mutable reference [INFO] [stderr] --> src/renderer/mod.rs:235:4 [INFO] [stderr] | [INFO] [stderr] 235 | &mut vw.connection, width as u32, height as u32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/renderer/mod.rs:235:24 [INFO] [stderr] | [INFO] [stderr] 235 | &mut vw.connection, width as u32, height as u32, [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u32::from(width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/renderer/mod.rs:235:38 [INFO] [stderr] | [INFO] [stderr] 235 | &mut vw.connection, width as u32, height as u32, [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: The function/method `ffi::copy_memory_pitched` doesn't need a mutable reference [INFO] [stderr] --> src/renderer/mod.rs:252:27 [INFO] [stderr] | [INFO] [stderr] 252 | ffi::copy_memory_pitched(&mut vw.connection, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `asi_vulkan::copy_image` doesn't need a mutable reference [INFO] [stderr] --> src/renderer/mod.rs:265:27 [INFO] [stderr] | [INFO] [stderr] 265 | asi_vulkan::copy_image(&mut vw.connection, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `asi_vulkan::get_buffering` doesn't need a mutable reference [INFO] [stderr] --> src/renderer/mod.rs:304:30 [INFO] [stderr] | [INFO] [stderr] 304 | asi_vulkan::get_buffering(&mut connection) [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `::new` doesn't need a mutable reference [INFO] [stderr] --> src/renderer/mod.rs:386:4 [INFO] [stderr] | [INFO] [stderr] 386 | &mut vw.connection, include_bytes!( [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `::new` doesn't need a mutable reference [INFO] [stderr] --> src/renderer/mod.rs:389:4 [INFO] [stderr] | [INFO] [stderr] 389 | &mut vw.connection, include_bytes!( [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `::new` doesn't need a mutable reference [INFO] [stderr] --> src/renderer/mod.rs:392:4 [INFO] [stderr] | [INFO] [stderr] 392 | &mut vw.connection, include_bytes!( [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `::new` doesn't need a mutable reference [INFO] [stderr] --> src/renderer/mod.rs:395:4 [INFO] [stderr] | [INFO] [stderr] 395 | &mut vw.connection, include_bytes!( [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `::new` doesn't need a mutable reference [INFO] [stderr] --> src/renderer/mod.rs:398:4 [INFO] [stderr] | [INFO] [stderr] 398 | &mut vw.connection, include_bytes!( [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `::new` doesn't need a mutable reference [INFO] [stderr] --> src/renderer/mod.rs:401:4 [INFO] [stderr] | [INFO] [stderr] 401 | &mut vw.connection, include_bytes!( [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `::new` doesn't need a mutable reference [INFO] [stderr] --> src/renderer/mod.rs:404:4 [INFO] [stderr] | [INFO] [stderr] 404 | &mut vw.connection, include_bytes!( [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `::new` doesn't need a mutable reference [INFO] [stderr] --> src/renderer/mod.rs:407:4 [INFO] [stderr] | [INFO] [stderr] 407 | &mut vw.connection, include_bytes!( [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `::new` doesn't need a mutable reference [INFO] [stderr] --> src/renderer/mod.rs:410:4 [INFO] [stderr] | [INFO] [stderr] 410 | &mut vw.connection, include_bytes!( [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `::new` doesn't need a mutable reference [INFO] [stderr] --> src/renderer/mod.rs:413:4 [INFO] [stderr] | [INFO] [stderr] 413 | &mut vw.connection, include_bytes!( [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `::new` doesn't need a mutable reference [INFO] [stderr] --> src/renderer/mod.rs:416:4 [INFO] [stderr] | [INFO] [stderr] 416 | &mut vw.connection, include_bytes!( [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `::new` doesn't need a mutable reference [INFO] [stderr] --> src/renderer/mod.rs:419:4 [INFO] [stderr] | [INFO] [stderr] 419 | &mut vw.connection, include_bytes!( [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `asi_vulkan::vw_camera_new` doesn't need a mutable reference [INFO] [stderr] --> src/renderer/mod.rs:454:30 [INFO] [stderr] | [INFO] [stderr] 454 | asi_vulkan::vw_camera_new(&mut vw.connection, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/renderer/mod.rs:576:13 [INFO] [stderr] | [INFO] [stderr] 576 | self.ar = size.0 as f32 / size.1 as f32; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f32::from(size.0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/renderer/mod.rs:576:29 [INFO] [stderr] | [INFO] [stderr] 576 | self.ar = size.0 as f32 / size.1 as f32; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f32::from(size.1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/renderer/mod.rs:669:2 [INFO] [stderr] | [INFO] [stderr] 669 | pub fn textured(&mut self, model: usize, mat4: Transform, [INFO] [stderr] | _____^ [INFO] [stderr] 670 | | texture: usize, texcoords: usize, alpha: bool, [INFO] [stderr] 671 | | fog: bool, camera: bool) -> ShapeHandle [INFO] [stderr] 672 | | { [INFO] [stderr] ... | [INFO] [stderr] 726 | | } [INFO] [stderr] 727 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/renderer/mod.rs:840:2 [INFO] [stderr] | [INFO] [stderr] 840 | pub fn faded(&mut self, model: usize, mat4: Transform, texture: usize, [INFO] [stderr] | _____^ [INFO] [stderr] 841 | | texcoords: usize, fade_factor: f32, fog: bool, [INFO] [stderr] 842 | | camera: bool) -> ShapeHandle [INFO] [stderr] 843 | | { [INFO] [stderr] ... | [INFO] [stderr] 889 | | } [INFO] [stderr] 890 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (9/7) [INFO] [stderr] --> src/renderer/mod.rs:892:2 [INFO] [stderr] | [INFO] [stderr] 892 | pub fn tinted(&mut self, model: usize, mat4: Transform, [INFO] [stderr] | _____^ [INFO] [stderr] 893 | | texture: usize, texcoords: usize, color: [f32; 4], [INFO] [stderr] 894 | | alpha: bool, fog: bool, camera: bool) [INFO] [stderr] 895 | | -> ShapeHandle [INFO] [stderr] ... | [INFO] [stderr] 951 | | } [INFO] [stderr] 952 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (9/7) [INFO] [stderr] --> src/renderer/mod.rs:954:2 [INFO] [stderr] | [INFO] [stderr] 954 | pub fn complex(&mut self, model: usize, mat4: Transform, [INFO] [stderr] | _____^ [INFO] [stderr] 955 | | texture: usize, texcoords: usize, colors: usize, alpha: bool, [INFO] [stderr] 956 | | fog: bool, camera: bool) -> ShapeHandle [INFO] [stderr] 957 | | { [INFO] [stderr] ... | [INFO] [stderr] 1013 | | } [INFO] [stderr] 1014 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.41s [INFO] running `"docker" "inspect" "27d4eb2f838ab689a40f5a9fd0187c46aca1659b510a429a3e080554540e0ce6"` [INFO] running `"docker" "rm" "-f" "27d4eb2f838ab689a40f5a9fd0187c46aca1659b510a429a3e080554540e0ce6"` [INFO] [stdout] 27d4eb2f838ab689a40f5a9fd0187c46aca1659b510a429a3e080554540e0ce6