[INFO] crate adi_gpu_opengl 0.11.0 is already in cache [INFO] extracting crate adi_gpu_opengl 0.11.0 into work/ex/clippy-test-run/sources/stable/reg/adi_gpu_opengl/0.11.0 [INFO] extracting crate adi_gpu_opengl 0.11.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/adi_gpu_opengl/0.11.0 [INFO] validating manifest of adi_gpu_opengl-0.11.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of adi_gpu_opengl-0.11.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing adi_gpu_opengl-0.11.0 [INFO] finished frobbing adi_gpu_opengl-0.11.0 [INFO] frobbed toml for adi_gpu_opengl-0.11.0 written to work/ex/clippy-test-run/sources/stable/reg/adi_gpu_opengl/0.11.0/Cargo.toml [INFO] started frobbing adi_gpu_opengl-0.11.0 [INFO] finished frobbing adi_gpu_opengl-0.11.0 [INFO] frobbed toml for adi_gpu_opengl-0.11.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/adi_gpu_opengl/0.11.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting adi_gpu_opengl-0.11.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/adi_gpu_opengl/0.11.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 87daa7ab8d6a29a5dee2e8b0571017ddde0277907d4f1b7dbf4dd5ef5c66b965 [INFO] running `"docker" "start" "-a" "87daa7ab8d6a29a5dee2e8b0571017ddde0277907d4f1b7dbf4dd5ef5c66b965"` [INFO] [stderr] Compiling cgmath v0.16.1 [INFO] [stderr] Checking stick v0.4.1 [INFO] [stderr] Checking afi v0.7.0 [INFO] [stderr] Checking dl_api v0.2.0 [INFO] [stderr] Checking asi_opengl v0.6.2 [INFO] [stderr] Checking awi v0.8.0 [INFO] [stderr] Checking euler v0.4.0 [INFO] [stderr] Checking adi_gpu_base v0.11.0 [INFO] [stderr] Checking adi_gpu_opengl v0.11.0 (/opt/crater/workdir) [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:26:27 [INFO] [stderr] | [INFO] [stderr] 26 | const SHADER_SOLID_FRAG: &'static [u8] = include_bytes!("shaders/solid-frag.glsl"); [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:27:27 [INFO] [stderr] | [INFO] [stderr] 27 | const SHADER_SOLID_VERT: &'static [u8] = include_bytes!("shaders/solid-vert.glsl"); [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:28:30 [INFO] [stderr] | [INFO] [stderr] 28 | const SHADER_GRADIENT_FRAG: &'static [u8] = include_bytes!("shaders/gradient-frag.glsl"); [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:29:30 [INFO] [stderr] | [INFO] [stderr] 29 | const SHADER_GRADIENT_VERT: &'static [u8] = include_bytes!("shaders/gradient-vert.glsl"); [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:30:25 [INFO] [stderr] | [INFO] [stderr] 30 | const SHADER_TEX_FRAG: &'static [u8] = include_bytes!("shaders/texture-frag.glsl"); [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:31:25 [INFO] [stderr] | [INFO] [stderr] 31 | const SHADER_TEX_VERT: &'static [u8] = include_bytes!("shaders/texture-vert.glsl"); [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:32:27 [INFO] [stderr] | [INFO] [stderr] 32 | const SHADER_FADED_VERT: &'static [u8] = include_bytes!("shaders/faded-vert.glsl"); [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:33:28 [INFO] [stderr] | [INFO] [stderr] 33 | const SHADER_TINTED_FRAG: &'static [u8] = include_bytes!("shaders/tinted-frag.glsl"); [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:34:29 [INFO] [stderr] | [INFO] [stderr] 34 | const SHADER_COMPLEX_VERT: &'static [u8] = include_bytes!("shaders/complex-vert.glsl"); [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:35:29 [INFO] [stderr] | [INFO] [stderr] 35 | const SHADER_COMPLEX_FRAG: &'static [u8] = include_bytes!("shaders/complex-frag.glsl"); [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/lib.rs:335:45 [INFO] [stderr] | [INFO] [stderr] 335 | fn fog(&mut self, fog: Option<(f32, f32)>) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/lib.rs:698:39 [INFO] [stderr] | [INFO] [stderr] 698 | fn resize(&mut self, wh: (u16, u16)) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: transmute from an integer to a pointer [INFO] [stderr] --> src/lib.rs:153:13 [INFO] [stderr] | [INFO] [stderr] 153 | unsafe {mem::transmute(window as usize)} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `window as usize as *mut std::ffi::c_void` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_transmute)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:199:12 [INFO] [stderr] | [INFO] [stderr] 199 | let ar = wh.0 as f32 / wh.1 as f32; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f32::from(wh.0)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:199:26 [INFO] [stderr] | [INFO] [stderr] 199 | let ar = wh.0 as f32 / wh.1 as f32; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f32::from(wh.1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:702:13 [INFO] [stderr] | [INFO] [stderr] 702 | self.ar = wh.0 as f32 / wh.1 as f32; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f32::from(wh.0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:702:27 [INFO] [stderr] | [INFO] [stderr] 702 | self.ar = wh.0 as f32 / wh.1 as f32; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f32::from(wh.1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:26:27 [INFO] [stderr] | [INFO] [stderr] 26 | const SHADER_SOLID_FRAG: &'static [u8] = include_bytes!("shaders/solid-frag.glsl"); [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:27:27 [INFO] [stderr] | [INFO] [stderr] 27 | const SHADER_SOLID_VERT: &'static [u8] = include_bytes!("shaders/solid-vert.glsl"); [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:28:30 [INFO] [stderr] | [INFO] [stderr] 28 | const SHADER_GRADIENT_FRAG: &'static [u8] = include_bytes!("shaders/gradient-frag.glsl"); [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:29:30 [INFO] [stderr] | [INFO] [stderr] 29 | const SHADER_GRADIENT_VERT: &'static [u8] = include_bytes!("shaders/gradient-vert.glsl"); [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:30:25 [INFO] [stderr] | [INFO] [stderr] 30 | const SHADER_TEX_FRAG: &'static [u8] = include_bytes!("shaders/texture-frag.glsl"); [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:31:25 [INFO] [stderr] | [INFO] [stderr] 31 | const SHADER_TEX_VERT: &'static [u8] = include_bytes!("shaders/texture-vert.glsl"); [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:32:27 [INFO] [stderr] | [INFO] [stderr] 32 | const SHADER_FADED_VERT: &'static [u8] = include_bytes!("shaders/faded-vert.glsl"); [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:33:28 [INFO] [stderr] | [INFO] [stderr] 33 | const SHADER_TINTED_FRAG: &'static [u8] = include_bytes!("shaders/tinted-frag.glsl"); [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:34:29 [INFO] [stderr] | [INFO] [stderr] 34 | const SHADER_COMPLEX_VERT: &'static [u8] = include_bytes!("shaders/complex-vert.glsl"); [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:35:29 [INFO] [stderr] | [INFO] [stderr] 35 | const SHADER_COMPLEX_FRAG: &'static [u8] = include_bytes!("shaders/complex-frag.glsl"); [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/lib.rs:335:45 [INFO] [stderr] | [INFO] [stderr] 335 | fn fog(&mut self, fog: Option<(f32, f32)>) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/lib.rs:698:39 [INFO] [stderr] | [INFO] [stderr] 698 | fn resize(&mut self, wh: (u16, u16)) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: transmute from an integer to a pointer [INFO] [stderr] --> src/lib.rs:153:13 [INFO] [stderr] | [INFO] [stderr] 153 | unsafe {mem::transmute(window as usize)} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `window as usize as *mut std::ffi::c_void` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_transmute)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:199:12 [INFO] [stderr] | [INFO] [stderr] 199 | let ar = wh.0 as f32 / wh.1 as f32; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f32::from(wh.0)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:199:26 [INFO] [stderr] | [INFO] [stderr] 199 | let ar = wh.0 as f32 / wh.1 as f32; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f32::from(wh.1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:702:13 [INFO] [stderr] | [INFO] [stderr] 702 | self.ar = wh.0 as f32 / wh.1 as f32; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f32::from(wh.0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:702:27 [INFO] [stderr] | [INFO] [stderr] 702 | self.ar = wh.0 as f32 / wh.1 as f32; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f32::from(wh.1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 13.55s [INFO] running `"docker" "inspect" "87daa7ab8d6a29a5dee2e8b0571017ddde0277907d4f1b7dbf4dd5ef5c66b965"` [INFO] running `"docker" "rm" "-f" "87daa7ab8d6a29a5dee2e8b0571017ddde0277907d4f1b7dbf4dd5ef5c66b965"` [INFO] [stdout] 87daa7ab8d6a29a5dee2e8b0571017ddde0277907d4f1b7dbf4dd5ef5c66b965