[INFO] crate adi_gpu_base 0.11.0 is already in cache [INFO] extracting crate adi_gpu_base 0.11.0 into work/ex/clippy-test-run/sources/stable/reg/adi_gpu_base/0.11.0 [INFO] extracting crate adi_gpu_base 0.11.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/adi_gpu_base/0.11.0 [INFO] validating manifest of adi_gpu_base-0.11.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of adi_gpu_base-0.11.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing adi_gpu_base-0.11.0 [INFO] finished frobbing adi_gpu_base-0.11.0 [INFO] frobbed toml for adi_gpu_base-0.11.0 written to work/ex/clippy-test-run/sources/stable/reg/adi_gpu_base/0.11.0/Cargo.toml [INFO] started frobbing adi_gpu_base-0.11.0 [INFO] finished frobbing adi_gpu_base-0.11.0 [INFO] frobbed toml for adi_gpu_base-0.11.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/adi_gpu_base/0.11.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting adi_gpu_base-0.11.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/adi_gpu_base/0.11.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 4392d7969aae2cadfc95e0fa85427f0a91bb36ed653c35b87609d40a2dfc9ee6 [INFO] running `"docker" "start" "-a" "4392d7969aae2cadfc95e0fa85427f0a91bb36ed653c35b87609d40a2dfc9ee6"` [INFO] [stderr] Checking adi_gpu_base v0.11.0 (/opt/crater/workdir) [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:62:35 [INFO] [stderr] | [INFO] [stderr] 62 | fn shape_solid(&mut self, model: &Model, transform: Transform, [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `Model` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:67:38 [INFO] [stderr] | [INFO] [stderr] 67 | fn shape_gradient(&mut self, model: &Model, transform: Transform, [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `Model` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:74:37 [INFO] [stderr] | [INFO] [stderr] 74 | fn shape_texture(&mut self, model: &Model, transform: Transform, [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `Model` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:82:35 [INFO] [stderr] | [INFO] [stderr] 82 | fn shape_faded(&mut self, model: &Model, transform: Transform, [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `Model` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:90:36 [INFO] [stderr] | [INFO] [stderr] 90 | fn shape_tinted(&mut self, model: &Model, transform: Transform, [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `Model` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:98:37 [INFO] [stderr] | [INFO] [stderr] 98 | fn shape_complex(&mut self, model: &Model, transform: Transform, [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `Model` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/lib.rs:74:2 [INFO] [stderr] | [INFO] [stderr] 74 | fn shape_texture(&mut self, model: &Model, transform: Transform, [INFO] [stderr] | _____^ [INFO] [stderr] 75 | | texture: &Texture, tc: TexCoords, blending: bool, [INFO] [stderr] 76 | | fog: bool, camera: bool) -> Shape; [INFO] [stderr] | |__________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/lib.rs:82:2 [INFO] [stderr] | [INFO] [stderr] 82 | fn shape_faded(&mut self, model: &Model, transform: Transform, [INFO] [stderr] | _____^ [INFO] [stderr] 83 | | texture: &Texture, tc: TexCoords, alpha: f32, [INFO] [stderr] 84 | | fog: bool, camera: bool) -> Shape; [INFO] [stderr] | |__________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (9/7) [INFO] [stderr] --> src/lib.rs:90:2 [INFO] [stderr] | [INFO] [stderr] 90 | fn shape_tinted(&mut self, model: &Model, transform: Transform, [INFO] [stderr] | _____^ [INFO] [stderr] 91 | | texture: &Texture, tc: TexCoords, tint: [f32; 4], [INFO] [stderr] 92 | | blending: bool, fog: bool, camera: bool) -> Shape; [INFO] [stderr] | |__________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (9/7) [INFO] [stderr] --> src/lib.rs:98:2 [INFO] [stderr] | [INFO] [stderr] 98 | fn shape_complex(&mut self, model: &Model, transform: Transform, [INFO] [stderr] | _____^ [INFO] [stderr] 99 | | texture: &Texture, tc: TexCoords, [INFO] [stderr] 100 | | gradient: Gradient, blending: bool, [INFO] [stderr] 101 | | fog: bool, camera: bool) -> Shape; [INFO] [stderr] | |__________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:178:55 [INFO] [stderr] | [INFO] [stderr] 178 | pub fn zsort(sorted: &mut Vec, points: &Vec, nr: bool, [INFO] [stderr] | ^^^^^^^ help: change this to: `&[T]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:62:35 [INFO] [stderr] | [INFO] [stderr] 62 | fn shape_solid(&mut self, model: &Model, transform: Transform, [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `Model` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:67:38 [INFO] [stderr] | [INFO] [stderr] 67 | fn shape_gradient(&mut self, model: &Model, transform: Transform, [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `Model` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:74:37 [INFO] [stderr] | [INFO] [stderr] 74 | fn shape_texture(&mut self, model: &Model, transform: Transform, [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `Model` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:82:35 [INFO] [stderr] | [INFO] [stderr] 82 | fn shape_faded(&mut self, model: &Model, transform: Transform, [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `Model` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:90:36 [INFO] [stderr] | [INFO] [stderr] 90 | fn shape_tinted(&mut self, model: &Model, transform: Transform, [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `Model` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:98:37 [INFO] [stderr] | [INFO] [stderr] 98 | fn shape_complex(&mut self, model: &Model, transform: Transform, [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `Model` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/lib.rs:74:2 [INFO] [stderr] | [INFO] [stderr] 74 | fn shape_texture(&mut self, model: &Model, transform: Transform, [INFO] [stderr] | _____^ [INFO] [stderr] 75 | | texture: &Texture, tc: TexCoords, blending: bool, [INFO] [stderr] 76 | | fog: bool, camera: bool) -> Shape; [INFO] [stderr] | |__________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/lib.rs:82:2 [INFO] [stderr] | [INFO] [stderr] 82 | fn shape_faded(&mut self, model: &Model, transform: Transform, [INFO] [stderr] | _____^ [INFO] [stderr] 83 | | texture: &Texture, tc: TexCoords, alpha: f32, [INFO] [stderr] 84 | | fog: bool, camera: bool) -> Shape; [INFO] [stderr] | |__________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (9/7) [INFO] [stderr] --> src/lib.rs:90:2 [INFO] [stderr] | [INFO] [stderr] 90 | fn shape_tinted(&mut self, model: &Model, transform: Transform, [INFO] [stderr] | _____^ [INFO] [stderr] 91 | | texture: &Texture, tc: TexCoords, tint: [f32; 4], [INFO] [stderr] 92 | | blending: bool, fog: bool, camera: bool) -> Shape; [INFO] [stderr] | |__________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (9/7) [INFO] [stderr] --> src/lib.rs:98:2 [INFO] [stderr] | [INFO] [stderr] 98 | fn shape_complex(&mut self, model: &Model, transform: Transform, [INFO] [stderr] | _____^ [INFO] [stderr] 99 | | texture: &Texture, tc: TexCoords, [INFO] [stderr] 100 | | gradient: Gradient, blending: bool, [INFO] [stderr] 101 | | fog: bool, camera: bool) -> Shape; [INFO] [stderr] | |__________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:178:55 [INFO] [stderr] | [INFO] [stderr] 178 | pub fn zsort(sorted: &mut Vec, points: &Vec, nr: bool, [INFO] [stderr] | ^^^^^^^ help: change this to: `&[T]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.72s [INFO] running `"docker" "inspect" "4392d7969aae2cadfc95e0fa85427f0a91bb36ed653c35b87609d40a2dfc9ee6"` [INFO] running `"docker" "rm" "-f" "4392d7969aae2cadfc95e0fa85427f0a91bb36ed653c35b87609d40a2dfc9ee6"` [INFO] [stdout] 4392d7969aae2cadfc95e0fa85427f0a91bb36ed653c35b87609d40a2dfc9ee6