[INFO] crate addressable-pairing-heap 0.2.0 is already in cache [INFO] extracting crate addressable-pairing-heap 0.2.0 into work/ex/clippy-test-run/sources/stable/reg/addressable-pairing-heap/0.2.0 [INFO] extracting crate addressable-pairing-heap 0.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/addressable-pairing-heap/0.2.0 [INFO] validating manifest of addressable-pairing-heap-0.2.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of addressable-pairing-heap-0.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing addressable-pairing-heap-0.2.0 [INFO] finished frobbing addressable-pairing-heap-0.2.0 [INFO] frobbed toml for addressable-pairing-heap-0.2.0 written to work/ex/clippy-test-run/sources/stable/reg/addressable-pairing-heap/0.2.0/Cargo.toml [INFO] started frobbing addressable-pairing-heap-0.2.0 [INFO] finished frobbing addressable-pairing-heap-0.2.0 [INFO] frobbed toml for addressable-pairing-heap-0.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/addressable-pairing-heap/0.2.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting addressable-pairing-heap-0.2.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/addressable-pairing-heap/0.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 3537fc35a044182671a13364d1fa1c1f702d08148859d699f068ac32dc151b5a [INFO] running `"docker" "start" "-a" "3537fc35a044182671a13364d1fa1c1f702d08148859d699f068ac32dc151b5a"` [INFO] [stderr] Checking stash v0.1.3 [INFO] [stderr] Checking addressable-pairing-heap v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:67:4 [INFO] [stderr] | [INFO] [stderr] 67 | key : key, [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `key` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:68:4 [INFO] [stderr] | [INFO] [stderr] 68 | elem: elem [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `elem` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:125:4 [INFO] [stderr] | [INFO] [stderr] 125 | entry : entry, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `entry` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:67:4 [INFO] [stderr] | [INFO] [stderr] 67 | key : key, [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `key` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:68:4 [INFO] [stderr] | [INFO] [stderr] 68 | elem: elem [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `elem` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:125:4 [INFO] [stderr] | [INFO] [stderr] 125 | entry : entry, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `entry` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `PairingHeap` [INFO] [stderr] --> src/lib.rs:184:2 [INFO] [stderr] | [INFO] [stderr] 184 | pub fn new() -> Self { [INFO] [stderr] | _____^ [INFO] [stderr] 185 | | PairingHeap{ [INFO] [stderr] 186 | | min : Handle::undef(), [INFO] [stderr] 187 | | roots: Vec::new(), [INFO] [stderr] 188 | | data : Stash::new() [INFO] [stderr] 189 | | } [INFO] [stderr] 190 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 179 | impl Default for PairingHeap { [INFO] [stderr] 180 | fn default() -> Self { [INFO] [stderr] 181 | Self::new() [INFO] [stderr] 182 | } [INFO] [stderr] 183 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:395:3 [INFO] [stderr] | [INFO] [stderr] 395 | match self.is_empty() { [INFO] [stderr] | _________^ [INFO] [stderr] 396 | | true => None, [INFO] [stderr] 397 | | _ => unsafe{ Some(self.pop_unchecked()) } [INFO] [stderr] 398 | | } [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if self.is_empty() { None } else unsafe{ Some(self.pop_unchecked()) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:423:2 [INFO] [stderr] | [INFO] [stderr] 423 | pub fn values<'a>(&'a self) -> Values<'a, T, K> { [INFO] [stderr] | _____^ [INFO] [stderr] 424 | | Values{iter: self.data.values()} [INFO] [stderr] 425 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:429:2 [INFO] [stderr] | [INFO] [stderr] 429 | pub fn values_mut<'a>(&'a mut self) -> ValuesMut<'a, T, K> { [INFO] [stderr] | _____^ [INFO] [stderr] 430 | | ValuesMut{iter: self.data.values_mut()} [INFO] [stderr] 431 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `PairingHeap` [INFO] [stderr] --> src/lib.rs:184:2 [INFO] [stderr] | [INFO] [stderr] 184 | pub fn new() -> Self { [INFO] [stderr] | _____^ [INFO] [stderr] 185 | | PairingHeap{ [INFO] [stderr] 186 | | min : Handle::undef(), [INFO] [stderr] 187 | | roots: Vec::new(), [INFO] [stderr] 188 | | data : Stash::new() [INFO] [stderr] 189 | | } [INFO] [stderr] 190 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 179 | impl Default for PairingHeap { [INFO] [stderr] 180 | fn default() -> Self { [INFO] [stderr] 181 | Self::new() [INFO] [stderr] 182 | } [INFO] [stderr] 183 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:395:3 [INFO] [stderr] | [INFO] [stderr] 395 | match self.is_empty() { [INFO] [stderr] | _________^ [INFO] [stderr] 396 | | true => None, [INFO] [stderr] 397 | | _ => unsafe{ Some(self.pop_unchecked()) } [INFO] [stderr] 398 | | } [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if self.is_empty() { None } else unsafe{ Some(self.pop_unchecked()) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:423:2 [INFO] [stderr] | [INFO] [stderr] 423 | pub fn values<'a>(&'a self) -> Values<'a, T, K> { [INFO] [stderr] | _____^ [INFO] [stderr] 424 | | Values{iter: self.data.values()} [INFO] [stderr] 425 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:429:2 [INFO] [stderr] | [INFO] [stderr] 429 | pub fn values_mut<'a>(&'a mut self) -> ValuesMut<'a, T, K> { [INFO] [stderr] | _____^ [INFO] [stderr] 430 | | ValuesMut{iter: self.data.values_mut()} [INFO] [stderr] 431 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.52s [INFO] running `"docker" "inspect" "3537fc35a044182671a13364d1fa1c1f702d08148859d699f068ac32dc151b5a"` [INFO] running `"docker" "rm" "-f" "3537fc35a044182671a13364d1fa1c1f702d08148859d699f068ac32dc151b5a"` [INFO] [stdout] 3537fc35a044182671a13364d1fa1c1f702d08148859d699f068ac32dc151b5a