[INFO] crate acyclic-network 0.2.0 is already in cache
[INFO] extracting crate acyclic-network 0.2.0 into work/ex/clippy-test-run/sources/stable/reg/acyclic-network/0.2.0
[INFO] extracting crate acyclic-network 0.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/acyclic-network/0.2.0
[INFO] validating manifest of acyclic-network-0.2.0 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of acyclic-network-0.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing acyclic-network-0.2.0
[INFO] finished frobbing acyclic-network-0.2.0
[INFO] frobbed toml for acyclic-network-0.2.0 written to work/ex/clippy-test-run/sources/stable/reg/acyclic-network/0.2.0/Cargo.toml
[INFO] started frobbing acyclic-network-0.2.0
[INFO] finished frobbing acyclic-network-0.2.0
[INFO] frobbed toml for acyclic-network-0.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/acyclic-network/0.2.0/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting acyclic-network-0.2.0 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/acyclic-network/0.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 13e406ad6fcde7c3b49908b96f0fb9ffb76935fad684962ccc2c75fa883dbd3a
[INFO] running `"docker" "start" "-a" "13e406ad6fcde7c3b49908b96f0fb9ffb76935fad684962ccc2c75fa883dbd3a"`
[INFO] [stderr]     Checking acyclic-network v0.2.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/lib.rs:81:13
[INFO] [stderr]    |
[INFO] [stderr] 81 |             link_array: link_array,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `link_array`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:173:13
[INFO] [stderr]     |
[INFO] [stderr] 173 |             network: network,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^ help: replace it with: `network`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:610:13
[INFO] [stderr]     |
[INFO] [stderr] 610 |             node_type: node_type,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `node_type`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:611:13
[INFO] [stderr]     |
[INFO] [stderr] 611 |             external_node_id: external_node_id,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `external_node_id`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:774:21
[INFO] [stderr]     |
[INFO] [stderr] 774 |                     link: link,
[INFO] [stderr]     |                     ^^^^^^^^^^ help: replace it with: `link`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:786:21
[INFO] [stderr]     |
[INFO] [stderr] 786 |                     link: link,
[INFO] [stderr]     |                     ^^^^^^^^^^ help: replace it with: `link`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:807:21
[INFO] [stderr]     |
[INFO] [stderr] 807 |                     link: link,
[INFO] [stderr]     |                     ^^^^^^^^^^ help: replace it with: `link`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:819:21
[INFO] [stderr]     |
[INFO] [stderr] 819 |                     link: link,
[INFO] [stderr]     |                     ^^^^^^^^^^ help: replace it with: `link`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:869:13
[INFO] [stderr]     |
[INFO] [stderr] 869 |             source_node_idx: source_node_idx,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `source_node_idx`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:870:13
[INFO] [stderr]     |
[INFO] [stderr] 870 |             target_node_idx: target_node_idx,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `target_node_idx`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:871:13
[INFO] [stderr]     |
[INFO] [stderr] 871 |             external_link_id: external_link_id,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `external_link_id`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:872:13
[INFO] [stderr]     |
[INFO] [stderr] 872 |             weight: weight,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^ help: replace it with: `weight`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:903:13
[INFO] [stderr]     |
[INFO] [stderr] 903 |             source_node_idx: source_node_idx,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `source_node_idx`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:904:13
[INFO] [stderr]     |
[INFO] [stderr] 904 |             target_node_idx: target_node_idx,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `target_node_idx`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:905:13
[INFO] [stderr]     |
[INFO] [stderr] 905 |             external_link_id: external_link_id,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `external_link_id`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:906:13
[INFO] [stderr]     |
[INFO] [stderr] 906 |             weight: weight,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^ help: replace it with: `weight`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:907:13
[INFO] [stderr]     |
[INFO] [stderr] 907 |             active: active,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^ help: replace it with: `active`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:936:29
[INFO] [stderr]     |
[INFO] [stderr] 936 |                             link: link,
[INFO] [stderr]     |                             ^^^^^^^^^^ help: replace it with: `link`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/lib.rs:81:13
[INFO] [stderr]    |
[INFO] [stderr] 81 |             link_array: link_array,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `link_array`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:173:13
[INFO] [stderr]     |
[INFO] [stderr] 173 |             network: network,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^ help: replace it with: `network`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:610:13
[INFO] [stderr]     |
[INFO] [stderr] 610 |             node_type: node_type,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `node_type`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:611:13
[INFO] [stderr]     |
[INFO] [stderr] 611 |             external_node_id: external_node_id,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `external_node_id`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:774:21
[INFO] [stderr]     |
[INFO] [stderr] 774 |                     link: link,
[INFO] [stderr]     |                     ^^^^^^^^^^ help: replace it with: `link`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:786:21
[INFO] [stderr]     |
[INFO] [stderr] 786 |                     link: link,
[INFO] [stderr]     |                     ^^^^^^^^^^ help: replace it with: `link`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:807:21
[INFO] [stderr]     |
[INFO] [stderr] 807 |                     link: link,
[INFO] [stderr]     |                     ^^^^^^^^^^ help: replace it with: `link`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:819:21
[INFO] [stderr]     |
[INFO] [stderr] 819 |                     link: link,
[INFO] [stderr]     |                     ^^^^^^^^^^ help: replace it with: `link`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:869:13
[INFO] [stderr]     |
[INFO] [stderr] 869 |             source_node_idx: source_node_idx,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `source_node_idx`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:870:13
[INFO] [stderr]     |
[INFO] [stderr] 870 |             target_node_idx: target_node_idx,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `target_node_idx`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:871:13
[INFO] [stderr]     |
[INFO] [stderr] 871 |             external_link_id: external_link_id,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `external_link_id`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:872:13
[INFO] [stderr]     |
[INFO] [stderr] 872 |             weight: weight,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^ help: replace it with: `weight`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:903:13
[INFO] [stderr]     |
[INFO] [stderr] 903 |             source_node_idx: source_node_idx,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `source_node_idx`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:904:13
[INFO] [stderr]     |
[INFO] [stderr] 904 |             target_node_idx: target_node_idx,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `target_node_idx`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:905:13
[INFO] [stderr]     |
[INFO] [stderr] 905 |             external_link_id: external_link_id,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `external_link_id`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:906:13
[INFO] [stderr]     |
[INFO] [stderr] 906 |             weight: weight,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^ help: replace it with: `weight`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:907:13
[INFO] [stderr]     |
[INFO] [stderr] 907 |             active: active,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^ help: replace it with: `active`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:936:29
[INFO] [stderr]     |
[INFO] [stderr] 936 |                             link: link,
[INFO] [stderr]     |                             ^^^^^^^^^^ help: replace it with: `link`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/cycle_detector.rs:79:9
[INFO] [stderr]    |
[INFO] [stderr] 79 |         return false;
[INFO] [stderr]    |         ^^^^^^^^^^^^^ help: remove `return` as shown: `false`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/lib.rs:98:17
[INFO] [stderr]    |
[INFO] [stderr] 98 |                 return Some((idx, &item.link));
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some((idx, &item.link))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:101:17
[INFO] [stderr]     |
[INFO] [stderr] 101 |                 return None;
[INFO] [stderr]     |                 ^^^^^^^^^^^^ help: remove `return` as shown: `None`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:191:17
[INFO] [stderr]     |
[INFO] [stderr] 191 | /                 return Some(LinkRefItem {
[INFO] [stderr] 192 | |                     link: &item.link,
[INFO] [stderr] 193 | |                     network: &self.network,
[INFO] [stderr] 194 | |                 });
[INFO] [stderr]     | |___________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]     |
[INFO] [stderr] 191 |                 Some(LinkRefItem {
[INFO] [stderr] 192 |                     link: &item.link,
[INFO] [stderr] 193 |                     network: &self.network,
[INFO] [stderr] 194 |                 })
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:197:17
[INFO] [stderr]     |
[INFO] [stderr] 197 |                 return None;
[INFO] [stderr]     |                 ^^^^^^^^^^^^ help: remove `return` as shown: `None`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:468:9
[INFO] [stderr]     |
[INFO] [stderr] 468 |         return None;
[INFO] [stderr]     |         ^^^^^^^^^^^^ help: remove `return` as shown: `None`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:494:9
[INFO] [stderr]     |
[INFO] [stderr] 494 |         return None;
[INFO] [stderr]     |         ^^^^^^^^^^^^ help: remove `return` as shown: `None`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:507:9
[INFO] [stderr]     |
[INFO] [stderr] 507 |         return None;
[INFO] [stderr]     |         ^^^^^^^^^^^^ help: remove `return` as shown: `None`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:616:9
[INFO] [stderr]     |
[INFO] [stderr] 616 |         return node_idx;
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `node_idx`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:672:9
[INFO] [stderr]     |
[INFO] [stderr] 672 |         return None;
[INFO] [stderr]     |         ^^^^^^^^^^^^ help: remove `return` as shown: `None`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:715:9
[INFO] [stderr]     |
[INFO] [stderr] 715 |         return new_link_idx;
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `new_link_idx`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:722:13
[INFO] [stderr]     |
[INFO] [stderr] 722 |             return true;
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: remove `return` as shown: `true`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:724:13
[INFO] [stderr]     |
[INFO] [stderr] 724 |             return false;
[INFO] [stderr]     |             ^^^^^^^^^^^^^ help: remove `return` as shown: `false`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:732:13
[INFO] [stderr]     |
[INFO] [stderr] 732 |             return true;
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: remove `return` as shown: `true`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:734:13
[INFO] [stderr]     |
[INFO] [stderr] 734 |             return false;
[INFO] [stderr]     |             ^^^^^^^^^^^^^ help: remove `return` as shown: `false`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:742:9
[INFO] [stderr]     |
[INFO] [stderr] 742 |         return false;
[INFO] [stderr]     |         ^^^^^^^^^^^^^ help: remove `return` as shown: `false`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:749:9
[INFO] [stderr]     |
[INFO] [stderr] 749 |         return false;
[INFO] [stderr]     |         ^^^^^^^^^^^^^ help: remove `return` as shown: `false`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:782:17
[INFO] [stderr]     |
[INFO] [stderr] 782 |                 return new_link_idx;
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `new_link_idx`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:793:17
[INFO] [stderr]     |
[INFO] [stderr] 793 |                 return new_link_idx;
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `new_link_idx`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:815:17
[INFO] [stderr]     |
[INFO] [stderr] 815 |                 return new_link_idx;
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `new_link_idx`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:826:17
[INFO] [stderr]     |
[INFO] [stderr] 826 |                 return new_link_idx;
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `new_link_idx`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:876:9
[INFO] [stderr]     |
[INFO] [stderr] 876 |         return self.append(source_node_idx, link);
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.append(source_node_idx, link)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:921:17
[INFO] [stderr]     |
[INFO] [stderr] 921 |                 return self.append(source_node_idx, link);
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.append(source_node_idx, link)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:926:25
[INFO] [stderr]     |
[INFO] [stderr] 926 |                         return self.prepend(source_node_idx, link);
[INFO] [stderr]     |                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.prepend(source_node_idx, link)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:944:25
[INFO] [stderr]     |
[INFO] [stderr] 944 |                         return new_link_idx;
[INFO] [stderr]     |                         ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `new_link_idx`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:966:9
[INFO] [stderr]     |
[INFO] [stderr] 966 |         return None;
[INFO] [stderr]     |         ^^^^^^^^^^^^ help: remove `return` as shown: `None`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:985:9
[INFO] [stderr]     |
[INFO] [stderr] 985 |         return None;
[INFO] [stderr]     |         ^^^^^^^^^^^^ help: remove `return` as shown: `None`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/cycle_detector.rs:79:9
[INFO] [stderr]    |
[INFO] [stderr] 79 |         return false;
[INFO] [stderr]    |         ^^^^^^^^^^^^^ help: remove `return` as shown: `false`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/lib.rs:98:17
[INFO] [stderr]    |
[INFO] [stderr] 98 |                 return Some((idx, &item.link));
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some((idx, &item.link))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:101:17
[INFO] [stderr]     |
[INFO] [stderr] 101 |                 return None;
[INFO] [stderr]     |                 ^^^^^^^^^^^^ help: remove `return` as shown: `None`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:191:17
[INFO] [stderr]     |
[INFO] [stderr] 191 | /                 return Some(LinkRefItem {
[INFO] [stderr] 192 | |                     link: &item.link,
[INFO] [stderr] 193 | |                     network: &self.network,
[INFO] [stderr] 194 | |                 });
[INFO] [stderr]     | |___________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]     |
[INFO] [stderr] 191 |                 Some(LinkRefItem {
[INFO] [stderr] 192 |                     link: &item.link,
[INFO] [stderr] 193 |                     network: &self.network,
[INFO] [stderr] 194 |                 })
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:197:17
[INFO] [stderr]     |
[INFO] [stderr] 197 |                 return None;
[INFO] [stderr]     |                 ^^^^^^^^^^^^ help: remove `return` as shown: `None`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:468:9
[INFO] [stderr]     |
[INFO] [stderr] 468 |         return None;
[INFO] [stderr]     |         ^^^^^^^^^^^^ help: remove `return` as shown: `None`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:494:9
[INFO] [stderr]     |
[INFO] [stderr] 494 |         return None;
[INFO] [stderr]     |         ^^^^^^^^^^^^ help: remove `return` as shown: `None`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:507:9
[INFO] [stderr]     |
[INFO] [stderr] 507 |         return None;
[INFO] [stderr]     |         ^^^^^^^^^^^^ help: remove `return` as shown: `None`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:616:9
[INFO] [stderr]     |
[INFO] [stderr] 616 |         return node_idx;
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `node_idx`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:672:9
[INFO] [stderr]     |
[INFO] [stderr] 672 |         return None;
[INFO] [stderr]     |         ^^^^^^^^^^^^ help: remove `return` as shown: `None`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:715:9
[INFO] [stderr]     |
[INFO] [stderr] 715 |         return new_link_idx;
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `new_link_idx`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:722:13
[INFO] [stderr]     |
[INFO] [stderr] 722 |             return true;
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: remove `return` as shown: `true`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:724:13
[INFO] [stderr]     |
[INFO] [stderr] 724 |             return false;
[INFO] [stderr]     |             ^^^^^^^^^^^^^ help: remove `return` as shown: `false`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:732:13
[INFO] [stderr]     |
[INFO] [stderr] 732 |             return true;
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: remove `return` as shown: `true`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:734:13
[INFO] [stderr]     |
[INFO] [stderr] 734 |             return false;
[INFO] [stderr]     |             ^^^^^^^^^^^^^ help: remove `return` as shown: `false`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:742:9
[INFO] [stderr]     |
[INFO] [stderr] 742 |         return false;
[INFO] [stderr]     |         ^^^^^^^^^^^^^ help: remove `return` as shown: `false`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:749:9
[INFO] [stderr]     |
[INFO] [stderr] 749 |         return false;
[INFO] [stderr]     |         ^^^^^^^^^^^^^ help: remove `return` as shown: `false`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:782:17
[INFO] [stderr]     |
[INFO] [stderr] 782 |                 return new_link_idx;
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `new_link_idx`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:793:17
[INFO] [stderr]     |
[INFO] [stderr] 793 |                 return new_link_idx;
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `new_link_idx`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:815:17
[INFO] [stderr]     |
[INFO] [stderr] 815 |                 return new_link_idx;
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `new_link_idx`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:826:17
[INFO] [stderr]     |
[INFO] [stderr] 826 |                 return new_link_idx;
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `new_link_idx`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:876:9
[INFO] [stderr]     |
[INFO] [stderr] 876 |         return self.append(source_node_idx, link);
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.append(source_node_idx, link)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:921:17
[INFO] [stderr]     |
[INFO] [stderr] 921 |                 return self.append(source_node_idx, link);
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.append(source_node_idx, link)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:926:25
[INFO] [stderr]     |
[INFO] [stderr] 926 |                         return self.prepend(source_node_idx, link);
[INFO] [stderr]     |                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.prepend(source_node_idx, link)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:944:25
[INFO] [stderr]     |
[INFO] [stderr] 944 |                         return new_link_idx;
[INFO] [stderr]     |                         ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `new_link_idx`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:966:9
[INFO] [stderr]     |
[INFO] [stderr] 966 |         return None;
[INFO] [stderr]     |         ^^^^^^^^^^^^ help: remove `return` as shown: `None`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:985:9
[INFO] [stderr]     |
[INFO] [stderr] 985 |         return None;
[INFO] [stderr]     |         ^^^^^^^^^^^^ help: remove `return` as shown: `None`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/lib.rs:36:18
[INFO] [stderr]    |
[INFO] [stderr] 36 |     pub fn index(&self) -> usize {
[INFO] [stderr]    |                  ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/lib.rs:47:18
[INFO] [stderr]    |
[INFO] [stderr] 47 |     pub fn index(&self) -> usize {
[INFO] [stderr]    |                  ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `Network<N, L, EXTID>`
[INFO] [stderr]    --> src/lib.rs:333:5
[INFO] [stderr]     |
[INFO] [stderr] 333 | /     pub fn new() -> Network<N, L, EXTID> {
[INFO] [stderr] 334 | |         Network {
[INFO] [stderr] 335 | |             nodes: Vec::new(),
[INFO] [stderr] 336 | |             links: Vec::new(),
[INFO] [stderr] ...   |
[INFO] [stderr] 339 | |         }
[INFO] [stderr] 340 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 320 | #[derive(Default)]
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/lib.rs:393:5
[INFO] [stderr]     |
[INFO] [stderr] 393 | /     pub fn link_iter_for_node<'a>(&'a self, node_idx: NodeIndex) -> LinkIter<'a, L, EXTID> {
[INFO] [stderr] 394 | |         self.node(node_idx).links.iter(&self.links)
[INFO] [stderr] 395 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_lifetimes)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/lib.rs:398:5
[INFO] [stderr]     |
[INFO] [stderr] 398 | /     pub fn link_ref_iter_for_node<'a>(
[INFO] [stderr] 399 | |         &'a self,
[INFO] [stderr] 400 | |         node_idx: NodeIndex,
[INFO] [stderr] 401 | |     ) -> LinkRefIter<'a, N, L, EXTID> {
[INFO] [stderr] 402 | |         LinkRefIter::new(self.node(node_idx).links.head, self)
[INFO] [stderr] 403 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/lib.rs:650:38
[INFO] [stderr]     |
[INFO] [stderr] 650 |         let mut node_order: Vec<_> = (0..n).into_iter().collect();
[INFO] [stderr]     |                                      ^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `(0..n)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::identity_conversion)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/lib.rs:651:38
[INFO] [stderr]     |
[INFO] [stderr] 651 |         let mut edge_order: Vec<_> = (0..n).into_iter().collect();
[INFO] [stderr]     |                                      ^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `(0..n)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: the function has a cyclomatic complexity of 39
[INFO] [stderr]     --> src/lib.rs:989:5
[INFO] [stderr]      |
[INFO] [stderr] 989  | /     pub fn remove_link_at(&mut self, link_index: LinkIndex) {
[INFO] [stderr] 990  | |         let found_idx = link_index;
[INFO] [stderr] 991  | |         let source_node_idx = self.link(found_idx).source_node_idx;
[INFO] [stderr] 992  | |         let target_node_idx = self.link(found_idx).target_node_idx;
[INFO] [stderr] ...    |
[INFO] [stderr] 1119 | |         self.link_count -= 1;
[INFO] [stderr] 1120 | |     }
[INFO] [stderr]      | |_____^
[INFO] [stderr]      |
[INFO] [stderr]      = note: #[warn(clippy::cyclomatic_complexity)] on by default
[INFO] [stderr]      = help: you could split it up into multiple smaller functions
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/lib.rs:36:18
[INFO] [stderr]    |
[INFO] [stderr] 36 |     pub fn index(&self) -> usize {
[INFO] [stderr]    |                  ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/lib.rs:47:18
[INFO] [stderr]    |
[INFO] [stderr] 47 |     pub fn index(&self) -> usize {
[INFO] [stderr]    |                  ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `Network<N, L, EXTID>`
[INFO] [stderr]    --> src/lib.rs:333:5
[INFO] [stderr]     |
[INFO] [stderr] 333 | /     pub fn new() -> Network<N, L, EXTID> {
[INFO] [stderr] 334 | |         Network {
[INFO] [stderr] 335 | |             nodes: Vec::new(),
[INFO] [stderr] 336 | |             links: Vec::new(),
[INFO] [stderr] ...   |
[INFO] [stderr] 339 | |         }
[INFO] [stderr] 340 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 320 | #[derive(Default)]
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/lib.rs:393:5
[INFO] [stderr]     |
[INFO] [stderr] 393 | /     pub fn link_iter_for_node<'a>(&'a self, node_idx: NodeIndex) -> LinkIter<'a, L, EXTID> {
[INFO] [stderr] 394 | |         self.node(node_idx).links.iter(&self.links)
[INFO] [stderr] 395 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_lifetimes)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/lib.rs:398:5
[INFO] [stderr]     |
[INFO] [stderr] 398 | /     pub fn link_ref_iter_for_node<'a>(
[INFO] [stderr] 399 | |         &'a self,
[INFO] [stderr] 400 | |         node_idx: NodeIndex,
[INFO] [stderr] 401 | |     ) -> LinkRefIter<'a, N, L, EXTID> {
[INFO] [stderr] 402 | |         LinkRefIter::new(self.node(node_idx).links.head, self)
[INFO] [stderr] 403 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/lib.rs:650:38
[INFO] [stderr]     |
[INFO] [stderr] 650 |         let mut node_order: Vec<_> = (0..n).into_iter().collect();
[INFO] [stderr]     |                                      ^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `(0..n)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::identity_conversion)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/lib.rs:651:38
[INFO] [stderr]     |
[INFO] [stderr] 651 |         let mut edge_order: Vec<_> = (0..n).into_iter().collect();
[INFO] [stderr]     |                                      ^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `(0..n)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: the function has a cyclomatic complexity of 39
[INFO] [stderr]     --> src/lib.rs:989:5
[INFO] [stderr]      |
[INFO] [stderr] 989  | /     pub fn remove_link_at(&mut self, link_index: LinkIndex) {
[INFO] [stderr] 990  | |         let found_idx = link_index;
[INFO] [stderr] 991  | |         let source_node_idx = self.link(found_idx).source_node_idx;
[INFO] [stderr] 992  | |         let target_node_idx = self.link(found_idx).target_node_idx;
[INFO] [stderr] ...    |
[INFO] [stderr] 1119 | |         self.link_count -= 1;
[INFO] [stderr] 1120 | |     }
[INFO] [stderr]      | |_____^
[INFO] [stderr]      |
[INFO] [stderr]      = note: #[warn(clippy::cyclomatic_complexity)] on by default
[INFO] [stderr]      = help: you could split it up into multiple smaller functions
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: the function has a cyclomatic complexity of 27
[INFO] [stderr]     --> src/lib.rs:1165:5
[INFO] [stderr]      |
[INFO] [stderr] 1165 | /     fn test_cycle() {
[INFO] [stderr] 1166 | |         let mut g = Network::new();
[INFO] [stderr] 1167 | |         let i1 = g.add_node(NodeT::Input, ExternalId(1));
[INFO] [stderr] 1168 | |         let h1 = g.add_node(NodeT::Hidden, ExternalId(2));
[INFO] [stderr] ...    |
[INFO] [stderr] 1203 | |         assert_eq!(false, g.link_would_cycle(i1, h2));
[INFO] [stderr] 1204 | |     }
[INFO] [stderr]      | |_____^
[INFO] [stderr]      |
[INFO] [stderr]      = help: you could split it up into multiple smaller functions
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: the function has a cyclomatic complexity of 28
[INFO] [stderr]     --> src/lib.rs:1231:5
[INFO] [stderr]      |
[INFO] [stderr] 1231 | /     fn test_remove_link() {
[INFO] [stderr] 1232 | |         let mut g = Network::new();
[INFO] [stderr] 1233 | |         let i1 = g.add_node(NodeT::Input, ExternalId(1));
[INFO] [stderr] 1234 | |         let h1 = g.add_node(NodeT::Hidden, ExternalId(2));
[INFO] [stderr] ...    |
[INFO] [stderr] 1293 | |         // XXX: test for sort order
[INFO] [stderr] 1294 | |     }
[INFO] [stderr]      | |_____^
[INFO] [stderr]      |
[INFO] [stderr]      = help: you could split it up into multiple smaller functions
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: the function has a cyclomatic complexity of 28
[INFO] [stderr]     --> src/lib.rs:1297:5
[INFO] [stderr]      |
[INFO] [stderr] 1297 | /     fn test_add_remove_link_unordered() {
[INFO] [stderr] 1298 | |         let mut g = Network::new();
[INFO] [stderr] 1299 | |         let i1 = g.add_node(NodeT::Input, ());
[INFO] [stderr] 1300 | |         let h1 = g.add_node(NodeT::Hidden, ());
[INFO] [stderr] ...    |
[INFO] [stderr] 1339 | |         assert!(g.last_link_of_node(i1).is_none());
[INFO] [stderr] 1340 | |     }
[INFO] [stderr]      | |_____^
[INFO] [stderr]      |
[INFO] [stderr]      = help: you could split it up into multiple smaller functions
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: the function has a cyclomatic complexity of 41
[INFO] [stderr]     --> src/lib.rs:1380:5
[INFO] [stderr]      |
[INFO] [stderr] 1380 | /     fn test_remove_all_incoming_links() {
[INFO] [stderr] 1381 | |         let mut g = Network::new();
[INFO] [stderr] 1382 | |         let i1 = g.add_node(NodeT::Input, ());
[INFO] [stderr] 1383 | |         let h1 = g.add_node(NodeT::Hidden, ());
[INFO] [stderr] ...    |
[INFO] [stderr] 1440 | |         assert!(g.last_link_of_node(i1).is_none());
[INFO] [stderr] 1441 | |     }
[INFO] [stderr]      | |_____^
[INFO] [stderr]      |
[INFO] [stderr]      = help: you could split it up into multiple smaller functions
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: the function has a cyclomatic complexity of 35
[INFO] [stderr]     --> src/lib.rs:1444:5
[INFO] [stderr]      |
[INFO] [stderr] 1444 | /     fn test_remove_all_inout_links() {
[INFO] [stderr] 1445 | |         let mut g = Network::new();
[INFO] [stderr] 1446 | |         let i1 = g.add_node(NodeT::Input, ());
[INFO] [stderr] 1447 | |         let h1 = g.add_node(NodeT::Hidden, ());
[INFO] [stderr] ...    |
[INFO] [stderr] 1499 | |         assert_eq!(0, g.link_count());
[INFO] [stderr] 1500 | |     }
[INFO] [stderr]      | |_____^
[INFO] [stderr]      |
[INFO] [stderr]      = help: you could split it up into multiple smaller functions
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: the function has a cyclomatic complexity of 36
[INFO] [stderr]     --> src/lib.rs:1503:5
[INFO] [stderr]      |
[INFO] [stderr] 1503 | /     fn test_remove_node() {
[INFO] [stderr] 1504 | |         let mut g = Network::new();
[INFO] [stderr] 1505 | |         let i1 = g.add_node(NodeT::Input, ());
[INFO] [stderr] 1506 | |         let h1 = g.add_node(NodeT::Hidden, ());
[INFO] [stderr] ...    |
[INFO] [stderr] 1565 | |         assert_eq!(0, g.node_count());
[INFO] [stderr] 1566 | |     }
[INFO] [stderr]      | |_____^
[INFO] [stderr]      |
[INFO] [stderr]      = help: you could split it up into multiple smaller functions
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity
[INFO] [stderr] 
[INFO] [stderr] error: calls to `std::mem::drop` with a value that implements Copy. Dropping a copy leaves the original intact.
[INFO] [stderr]     --> src/lib.rs:1529:9
[INFO] [stderr]      |
[INFO] [stderr] 1529 |         drop(i1);
[INFO] [stderr]      |         ^^^^^^^^
[INFO] [stderr]      |
[INFO] [stderr]      = note: #[deny(clippy::drop_copy)] on by default
[INFO] [stderr] note: argument has type NodeIndex
[INFO] [stderr]     --> src/lib.rs:1529:14
[INFO] [stderr]      |
[INFO] [stderr] 1529 |         drop(i1);
[INFO] [stderr]      |              ^^
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#drop_copy
[INFO] [stderr] 
[INFO] [stderr] error: calls to `std::mem::drop` with a value that implements Copy. Dropping a copy leaves the original intact.
[INFO] [stderr]     --> src/lib.rs:1543:9
[INFO] [stderr]      |
[INFO] [stderr] 1543 |         drop(h2);
[INFO] [stderr]      |         ^^^^^^^^
[INFO] [stderr]      |
[INFO] [stderr] note: argument has type NodeIndex
[INFO] [stderr]     --> src/lib.rs:1543:14
[INFO] [stderr]      |
[INFO] [stderr] 1543 |         drop(h2);
[INFO] [stderr]      |              ^^
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#drop_copy
[INFO] [stderr] 
[INFO] [stderr] error: calls to `std::mem::drop` with a value that implements Copy. Dropping a copy leaves the original intact.
[INFO] [stderr]     --> src/lib.rs:1555:9
[INFO] [stderr]      |
[INFO] [stderr] 1555 |         drop(o1);
[INFO] [stderr]      |         ^^^^^^^^
[INFO] [stderr]      |
[INFO] [stderr] note: argument has type NodeIndex
[INFO] [stderr]     --> src/lib.rs:1555:14
[INFO] [stderr]      |
[INFO] [stderr] 1555 |         drop(o1);
[INFO] [stderr]      |              ^^
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#drop_copy
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to 3 previous errors
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `acyclic-network`.
[INFO] [stderr] 
[INFO] [stderr] To learn more, run the command again with --verbose.
[INFO] running `"docker" "inspect" "13e406ad6fcde7c3b49908b96f0fb9ffb76935fad684962ccc2c75fa883dbd3a"`
[INFO] running `"docker" "rm" "-f" "13e406ad6fcde7c3b49908b96f0fb9ffb76935fad684962ccc2c75fa883dbd3a"`
[INFO] [stdout] 13e406ad6fcde7c3b49908b96f0fb9ffb76935fad684962ccc2c75fa883dbd3a