[INFO] crate actress 0.1.0 is already in cache [INFO] extracting crate actress 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/actress/0.1.0 [INFO] extracting crate actress 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/actress/0.1.0 [INFO] validating manifest of actress-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of actress-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing actress-0.1.0 [INFO] finished frobbing actress-0.1.0 [INFO] frobbed toml for actress-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/actress/0.1.0/Cargo.toml [INFO] started frobbing actress-0.1.0 [INFO] finished frobbing actress-0.1.0 [INFO] frobbed toml for actress-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/actress/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting actress-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/actress/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 13a5cb93f6e988f0b7fb4b66377e51d44fad1e201f963ce3686af8a223f22852 [INFO] running `"docker" "start" "-a" "13a5cb93f6e988f0b7fb4b66377e51d44fad1e201f963ce3686af8a223f22852"` [INFO] [stderr] Checking actress v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/lib.rs:54:9 [INFO] [stderr] | [INFO] [stderr] 54 | / loop { [INFO] [stderr] 55 | | match rx.recv() { [INFO] [stderr] 56 | | Ok(result) => if contained.recv(result) == true { break }, [INFO] [stderr] 57 | | Err(_) => break [INFO] [stderr] 58 | | } [INFO] [stderr] 59 | | } [INFO] [stderr] | |_________^ help: try: `while let Ok(result) = rx.recv() { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/lib.rs:56:34 [INFO] [stderr] | [INFO] [stderr] 56 | Ok(result) => if contained.recv(result) == true { break }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `contained.recv(result)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/lib.rs:54:9 [INFO] [stderr] | [INFO] [stderr] 54 | / loop { [INFO] [stderr] 55 | | match rx.recv() { [INFO] [stderr] 56 | | Ok(result) => if contained.recv(result) == true { break }, [INFO] [stderr] 57 | | Err(_) => break [INFO] [stderr] 58 | | } [INFO] [stderr] 59 | | } [INFO] [stderr] | |_________^ help: try: `while let Ok(result) = rx.recv() { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/lib.rs:56:34 [INFO] [stderr] | [INFO] [stderr] 56 | Ok(result) => if contained.recv(result) == true { break }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `contained.recv(result)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.90s [INFO] running `"docker" "inspect" "13a5cb93f6e988f0b7fb4b66377e51d44fad1e201f963ce3686af8a223f22852"` [INFO] running `"docker" "rm" "-f" "13a5cb93f6e988f0b7fb4b66377e51d44fad1e201f963ce3686af8a223f22852"` [INFO] [stdout] 13a5cb93f6e988f0b7fb4b66377e51d44fad1e201f963ce3686af8a223f22852