[INFO] crate actox 0.1.5 is already in cache [INFO] extracting crate actox 0.1.5 into work/ex/clippy-test-run/sources/stable/reg/actox/0.1.5 [INFO] extracting crate actox 0.1.5 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/actox/0.1.5 [INFO] validating manifest of actox-0.1.5 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of actox-0.1.5 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing actox-0.1.5 [INFO] finished frobbing actox-0.1.5 [INFO] frobbed toml for actox-0.1.5 written to work/ex/clippy-test-run/sources/stable/reg/actox/0.1.5/Cargo.toml [INFO] started frobbing actox-0.1.5 [INFO] finished frobbing actox-0.1.5 [INFO] frobbed toml for actox-0.1.5 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/actox/0.1.5/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting actox-0.1.5 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/actox/0.1.5:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f075b5e0af8b2cc3af2ee790adbdcab2b52c261c0d4180eff4e971480c51578c [INFO] running `"docker" "start" "-a" "f075b5e0af8b2cc3af2ee790adbdcab2b52c261c0d4180eff4e971480c51578c"` [INFO] [stderr] Checking etrace v1.1.1 [INFO] [stderr] Checking actox v0.1.5 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:37:3 [INFO] [stderr] | [INFO] [stderr] 37 | return error.kind [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `error.kind` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:37:3 [INFO] [stderr] | [INFO] [stderr] 37 | return error.kind [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `error.kind` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `event_loop::EventLoop` [INFO] [stderr] --> src/event_loop.rs:54:2 [INFO] [stderr] | [INFO] [stderr] 54 | pub fn new() -> Self { [INFO] [stderr] | _____^ [INFO] [stderr] 55 | | Self{ blocking: Vec::new(), polling: VecDeque::new() } [INFO] [stderr] 56 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 48 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unused label `'event_loop` [INFO] [stderr] --> src/event_loop.rs:96:3 [INFO] [stderr] | [INFO] [stderr] 96 | 'event_loop: loop { [INFO] [stderr] | _________^ [INFO] [stderr] 97 | | // Receive event from aggregator and handle event [INFO] [stderr] 98 | | let event: Option> = ok_or!(aggregator.recv(), return Ok(handler)); [INFO] [stderr] 99 | | if let Some(e) = event { handler.handle_event(e)?; } [INFO] [stderr] 100 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_label)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/actor_pool.rs:47:3 [INFO] [stderr] | [INFO] [stderr] 47 | pool.keys().map(|key| key.clone()).collect() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `pool.keys().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/actor_pool.rs:66:6 [INFO] [stderr] | [INFO] [stderr] 66 | Ok(ok_or!(actor.send(message), throw_err!(ActoxError::EndpointNotConnected))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `event_loop::EventLoop` [INFO] [stderr] --> src/event_loop.rs:54:2 [INFO] [stderr] | [INFO] [stderr] 54 | pub fn new() -> Self { [INFO] [stderr] | _____^ [INFO] [stderr] 55 | | Self{ blocking: Vec::new(), polling: VecDeque::new() } [INFO] [stderr] 56 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 48 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unused label `'event_loop` [INFO] [stderr] --> src/event_loop.rs:96:3 [INFO] [stderr] | [INFO] [stderr] 96 | 'event_loop: loop { [INFO] [stderr] | _________^ [INFO] [stderr] 97 | | // Receive event from aggregator and handle event [INFO] [stderr] 98 | | let event: Option> = ok_or!(aggregator.recv(), return Ok(handler)); [INFO] [stderr] 99 | | if let Some(e) = event { handler.handle_event(e)?; } [INFO] [stderr] 100 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_label)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/actor_pool.rs:47:3 [INFO] [stderr] | [INFO] [stderr] 47 | pool.keys().map(|key| key.clone()).collect() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `pool.keys().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/actor_pool.rs:66:6 [INFO] [stderr] | [INFO] [stderr] 66 | Ok(ok_or!(actor.send(message), throw_err!(ActoxError::EndpointNotConnected))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> tests/actor.rs:24:6 [INFO] [stderr] | [INFO] [stderr] 24 | Ok(match event { [INFO] [stderr] | ____________^ [INFO] [stderr] 25 | | Message::Put(num) => self.sum += num, [INFO] [stderr] 26 | | Message::Get(sender) => sender.send(self.sum).unwrap(), [INFO] [stderr] 27 | | }) [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 24 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> tests/event_loop.rs:27:37 [INFO] [stderr] | [INFO] [stderr] 27 | (now.as_secs() * 1_000_000_000) + (now.subsec_nanos() as u64) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(now.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> tests/event_loop.rs:83:8 [INFO] [stderr] | [INFO] [stderr] 83 | .map(|i| TestEventSource::new(i)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `TestEventSource::new` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> tests/event_loop.rs:90:7 [INFO] [stderr] | [INFO] [stderr] 90 | Ok(match event { [INFO] [stderr] | ________________^ [INFO] [stderr] 91 | | Ok(event) => self.0 += event, [INFO] [stderr] 92 | | Err(event) => eprintln!("Source failed with error: {}", event) [INFO] [stderr] 93 | | }) [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 90 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.61s [INFO] running `"docker" "inspect" "f075b5e0af8b2cc3af2ee790adbdcab2b52c261c0d4180eff4e971480c51578c"` [INFO] running `"docker" "rm" "-f" "f075b5e0af8b2cc3af2ee790adbdcab2b52c261c0d4180eff4e971480c51578c"` [INFO] [stdout] f075b5e0af8b2cc3af2ee790adbdcab2b52c261c0d4180eff4e971480c51578c