[INFO] crate acto-rs 0.5.2 is already in cache [INFO] extracting crate acto-rs 0.5.2 into work/ex/clippy-test-run/sources/stable/reg/acto-rs/0.5.2 [INFO] extracting crate acto-rs 0.5.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/acto-rs/0.5.2 [INFO] validating manifest of acto-rs-0.5.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of acto-rs-0.5.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing acto-rs-0.5.2 [INFO] finished frobbing acto-rs-0.5.2 [INFO] frobbed toml for acto-rs-0.5.2 written to work/ex/clippy-test-run/sources/stable/reg/acto-rs/0.5.2/Cargo.toml [INFO] started frobbing acto-rs-0.5.2 [INFO] finished frobbing acto-rs-0.5.2 [INFO] frobbed toml for acto-rs-0.5.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/acto-rs/0.5.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting acto-rs-0.5.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/acto-rs/0.5.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 5326ad86c21f422ac6f4a853307bc06f9fa666526144eee1d24ea8774e77b802 [INFO] running `"docker" "start" "-a" "5326ad86c21f422ac6f4a853307bc06f9fa666526144eee1d24ea8774e77b802"` [INFO] [stderr] warning: An explicit [[bin]] section is specified in Cargo.toml which currently [INFO] [stderr] disables Cargo from automatically inferring other binary targets. [INFO] [stderr] This inference behavior will change in the Rust 2018 edition and the following [INFO] [stderr] files will be included as a binary target: [INFO] [stderr] [INFO] [stderr] * /opt/crater/workdir/src/main.rs [INFO] [stderr] [INFO] [stderr] This is likely to break cargo build or cargo test as these files may not be [INFO] [stderr] ready to be compiled as a binary target today. You can future-proof yourself [INFO] [stderr] and disable this warning by adding `autobins = false` to your [package] [INFO] [stderr] section. You may also move the files to a location where Cargo would not [INFO] [stderr] automatically infer them to be a target, such as in subfolders. [INFO] [stderr] [INFO] [stderr] For more information on this warning you can consult [INFO] [stderr] https://github.com/rust-lang/cargo/issues/5330 [INFO] [stderr] warning: path `/opt/crater/workdir/src/main.rs` was erroneously implicitly accepted for binary `bench`, [INFO] [stderr] please set bin.path in Cargo.toml [INFO] [stderr] Checking acto-rs v0.5.2 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/scheduler/wrap.rs:49:5 [INFO] [stderr] | [INFO] [stderr] 49 | task: task, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `task` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/scheduler/page.rs:195:5 [INFO] [stderr] | [INFO] [stderr] 195 | data: data, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elem/wrap/source_wrap.rs:21:15 [INFO] [stderr] | [INFO] [stderr] 21 | SourceWrap{ name: name, state: state, output_tx: output_tx } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elem/wrap/source_wrap.rs:21:27 [INFO] [stderr] | [INFO] [stderr] 21 | SourceWrap{ name: name, state: state, output_tx: output_tx } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `state` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elem/wrap/source_wrap.rs:21:41 [INFO] [stderr] | [INFO] [stderr] 21 | SourceWrap{ name: name, state: state, output_tx: output_tx } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `output_tx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elem/wrap/filter_wrap.rs:27:15 [INFO] [stderr] | [INFO] [stderr] 27 | FilterWrap{ name: name, state: state, input_rx: input_rx, output_tx: output_tx } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elem/wrap/filter_wrap.rs:27:27 [INFO] [stderr] | [INFO] [stderr] 27 | FilterWrap{ name: name, state: state, input_rx: input_rx, output_tx: output_tx } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `state` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elem/wrap/filter_wrap.rs:27:41 [INFO] [stderr] | [INFO] [stderr] 27 | FilterWrap{ name: name, state: state, input_rx: input_rx, output_tx: output_tx } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `input_rx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elem/wrap/filter_wrap.rs:27:61 [INFO] [stderr] | [INFO] [stderr] 27 | FilterWrap{ name: name, state: state, input_rx: input_rx, output_tx: output_tx } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `output_tx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elem/wrap/ysplit_wrap.rs:35:5 [INFO] [stderr] | [INFO] [stderr] 35 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elem/wrap/ysplit_wrap.rs:36:5 [INFO] [stderr] | [INFO] [stderr] 36 | state: state, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `state` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elem/wrap/ysplit_wrap.rs:37:5 [INFO] [stderr] | [INFO] [stderr] 37 | input_rx: input_rx, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `input_rx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elem/wrap/ysplit_wrap.rs:38:5 [INFO] [stderr] | [INFO] [stderr] 38 | output_a_tx: output_a_tx, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `output_a_tx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elem/wrap/ysplit_wrap.rs:39:5 [INFO] [stderr] | [INFO] [stderr] 39 | output_b_tx: output_b_tx [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `output_b_tx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elem/wrap/ymerge_wrap.rs:36:5 [INFO] [stderr] | [INFO] [stderr] 36 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elem/wrap/ymerge_wrap.rs:37:5 [INFO] [stderr] | [INFO] [stderr] 37 | state: state, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `state` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elem/wrap/ymerge_wrap.rs:38:5 [INFO] [stderr] | [INFO] [stderr] 38 | input_a_rx: input_a_rx, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `input_a_rx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elem/wrap/ymerge_wrap.rs:39:5 [INFO] [stderr] | [INFO] [stderr] 39 | input_b_rx: input_b_rx, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `input_b_rx` [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] | [INFO] [stderr] --> src/scheduler/wrap.rs:49:5 [INFO] [stderr] | [INFO] [stderr] 49 | task: task, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `task` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elem/wrap/ymerge_wrap.rs:40:5 [INFO] [stderr] | [INFO] [stderr] 40 | output_tx: output_tx [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `output_tx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/scheduler/page.rs:195:5 [INFO] [stderr] | [INFO] [stderr] 195 | data: data, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elem/wrap/sink_wrap.rs:21:13 [INFO] [stderr] | [INFO] [stderr] 21 | SinkWrap{ name: name, state: state, input_rx: input_rx } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elem/wrap/sink_wrap.rs:21:25 [INFO] [stderr] | [INFO] [stderr] 21 | SinkWrap{ name: name, state: state, input_rx: input_rx } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `state` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elem/wrap/sink_wrap.rs:21:39 [INFO] [stderr] | [INFO] [stderr] 21 | SinkWrap{ name: name, state: state, input_rx: input_rx } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `input_rx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elem/wrap/scatter_wrap.rs:27:16 [INFO] [stderr] | [INFO] [stderr] 27 | ScatterWrap{ name: name, state: state, input_rx: input_rx, output_tx_vec: output_tx_vec } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elem/wrap/scatter_wrap.rs:27:28 [INFO] [stderr] | [INFO] [stderr] 27 | ScatterWrap{ name: name, state: state, input_rx: input_rx, output_tx_vec: output_tx_vec } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `state` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elem/wrap/scatter_wrap.rs:27:42 [INFO] [stderr] | [INFO] [stderr] 27 | ScatterWrap{ name: name, state: state, input_rx: input_rx, output_tx_vec: output_tx_vec } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `input_rx` [INFO] [stderr] --> src/elem/wrap/source_wrap.rs:21:15 [INFO] [stderr] | [INFO] [stderr] 21 | SourceWrap{ name: name, state: state, output_tx: output_tx } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elem/wrap/scatter_wrap.rs:27:62 [INFO] [stderr] | [INFO] [stderr] 27 | ScatterWrap{ name: name, state: state, input_rx: input_rx, output_tx_vec: output_tx_vec } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `output_tx_vec` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elem/wrap/source_wrap.rs:21:27 [INFO] [stderr] | [INFO] [stderr] 21 | SourceWrap{ name: name, state: state, output_tx: output_tx } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `state` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elem/wrap/gather_wrap.rs:27:15 [INFO] [stderr] | [INFO] [stderr] 27 | GatherWrap{ name: name, state: state, input_rx_vec: input_rx_vec, output_tx: output_tx } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elem/wrap/source_wrap.rs:21:41 [INFO] [stderr] | [INFO] [stderr] 21 | SourceWrap{ name: name, state: state, output_tx: output_tx } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `output_tx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] [INFO] [stderr] --> src/elem/wrap/filter_wrap.rs:27:15 [INFO] [stderr] | [INFO] [stderr] 27 | FilterWrap{ name: name, state: state, input_rx: input_rx, output_tx: output_tx } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elem/wrap/gather_wrap.rs:27:27 [INFO] [stderr] | [INFO] [stderr] 27 | GatherWrap{ name: name, state: state, input_rx_vec: input_rx_vec, output_tx: output_tx } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `state` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elem/wrap/filter_wrap.rs:27:27 [INFO] [stderr] | [INFO] [stderr] 27 | FilterWrap{ name: name, state: state, input_rx: input_rx, output_tx: output_tx } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `state` [INFO] [stderr] | [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elem/wrap/gather_wrap.rs:27:41 [INFO] [stderr] | [INFO] [stderr] 27 | GatherWrap{ name: name, state: state, input_rx_vec: input_rx_vec, output_tx: output_tx } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `input_rx_vec` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elem/wrap/filter_wrap.rs:27:41 [INFO] [stderr] | [INFO] [stderr] 27 | FilterWrap{ name: name, state: state, input_rx: input_rx, output_tx: output_tx } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `input_rx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elem/wrap/filter_wrap.rs:27:61 [INFO] [stderr] | [INFO] [stderr] 27 | FilterWrap{ name: name, state: state, input_rx: input_rx, output_tx: output_tx } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `output_tx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elem/wrap/gather_wrap.rs:27:69 [INFO] [stderr] | [INFO] [stderr] 27 | GatherWrap{ name: name, state: state, input_rx_vec: input_rx_vec, output_tx: output_tx } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `output_tx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elem/wrap/ysplit_wrap.rs:35:5 [INFO] [stderr] | [INFO] [stderr] 35 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elem/wrap/ysplit_wrap.rs:36:5 [INFO] [stderr] | [INFO] [stderr] 36 | state: state, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `state` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elem/wrap/ysplit_wrap.rs:37:5 [INFO] [stderr] | [INFO] [stderr] 37 | input_rx: input_rx, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `input_rx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elem/wrap/ysplit_wrap.rs:38:5 [INFO] [stderr] | [INFO] [stderr] 38 | output_a_tx: output_a_tx, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `output_a_tx` [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sample/measured_pipeline_source.rs:31:7 [INFO] [stderr] | [INFO] [stderr] 31 | spinned: spinned, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `spinned` [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elem/wrap/ysplit_wrap.rs:39:5 [INFO] [stderr] | [INFO] [stderr] 39 | output_b_tx: output_b_tx [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `output_b_tx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sample/measured_pipeline_filter.rs:52:7 [INFO] [stderr] | [INFO] [stderr] 52 | spinned: spinned, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `spinned` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sample/measured_pipeline_sink.rs:58:7 [INFO] [stderr] | [INFO] [stderr] 58 | spinned: spinned, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `spinned` [INFO] [stderr] --> src/elem/wrap/ymerge_wrap.rs:36:5 [INFO] [stderr] | [INFO] [stderr] 36 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elem/wrap/ymerge_wrap.rs:37:5 [INFO] [stderr] | [INFO] [stderr] 37 | state: state, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `state` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elem/wrap/ymerge_wrap.rs:38:5 [INFO] [stderr] | [INFO] [stderr] 38 | input_a_rx: input_a_rx, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `input_a_rx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elem/wrap/ymerge_wrap.rs:39:5 [INFO] [stderr] | [INFO] [stderr] 39 | input_b_rx: input_b_rx, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `input_b_rx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elem/wrap/ymerge_wrap.rs:40:5 [INFO] [stderr] | [INFO] [stderr] 40 | output_tx: output_tx [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `output_tx` [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sample/measured_pipeline.rs:48:7 [INFO] [stderr] | [INFO] [stderr] 48 | sched: sched, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `sched` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sample/measured_pipeline.rs:49:7 [INFO] [stderr] | [INFO] [stderr] 49 | source_id: source_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `source_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elem/wrap/sink_wrap.rs:21:13 [INFO] [stderr] | [INFO] [stderr] 21 | SinkWrap{ name: name, state: state, input_rx: input_rx } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elem/wrap/sink_wrap.rs:21:25 [INFO] [stderr] | [INFO] [stderr] 21 | SinkWrap{ name: name, state: state, input_rx: input_rx } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `state` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elem/wrap/sink_wrap.rs:21:39 [INFO] [stderr] | [INFO] [stderr] 21 | SinkWrap{ name: name, state: state, input_rx: input_rx } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `input_rx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elem/wrap/scatter_wrap.rs:27:16 [INFO] [stderr] | [INFO] [stderr] 27 | ScatterWrap{ name: name, state: state, input_rx: input_rx, output_tx_vec: output_tx_vec } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elem/wrap/scatter_wrap.rs:27:28 [INFO] [stderr] | [INFO] [stderr] 27 | ScatterWrap{ name: name, state: state, input_rx: input_rx, output_tx_vec: output_tx_vec } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `state` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elem/wrap/scatter_wrap.rs:27:42 [INFO] [stderr] | [INFO] [stderr] 27 | ScatterWrap{ name: name, state: state, input_rx: input_rx, output_tx_vec: output_tx_vec } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `input_rx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elem/wrap/scatter_wrap.rs:27:62 [INFO] [stderr] | [INFO] [stderr] 27 | ScatterWrap{ name: name, state: state, input_rx: input_rx, output_tx_vec: output_tx_vec } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `output_tx_vec` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elem/wrap/gather_wrap.rs:27:15 [INFO] [stderr] | [INFO] [stderr] 27 | GatherWrap{ name: name, state: state, input_rx_vec: input_rx_vec, output_tx: output_tx } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elem/wrap/gather_wrap.rs:27:27 [INFO] [stderr] | [INFO] [stderr] 27 | GatherWrap{ name: name, state: state, input_rx_vec: input_rx_vec, output_tx: output_tx } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `state` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elem/wrap/gather_wrap.rs:27:41 [INFO] [stderr] | [INFO] [stderr] 27 | GatherWrap{ name: name, state: state, input_rx_vec: input_rx_vec, output_tx: output_tx } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `input_rx_vec` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elem/wrap/gather_wrap.rs:27:69 [INFO] [stderr] | [INFO] [stderr] 27 | GatherWrap{ name: name, state: state, input_rx_vec: input_rx_vec, output_tx: output_tx } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `output_tx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/scheduler/page.rs:83:28 [INFO] [stderr] | [INFO] [stderr] 83 | let delay_exec : u64 = 0xffffffffffffff << 6; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider: `0x00ff_ffff_ffff_ffff` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: digits grouped inconsistently by underscores [INFO] [stderr] --> src/scheduler/data.rs:220:47 [INFO] [stderr] | [INFO] [stderr] 220 | let diff_us = diff.as_secs() as usize * 1000_000 + diff.subsec_nanos() as usize / 1000; [INFO] [stderr] | ^^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::inconsistent_digit_grouping)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inconsistent_digit_grouping [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/scheduler/page.rs:83:28 [INFO] [stderr] | [INFO] [stderr] 83 | let delay_exec : u64 = 0xffffffffffffff << 6; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider: `0x00ff_ffff_ffff_ffff` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: digits grouped inconsistently by underscores [INFO] [stderr] --> src/scheduler/data.rs:220:47 [INFO] [stderr] | [INFO] [stderr] 220 | let diff_us = diff.as_secs() as usize * 1000_000 + diff.subsec_nanos() as usize / 1000; [INFO] [stderr] | ^^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::inconsistent_digit_grouping)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inconsistent_digit_grouping [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bench/ext_pipeline_latency.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | latency(100000,20*i); [INFO] [stderr] | ^^^^^^ help: consider: `100_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bench/ext_pipeline_latency.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | latency(5000000,20*i); [INFO] [stderr] | ^^^^^^^ help: consider: `5_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: digits grouped inconsistently by underscores [INFO] [stderr] --> src/bench/mod.rs:39:32 [INFO] [stderr] | [INFO] [stderr] 39 | diff_ns = diff.as_secs() * 1000_000_000 + diff.subsec_nanos() as u64; [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `1_000_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inconsistent_digit_grouping [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/scheduler/wrap.rs:19:11 [INFO] [stderr] | [INFO] [stderr] 19 | let mut slice = self.output_positions.as_mut_slice(); [INFO] [stderr] | ----^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/scheduler/wrap.rs:35:9 [INFO] [stderr] | [INFO] [stderr] 35 | let mut slice = self.output_positions.as_mut_slice(); [INFO] [stderr] | ----^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/scheduler/page.rs:51:9 [INFO] [stderr] | [INFO] [stderr] 51 | let mut data_ref = &mut slice[idx]; [INFO] [stderr] | ----^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `slice` [INFO] [stderr] --> src/scheduler/wrap.rs:20:16 [INFO] [stderr] | [INFO] [stderr] 20 | for i in 0..n_outputs { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 20 | for (i, ) in slice.iter_mut().enumerate().take(n_outputs) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/scheduler/page.rs:33:8 [INFO] [stderr] | [INFO] [stderr] 33 | if old.is_null() == false { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!old.is_null()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `slice`. [INFO] [stderr] --> src/scheduler/page.rs:203:14 [INFO] [stderr] | [INFO] [stderr] 203 | for i in 0..(1+max_idx()) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 203 | for in slice.iter_mut().take((1+max_idx())) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/scheduler/page.rs:203:14 [INFO] [stderr] | [INFO] [stderr] 203 | for i in 0..(1+max_idx()) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: use: `0..=max_idx()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/scheduler/page.rs:207:10 [INFO] [stderr] | [INFO] [stderr] 207 | if ptr.is_null() == false { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!ptr.is_null()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/scheduler/data.rs:69:10 [INFO] [stderr] | [INFO] [stderr] 69 | if l1_ptr.is_null() == false { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!l1_ptr.is_null()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/scheduler/data.rs:82:10 [INFO] [stderr] | [INFO] [stderr] 82 | if l1_ptr.is_null() == false { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!l1_ptr.is_null()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/scheduler/data.rs:88:44 [INFO] [stderr] | [INFO] [stderr] 88 | fn allocate_id_for_task(&mut self, task: &Box) -> Result { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `&Task+Send` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::borrowed_box)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/scheduler/data.rs:99:35 [INFO] [stderr] | [INFO] [stderr] 99 | fn resolve_task_id(&self, name: &String) -> Option { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/scheduler/data.rs:115:10 [INFO] [stderr] | [INFO] [stderr] 115 | if l1_ptr.is_null() == false { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!l1_ptr.is_null()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/scheduler/data.rs:142:19 [INFO] [stderr] | [INFO] [stderr] 142 | let ref sender_ch_id = ch_id_sender_name.0; [INFO] [stderr] | ----^^^^^^^^^^^^^^^^------------------------ help: try: `let sender_ch_id = &ch_id_sender_name.0;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/scheduler/data.rs:143:19 [INFO] [stderr] | [INFO] [stderr] 143 | let ref sender_name = ch_id_sender_name.1; [INFO] [stderr] | ----^^^^^^^^^^^^^^^------------------------- help: try: `let sender_name = &ch_id_sender_name.1;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/scheduler/data.rs:157:76 [INFO] [stderr] | [INFO] [stderr] 157 | let dependents = unresolved.entry(sender_name.0.clone()).or_insert(HashMap::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(HashMap::new)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/scheduler/data.rs:158:60 [INFO] [stderr] | [INFO] [stderr] 158 | let channels = dependents.entry(task_id).or_insert(Vec::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Vec::new)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/scheduler/data.rs:187:14 [INFO] [stderr] | [INFO] [stderr] 187 | if l1_ptr.is_null() == false { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!l1_ptr.is_null()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: the loop variable `l1_idx` is only used to index `l1_slice`. [INFO] [stderr] --> src/scheduler/data.rs:248:23 [INFO] [stderr] | [INFO] [stderr] 248 | for l1_idx in 0..l1 { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 248 | for in l1_slice.iter().take(l1) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `l1_idx` is only used to index `l1_slice`. [INFO] [stderr] --> src/scheduler/data.rs:262:23 [INFO] [stderr] | [INFO] [stderr] 262 | for l1_idx in l1..(l1+1) { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 262 | for in l1_slice.iter().skip(l1).take(1) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/scheduler/data.rs:262:23 [INFO] [stderr] | [INFO] [stderr] 262 | for l1_idx in l1..(l1+1) { [INFO] [stderr] | ^^^^^^^^^^ help: use: `l1..=l1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/scheduler/data.rs:293:54 [INFO] [stderr] | [INFO] [stderr] 293 | let diff_ns = diff.as_secs() * 1_000_000_000 + diff.subsec_nanos() as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(diff.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/scheduler/data.rs:300:39 [INFO] [stderr] | [INFO] [stderr] 300 | pub fn schedule_exec(&mut self, id: &TaskId) { [INFO] [stderr] | ^^^^^^^ help: consider passing by value instead: `TaskId` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/scheduler/data.rs:304:10 [INFO] [stderr] | [INFO] [stderr] 304 | if l1_ptr.is_null() == false { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!l1_ptr.is_null()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/scheduler/data.rs:310:32 [INFO] [stderr] | [INFO] [stderr] 310 | pub fn notify(&mut self, id: &TaskId) -> Result<(), Error> { [INFO] [stderr] | ^^^^^^^ help: consider passing by value instead: `TaskId` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/scheduler/data.rs:324:17 [INFO] [stderr] | [INFO] [stderr] 324 | unsafe { Ok((*l1_ptr).schedule_exec(l2)) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 324 | unsafe { Ok(()) } [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `l1_slice`. [INFO] [stderr] --> src/scheduler/data.rs:350:14 [INFO] [stderr] | [INFO] [stderr] 350 | for i in 0..len { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 350 | for in l1_slice.iter_mut().take(len) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/scheduler/data.rs:353:10 [INFO] [stderr] | [INFO] [stderr] 353 | if ptr.is_null() == false { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!ptr.is_null()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `scheduler::Scheduler` [INFO] [stderr] --> src/scheduler/mod.rs:63:3 [INFO] [stderr] | [INFO] [stderr] 63 | / pub fn new() -> Scheduler { [INFO] [stderr] 64 | | Scheduler{ [INFO] [stderr] 65 | | data: handle::new(), [INFO] [stderr] 66 | | threads: Vec::new(), [INFO] [stderr] 67 | | } [INFO] [stderr] 68 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 15 | impl Default for scheduler::Scheduler { [INFO] [stderr] 16 | fn default() -> Self { [INFO] [stderr] 17 | Self::new() [INFO] [stderr] 18 | } [INFO] [stderr] 19 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/scheduler/mod.rs:29:21 [INFO] [stderr] | [INFO] [stderr] 29 | id: &TaskId) [INFO] [stderr] | ^^^^^^^ help: consider passing by value instead: `TaskId` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/elem/source.rs:19:10 [INFO] [stderr] | [INFO] [stderr] 19 | -> (Box>, [INFO] [stderr] | __________^ [INFO] [stderr] 20 | | Box>) [INFO] [stderr] | |________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/elem/filter.rs:25:10 [INFO] [stderr] | [INFO] [stderr] 25 | -> (Box>, [INFO] [stderr] | __________^ [INFO] [stderr] 26 | | Box>) [INFO] [stderr] | |________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/elem/ysplit.rs:32:10 [INFO] [stderr] | [INFO] [stderr] 32 | -> (Box>, [INFO] [stderr] 35 | | Box>, [INFO] [stderr] 36 | | Box>) [INFO] [stderr] | |__________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/elem/ymerge.rs:31:10 [INFO] [stderr] | [INFO] [stderr] 31 | -> (Box>, [INFO] [stderr] 34 | | Box>) [INFO] [stderr] | |________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/elem/scatter.rs:26:10 [INFO] [stderr] | [INFO] [stderr] 26 | -> (Box>, [INFO] [stderr] | __________^ [INFO] [stderr] 27 | | Vec>>) [INFO] [stderr] | |_____________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/elem/gather.rs:26:10 [INFO] [stderr] | [INFO] [stderr] 26 | -> (Box>, [INFO] [stderr] | __________^ [INFO] [stderr] 27 | | Box>) [INFO] [stderr] | |________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/elem/connectable.rs:12:38 [INFO] [stderr] | [INFO] [stderr] 12 | let (channel_id, mut tmp_sender) = match rcv { [INFO] [stderr] | ______________________________________^ [INFO] [stderr] 13 | | &mut ChannelWrapper::ReceiverNotConnected(ref mut receiver_channel_id, ref mut receiver_name) => { [INFO] [stderr] 14 | | match snd { [INFO] [stderr] 15 | | &mut ChannelWrapper::SenderNotConnected(ref mut sender_channel_id, ref mut _receiver, ref mut _sender_name) => { [INFO] [stderr] ... | [INFO] [stderr] 50 | | }, [INFO] [stderr] 51 | | }; [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 12 | let (channel_id, mut tmp_sender) = match *rcv { [INFO] [stderr] 13 | ChannelWrapper::ReceiverNotConnected(ref mut receiver_channel_id, ref mut receiver_name) => { [INFO] [stderr] 14 | match snd { [INFO] [stderr] 15 | &mut ChannelWrapper::SenderNotConnected(ref mut sender_channel_id, ref mut _receiver, ref mut _sender_name) => { [INFO] [stderr] 16 | let channel_id = ChannelId{sender_id: *sender_channel_id, receiver_id: *receiver_channel_id}; [INFO] [stderr] 17 | (channel_id, ChannelWrapper::ConnectedSender::(channel_id.clone(), receiver_name.clone())) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/elem/connectable.rs:14:7 [INFO] [stderr] | [INFO] [stderr] 14 | / match snd { [INFO] [stderr] 15 | | &mut ChannelWrapper::SenderNotConnected(ref mut sender_channel_id, ref mut _receiver, ref mut _sender_name) => { [INFO] [stderr] 16 | | let channel_id = ChannelId{sender_id: *sender_channel_id, receiver_id: *receiver_channel_id}; [INFO] [stderr] 17 | | (channel_id, ChannelWrapper::ConnectedSender::(channel_id.clone(), receiver_name.clone())) [INFO] [stderr] ... | [INFO] [stderr] 33 | | }, [INFO] [stderr] 34 | | } [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 14 | match *snd { [INFO] [stderr] 15 | ChannelWrapper::SenderNotConnected(ref mut sender_channel_id, ref mut _receiver, ref mut _sender_name) => { [INFO] [stderr] 16 | let channel_id = ChannelId{sender_id: *sender_channel_id, receiver_id: *receiver_channel_id}; [INFO] [stderr] 17 | (channel_id, ChannelWrapper::ConnectedSender::(channel_id.clone(), receiver_name.clone())) [INFO] [stderr] 18 | }, [INFO] [stderr] 19 | ChannelWrapper::ReceiverNotConnected(..) => { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/elem/connectable.rs:17:72 [INFO] [stderr] | [INFO] [stderr] 17 | (channel_id, ChannelWrapper::ConnectedSender::(channel_id.clone(), receiver_name.clone())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `channel_id` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/elem/connectable.rs:86:26 [INFO] [stderr] | [INFO] [stderr] 86 | let mut tmp_receiver = match snd { [INFO] [stderr] | __________________________^ [INFO] [stderr] 87 | | &mut ChannelWrapper::ConnectedSender(ref mut channel_id_rcv, ref mut receiver_name) => { [INFO] [stderr] 88 | | match rcv { [INFO] [stderr] 89 | | &mut ChannelWrapper::ConnectedReceiver(ref mut _channel_id_snd, ref mut _receiver, ref mut _sender_name) => { [INFO] [stderr] ... | [INFO] [stderr] 124 | | }, [INFO] [stderr] 125 | | }; [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 86 | let mut tmp_receiver = match *snd { [INFO] [stderr] 87 | ChannelWrapper::ConnectedSender(ref mut channel_id_rcv, ref mut receiver_name) => { [INFO] [stderr] 88 | match rcv { [INFO] [stderr] 89 | &mut ChannelWrapper::ConnectedReceiver(ref mut _channel_id_snd, ref mut _receiver, ref mut _sender_name) => { [INFO] [stderr] 90 | ChannelWrapper::ReceiverNotConnected::(channel_id_rcv.receiver_id,receiver_name.clone()) [INFO] [stderr] 91 | }, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/elem/connectable.rs:88:7 [INFO] [stderr] | [INFO] [stderr] 88 | / match rcv { [INFO] [stderr] 89 | | &mut ChannelWrapper::ConnectedReceiver(ref mut _channel_id_snd, ref mut _receiver, ref mut _sender_name) => { [INFO] [stderr] 90 | | ChannelWrapper::ReceiverNotConnected::(channel_id_rcv.receiver_id,receiver_name.clone()) [INFO] [stderr] 91 | | }, [INFO] [stderr] ... | [INFO] [stderr] 106 | | }, [INFO] [stderr] 107 | | } [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 88 | match *rcv { [INFO] [stderr] 89 | ChannelWrapper::ConnectedReceiver(ref mut _channel_id_snd, ref mut _receiver, ref mut _sender_name) => { [INFO] [stderr] 90 | ChannelWrapper::ReceiverNotConnected::(channel_id_rcv.receiver_id,receiver_name.clone()) [INFO] [stderr] 91 | }, [INFO] [stderr] 92 | ChannelWrapper::ReceiverNotConnected(..) => { [INFO] [stderr] 93 | return Err(ActorError::InvalidChannelState( [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/elem/connectable.rs:158:3 [INFO] [stderr] | [INFO] [stderr] 158 | / match me { [INFO] [stderr] 159 | | &mut ChannelWrapper::ReceiverNotConnected(..) => { [INFO] [stderr] 160 | | match to { [INFO] [stderr] 161 | | &mut ChannelWrapper::SenderNotConnected(..) => { [INFO] [stderr] ... | [INFO] [stderr] 212 | | }, [INFO] [stderr] 213 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 158 | match *me { [INFO] [stderr] 159 | ChannelWrapper::ReceiverNotConnected(..) => { [INFO] [stderr] 160 | match to { [INFO] [stderr] 161 | &mut ChannelWrapper::SenderNotConnected(..) => { [INFO] [stderr] 162 | connect_receiver_to_sender(me, to) [INFO] [stderr] 163 | }, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/elem/connectable.rs:160:7 [INFO] [stderr] | [INFO] [stderr] 160 | / match to { [INFO] [stderr] 161 | | &mut ChannelWrapper::SenderNotConnected(..) => { [INFO] [stderr] 162 | | connect_receiver_to_sender(me, to) [INFO] [stderr] 163 | | }, [INFO] [stderr] ... | [INFO] [stderr] 178 | | } [INFO] [stderr] 179 | | } [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 160 | match *to { [INFO] [stderr] 161 | ChannelWrapper::SenderNotConnected(..) => { [INFO] [stderr] 162 | connect_receiver_to_sender(me, to) [INFO] [stderr] 163 | }, [INFO] [stderr] 164 | ChannelWrapper::ConnectedSender(..) => { [INFO] [stderr] 165 | Err(ActorError::InvalidChannelState( [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/elem/connectable.rs:187:7 [INFO] [stderr] | [INFO] [stderr] 187 | / match to { [INFO] [stderr] 188 | | &mut ChannelWrapper::ReceiverNotConnected(..) => { [INFO] [stderr] 189 | | connect_receiver_to_sender(to, me) [INFO] [stderr] 190 | | }, [INFO] [stderr] ... | [INFO] [stderr] 205 | | } [INFO] [stderr] 206 | | } [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 187 | match *to { [INFO] [stderr] 188 | ChannelWrapper::ReceiverNotConnected(..) => { [INFO] [stderr] 189 | connect_receiver_to_sender(to, me) [INFO] [stderr] 190 | }, [INFO] [stderr] 191 | ChannelWrapper::ConnectedSender(..) => { [INFO] [stderr] 192 | Err(ActorError::InvalidChannelState( [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/elem/connectable.rs:220:3 [INFO] [stderr] | [INFO] [stderr] 220 | / match me { [INFO] [stderr] 221 | | &mut ChannelWrapper::ConnectedReceiver(..) => { [INFO] [stderr] 222 | | match from { [INFO] [stderr] 223 | | &mut ChannelWrapper::ConnectedSender(..) => { [INFO] [stderr] ... | [INFO] [stderr] 274 | | }, [INFO] [stderr] 275 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 220 | match *me { [INFO] [stderr] 221 | ChannelWrapper::ConnectedReceiver(..) => { [INFO] [stderr] 222 | match from { [INFO] [stderr] 223 | &mut ChannelWrapper::ConnectedSender(..) => { [INFO] [stderr] 224 | disconnect_receiver_from_sender(me, from) [INFO] [stderr] 225 | }, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/elem/connectable.rs:222:7 [INFO] [stderr] | [INFO] [stderr] 222 | / match from { [INFO] [stderr] 223 | | &mut ChannelWrapper::ConnectedSender(..) => { [INFO] [stderr] 224 | | disconnect_receiver_from_sender(me, from) [INFO] [stderr] 225 | | }, [INFO] [stderr] ... | [INFO] [stderr] 240 | | } [INFO] [stderr] 241 | | } [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 222 | match *from { [INFO] [stderr] 223 | ChannelWrapper::ConnectedSender(..) => { [INFO] [stderr] 224 | disconnect_receiver_from_sender(me, from) [INFO] [stderr] 225 | }, [INFO] [stderr] 226 | ChannelWrapper::ConnectedReceiver(..) => { [INFO] [stderr] 227 | Err(ActorError::InvalidChannelState( [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/elem/connectable.rs:244:7 [INFO] [stderr] | [INFO] [stderr] 244 | / match from { [INFO] [stderr] 245 | | &mut ChannelWrapper::ConnectedReceiver(..) => { [INFO] [stderr] 246 | | disconnect_receiver_from_sender(from, me) [INFO] [stderr] 247 | | }, [INFO] [stderr] ... | [INFO] [stderr] 262 | | } [INFO] [stderr] 263 | | } [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 244 | match *from { [INFO] [stderr] 245 | ChannelWrapper::ConnectedReceiver(..) => { [INFO] [stderr] 246 | disconnect_receiver_from_sender(from, me) [INFO] [stderr] 247 | }, [INFO] [stderr] 248 | ChannelWrapper::ReceiverNotConnected(..) => { [INFO] [stderr] 249 | Err(ActorError::InvalidChannelState( [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/elem/wrap/filter_wrap.rs:35:7 [INFO] [stderr] | [INFO] [stderr] 35 | / match &self.input_rx { [INFO] [stderr] 36 | | &ChannelWrapper::ConnectedReceiver(ref channel_id, ref _receiver, ref sender_name) => { [INFO] [stderr] 37 | | Some((*channel_id, sender_name.clone())) [INFO] [stderr] 38 | | }, [INFO] [stderr] 39 | | _ => None, [INFO] [stderr] 40 | | } [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 35 | match self.input_rx { [INFO] [stderr] 36 | ChannelWrapper::ConnectedReceiver(ref channel_id, ref _receiver, ref sender_name) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/elem/wrap/filter_wrap.rs:52:7 [INFO] [stderr] | [INFO] [stderr] 52 | / if let &ChannelWrapper::ConnectedReceiver(ref _channel_id, ref receiver, ref _sender_name) = &self.input_rx { [INFO] [stderr] 53 | | receiver.seqno() [INFO] [stderr] 54 | | } else { [INFO] [stderr] 55 | | 0 [INFO] [stderr] 56 | | } [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 52 | if let ChannelWrapper::ConnectedReceiver(ref _channel_id, ref receiver, ref _sender_name) = self.input_rx { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/elem/wrap/ysplit_wrap.rs:54:7 [INFO] [stderr] | [INFO] [stderr] 54 | / match &self.input_rx { [INFO] [stderr] 55 | | &ChannelWrapper::ConnectedReceiver(ref channel_id, ref _receiver, ref sender_name) => { [INFO] [stderr] 56 | | Some((*channel_id, sender_name.clone())) [INFO] [stderr] 57 | | }, [INFO] [stderr] 58 | | _ => None, [INFO] [stderr] 59 | | } [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 54 | match self.input_rx { [INFO] [stderr] 55 | ChannelWrapper::ConnectedReceiver(ref channel_id, ref _receiver, ref sender_name) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/elem/wrap/ysplit_wrap.rs:73:7 [INFO] [stderr] | [INFO] [stderr] 73 | / if let &ChannelWrapper::ConnectedReceiver(ref _channel_id, ref receiver, ref _sender_name) = &self.input_rx { [INFO] [stderr] 74 | | receiver.seqno() [INFO] [stderr] 75 | | } else { [INFO] [stderr] 76 | | 0 [INFO] [stderr] 77 | | } [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 73 | if let ChannelWrapper::ConnectedReceiver(ref _channel_id, ref receiver, ref _sender_name) = self.input_rx { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/elem/wrap/ymerge_wrap.rs:55:7 [INFO] [stderr] | [INFO] [stderr] 55 | / match &self.input_a_rx { [INFO] [stderr] 56 | | &ChannelWrapper::ConnectedReceiver(ref channel_id, ref _receiver, ref sender_name) => { [INFO] [stderr] 57 | | Some((*channel_id, sender_name.clone())) [INFO] [stderr] 58 | | }, [INFO] [stderr] 59 | | _ => None [INFO] [stderr] 60 | | } [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 55 | match self.input_a_rx { [INFO] [stderr] 56 | ChannelWrapper::ConnectedReceiver(ref channel_id, ref _receiver, ref sender_name) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/elem/wrap/ymerge_wrap.rs:62:7 [INFO] [stderr] | [INFO] [stderr] 62 | / match &self.input_b_rx { [INFO] [stderr] 63 | | &ChannelWrapper::ConnectedReceiver(ref channel_id, ref _receiver, ref sender_name) => { [INFO] [stderr] 64 | | Some((*channel_id, sender_name.clone())) [INFO] [stderr] 65 | | }, [INFO] [stderr] 66 | | _ => None [INFO] [stderr] 67 | | } [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 62 | match self.input_b_rx { [INFO] [stderr] 63 | ChannelWrapper::ConnectedReceiver(ref channel_id, ref _receiver, ref sender_name) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/elem/wrap/ymerge_wrap.rs:81:7 [INFO] [stderr] | [INFO] [stderr] 81 | / match &self.input_a_rx { [INFO] [stderr] 82 | | &ChannelWrapper::ConnectedReceiver(ref _channel_id, ref receiver, ref _sender_name) => { [INFO] [stderr] 83 | | receiver.seqno() [INFO] [stderr] 84 | | }, [INFO] [stderr] 85 | | _ => 0 [INFO] [stderr] 86 | | } [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 81 | match self.input_a_rx { [INFO] [stderr] 82 | ChannelWrapper::ConnectedReceiver(ref _channel_id, ref receiver, ref _sender_name) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/elem/wrap/ymerge_wrap.rs:88:7 [INFO] [stderr] | [INFO] [stderr] 88 | / match &self.input_b_rx { [INFO] [stderr] 89 | | &ChannelWrapper::ConnectedReceiver(ref _channel_id, ref receiver, ref _sender_name) => { [INFO] [stderr] 90 | | receiver.seqno() [INFO] [stderr] 91 | | }, [INFO] [stderr] 92 | | _ => 0 [INFO] [stderr] 93 | | } [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 88 | match self.input_b_rx { [INFO] [stderr] 89 | ChannelWrapper::ConnectedReceiver(ref _channel_id, ref receiver, ref _sender_name) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/elem/wrap/sink_wrap.rs:32:7 [INFO] [stderr] | [INFO] [stderr] 32 | / match &self.input_rx { [INFO] [stderr] 33 | | &ChannelWrapper::ConnectedReceiver(ref channel_id, ref _receiver, ref sender_name) => { [INFO] [stderr] 34 | | Some((*channel_id, sender_name.clone())) [INFO] [stderr] 35 | | }, [INFO] [stderr] 36 | | _ => None, [INFO] [stderr] 37 | | } [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 32 | match self.input_rx { [INFO] [stderr] 33 | ChannelWrapper::ConnectedReceiver(ref channel_id, ref _receiver, ref sender_name) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/elem/wrap/sink_wrap.rs:47:7 [INFO] [stderr] | [INFO] [stderr] 47 | / if let &ChannelWrapper::ConnectedReceiver(ref _channel_id, ref receiver, ref _sender_name) = &self.input_rx { [INFO] [stderr] 48 | | receiver.seqno() [INFO] [stderr] 49 | | } else { [INFO] [stderr] 50 | | 0 [INFO] [stderr] 51 | | } [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 47 | if let ChannelWrapper::ConnectedReceiver(ref _channel_id, ref receiver, ref _sender_name) = self.input_rx { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/elem/wrap/scatter_wrap.rs:37:7 [INFO] [stderr] | [INFO] [stderr] 37 | / match &self.input_rx { [INFO] [stderr] 38 | | &ChannelWrapper::ConnectedReceiver(ref channel_id, ref _receiver, ref sender_name) => { [INFO] [stderr] 39 | | Some((*channel_id, sender_name.clone())) [INFO] [stderr] 40 | | }, [INFO] [stderr] 41 | | _ => None, [INFO] [stderr] 42 | | } [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 37 | match self.input_rx { [INFO] [stderr] 38 | ChannelWrapper::ConnectedReceiver(ref channel_id, ref _receiver, ref sender_name) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/elem/wrap/scatter_wrap.rs:52:7 [INFO] [stderr] | [INFO] [stderr] 52 | / if let &ChannelWrapper::ConnectedReceiver(ref _channel_id, ref receiver, ref _sender_name) = &self.input_rx { [INFO] [stderr] 53 | | receiver.seqno() [INFO] [stderr] 54 | | } else { [INFO] [stderr] 55 | | 0 [INFO] [stderr] 56 | | } [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 52 | if let ChannelWrapper::ConnectedReceiver(ref _channel_id, ref receiver, ref _sender_name) = self.input_rx { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/elem/wrap/gather_wrap.rs:36:7 [INFO] [stderr] | [INFO] [stderr] 36 | / match &slice[ch_id.0] { [INFO] [stderr] 37 | | &ChannelWrapper::ConnectedReceiver(ref channel_id, ref _receiver, ref sender_name) => { [INFO] [stderr] 38 | | Some((*channel_id, sender_name.clone())) [INFO] [stderr] 39 | | }, [INFO] [stderr] 40 | | _ => None, [INFO] [stderr] 41 | | } [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 36 | match slice[ch_id.0] { [INFO] [stderr] 37 | ChannelWrapper::ConnectedReceiver(ref channel_id, ref _receiver, ref sender_name) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/elem/wrap/gather_wrap.rs:54:7 [INFO] [stderr] | [INFO] [stderr] 54 | / match &slice[ch_id.0] { [INFO] [stderr] 55 | | &ChannelWrapper::ConnectedReceiver(ref _channel_id, ref receiver, ref _sender_name) => { [INFO] [stderr] 56 | | receiver.seqno() [INFO] [stderr] 57 | | }, [INFO] [stderr] 58 | | _ => 0, [INFO] [stderr] 59 | | } [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 54 | match slice[ch_id.0] { [INFO] [stderr] 55 | ChannelWrapper::ConnectedReceiver(ref _channel_id, ref receiver, ref _sender_name) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/scheduler/wrap.rs:19:11 [INFO] [stderr] | [INFO] [stderr] 19 | let mut slice = self.output_positions.as_mut_slice(); [INFO] [stderr] | ----^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/scheduler/wrap.rs:35:9 [INFO] [stderr] | [INFO] [stderr] 35 | let mut slice = self.output_positions.as_mut_slice(); [INFO] [stderr] | ----^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/scheduler/page.rs:51:9 [INFO] [stderr] | [INFO] [stderr] 51 | let mut data_ref = &mut slice[idx]; [INFO] [stderr] | ----^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/bench/bitset.rs:19:9 [INFO] [stderr] | [INFO] [stderr] 19 | let mut slice = self.bits.as_mut_slice(); [INFO] [stderr] | ----^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `slice` [INFO] [stderr] --> src/scheduler/wrap.rs:20:16 [INFO] [stderr] | [INFO] [stderr] 20 | for i in 0..n_outputs { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 20 | for (i, ) in slice.iter_mut().enumerate().take(n_outputs) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/scheduler/page.rs:33:8 [INFO] [stderr] | [INFO] [stderr] 33 | if old.is_null() == false { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!old.is_null()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `slice`. [INFO] [stderr] --> src/scheduler/page.rs:203:14 [INFO] [stderr] | [INFO] [stderr] 203 | for i in 0..(1+max_idx()) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 203 | for in slice.iter_mut().take((1+max_idx())) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/scheduler/page.rs:203:14 [INFO] [stderr] | [INFO] [stderr] 203 | for i in 0..(1+max_idx()) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: use: `0..=max_idx()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/scheduler/page.rs:207:10 [INFO] [stderr] | [INFO] [stderr] 207 | if ptr.is_null() == false { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!ptr.is_null()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/scheduler/data.rs:69:10 [INFO] [stderr] | [INFO] [stderr] 69 | if l1_ptr.is_null() == false { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!l1_ptr.is_null()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/scheduler/data.rs:82:10 [INFO] [stderr] | [INFO] [stderr] 82 | if l1_ptr.is_null() == false { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!l1_ptr.is_null()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/scheduler/data.rs:88:44 [INFO] [stderr] | [INFO] [stderr] 88 | fn allocate_id_for_task(&mut self, task: &Box) -> Result { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `&Task+Send` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::borrowed_box)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/scheduler/data.rs:99:35 [INFO] [stderr] | [INFO] [stderr] 99 | fn resolve_task_id(&self, name: &String) -> Option { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/scheduler/data.rs:115:10 [INFO] [stderr] | [INFO] [stderr] 115 | if l1_ptr.is_null() == false { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!l1_ptr.is_null()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/scheduler/data.rs:142:19 [INFO] [stderr] | [INFO] [stderr] 142 | let ref sender_ch_id = ch_id_sender_name.0; [INFO] [stderr] | ----^^^^^^^^^^^^^^^^------------------------ help: try: `let sender_ch_id = &ch_id_sender_name.0;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/scheduler/data.rs:143:19 [INFO] [stderr] | [INFO] [stderr] 143 | let ref sender_name = ch_id_sender_name.1; [INFO] [stderr] | ----^^^^^^^^^^^^^^^------------------------- help: try: `let sender_name = &ch_id_sender_name.1;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/scheduler/data.rs:157:76 [INFO] [stderr] | [INFO] [stderr] 157 | let dependents = unresolved.entry(sender_name.0.clone()).or_insert(HashMap::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(HashMap::new)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/scheduler/data.rs:158:60 [INFO] [stderr] | [INFO] [stderr] 158 | let channels = dependents.entry(task_id).or_insert(Vec::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Vec::new)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/scheduler/data.rs:187:14 [INFO] [stderr] | [INFO] [stderr] 187 | if l1_ptr.is_null() == false { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!l1_ptr.is_null()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: the loop variable `l1_idx` is only used to index `l1_slice`. [INFO] [stderr] --> src/scheduler/data.rs:248:23 [INFO] [stderr] | [INFO] [stderr] 248 | for l1_idx in 0..l1 { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 248 | for in l1_slice.iter().take(l1) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `l1_idx` is only used to index `l1_slice`. [INFO] [stderr] --> src/scheduler/data.rs:262:23 [INFO] [stderr] | [INFO] [stderr] 262 | for l1_idx in l1..(l1+1) { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 262 | for in l1_slice.iter().skip(l1).take(1) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/scheduler/data.rs:262:23 [INFO] [stderr] | [INFO] [stderr] 262 | for l1_idx in l1..(l1+1) { [INFO] [stderr] | ^^^^^^^^^^ help: use: `l1..=l1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/scheduler/data.rs:293:54 [INFO] [stderr] | [INFO] [stderr] 293 | let diff_ns = diff.as_secs() * 1_000_000_000 + diff.subsec_nanos() as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(diff.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/scheduler/data.rs:300:39 [INFO] [stderr] | [INFO] [stderr] 300 | pub fn schedule_exec(&mut self, id: &TaskId) { [INFO] [stderr] | ^^^^^^^ help: consider passing by value instead: `TaskId` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/scheduler/data.rs:304:10 [INFO] [stderr] | [INFO] [stderr] 304 | if l1_ptr.is_null() == false { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!l1_ptr.is_null()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/scheduler/data.rs:310:32 [INFO] [stderr] | [INFO] [stderr] 310 | pub fn notify(&mut self, id: &TaskId) -> Result<(), Error> { [INFO] [stderr] | ^^^^^^^ help: consider passing by value instead: `TaskId` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/scheduler/data.rs:324:17 [INFO] [stderr] | [INFO] [stderr] 324 | unsafe { Ok((*l1_ptr).schedule_exec(l2)) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 324 | unsafe { Ok(()) } [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `l1_slice`. [INFO] [stderr] --> src/scheduler/data.rs:350:14 [INFO] [stderr] | [INFO] [stderr] 350 | for i in 0..len { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 350 | for in l1_slice.iter_mut().take(len) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/scheduler/data.rs:353:10 [INFO] [stderr] | [INFO] [stderr] 353 | if ptr.is_null() == false { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!ptr.is_null()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `scheduler::Scheduler` [INFO] [stderr] --> src/scheduler/mod.rs:63:3 [INFO] [stderr] | [INFO] [stderr] 63 | / pub fn new() -> Scheduler { [INFO] [stderr] 64 | | Scheduler{ [INFO] [stderr] 65 | | data: handle::new(), [INFO] [stderr] 66 | | threads: Vec::new(), [INFO] [stderr] 67 | | } [INFO] [stderr] 68 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 15 | impl Default for scheduler::Scheduler { [INFO] [stderr] 16 | fn default() -> Self { [INFO] [stderr] 17 | Self::new() [INFO] [stderr] 18 | } [INFO] [stderr] 19 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/scheduler/mod.rs:29:21 [INFO] [stderr] | [INFO] [stderr] 29 | id: &TaskId) [INFO] [stderr] | ^^^^^^^ help: consider passing by value instead: `TaskId` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/elem/source.rs:19:10 [INFO] [stderr] | [INFO] [stderr] 19 | -> (Box>, [INFO] [stderr] | __________^ [INFO] [stderr] 20 | | Box>) [INFO] [stderr] | |________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/elem/filter.rs:25:10 [INFO] [stderr] | [INFO] [stderr] 25 | -> (Box>, [INFO] [stderr] | __________^ [INFO] [stderr] 26 | | Box>) [INFO] [stderr] | |________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/elem/ysplit.rs:32:10 [INFO] [stderr] | [INFO] [stderr] 32 | -> (Box>, [INFO] [stderr] 35 | | Box>, [INFO] [stderr] 36 | | Box>) [INFO] [stderr] | |__________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/elem/ymerge.rs:31:10 [INFO] [stderr] | [INFO] [stderr] 31 | -> (Box>, [INFO] [stderr] 34 | | Box>) [INFO] [stderr] | |________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/elem/scatter.rs:26:10 [INFO] [stderr] | [INFO] [stderr] 26 | -> (Box>, [INFO] [stderr] | __________^ [INFO] [stderr] 27 | | Vec>>) [INFO] [stderr] | |_____________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/elem/gather.rs:26:10 [INFO] [stderr] | [INFO] [stderr] 26 | -> (Box>, [INFO] [stderr] | __________^ [INFO] [stderr] 27 | | Box>) [INFO] [stderr] | |________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/elem/connectable.rs:12:38 [INFO] [stderr] | [INFO] [stderr] 12 | let (channel_id, mut tmp_sender) = match rcv { [INFO] [stderr] | ______________________________________^ [INFO] [stderr] 13 | | &mut ChannelWrapper::ReceiverNotConnected(ref mut receiver_channel_id, ref mut receiver_name) => { [INFO] [stderr] 14 | | match snd { [INFO] [stderr] 15 | | &mut ChannelWrapper::SenderNotConnected(ref mut sender_channel_id, ref mut _receiver, ref mut _sender_name) => { [INFO] [stderr] ... | [INFO] [stderr] 50 | | }, [INFO] [stderr] 51 | | }; [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 12 | let (channel_id, mut tmp_sender) = match *rcv { [INFO] [stderr] 13 | ChannelWrapper::ReceiverNotConnected(ref mut receiver_channel_id, ref mut receiver_name) => { [INFO] [stderr] 14 | match snd { [INFO] [stderr] 15 | &mut ChannelWrapper::SenderNotConnected(ref mut sender_channel_id, ref mut _receiver, ref mut _sender_name) => { [INFO] [stderr] 16 | let channel_id = ChannelId{sender_id: *sender_channel_id, receiver_id: *receiver_channel_id}; [INFO] [stderr] 17 | (channel_id, ChannelWrapper::ConnectedSender::(channel_id.clone(), receiver_name.clone())) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/elem/connectable.rs:14:7 [INFO] [stderr] | [INFO] [stderr] 14 | / match snd { [INFO] [stderr] 15 | | &mut ChannelWrapper::SenderNotConnected(ref mut sender_channel_id, ref mut _receiver, ref mut _sender_name) => { [INFO] [stderr] 16 | | let channel_id = ChannelId{sender_id: *sender_channel_id, receiver_id: *receiver_channel_id}; [INFO] [stderr] 17 | | (channel_id, ChannelWrapper::ConnectedSender::(channel_id.clone(), receiver_name.clone())) [INFO] [stderr] ... | [INFO] [stderr] 33 | | }, [INFO] [stderr] 34 | | } [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 14 | match *snd { [INFO] [stderr] 15 | ChannelWrapper::SenderNotConnected(ref mut sender_channel_id, ref mut _receiver, ref mut _sender_name) => { [INFO] [stderr] 16 | let channel_id = ChannelId{sender_id: *sender_channel_id, receiver_id: *receiver_channel_id}; [INFO] [stderr] 17 | (channel_id, ChannelWrapper::ConnectedSender::(channel_id.clone(), receiver_name.clone())) [INFO] [stderr] 18 | }, [INFO] [stderr] 19 | ChannelWrapper::ReceiverNotConnected(..) => { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/elem/connectable.rs:17:72 [INFO] [stderr] | [INFO] [stderr] 17 | (channel_id, ChannelWrapper::ConnectedSender::(channel_id.clone(), receiver_name.clone())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `channel_id` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/elem/connectable.rs:86:26 [INFO] [stderr] | [INFO] [stderr] 86 | let mut tmp_receiver = match snd { [INFO] [stderr] | __________________________^ [INFO] [stderr] 87 | | &mut ChannelWrapper::ConnectedSender(ref mut channel_id_rcv, ref mut receiver_name) => { [INFO] [stderr] 88 | | match rcv { [INFO] [stderr] 89 | | &mut ChannelWrapper::ConnectedReceiver(ref mut _channel_id_snd, ref mut _receiver, ref mut _sender_name) => { [INFO] [stderr] ... | [INFO] [stderr] 124 | | }, [INFO] [stderr] 125 | | }; [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 86 | let mut tmp_receiver = match *snd { [INFO] [stderr] 87 | ChannelWrapper::ConnectedSender(ref mut channel_id_rcv, ref mut receiver_name) => { [INFO] [stderr] 88 | match rcv { [INFO] [stderr] 89 | &mut ChannelWrapper::ConnectedReceiver(ref mut _channel_id_snd, ref mut _receiver, ref mut _sender_name) => { [INFO] [stderr] 90 | ChannelWrapper::ReceiverNotConnected::(channel_id_rcv.receiver_id,receiver_name.clone()) [INFO] [stderr] 91 | }, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/elem/connectable.rs:88:7 [INFO] [stderr] | [INFO] [stderr] 88 | / match rcv { [INFO] [stderr] 89 | | &mut ChannelWrapper::ConnectedReceiver(ref mut _channel_id_snd, ref mut _receiver, ref mut _sender_name) => { [INFO] [stderr] 90 | | ChannelWrapper::ReceiverNotConnected::(channel_id_rcv.receiver_id,receiver_name.clone()) [INFO] [stderr] 91 | | }, [INFO] [stderr] ... | [INFO] [stderr] 106 | | }, [INFO] [stderr] 107 | | } [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 88 | match *rcv { [INFO] [stderr] 89 | ChannelWrapper::ConnectedReceiver(ref mut _channel_id_snd, ref mut _receiver, ref mut _sender_name) => { [INFO] [stderr] 90 | ChannelWrapper::ReceiverNotConnected::(channel_id_rcv.receiver_id,receiver_name.clone()) [INFO] [stderr] 91 | }, [INFO] [stderr] 92 | ChannelWrapper::ReceiverNotConnected(..) => { [INFO] [stderr] 93 | return Err(ActorError::InvalidChannelState( [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/elem/connectable.rs:158:3 [INFO] [stderr] | [INFO] [stderr] 158 | / match me { [INFO] [stderr] 159 | | &mut ChannelWrapper::ReceiverNotConnected(..) => { [INFO] [stderr] 160 | | match to { [INFO] [stderr] 161 | | &mut ChannelWrapper::SenderNotConnected(..) => { [INFO] [stderr] ... | [INFO] [stderr] 212 | | }, [INFO] [stderr] 213 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 158 | match *me { [INFO] [stderr] 159 | ChannelWrapper::ReceiverNotConnected(..) => { [INFO] [stderr] 160 | match to { [INFO] [stderr] 161 | &mut ChannelWrapper::SenderNotConnected(..) => { [INFO] [stderr] 162 | connect_receiver_to_sender(me, to) [INFO] [stderr] 163 | }, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/elem/connectable.rs:160:7 [INFO] [stderr] | [INFO] [stderr] 160 | / match to { [INFO] [stderr] 161 | | &mut ChannelWrapper::SenderNotConnected(..) => { [INFO] [stderr] 162 | | connect_receiver_to_sender(me, to) [INFO] [stderr] 163 | | }, [INFO] [stderr] ... | [INFO] [stderr] 178 | | } [INFO] [stderr] 179 | | } [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 160 | match *to { [INFO] [stderr] 161 | ChannelWrapper::SenderNotConnected(..) => { [INFO] [stderr] 162 | connect_receiver_to_sender(me, to) [INFO] [stderr] 163 | }, [INFO] [stderr] 164 | ChannelWrapper::ConnectedSender(..) => { [INFO] [stderr] 165 | Err(ActorError::InvalidChannelState( [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/elem/connectable.rs:187:7 [INFO] [stderr] | [INFO] [stderr] 187 | / match to { [INFO] [stderr] 188 | | &mut ChannelWrapper::ReceiverNotConnected(..) => { [INFO] [stderr] 189 | | connect_receiver_to_sender(to, me) [INFO] [stderr] 190 | | }, [INFO] [stderr] ... | [INFO] [stderr] 205 | | } [INFO] [stderr] 206 | | } [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 187 | match *to { [INFO] [stderr] 188 | ChannelWrapper::ReceiverNotConnected(..) => { [INFO] [stderr] 189 | connect_receiver_to_sender(to, me) [INFO] [stderr] 190 | }, [INFO] [stderr] 191 | ChannelWrapper::ConnectedSender(..) => { [INFO] [stderr] 192 | Err(ActorError::InvalidChannelState( [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/elem/connectable.rs:220:3 [INFO] [stderr] | [INFO] [stderr] 220 | / match me { [INFO] [stderr] 221 | | &mut ChannelWrapper::ConnectedReceiver(..) => { [INFO] [stderr] 222 | | match from { [INFO] [stderr] 223 | | &mut ChannelWrapper::ConnectedSender(..) => { [INFO] [stderr] ... | [INFO] [stderr] 274 | | }, [INFO] [stderr] 275 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 220 | match *me { [INFO] [stderr] 221 | ChannelWrapper::ConnectedReceiver(..) => { [INFO] [stderr] 222 | match from { [INFO] [stderr] 223 | &mut ChannelWrapper::ConnectedSender(..) => { [INFO] [stderr] 224 | disconnect_receiver_from_sender(me, from) [INFO] [stderr] 225 | }, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/elem/connectable.rs:222:7 [INFO] [stderr] | [INFO] [stderr] 222 | / match from { [INFO] [stderr] 223 | | &mut ChannelWrapper::ConnectedSender(..) => { [INFO] [stderr] 224 | | disconnect_receiver_from_sender(me, from) [INFO] [stderr] 225 | | }, [INFO] [stderr] ... | [INFO] [stderr] 240 | | } [INFO] [stderr] 241 | | } [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 222 | match *from { [INFO] [stderr] 223 | ChannelWrapper::ConnectedSender(..) => { [INFO] [stderr] 224 | disconnect_receiver_from_sender(me, from) [INFO] [stderr] 225 | }, [INFO] [stderr] 226 | ChannelWrapper::ConnectedReceiver(..) => { [INFO] [stderr] 227 | Err(ActorError::InvalidChannelState( [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/elem/connectable.rs:244:7 [INFO] [stderr] | [INFO] [stderr] 244 | / match from { [INFO] [stderr] 245 | | &mut ChannelWrapper::ConnectedReceiver(..) => { [INFO] [stderr] 246 | | disconnect_receiver_from_sender(from, me) [INFO] [stderr] 247 | | }, [INFO] [stderr] ... | [INFO] [stderr] 262 | | } [INFO] [stderr] 263 | | } [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 244 | match *from { [INFO] [stderr] 245 | ChannelWrapper::ConnectedReceiver(..) => { [INFO] [stderr] 246 | disconnect_receiver_from_sender(from, me) [INFO] [stderr] 247 | }, [INFO] [stderr] 248 | ChannelWrapper::ReceiverNotConnected(..) => { [INFO] [stderr] 249 | Err(ActorError::InvalidChannelState( [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/elem/wrap/filter_wrap.rs:35:7 [INFO] [stderr] | [INFO] [stderr] 35 | / match &self.input_rx { [INFO] [stderr] 36 | | &ChannelWrapper::ConnectedReceiver(ref channel_id, ref _receiver, ref sender_name) => { [INFO] [stderr] 37 | | Some((*channel_id, sender_name.clone())) [INFO] [stderr] 38 | | }, [INFO] [stderr] 39 | | _ => None, [INFO] [stderr] 40 | | } [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 35 | match self.input_rx { [INFO] [stderr] 36 | ChannelWrapper::ConnectedReceiver(ref channel_id, ref _receiver, ref sender_name) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/elem/wrap/filter_wrap.rs:52:7 [INFO] [stderr] | [INFO] [stderr] 52 | / if let &ChannelWrapper::ConnectedReceiver(ref _channel_id, ref receiver, ref _sender_name) = &self.input_rx { [INFO] [stderr] 53 | | receiver.seqno() [INFO] [stderr] 54 | | } else { [INFO] [stderr] 55 | | 0 [INFO] [stderr] 56 | | } [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 52 | if let ChannelWrapper::ConnectedReceiver(ref _channel_id, ref receiver, ref _sender_name) = self.input_rx { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/elem/wrap/ysplit_wrap.rs:54:7 [INFO] [stderr] | [INFO] [stderr] 54 | / match &self.input_rx { [INFO] [stderr] 55 | | &ChannelWrapper::ConnectedReceiver(ref channel_id, ref _receiver, ref sender_name) => { [INFO] [stderr] 56 | | Some((*channel_id, sender_name.clone())) [INFO] [stderr] 57 | | }, [INFO] [stderr] 58 | | _ => None, [INFO] [stderr] 59 | | } [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 54 | match self.input_rx { [INFO] [stderr] 55 | ChannelWrapper::ConnectedReceiver(ref channel_id, ref _receiver, ref sender_name) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/elem/wrap/ysplit_wrap.rs:73:7 [INFO] [stderr] | [INFO] [stderr] 73 | / if let &ChannelWrapper::ConnectedReceiver(ref _channel_id, ref receiver, ref _sender_name) = &self.input_rx { [INFO] [stderr] 74 | | receiver.seqno() [INFO] [stderr] 75 | | } else { [INFO] [stderr] 76 | | 0 [INFO] [stderr] 77 | | } [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 73 | if let ChannelWrapper::ConnectedReceiver(ref _channel_id, ref receiver, ref _sender_name) = self.input_rx { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/elem/wrap/ymerge_wrap.rs:55:7 [INFO] [stderr] | [INFO] [stderr] 55 | / match &self.input_a_rx { [INFO] [stderr] 56 | | &ChannelWrapper::ConnectedReceiver(ref channel_id, ref _receiver, ref sender_name) => { [INFO] [stderr] 57 | | Some((*channel_id, sender_name.clone())) [INFO] [stderr] 58 | | }, [INFO] [stderr] 59 | | _ => None [INFO] [stderr] 60 | | } [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 55 | match self.input_a_rx { [INFO] [stderr] 56 | ChannelWrapper::ConnectedReceiver(ref channel_id, ref _receiver, ref sender_name) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/elem/wrap/ymerge_wrap.rs:62:7 [INFO] [stderr] | [INFO] [stderr] 62 | / match &self.input_b_rx { [INFO] [stderr] 63 | | &ChannelWrapper::ConnectedReceiver(ref channel_id, ref _receiver, ref sender_name) => { [INFO] [stderr] 64 | | Some((*channel_id, sender_name.clone())) [INFO] [stderr] 65 | | }, [INFO] [stderr] 66 | | _ => None [INFO] [stderr] 67 | | } [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 62 | match self.input_b_rx { [INFO] [stderr] 63 | ChannelWrapper::ConnectedReceiver(ref channel_id, ref _receiver, ref sender_name) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/elem/wrap/ymerge_wrap.rs:81:7 [INFO] [stderr] | [INFO] [stderr] 81 | / match &self.input_a_rx { [INFO] [stderr] 82 | | &ChannelWrapper::ConnectedReceiver(ref _channel_id, ref receiver, ref _sender_name) => { [INFO] [stderr] 83 | | receiver.seqno() [INFO] [stderr] 84 | | }, [INFO] [stderr] 85 | | _ => 0 [INFO] [stderr] 86 | | } [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 81 | match self.input_a_rx { [INFO] [stderr] 82 | ChannelWrapper::ConnectedReceiver(ref _channel_id, ref receiver, ref _sender_name) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/elem/wrap/ymerge_wrap.rs:88:7 [INFO] [stderr] | [INFO] [stderr] 88 | / match &self.input_b_rx { [INFO] [stderr] 89 | | &ChannelWrapper::ConnectedReceiver(ref _channel_id, ref receiver, ref _sender_name) => { [INFO] [stderr] 90 | | receiver.seqno() [INFO] [stderr] 91 | | }, [INFO] [stderr] 92 | | _ => 0 [INFO] [stderr] 93 | | } [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 88 | match self.input_b_rx { [INFO] [stderr] 89 | ChannelWrapper::ConnectedReceiver(ref _channel_id, ref receiver, ref _sender_name) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/elem/wrap/sink_wrap.rs:32:7 [INFO] [stderr] | [INFO] [stderr] 32 | / match &self.input_rx { [INFO] [stderr] 33 | | &ChannelWrapper::ConnectedReceiver(ref channel_id, ref _receiver, ref sender_name) => { [INFO] [stderr] 34 | | Some((*channel_id, sender_name.clone())) [INFO] [stderr] 35 | | }, [INFO] [stderr] 36 | | _ => None, [INFO] [stderr] 37 | | } [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 32 | match self.input_rx { [INFO] [stderr] 33 | ChannelWrapper::ConnectedReceiver(ref channel_id, ref _receiver, ref sender_name) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/elem/wrap/sink_wrap.rs:47:7 [INFO] [stderr] | [INFO] [stderr] 47 | / if let &ChannelWrapper::ConnectedReceiver(ref _channel_id, ref receiver, ref _sender_name) = &self.input_rx { [INFO] [stderr] 48 | | receiver.seqno() [INFO] [stderr] 49 | | } else { [INFO] [stderr] 50 | | 0 [INFO] [stderr] 51 | | } [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 47 | if let ChannelWrapper::ConnectedReceiver(ref _channel_id, ref receiver, ref _sender_name) = self.input_rx { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/elem/wrap/scatter_wrap.rs:37:7 [INFO] [stderr] | [INFO] [stderr] 37 | / match &self.input_rx { [INFO] [stderr] 38 | | &ChannelWrapper::ConnectedReceiver(ref channel_id, ref _receiver, ref sender_name) => { [INFO] [stderr] 39 | | Some((*channel_id, sender_name.clone())) [INFO] [stderr] 40 | | }, [INFO] [stderr] 41 | | _ => None, [INFO] [stderr] 42 | | } [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 37 | match self.input_rx { [INFO] [stderr] 38 | ChannelWrapper::ConnectedReceiver(ref channel_id, ref _receiver, ref sender_name) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/elem/wrap/scatter_wrap.rs:52:7 [INFO] [stderr] | [INFO] [stderr] 52 | / if let &ChannelWrapper::ConnectedReceiver(ref _channel_id, ref receiver, ref _sender_name) = &self.input_rx { [INFO] [stderr] 53 | | receiver.seqno() [INFO] [stderr] 54 | | } else { [INFO] [stderr] 55 | | 0 [INFO] [stderr] 56 | | } [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 52 | if let ChannelWrapper::ConnectedReceiver(ref _channel_id, ref receiver, ref _sender_name) = self.input_rx { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/elem/wrap/gather_wrap.rs:36:7 [INFO] [stderr] | [INFO] [stderr] 36 | / match &slice[ch_id.0] { [INFO] [stderr] 37 | | &ChannelWrapper::ConnectedReceiver(ref channel_id, ref _receiver, ref sender_name) => { [INFO] [stderr] 38 | | Some((*channel_id, sender_name.clone())) [INFO] [stderr] 39 | | }, [INFO] [stderr] 40 | | _ => None, [INFO] [stderr] 41 | | } [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 36 | match slice[ch_id.0] { [INFO] [stderr] 37 | ChannelWrapper::ConnectedReceiver(ref channel_id, ref _receiver, ref sender_name) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/elem/wrap/gather_wrap.rs:54:7 [INFO] [stderr] | [INFO] [stderr] 54 | / match &slice[ch_id.0] { [INFO] [stderr] 55 | | &ChannelWrapper::ConnectedReceiver(ref _channel_id, ref receiver, ref _sender_name) => { [INFO] [stderr] 56 | | receiver.seqno() [INFO] [stderr] 57 | | }, [INFO] [stderr] 58 | | _ => 0, [INFO] [stderr] 59 | | } [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 54 | match slice[ch_id.0] { [INFO] [stderr] 55 | ChannelWrapper::ConnectedReceiver(ref _channel_id, ref receiver, ref _sender_name) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `sample::dummy_source::DummySource` [INFO] [stderr] --> src/sample/dummy_source.rs:20:3 [INFO] [stderr] | [INFO] [stderr] 20 | / pub fn new() -> DummySource { [INFO] [stderr] 21 | | DummySource{} [INFO] [stderr] 22 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 6 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/sample/measured_pipeline_filter.rs:29:5 [INFO] [stderr] | [INFO] [stderr] 29 | / if let &mut ChannelWrapper::ConnectedReceiver(ref mut _channel_id, [INFO] [stderr] 30 | | ref mut receiver, [INFO] [stderr] 31 | | ref mut _sender_name) = input { [INFO] [stderr] 32 | | let now = self.spinned.load(Ordering::Acquire); [INFO] [stderr] ... | [INFO] [stderr] 41 | | *stop = true; [INFO] [stderr] 42 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 29 | if let ChannelWrapper::ConnectedReceiver(ref mut _channel_id, [INFO] [stderr] 30 | ref mut receiver, [INFO] [stderr] 31 | ref mut _sender_name) = *input { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/sample/measured_pipeline_sink.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | / if let &mut ChannelWrapper::ConnectedReceiver(ref mut _channel_id, [INFO] [stderr] 29 | | ref mut receiver, [INFO] [stderr] 30 | | ref mut _sender_name) = input { [INFO] [stderr] 31 | | let now = self.spinned.load(Ordering::Acquire); [INFO] [stderr] ... | [INFO] [stderr] 46 | | *stop = true; [INFO] [stderr] 47 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 28 | if let ChannelWrapper::ConnectedReceiver(ref mut _channel_id, [INFO] [stderr] 29 | ref mut receiver, [INFO] [stderr] 30 | ref mut _sender_name) = *input { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `sample::tick::Tick` [INFO] [stderr] --> src/sample/tick.rs:9:3 [INFO] [stderr] | [INFO] [stderr] 9 | / pub fn new() -> Tick { [INFO] [stderr] 10 | | Tick { [INFO] [stderr] 11 | | time: Instant::now(), [INFO] [stderr] 12 | | } [INFO] [stderr] 13 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 8 | impl Default for sample::tick::Tick { [INFO] [stderr] 9 | fn default() -> Self { [INFO] [stderr] 10 | Self::new() [INFO] [stderr] 11 | } [INFO] [stderr] 12 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/sample/tick.rs:17:37 [INFO] [stderr] | [INFO] [stderr] 17 | ela.as_secs() * 1_000_000_000 + ela.subsec_nanos() as u64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(ela.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `bench::spinner::Spinner` [INFO] [stderr] --> src/bench/spinner.rs:13:3 [INFO] [stderr] | [INFO] [stderr] 13 | / pub fn new() -> Spinner { [INFO] [stderr] 14 | | let start = Arc::new(AtomicUsize::new(0)); [INFO] [stderr] 15 | | let stop = Arc::new(AtomicBool::new(false)); [INFO] [stderr] 16 | | Spinner { [INFO] [stderr] ... | [INFO] [stderr] 20 | | } [INFO] [stderr] 21 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 12 | impl Default for bench::spinner::Spinner { [INFO] [stderr] 13 | fn default() -> Self { [INFO] [stderr] 14 | Self::new() [INFO] [stderr] 15 | } [INFO] [stderr] 16 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/bench/spinner.rs:34:10 [INFO] [stderr] | [INFO] [stderr] 34 | if stop.load(Ordering::Acquire) == true { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `stop.load(Ordering::Acquire)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `slice` [INFO] [stderr] --> src/bench/bitset.rs:34:14 [INFO] [stderr] | [INFO] [stderr] 34 | for i in 0..max { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 34 | for (i, ) in slice.iter().enumerate().take(max) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/bench/mod.rs:39:47 [INFO] [stderr] | [INFO] [stderr] 39 | diff_ns = diff.as_secs() * 1000_000_000 + diff.subsec_nanos() as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(diff.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.46s [INFO] running `"docker" "inspect" "5326ad86c21f422ac6f4a853307bc06f9fa666526144eee1d24ea8774e77b802"` [INFO] running `"docker" "rm" "-f" "5326ad86c21f422ac6f4a853307bc06f9fa666526144eee1d24ea8774e77b802"` [INFO] [stdout] 5326ad86c21f422ac6f4a853307bc06f9fa666526144eee1d24ea8774e77b802