[INFO] crate actix-web-sql-identity 0.4.3 is already in cache [INFO] extracting crate actix-web-sql-identity 0.4.3 into work/ex/clippy-test-run/sources/stable/reg/actix-web-sql-identity/0.4.3 [INFO] extracting crate actix-web-sql-identity 0.4.3 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/actix-web-sql-identity/0.4.3 [INFO] validating manifest of actix-web-sql-identity-0.4.3 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of actix-web-sql-identity-0.4.3 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing actix-web-sql-identity-0.4.3 [INFO] finished frobbing actix-web-sql-identity-0.4.3 [INFO] frobbed toml for actix-web-sql-identity-0.4.3 written to work/ex/clippy-test-run/sources/stable/reg/actix-web-sql-identity/0.4.3/Cargo.toml [INFO] started frobbing actix-web-sql-identity-0.4.3 [INFO] finished frobbing actix-web-sql-identity-0.4.3 [INFO] frobbed toml for actix-web-sql-identity-0.4.3 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/actix-web-sql-identity/0.4.3/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting actix-web-sql-identity-0.4.3 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/actix-web-sql-identity/0.4.3:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] aed29dc5bea44bcfc2eb95c5ecc8da8d3fc3640c579a752a1c3896a3637201c6 [INFO] running `"docker" "start" "-a" "aed29dc5bea44bcfc2eb95c5ecc8da8d3fc3640c579a752a1c3896a3637201c6"` [INFO] [stderr] Compiling mysqlclient-sys v0.2.3 [INFO] [stderr] Compiling v_escape_derive v0.2.1 [INFO] [stderr] Compiling actix_derive v0.3.2 [INFO] [stderr] Compiling diesel_derives v1.4.0 [INFO] [stderr] Checking dotenv v0.13.0 [INFO] [stderr] Checking tokio-signal v0.2.7 [INFO] [stderr] Checking trust-dns-proto v0.6.3 [INFO] [stderr] Checking trust-dns-proto v0.5.0 [INFO] [stderr] Checking v_escape v0.3.2 [INFO] [stderr] Checking v_htmlescape v0.3.2 [INFO] [stderr] Checking diesel v1.4.1 [INFO] [stderr] Checking trust-dns-resolver v0.10.3 [INFO] [stderr] Checking actix v0.7.9 [INFO] [stderr] Checking actix-net v0.2.6 [INFO] [stderr] Checking actix-web v0.7.18 [INFO] [stderr] Checking actix-web-sql-identity v0.4.3 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:380:13 [INFO] [stderr] | [INFO] [stderr] 380 | uri: uri, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `uri` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:382:13 [INFO] [stderr] | [INFO] [stderr] 382 | variant: variant, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `variant` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:500:21 [INFO] [stderr] | [INFO] [stderr] 500 | inner: inner, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `inner` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:511:21 [INFO] [stderr] | [INFO] [stderr] 511 | inner: inner, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `inner` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:380:13 [INFO] [stderr] | [INFO] [stderr] 380 | uri: uri, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `uri` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:382:13 [INFO] [stderr] | [INFO] [stderr] 382 | variant: variant, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `variant` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:500:21 [INFO] [stderr] | [INFO] [stderr] 500 | inner: inner, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `inner` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:511:21 [INFO] [stderr] | [INFO] [stderr] 511 | inner: inner, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `inner` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused import: `SqlIdentityError` [INFO] [stderr] --> src/sql.rs:27:26 [INFO] [stderr] | [INFO] [stderr] 27 | use super::{SqlIdentity, SqlIdentityError}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: Variant name ends with the enum's name [INFO] [stderr] --> src/sql.rs:67:5 [INFO] [stderr] | [INFO] [stderr] 67 | MySqlPool(Pool>), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::enum_variant_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stderr] [INFO] [stderr] warning: All variants have the same postfix: `Pool` [INFO] [stderr] --> src/sql.rs:62:1 [INFO] [stderr] | [INFO] [stderr] 62 | / enum SqlPool { [INFO] [stderr] 63 | | #[cfg(feature = "sqlite")] [INFO] [stderr] 64 | | SqlitePool(Pool>), [INFO] [stderr] 65 | | [INFO] [stderr] ... | [INFO] [stderr] 70 | | PgPool(Pool>), [INFO] [stderr] 71 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: remove the postfixes and use full paths to the variants instead of glob imports [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:97:30 [INFO] [stderr] | [INFO] [stderr] 97 | const DEFAULT_RESPONSE_HDR: &'static str = "X-Actix-Auth"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:388:13 [INFO] [stderr] | [INFO] [stderr] 388 | return Variant::Mysql; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Variant::Mysql` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:390:13 [INFO] [stderr] | [INFO] [stderr] 390 | return Variant::Pg; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Variant::Pg` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:392:13 [INFO] [stderr] | [INFO] [stderr] 392 | return Variant::Sqlite; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Variant::Sqlite` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `SqlIdentityError` [INFO] [stderr] --> src/sql.rs:27:26 [INFO] [stderr] | [INFO] [stderr] 27 | use super::{SqlIdentity, SqlIdentityError}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: Variant name ends with the enum's name [INFO] [stderr] --> src/sql.rs:67:5 [INFO] [stderr] | [INFO] [stderr] 67 | MySqlPool(Pool>), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::enum_variant_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stderr] [INFO] [stderr] warning: All variants have the same postfix: `Pool` [INFO] [stderr] --> src/sql.rs:62:1 [INFO] [stderr] | [INFO] [stderr] 62 | / enum SqlPool { [INFO] [stderr] 63 | | #[cfg(feature = "sqlite")] [INFO] [stderr] 64 | | SqlitePool(Pool>), [INFO] [stderr] 65 | | [INFO] [stderr] ... | [INFO] [stderr] 70 | | PgPool(Pool>), [INFO] [stderr] 71 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: remove the postfixes and use full paths to the variants instead of glob imports [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:97:30 [INFO] [stderr] | [INFO] [stderr] 97 | const DEFAULT_RESPONSE_HDR: &'static str = "X-Actix-Auth"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:388:13 [INFO] [stderr] | [INFO] [stderr] 388 | return Variant::Mysql; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Variant::Mysql` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:390:13 [INFO] [stderr] | [INFO] [stderr] 390 | return Variant::Pg; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Variant::Pg` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:392:13 [INFO] [stderr] | [INFO] [stderr] 392 | return Variant::Sqlite; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Variant::Sqlite` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> tests/common/mod.rs:15:25 [INFO] [stderr] | [INFO] [stderr] 15 | const RESPONSE_HEADER: &'static str = "test-auth"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> tests/common/mod.rs:178:5 [INFO] [stderr] | [INFO] [stderr] 178 | / match token { [INFO] [stderr] 179 | | Some(t) => add_token_to_request(&mut request, t), [INFO] [stderr] 180 | | None => (), [INFO] [stderr] 181 | | } [INFO] [stderr] | |_____^ help: try this: `if let Some(t) = token { add_token_to_request(&mut request, t) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2m 11s [INFO] running `"docker" "inspect" "aed29dc5bea44bcfc2eb95c5ecc8da8d3fc3640c579a752a1c3896a3637201c6"` [INFO] running `"docker" "rm" "-f" "aed29dc5bea44bcfc2eb95c5ecc8da8d3fc3640c579a752a1c3896a3637201c6"` [INFO] [stdout] aed29dc5bea44bcfc2eb95c5ecc8da8d3fc3640c579a752a1c3896a3637201c6