[INFO] crate actix-web 0.7.15 is already in cache [INFO] extracting crate actix-web 0.7.15 into work/ex/clippy-test-run/sources/stable/reg/actix-web/0.7.15 [INFO] extracting crate actix-web 0.7.15 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/actix-web/0.7.15 [INFO] validating manifest of actix-web-0.7.15 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of actix-web-0.7.15 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing actix-web-0.7.15 [INFO] finished frobbing actix-web-0.7.15 [INFO] frobbed toml for actix-web-0.7.15 written to work/ex/clippy-test-run/sources/stable/reg/actix-web/0.7.15/Cargo.toml [INFO] started frobbing actix-web-0.7.15 [INFO] finished frobbing actix-web-0.7.15 [INFO] frobbed toml for actix-web-0.7.15 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/actix-web/0.7.15/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting actix-web-0.7.15 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/actix-web/0.7.15:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 8b485d3e6b9a4d6e4aa834241493351267233976bf60143e48231215ed54d931 [INFO] running `"docker" "start" "-a" "8b485d3e6b9a4d6e4aa834241493351267233976bf60143e48231215ed54d931"` [INFO] [stderr] Compiling actix-web v0.7.15 (/opt/crater/workdir) [INFO] [stderr] Checking trust-dns-proto v0.6.3 [INFO] [stderr] Checking trust-dns-proto v0.5.0 [INFO] [stderr] Checking trust-dns-resolver v0.10.3 [INFO] [stderr] Checking actix v0.7.9 [INFO] [stderr] Checking actix-net v0.2.6 [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/header/common/mod.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | #![cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#![rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::deprecated_cfg_attr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/client/connector.rs:282:13 [INFO] [stderr] | [INFO] [stderr] 282 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/header/common/mod.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | #![cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#![rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::deprecated_cfg_attr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/client/connector.rs:282:13 [INFO] [stderr] | [INFO] [stderr] 282 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: lint name `borrowed_box` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/httpresponse.rs:697:44 [INFO] [stderr] | [INFO] [stderr] 697 | #[cfg_attr(feature = "cargo-clippy", allow(borrowed_box))] [INFO] [stderr] | ^^^^^^^^^^^^ help: change it to: `clippy::borrowed_box` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `cyclomatic_complexity` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/info.rs:21:15 [INFO] [stderr] | [INFO] [stderr] 21 | allow(cyclomatic_complexity) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::cyclomatic_complexity` [INFO] [stderr] [INFO] [stderr] warning: lint name `new_without_default_derive` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/scope.rs:64:11 [INFO] [stderr] | [INFO] [stderr] 64 | allow(new_without_default_derive) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::new_without_default_derive` [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/client/connector.rs:286:17 [INFO] [stderr] | [INFO] [stderr] 286 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: lint name `let_unit_value` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/client/connector.rs:290:52 [INFO] [stderr] | [INFO] [stderr] 290 | #[cfg_attr(feature = "cargo-clippy", allow(let_unit_value))] [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change it to: `clippy::let_unit_value` [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/client/connector.rs:730:13 [INFO] [stderr] | [INFO] [stderr] 730 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: lint name `redundant_field_names` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/client/writer.rs:3:11 [INFO] [stderr] | [INFO] [stderr] 3 | allow(redundant_field_names) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::redundant_field_names` [INFO] [stderr] [INFO] [stderr] warning: lint name `match_wild_err_arm` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/middleware/defaultheaders.rs:51:48 [INFO] [stderr] | [INFO] [stderr] 51 | #[cfg_attr(feature = "cargo-clippy", allow(match_wild_err_arm))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::match_wild_err_arm` [INFO] [stderr] [INFO] [stderr] warning: lint name `redundant_field_names` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/server/h2writer.rs:3:11 [INFO] [stderr] | [INFO] [stderr] 3 | allow(redundant_field_names) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::redundant_field_names` [INFO] [stderr] [INFO] [stderr] warning: lint name `needless_pass_by_value` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/server/http.rs:329:15 [INFO] [stderr] | [INFO] [stderr] 329 | allow(needless_pass_by_value) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::needless_pass_by_value` [INFO] [stderr] [INFO] [stderr] warning: lint name `inline_always` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/server/output.rs:441:48 [INFO] [stderr] | [INFO] [stderr] 441 | #[cfg_attr(feature = "cargo-clippy", allow(inline_always))] [INFO] [stderr] | ^^^^^^^^^^^^^ help: change it to: `clippy::inline_always` [INFO] [stderr] [INFO] [stderr] warning: lint name `inline_always` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/server/output.rs:483:48 [INFO] [stderr] | [INFO] [stderr] 483 | #[cfg_attr(feature = "cargo-clippy", allow(inline_always))] [INFO] [stderr] | ^^^^^^^^^^^^^ help: change it to: `clippy::inline_always` [INFO] [stderr] [INFO] [stderr] warning: lint name `type_complexity` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/ws/frame.rs:49:48 [INFO] [stderr] | [INFO] [stderr] 49 | #[cfg_attr(feature = "cargo-clippy", allow(type_complexity))] [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change it to: `clippy::type_complexity` [INFO] [stderr] [INFO] [stderr] warning: lint name `cast_ptr_alignment` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/ws/mask.rs:2:45 [INFO] [stderr] | [INFO] [stderr] 2 | #![cfg_attr(feature = "cargo-clippy", allow(cast_ptr_alignment))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::cast_ptr_alignment` [INFO] [stderr] [INFO] [stderr] warning: lint name `cast_lossless` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/ws/mask.rs:22:44 [INFO] [stderr] | [INFO] [stderr] 22 | #[cfg_attr(feature = "cargo-clippy", allow(cast_lossless))] [INFO] [stderr] | ^^^^^^^^^^^^^ help: change it to: `clippy::cast_lossless` [INFO] [stderr] [INFO] [stderr] warning: lint name `needless_pass_by_value` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/ws/mask.rs:55:11 [INFO] [stderr] | [INFO] [stderr] 55 | allow(needless_pass_by_value) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::needless_pass_by_value` [INFO] [stderr] [INFO] [stderr] warning: lint name `borrowed_box` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/httpresponse.rs:697:44 [INFO] [stderr] | [INFO] [stderr] 697 | #[cfg_attr(feature = "cargo-clippy", allow(borrowed_box))] [INFO] [stderr] | ^^^^^^^^^^^^ help: change it to: `clippy::borrowed_box` [INFO] [stderr] [INFO] [stderr] warning: lint name `borrowed_box` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/httpresponse.rs:697:44 [INFO] [stderr] | [INFO] [stderr] 697 | #[cfg_attr(feature = "cargo-clippy", allow(borrowed_box))] [INFO] [stderr] | ^^^^^^^^^^^^ help: change it to: `clippy::borrowed_box` [INFO] [stderr] [INFO] [stderr] warning: lint name `cyclomatic_complexity` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/info.rs:21:15 [INFO] [stderr] | [INFO] [stderr] 21 | allow(cyclomatic_complexity) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::cyclomatic_complexity` [INFO] [stderr] [INFO] [stderr] warning: lint name `new_without_default_derive` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/scope.rs:64:11 [INFO] [stderr] | [INFO] [stderr] 64 | allow(new_without_default_derive) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::new_without_default_derive` [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/client/connector.rs:286:17 [INFO] [stderr] | [INFO] [stderr] 286 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: lint name `let_unit_value` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/client/connector.rs:290:52 [INFO] [stderr] | [INFO] [stderr] 290 | #[cfg_attr(feature = "cargo-clippy", allow(let_unit_value))] [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change it to: `clippy::let_unit_value` [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/client/connector.rs:730:13 [INFO] [stderr] | [INFO] [stderr] 730 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: lint name `redundant_field_names` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/client/writer.rs:3:11 [INFO] [stderr] | [INFO] [stderr] 3 | allow(redundant_field_names) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::redundant_field_names` [INFO] [stderr] [INFO] [stderr] warning: lint name `match_wild_err_arm` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/middleware/defaultheaders.rs:51:48 [INFO] [stderr] | [INFO] [stderr] 51 | #[cfg_attr(feature = "cargo-clippy", allow(match_wild_err_arm))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::match_wild_err_arm` [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/server/h1.rs:611:41 [INFO] [stderr] | [INFO] [stderr] 611 | Message::Message { msg, payload: _ } => msg, [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unneeded_field_pattern)] on by default [INFO] [stderr] = help: Try with `Message { msg, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/server/h1.rs:617:36 [INFO] [stderr] | [INFO] [stderr] 617 | Message::Message { msg: _, payload } => payload, [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `Message { payload, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: lint name `redundant_field_names` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/server/h2writer.rs:3:11 [INFO] [stderr] | [INFO] [stderr] 3 | allow(redundant_field_names) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::redundant_field_names` [INFO] [stderr] [INFO] [stderr] warning: lint name `needless_pass_by_value` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/server/http.rs:329:15 [INFO] [stderr] | [INFO] [stderr] 329 | allow(needless_pass_by_value) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::needless_pass_by_value` [INFO] [stderr] [INFO] [stderr] warning: lint name `inline_always` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/server/output.rs:441:48 [INFO] [stderr] | [INFO] [stderr] 441 | #[cfg_attr(feature = "cargo-clippy", allow(inline_always))] [INFO] [stderr] | ^^^^^^^^^^^^^ help: change it to: `clippy::inline_always` [INFO] [stderr] [INFO] [stderr] warning: lint name `inline_always` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/server/output.rs:483:48 [INFO] [stderr] | [INFO] [stderr] 483 | #[cfg_attr(feature = "cargo-clippy", allow(inline_always))] [INFO] [stderr] | ^^^^^^^^^^^^^ help: change it to: `clippy::inline_always` [INFO] [stderr] [INFO] [stderr] warning: lint name `type_complexity` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/ws/frame.rs:49:48 [INFO] [stderr] | [INFO] [stderr] 49 | #[cfg_attr(feature = "cargo-clippy", allow(type_complexity))] [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change it to: `clippy::type_complexity` [INFO] [stderr] [INFO] [stderr] warning: lint name `cast_ptr_alignment` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/ws/mask.rs:2:45 [INFO] [stderr] | [INFO] [stderr] 2 | #![cfg_attr(feature = "cargo-clippy", allow(cast_ptr_alignment))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::cast_ptr_alignment` [INFO] [stderr] [INFO] [stderr] warning: lint name `cast_lossless` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/ws/mask.rs:22:44 [INFO] [stderr] | [INFO] [stderr] 22 | #[cfg_attr(feature = "cargo-clippy", allow(cast_lossless))] [INFO] [stderr] | ^^^^^^^^^^^^^ help: change it to: `clippy::cast_lossless` [INFO] [stderr] [INFO] [stderr] warning: lint name `needless_pass_by_value` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/ws/mask.rs:55:11 [INFO] [stderr] | [INFO] [stderr] 55 | allow(needless_pass_by_value) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::needless_pass_by_value` [INFO] [stderr] [INFO] [stderr] warning: method is never used: `clear` [INFO] [stderr] --> src/param.rs:56:5 [INFO] [stderr] | [INFO] [stderr] 56 | pub(crate) fn clear(&mut self) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/header/common/content_disposition.rs:92:5 [INFO] [stderr] | [INFO] [stderr] 92 | UnknownExt(String, ExtendedValue), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::large_enum_variant)] on by default [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] --> src/header/common/content_disposition.rs:92:5 [INFO] [stderr] | [INFO] [stderr] 92 | UnknownExt(String, ExtendedValue), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/router.rs:35:5 [INFO] [stderr] | [INFO] [stderr] 35 | Resource(Resource), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] | [INFO] [stderr] 35 | Resource(Box>), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let connector =` [INFO] [stderr] --> src/client/connector.rs:256:9 [INFO] [stderr] | [INFO] [stderr] 256 | / let connector = { [INFO] [stderr] 257 | | #[cfg(all(any(feature = "alpn", feature = "ssl")))] [INFO] [stderr] 258 | | { [INFO] [stderr] 259 | | SslConnector::builder(SslMethod::tls()).unwrap().build() [INFO] [stderr] ... | [INFO] [stderr] 287 | | } [INFO] [stderr] 288 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/client/connector.rs:291:46 [INFO] [stderr] | [INFO] [stderr] 291 | ClientConnector::with_connector_impl(connector) [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 291 | ClientConnector::with_connector_impl(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (9/7) [INFO] [stderr] --> src/server/builder.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | / fn register( [INFO] [stderr] 18 | | &self, [INFO] [stderr] 19 | | server: Server, [INFO] [stderr] 20 | | lst: net::TcpListener, [INFO] [stderr] ... | [INFO] [stderr] 26 | | client_shutdown: u64, [INFO] [stderr] 27 | | ) -> Server; [INFO] [stderr] | |________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/server/channel.rs:99:17 [INFO] [stderr] | [INFO] [stderr] 99 | Err(_) => panic!("Something is really wrong"), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/server/output.rs:51:5 [INFO] [stderr] | [INFO] [stderr] 51 | Encoder(ContentEncoder), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] | [INFO] [stderr] 51 | Encoder(Box), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/server/output.rs:355:5 [INFO] [stderr] | [INFO] [stderr] 355 | Gzip(GzEncoder), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] | [INFO] [stderr] 355 | Gzip(Box>), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: consider using `Option` instead of `Option>` or a custom enum if you need to distinguish all 3 cases [INFO] [stderr] --> src/server/service.rs:185:13 [INFO] [stderr] | [INFO] [stderr] 185 | tcp_ka: Option>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_option)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_option [INFO] [stderr] [INFO] [stderr] warning: consider using `Option` instead of `Option>` or a custom enum if you need to distinguish all 3 cases [INFO] [stderr] --> src/server/service.rs:241:13 [INFO] [stderr] | [INFO] [stderr] 241 | tcp_ka: Option>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_option [INFO] [stderr] [INFO] [stderr] warning: method is never used: `clear` [INFO] [stderr] --> src/param.rs:56:5 [INFO] [stderr] | [INFO] [stderr] 56 | pub(crate) fn clear(&mut self) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `readall` [INFO] [stderr] --> src/payload.rs:83:5 [INFO] [stderr] | [INFO] [stderr] 83 | pub(crate) fn readall(&self) -> Option { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `readall` [INFO] [stderr] --> src/payload.rs:230:5 [INFO] [stderr] | [INFO] [stderr] 230 | pub(crate) fn readall(&mut self) -> Option { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let () =` [INFO] [stderr] --> src/extractor.rs:1192:9 [INFO] [stderr] | [INFO] [stderr] 1192 | let () = <()>::extract(&req); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/handler.rs:276:9 [INFO] [stderr] | [INFO] [stderr] 276 | / match self.0.as_ref().unwrap() { [INFO] [stderr] 277 | | &AsyncResultItem::Ok(ref resp) => resp, [INFO] [stderr] 278 | | _ => panic!(), [INFO] [stderr] 279 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 276 | match *self.0.as_ref().unwrap() { [INFO] [stderr] 277 | AsyncResultItem::Ok(ref resp) => resp, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/handler.rs:284:9 [INFO] [stderr] | [INFO] [stderr] 284 | / match self.0.as_ref().unwrap() { [INFO] [stderr] 285 | | &AsyncResultItem::Err(ref err) => Some(err), [INFO] [stderr] 286 | | _ => None, [INFO] [stderr] 287 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 284 | match *self.0.as_ref().unwrap() { [INFO] [stderr] 285 | AsyncResultItem::Err(ref err) => Some(err), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/header/common/content_disposition.rs:92:5 [INFO] [stderr] | [INFO] [stderr] 92 | UnknownExt(String, ExtendedValue), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::large_enum_variant)] on by default [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] --> src/header/common/content_disposition.rs:92:5 [INFO] [stderr] | [INFO] [stderr] 92 | UnknownExt(String, ExtendedValue), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 49 [INFO] [stderr] --> src/httpresponse.rs:1228:5 [INFO] [stderr] | [INFO] [stderr] 1228 | / fn test_into_response() { [INFO] [stderr] 1229 | | let req = TestRequest::default().finish(); [INFO] [stderr] 1230 | | [INFO] [stderr] 1231 | | let resp: HttpResponse = "test".into(); [INFO] [stderr] ... | [INFO] [stderr] 1347 | | assert_eq!(resp.body().bin_ref(), &Binary::from(BytesMut::from("test"))); [INFO] [stderr] 1348 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/router.rs:35:5 [INFO] [stderr] | [INFO] [stderr] 35 | Resource(Resource), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] | [INFO] [stderr] 35 | Resource(Box>), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/scope.rs:915:9 [INFO] [stderr] | [INFO] [stderr] 915 | / match resp.as_msg().body() { [INFO] [stderr] 916 | | &Body::Binary(ref b) => { [INFO] [stderr] 917 | | let bytes: Bytes = b.clone().into(); [INFO] [stderr] 918 | | assert_eq!(bytes, Bytes::from_static(b"project: project1")); [INFO] [stderr] 919 | | } [INFO] [stderr] 920 | | _ => panic!(), [INFO] [stderr] 921 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 915 | match *resp.as_msg().body() { [INFO] [stderr] 916 | Body::Binary(ref b) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/scope.rs:1124:9 [INFO] [stderr] | [INFO] [stderr] 1124 | / match resp.as_msg().body() { [INFO] [stderr] 1125 | | &Body::Binary(ref b) => { [INFO] [stderr] 1126 | | let bytes: Bytes = b.clone().into(); [INFO] [stderr] 1127 | | assert_eq!(bytes, Bytes::from_static(b"project: project_1")); [INFO] [stderr] 1128 | | } [INFO] [stderr] 1129 | | _ => panic!(), [INFO] [stderr] 1130 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 1124 | match *resp.as_msg().body() { [INFO] [stderr] 1125 | Body::Binary(ref b) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/scope.rs:1156:9 [INFO] [stderr] | [INFO] [stderr] 1156 | / match resp.as_msg().body() { [INFO] [stderr] 1157 | | &Body::Binary(ref b) => { [INFO] [stderr] 1158 | | let bytes: Bytes = b.clone().into(); [INFO] [stderr] 1159 | | assert_eq!(bytes, Bytes::from_static(b"project: test - 1")); [INFO] [stderr] 1160 | | } [INFO] [stderr] 1161 | | _ => panic!(), [INFO] [stderr] 1162 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 1156 | match *resp.as_msg().body() { [INFO] [stderr] 1157 | Body::Binary(ref b) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let connector =` [INFO] [stderr] --> src/client/connector.rs:256:9 [INFO] [stderr] | [INFO] [stderr] 256 | / let connector = { [INFO] [stderr] 257 | | #[cfg(all(any(feature = "alpn", feature = "ssl")))] [INFO] [stderr] 258 | | { [INFO] [stderr] 259 | | SslConnector::builder(SslMethod::tls()).unwrap().build() [INFO] [stderr] ... | [INFO] [stderr] 287 | | } [INFO] [stderr] 288 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/client/connector.rs:291:46 [INFO] [stderr] | [INFO] [stderr] 291 | ClientConnector::with_connector_impl(connector) [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 291 | ClientConnector::with_connector_impl(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 40 [INFO] [stderr] --> src/error.rs:1304:5 [INFO] [stderr] | [INFO] [stderr] 1304 | / fn test_error_helpers() { [INFO] [stderr] 1305 | | let r: HttpResponse = ErrorBadRequest("err").into(); [INFO] [stderr] 1306 | | assert_eq!(r.status(), StatusCode::BAD_REQUEST); [INFO] [stderr] 1307 | | [INFO] [stderr] ... | [INFO] [stderr] 1420 | | assert_eq!(r.status(), StatusCode::NETWORK_AUTHENTICATION_REQUIRED); [INFO] [stderr] 1421 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: The function/method `response` doesn't need a mutable reference [INFO] [stderr] --> src/middleware/errhandlers.rs:105:38 [INFO] [stderr] | [INFO] [stderr] 105 | let resp = match mw.response(&mut req, resp) { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `response` doesn't need a mutable reference [INFO] [stderr] --> src/middleware/errhandlers.rs:112:38 [INFO] [stderr] | [INFO] [stderr] 112 | let resp = match mw.response(&mut req, resp) { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (9/7) [INFO] [stderr] --> src/server/builder.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | / fn register( [INFO] [stderr] 18 | | &self, [INFO] [stderr] 19 | | server: Server, [INFO] [stderr] 20 | | lst: net::TcpListener, [INFO] [stderr] ... | [INFO] [stderr] 26 | | client_shutdown: u64, [INFO] [stderr] 27 | | ) -> Server; [INFO] [stderr] | |________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/server/channel.rs:99:17 [INFO] [stderr] | [INFO] [stderr] 99 | Err(_) => panic!("Something is really wrong"), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/server/output.rs:51:5 [INFO] [stderr] | [INFO] [stderr] 51 | Encoder(ContentEncoder), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] | [INFO] [stderr] 51 | Encoder(Box), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/server/output.rs:355:5 [INFO] [stderr] | [INFO] [stderr] 355 | Gzip(GzEncoder), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] | [INFO] [stderr] 355 | Gzip(Box>), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: consider using `Option` instead of `Option>` or a custom enum if you need to distinguish all 3 cases [INFO] [stderr] --> src/server/service.rs:185:13 [INFO] [stderr] | [INFO] [stderr] 185 | tcp_ka: Option>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_option)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_option [INFO] [stderr] [INFO] [stderr] warning: consider using `Option` instead of `Option>` or a custom enum if you need to distinguish all 3 cases [INFO] [stderr] --> src/server/service.rs:241:13 [INFO] [stderr] | [INFO] [stderr] 241 | tcp_ka: Option>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_option [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/ws/mask.rs:114:50 [INFO] [stderr] | [INFO] [stderr] 114 | fn apply_mask_fallback(buf: &mut [u8], mask: &[u8; 4]) { [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `[u8; 4]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> tests/test_middleware.rs:987:25 [INFO] [stderr] | [INFO] [stderr] 987 | const SIMPLE_NAME: &'static str = "simple"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> tests/test_middleware.rs:988:28 [INFO] [stderr] | [INFO] [stderr] 988 | const SIMPLE_PAYLOAD: &'static str = "kantan"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> tests/test_middleware.rs:989:26 [INFO] [stderr] | [INFO] [stderr] 989 | const COMPLEX_NAME: &'static str = "test"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> tests/test_middleware.rs:990:29 [INFO] [stderr] | [INFO] [stderr] 990 | const COMPLEX_PAYLOAD: &'static str = "url=https://test.com&generate_204"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> tests/test_ws.rs:369:9 [INFO] [stderr] | [INFO] [stderr] 369 | / match msg { [INFO] [stderr] 370 | | ws::Message::Text(text) => ctx.text(text), [INFO] [stderr] 371 | | _ => (), [INFO] [stderr] 372 | | } [INFO] [stderr] | |_________^ help: try this: `if let ws::Message::Text(text) = msg { ctx.text(text) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> tests/test_handlers.rs:184:46 [INFO] [stderr] | [INFO] [stderr] 184 | .with(|form: Form| format!("{}", form.username)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `form.username.to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> tests/test_handlers.rs:208:40 [INFO] [stderr] | [INFO] [stderr] 208 | |form: Form| format!("{}", form.username), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `form.username.to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> tests/test_server.rs:126:5 [INFO] [stderr] | [INFO] [stderr] 126 | let _ = sys.stop(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> tests/test_server.rs:169:5 [INFO] [stderr] | [INFO] [stderr] 169 | let _ = sys.stop(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> tests/test_server.rs:227:5 [INFO] [stderr] | [INFO] [stderr] 227 | let _ = sys.stop(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 51s [INFO] running `"docker" "inspect" "8b485d3e6b9a4d6e4aa834241493351267233976bf60143e48231215ed54d931"` [INFO] running `"docker" "rm" "-f" "8b485d3e6b9a4d6e4aa834241493351267233976bf60143e48231215ed54d931"` [INFO] [stdout] 8b485d3e6b9a4d6e4aa834241493351267233976bf60143e48231215ed54d931