[INFO] crate actix-form-data 0.3.1 is already in cache [INFO] extracting crate actix-form-data 0.3.1 into work/ex/clippy-test-run/sources/stable/reg/actix-form-data/0.3.1 [INFO] extracting crate actix-form-data 0.3.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/actix-form-data/0.3.1 [INFO] validating manifest of actix-form-data-0.3.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of actix-form-data-0.3.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing actix-form-data-0.3.1 [INFO] finished frobbing actix-form-data-0.3.1 [INFO] frobbed toml for actix-form-data-0.3.1 written to work/ex/clippy-test-run/sources/stable/reg/actix-form-data/0.3.1/Cargo.toml [INFO] started frobbing actix-form-data-0.3.1 [INFO] finished frobbing actix-form-data-0.3.1 [INFO] frobbed toml for actix-form-data-0.3.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/actix-form-data/0.3.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting actix-form-data-0.3.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/actix-form-data/0.3.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b9467dc918f4ef5760ed7f469808e5dd43547f8ff2ac6569b909b04853d34622 [INFO] running `"docker" "start" "-a" "b9467dc918f4ef5760ed7f469808e5dd43547f8ff2ac6569b909b04853d34622"` [INFO] [stderr] Checking futures-fs v0.0.5 [INFO] [stderr] Checking actix-form-data v0.3.1 (/opt/crater/workdir) [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the HashMap [INFO] [stderr] --> src/types.rs:76:23 [INFO] [stderr] | [INFO] [stderr] 76 | other.into_iter().fold(hm, |hm, (key, value)| { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `types::Form` [INFO] [stderr] --> src/types.rs:442:5 [INFO] [stderr] | [INFO] [stderr] 442 | / pub fn new() -> Self { [INFO] [stderr] 443 | | Form::from_executor(CpuPool::new_num_cpus()) [INFO] [stderr] 444 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 437 | impl Default for types::Form { [INFO] [stderr] 438 | fn default() -> Self { [INFO] [stderr] 439 | Self::new() [INFO] [stderr] 440 | } [INFO] [stderr] 441 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/upload.rs:85:20 [INFO] [stderr] | [INFO] [stderr] 85 | if v.len() == 0 && !part.is_map() { [INFO] [stderr] | ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `v.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the HashMap [INFO] [stderr] --> src/types.rs:76:23 [INFO] [stderr] | [INFO] [stderr] 76 | other.into_iter().fold(hm, |hm, (key, value)| { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `types::Form` [INFO] [stderr] --> src/types.rs:442:5 [INFO] [stderr] | [INFO] [stderr] 442 | / pub fn new() -> Self { [INFO] [stderr] 443 | | Form::from_executor(CpuPool::new_num_cpus()) [INFO] [stderr] 444 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 437 | impl Default for types::Form { [INFO] [stderr] 438 | fn default() -> Self { [INFO] [stderr] 439 | Self::new() [INFO] [stderr] 440 | } [INFO] [stderr] 441 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/upload.rs:85:20 [INFO] [stderr] | [INFO] [stderr] 85 | if v.len() == 0 && !part.is_map() { [INFO] [stderr] | ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `v.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 28.60s [INFO] running `"docker" "inspect" "b9467dc918f4ef5760ed7f469808e5dd43547f8ff2ac6569b909b04853d34622"` [INFO] running `"docker" "rm" "-f" "b9467dc918f4ef5760ed7f469808e5dd43547f8ff2ac6569b909b04853d34622"` [INFO] [stdout] b9467dc918f4ef5760ed7f469808e5dd43547f8ff2ac6569b909b04853d34622