[INFO] crate actix 0.7.8 is already in cache [INFO] extracting crate actix 0.7.8 into work/ex/clippy-test-run/sources/stable/reg/actix/0.7.8 [INFO] extracting crate actix 0.7.8 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/actix/0.7.8 [INFO] validating manifest of actix-0.7.8 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of actix-0.7.8 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing actix-0.7.8 [INFO] finished frobbing actix-0.7.8 [INFO] frobbed toml for actix-0.7.8 written to work/ex/clippy-test-run/sources/stable/reg/actix/0.7.8/Cargo.toml [INFO] started frobbing actix-0.7.8 [INFO] finished frobbing actix-0.7.8 [INFO] frobbed toml for actix-0.7.8 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/actix/0.7.8/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting actix-0.7.8 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/actix/0.7.8:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] faed1216da583f5ba732d48af851bdec4907e6f4ed613f843bacc38905972c0a [INFO] running `"docker" "start" "-a" "faed1216da583f5ba732d48af851bdec4907e6f4ed613f843bacc38905972c0a"` [INFO] [stderr] Checking trust-dns-proto v0.6.3 [INFO] [stderr] Checking trust-dns-proto v0.5.0 [INFO] [stderr] Checking trust-dns-resolver v0.10.3 [INFO] [stderr] Checking actix v0.7.8 (/opt/crater/workdir) [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/fut/mod.rs:278:5 [INFO] [stderr] | [INFO] [stderr] 278 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::deprecated_cfg_attr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/fut/mod.rs:278:5 [INFO] [stderr] | [INFO] [stderr] 278 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::deprecated_cfg_attr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: lint name `useless_attribute` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:57:44 [INFO] [stderr] | [INFO] [stderr] 57 | #[cfg_attr(feature = "cargo-clippy", allow(useless_attribute))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: change it to: `clippy::useless_attribute` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `new_ret_no_self` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/system.rs:79:48 [INFO] [stderr] | [INFO] [stderr] 79 | #[cfg_attr(feature = "cargo-clippy", allow(new_ret_no_self))] [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change it to: `clippy::new_ret_no_self` [INFO] [stderr] [INFO] [stderr] warning: lint name `boxed_local` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/msgs.rs:44:48 [INFO] [stderr] | [INFO] [stderr] 44 | #[cfg_attr(feature = "cargo-clippy", allow(boxed_local))] [INFO] [stderr] | ^^^^^^^^^^^ help: change it to: `clippy::boxed_local` [INFO] [stderr] [INFO] [stderr] warning: lint name `boxed_local` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/msgs.rs:113:48 [INFO] [stderr] | [INFO] [stderr] 113 | #[cfg_attr(feature = "cargo-clippy", allow(boxed_local))] [INFO] [stderr] | ^^^^^^^^^^^ help: change it to: `clippy::boxed_local` [INFO] [stderr] [INFO] [stderr] warning: lint name `boxed_local` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/utils.rs:113:48 [INFO] [stderr] | [INFO] [stderr] 113 | #[cfg_attr(feature = "cargo-clippy", allow(boxed_local))] [INFO] [stderr] | ^^^^^^^^^^^ help: change it to: `clippy::boxed_local` [INFO] [stderr] [INFO] [stderr] warning: lint name `boxed_local` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/utils.rs:208:48 [INFO] [stderr] | [INFO] [stderr] 208 | #[cfg_attr(feature = "cargo-clippy", allow(boxed_local))] [INFO] [stderr] | ^^^^^^^^^^^ help: change it to: `clippy::boxed_local` [INFO] [stderr] [INFO] [stderr] warning: lint name `useless_attribute` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:57:44 [INFO] [stderr] | [INFO] [stderr] 57 | #[cfg_attr(feature = "cargo-clippy", allow(useless_attribute))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: change it to: `clippy::useless_attribute` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `new_ret_no_self` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/system.rs:79:48 [INFO] [stderr] | [INFO] [stderr] 79 | #[cfg_attr(feature = "cargo-clippy", allow(new_ret_no_self))] [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change it to: `clippy::new_ret_no_self` [INFO] [stderr] [INFO] [stderr] warning: lint name `boxed_local` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/msgs.rs:44:48 [INFO] [stderr] | [INFO] [stderr] 44 | #[cfg_attr(feature = "cargo-clippy", allow(boxed_local))] [INFO] [stderr] | ^^^^^^^^^^^ help: change it to: `clippy::boxed_local` [INFO] [stderr] [INFO] [stderr] warning: lint name `boxed_local` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/msgs.rs:113:48 [INFO] [stderr] | [INFO] [stderr] 113 | #[cfg_attr(feature = "cargo-clippy", allow(boxed_local))] [INFO] [stderr] | ^^^^^^^^^^^ help: change it to: `clippy::boxed_local` [INFO] [stderr] [INFO] [stderr] warning: lint name `boxed_local` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/utils.rs:113:48 [INFO] [stderr] | [INFO] [stderr] 113 | #[cfg_attr(feature = "cargo-clippy", allow(boxed_local))] [INFO] [stderr] | ^^^^^^^^^^^ help: change it to: `clippy::boxed_local` [INFO] [stderr] [INFO] [stderr] warning: lint name `boxed_local` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/utils.rs:208:48 [INFO] [stderr] | [INFO] [stderr] 208 | #[cfg_attr(feature = "cargo-clippy", allow(boxed_local))] [INFO] [stderr] | ^^^^^^^^^^^ help: change it to: `clippy::boxed_local` [INFO] [stderr] [INFO] [stderr] warning: lint name `useless_attribute` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:57:44 [INFO] [stderr] | [INFO] [stderr] 57 | #[cfg_attr(feature = "cargo-clippy", allow(useless_attribute))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: change it to: `clippy::useless_attribute` [INFO] [stderr] [INFO] [stderr] warning: lint name `useless_attribute` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:57:44 [INFO] [stderr] | [INFO] [stderr] 57 | #[cfg_attr(feature = "cargo-clippy", allow(useless_attribute))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: change it to: `clippy::useless_attribute` [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/actors/mocker.rs:38:11 [INFO] [stderr] | [INFO] [stderr] 38 | mock: Box, &mut Context>) -> Box>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/actors/mocker.rs:43:15 [INFO] [stderr] | [INFO] [stderr] 43 | mock: Box, &mut Context>) -> Box>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/actors/mocker.rs:38:11 [INFO] [stderr] | [INFO] [stderr] 38 | mock: Box, &mut Context>) -> Box>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/actors/mocker.rs:43:15 [INFO] [stderr] | [INFO] [stderr] 43 | mock: Box, &mut Context>) -> Box>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: lint name `let_unit_value` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> tests/test_context.rs:1:45 [INFO] [stderr] | [INFO] [stderr] 1 | #![cfg_attr(feature = "cargo-clippy", allow(let_unit_value))] [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change it to: `clippy::let_unit_value` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `mutex_atomic` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> tests/test_sync.rs:65:44 [INFO] [stderr] | [INFO] [stderr] 65 | #[cfg_attr(feature = "cargo-clippy", allow(mutex_atomic))] [INFO] [stderr] | ^^^^^^^^^^^^ help: change it to: `clippy::mutex_atomic` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `mutex_atomic` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> tests/test_sync.rs:65:44 [INFO] [stderr] | [INFO] [stderr] 65 | #[cfg_attr(feature = "cargo-clippy", allow(mutex_atomic))] [INFO] [stderr] | ^^^^^^^^^^^^ help: change it to: `clippy::mutex_atomic` [INFO] [stderr] [INFO] [stderr] warning: lint name `let_unit_value` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> tests/test_lifecycle.rs:1:45 [INFO] [stderr] | [INFO] [stderr] 1 | #![cfg_attr(feature = "cargo-clippy", allow(let_unit_value))] [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change it to: `clippy::let_unit_value` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> tests/test_fut.rs:39:21 [INFO] [stderr] | [INFO] [stderr] 39 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: lint name `let_unit_value` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> tests/test_context.rs:1:45 [INFO] [stderr] | [INFO] [stderr] 1 | #![cfg_attr(feature = "cargo-clippy", allow(let_unit_value))] [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change it to: `clippy::let_unit_value` [INFO] [stderr] [INFO] [stderr] warning: lint name `let_unit_value` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> tests/test_lifecycle.rs:1:45 [INFO] [stderr] | [INFO] [stderr] 1 | #![cfg_attr(feature = "cargo-clippy", allow(let_unit_value))] [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change it to: `clippy::let_unit_value` [INFO] [stderr] [INFO] [stderr] warning: lint name `unit_cmp` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> tests/derive.rs:25:44 [INFO] [stderr] | [INFO] [stderr] 25 | #[cfg_attr(feature = "cargo-clippy", allow(unit_cmp))] [INFO] [stderr] | ^^^^^^^^ help: change it to: `clippy::unit_cmp` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `unit_cmp` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> tests/derive.rs:25:44 [INFO] [stderr] | [INFO] [stderr] 25 | #[cfg_attr(feature = "cargo-clippy", allow(unit_cmp))] [INFO] [stderr] | ^^^^^^^^ help: change it to: `clippy::unit_cmp` [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 52.36s [INFO] running `"docker" "inspect" "faed1216da583f5ba732d48af851bdec4907e6f4ed613f843bacc38905972c0a"` [INFO] running `"docker" "rm" "-f" "faed1216da583f5ba732d48af851bdec4907e6f4ed613f843bacc38905972c0a"` [INFO] [stdout] faed1216da583f5ba732d48af851bdec4907e6f4ed613f843bacc38905972c0a