[INFO] crate activitystreams-traits 0.1.0 is already in cache [INFO] extracting crate activitystreams-traits 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/activitystreams-traits/0.1.0 [INFO] extracting crate activitystreams-traits 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/activitystreams-traits/0.1.0 [INFO] validating manifest of activitystreams-traits-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of activitystreams-traits-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing activitystreams-traits-0.1.0 [INFO] finished frobbing activitystreams-traits-0.1.0 [INFO] frobbed toml for activitystreams-traits-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/activitystreams-traits/0.1.0/Cargo.toml [INFO] started frobbing activitystreams-traits-0.1.0 [INFO] finished frobbing activitystreams-traits-0.1.0 [INFO] frobbed toml for activitystreams-traits-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/activitystreams-traits/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting activitystreams-traits-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/activitystreams-traits/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 15bff9ca940d3b1fd0b13c10d49c27b826266063ed31ca5b96f7783021de8a4c [INFO] running `"docker" "start" "-a" "15bff9ca940d3b1fd0b13c10d49c27b826266063ed31ca5b96f7783021de8a4c"` [INFO] [stderr] Checking activitystreams-traits v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/properties.rs:49:5 [INFO] [stderr] | [INFO] [stderr] 49 | / if let &Some(ref item) = item { [INFO] [stderr] 50 | | from_value(item) [INFO] [stderr] 51 | | } else { [INFO] [stderr] 52 | | Err(Error::NotFound) [INFO] [stderr] 53 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 49 | if let Some(ref item) = *item { [INFO] [stderr] | ^^^^^^^^^^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/properties.rs:65:23 [INFO] [stderr] | [INFO] [stderr] 65 | pub fn from_vec(v: &Vec) -> Result> [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[serde_json::Value]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/properties.rs:49:5 [INFO] [stderr] | [INFO] [stderr] 49 | / if let &Some(ref item) = item { [INFO] [stderr] 50 | | from_value(item) [INFO] [stderr] 51 | | } else { [INFO] [stderr] 52 | | Err(Error::NotFound) [INFO] [stderr] 53 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 49 | if let Some(ref item) = *item { [INFO] [stderr] | ^^^^^^^^^^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/properties.rs:65:23 [INFO] [stderr] | [INFO] [stderr] 65 | pub fn from_vec(v: &Vec) -> Result> [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[serde_json::Value]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.60s [INFO] running `"docker" "inspect" "15bff9ca940d3b1fd0b13c10d49c27b826266063ed31ca5b96f7783021de8a4c"` [INFO] running `"docker" "rm" "-f" "15bff9ca940d3b1fd0b13c10d49c27b826266063ed31ca5b96f7783021de8a4c"` [INFO] [stdout] 15bff9ca940d3b1fd0b13c10d49c27b826266063ed31ca5b96f7783021de8a4c