[INFO] crate actiondb 0.7.0 is already in cache [INFO] extracting crate actiondb 0.7.0 into work/ex/clippy-test-run/sources/stable/reg/actiondb/0.7.0 [INFO] extracting crate actiondb 0.7.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/actiondb/0.7.0 [INFO] validating manifest of actiondb-0.7.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of actiondb-0.7.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing actiondb-0.7.0 [INFO] finished frobbing actiondb-0.7.0 [INFO] frobbed toml for actiondb-0.7.0 written to work/ex/clippy-test-run/sources/stable/reg/actiondb/0.7.0/Cargo.toml [INFO] started frobbing actiondb-0.7.0 [INFO] finished frobbing actiondb-0.7.0 [INFO] frobbed toml for actiondb-0.7.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/actiondb/0.7.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting actiondb-0.7.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/actiondb/0.7.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] dbbd51baf67cd5a9288134bf0a2fe3ecb1531b86f2b2700bd64d2cffbf8a6a69 [INFO] running `"docker" "start" "-a" "dbbd51baf67cd5a9288134bf0a2fe3ecb1531b86f2b2700bd64d2cffbf8a6a69"` [INFO] [stderr] Checking serde_yaml v0.2.5 [INFO] [stderr] Checking actiondb v0.7.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parsers/int.rs:13:21 [INFO] [stderr] | [INFO] [stderr] 13 | IntParser { delegate: delegate } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `delegate` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parsers/mod.rs:39:13 [INFO] [stderr] | [INFO] [stderr] 39 | parser: parser, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `parser` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parsers/mod.rs:40:13 [INFO] [stderr] | [INFO] [stderr] 40 | value: value, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/matcher/trie/node/parser.rs:18:13 [INFO] [stderr] | [INFO] [stderr] 18 | parser: parser, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `parser` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/matcher/pattern/pattern.rs:33:13 [INFO] [stderr] | [INFO] [stderr] 33 | uuid: uuid, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `uuid` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/matcher/pattern/pattern.rs:34:13 [INFO] [stderr] | [INFO] [stderr] 34 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/matcher/pattern/pattern.rs:35:13 [INFO] [stderr] | [INFO] [stderr] 35 | pattern: pattern, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `pattern` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/matcher/pattern/pattern.rs:36:13 [INFO] [stderr] | [INFO] [stderr] 36 | values: values, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `values` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/matcher/pattern/pattern.rs:37:13 [INFO] [stderr] | [INFO] [stderr] 37 | tags: tags, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `tags` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/matcher/pattern/pattern.rs:38:13 [INFO] [stderr] | [INFO] [stderr] 38 | test_messages: test_messages, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `test_messages` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/matcher/pattern/testmessage/error.rs:81:13 [INFO] [stderr] | [INFO] [stderr] 81 | expected: expected, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `expected` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/matcher/pattern/testmessage/error.rs:82:13 [INFO] [stderr] | [INFO] [stderr] 82 | got: got, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `got` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/matcher/pattern/testmessage/message.rs:20:13 [INFO] [stderr] | [INFO] [stderr] 20 | message: message, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `message` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/matcher/pattern/testmessage/message.rs:21:13 [INFO] [stderr] | [INFO] [stderr] 21 | values: values, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `values` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/matcher/pattern/testmessage/message.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | tags: tags, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `tags` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/matcher/result.rs:15:13 [INFO] [stderr] | [INFO] [stderr] 15 | pattern: pattern, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `pattern` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/matcher/suffix_array/impls.rs:147:13 [INFO] [stderr] | [INFO] [stderr] 147 | parser: parser, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `parser` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/matcher/suffix_array/impls.rs:216:13 [INFO] [stderr] | [INFO] [stderr] 216 | literal: literal, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `literal` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: lint name `clippy` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/grammar/parser/mod.rs:7:9 [INFO] [stderr] | [INFO] [stderr] 7 | #[allow(clippy)] [INFO] [stderr] | ^^^^^^ help: change it to: `clippy::all` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parsers/int.rs:13:21 [INFO] [stderr] | [INFO] [stderr] 13 | IntParser { delegate: delegate } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `delegate` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parsers/mod.rs:39:13 [INFO] [stderr] | [INFO] [stderr] 39 | parser: parser, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `parser` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parsers/mod.rs:40:13 [INFO] [stderr] | [INFO] [stderr] 40 | value: value, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/matcher/trie/node/parser.rs:18:13 [INFO] [stderr] | [INFO] [stderr] 18 | parser: parser, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `parser` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/matcher/pattern/pattern.rs:33:13 [INFO] [stderr] | [INFO] [stderr] 33 | uuid: uuid, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `uuid` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/matcher/pattern/pattern.rs:34:13 [INFO] [stderr] | [INFO] [stderr] 34 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/matcher/pattern/pattern.rs:35:13 [INFO] [stderr] | [INFO] [stderr] 35 | pattern: pattern, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `pattern` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/matcher/pattern/pattern.rs:36:13 [INFO] [stderr] | [INFO] [stderr] 36 | values: values, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `values` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/matcher/pattern/pattern.rs:37:13 [INFO] [stderr] | [INFO] [stderr] 37 | tags: tags, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `tags` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/matcher/pattern/pattern.rs:38:13 [INFO] [stderr] | [INFO] [stderr] 38 | test_messages: test_messages, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `test_messages` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/matcher/pattern/testmessage/error.rs:81:13 [INFO] [stderr] | [INFO] [stderr] 81 | expected: expected, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `expected` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/matcher/pattern/testmessage/error.rs:82:13 [INFO] [stderr] | [INFO] [stderr] 82 | got: got, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `got` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/matcher/pattern/testmessage/message.rs:20:13 [INFO] [stderr] | [INFO] [stderr] 20 | message: message, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `message` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/matcher/pattern/testmessage/message.rs:21:13 [INFO] [stderr] | [INFO] [stderr] 21 | values: values, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `values` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/matcher/pattern/testmessage/message.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | tags: tags, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `tags` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/matcher/result.rs:15:13 [INFO] [stderr] | [INFO] [stderr] 15 | pattern: pattern, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `pattern` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/matcher/suffix_array/impls.rs:147:13 [INFO] [stderr] | [INFO] [stderr] 147 | parser: parser, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `parser` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/matcher/suffix_array/impls.rs:216:13 [INFO] [stderr] | [INFO] [stderr] 216 | literal: literal, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `literal` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: lint name `clippy` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/grammar/parser/mod.rs:7:9 [INFO] [stderr] | [INFO] [stderr] 7 | #[allow(clippy)] [INFO] [stderr] | ^^^^^^ help: change it to: `clippy::all` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/matcher/pattern/mod.rs:6:1 [INFO] [stderr] | [INFO] [stderr] 6 | mod pattern; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/matcher/pattern/file/mod.rs:4:1 [INFO] [stderr] | [INFO] [stderr] 4 | mod file; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/matcher/suffix_array/impls.rs:195:20 [INFO] [stderr] | [INFO] [stderr] 195 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 196 | | if value.is_empty() { [INFO] [stderr] 197 | | self.create_match_result(kvpair) [INFO] [stderr] 198 | | } else { [INFO] [stderr] 199 | | None [INFO] [stderr] 200 | | } [INFO] [stderr] 201 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 195 | } else if value.is_empty() { [INFO] [stderr] 196 | self.create_match_result(kvpair) [INFO] [stderr] 197 | } else { [INFO] [stderr] 198 | None [INFO] [stderr] 199 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: lint name `clippy` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/grammar/parser/mod.rs:7:9 [INFO] [stderr] | [INFO] [stderr] 7 | #[allow(clippy)] [INFO] [stderr] | ^^^^^^ help: change it to: `clippy::all` [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::hash::SipHasher': use `std::collections::hash_map::DefaultHasher` instead [INFO] [stderr] --> src/parsers/set.rs:3:17 [INFO] [stderr] | [INFO] [stderr] 3 | use std::hash::{SipHasher, Hash, Hasher}; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::hash::SipHasher': use `std::collections::hash_map::DefaultHasher` instead [INFO] [stderr] --> src/parsers/int.rs:1:17 [INFO] [stderr] | [INFO] [stderr] 1 | use std::hash::{SipHasher, Hash, Hasher}; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::hash::SipHasher': use `std::collections::hash_map::DefaultHasher` instead [INFO] [stderr] --> src/parsers/greedy.rs:1:17 [INFO] [stderr] | [INFO] [stderr] 1 | use std::hash::{SipHasher, Hash, Hasher}; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::hash::SipHasher': use `std::collections::hash_map::DefaultHasher` instead [INFO] [stderr] --> src/parsers/set.rs:103:26 [INFO] [stderr] | [INFO] [stderr] 103 | let mut hasher = SipHasher::new(); [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::hash::SipHasher': use `std::collections::hash_map::DefaultHasher` instead [INFO] [stderr] --> src/parsers/int.rs:62:26 [INFO] [stderr] | [INFO] [stderr] 62 | let mut hasher = SipHasher::new(); [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::hash::SipHasher': use `std::collections::hash_map::DefaultHasher` instead [INFO] [stderr] --> src/parsers/greedy.rs:45:26 [INFO] [stderr] | [INFO] [stderr] 45 | let mut hasher = SipHasher::new(); [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::hash::SipHasher::new': use `std::collections::hash_map::DefaultHasher` instead [INFO] [stderr] --> src/parsers/set.rs:103:26 [INFO] [stderr] | [INFO] [stderr] 103 | let mut hasher = SipHasher::new(); [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::hash::SipHasher::new': use `std::collections::hash_map::DefaultHasher` instead [INFO] [stderr] --> src/parsers/int.rs:62:26 [INFO] [stderr] | [INFO] [stderr] 62 | let mut hasher = SipHasher::new(); [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::hash::SipHasher::new': use `std::collections::hash_map::DefaultHasher` instead [INFO] [stderr] --> src/parsers/greedy.rs:45:26 [INFO] [stderr] | [INFO] [stderr] 45 | let mut hasher = SipHasher::new(); [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `LiteralEntry` [INFO] [stderr] --> src/matcher/trie/node/mod.rs:11:30 [INFO] [stderr] | [INFO] [stderr] 11 | use self::interface::{Entry, LiteralEntry, ParserEntry}; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `ParserEntry` [INFO] [stderr] --> src/matcher/trie/node/mod.rs:11:44 [INFO] [stderr] | [INFO] [stderr] 11 | use self::interface::{Entry, LiteralEntry, ParserEntry}; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `utils::sortedvec::SortedVec` [INFO] [stderr] --> src/utils/sortedvec.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | / pub fn new() -> SortedVec { [INFO] [stderr] 10 | | SortedVec { array: vec![] } [INFO] [stderr] 11 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 4 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: re-implementing `PartialEq::ne` is unnecessary [INFO] [stderr] --> src/matcher/trie/node/literal.rs:135:5 [INFO] [stderr] | [INFO] [stderr] 135 | / fn ne(&self, other: &Self) -> bool { [INFO] [stderr] 136 | | self.compare_first_chars(other) != Ordering::Equal [INFO] [stderr] 137 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::partialeq_ne_impl)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/matcher/trie/node/interface.rs:34:25 [INFO] [stderr] | [INFO] [stderr] 34 | fn parser(&self) -> &Box; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `&Parser` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::borrowed_box)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/matcher/trie/node/mod.rs:151:16 [INFO] [stderr] | [INFO] [stderr] 151 | if let Some(_) = literal_node.node() { [INFO] [stderr] | _________- ^^^^^^^ [INFO] [stderr] 152 | | trace!("search(): literal len = {}", literal.len()); [INFO] [stderr] 153 | | trace!("search(): common_prefix_len = {}", common_prefix_len); [INFO] [stderr] 154 | | trace!("search(): going deeper"); [INFO] [stderr] ... | [INFO] [stderr] 157 | | unreachable!(); [INFO] [stderr] 158 | | } [INFO] [stderr] | |_________- help: try this: `if literal_node.node().is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: called `.get_mut().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/matcher/trie/node/mod.rs:279:13 [INFO] [stderr] | [INFO] [stderr] 279 | self.parser_children.get_mut(item).unwrap() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `self.parser_children[item]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `map_or(None, f)` on an Option value. This can be done more directly by calling `and_then(f)` instead [INFO] [stderr] --> src/matcher/pattern/pattern.rs:83:9 [INFO] [stderr] | [INFO] [stderr] 83 | self.test_messages.as_mut().map_or(None, |x| x.pop()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try using and_then instead: `self.test_messages.as_mut().and_then(|x| x.pop())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_or_none)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_or_none [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/matcher/pattern_source/mod.rs:56:39 [INFO] [stderr] | [INFO] [stderr] 56 | .ok_or(testmessage::Error::test_message_does_not_match(uuid, [INFO] [stderr] | _______________________________________^ [INFO] [stderr] 57 | | msg))); [INFO] [stderr] | |_________________________________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 56 | .ok_or_else(|| testmessage::Error::test_message_does_not_match(uuid, [INFO] [stderr] 57 | msg))); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/matcher/suffix_array/interface.rs:34:25 [INFO] [stderr] | [INFO] [stderr] 34 | fn parser(&self) -> &Box; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `&Parser` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/matcher/pattern/mod.rs:6:1 [INFO] [stderr] | [INFO] [stderr] 6 | mod pattern; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/matcher/pattern/file/mod.rs:4:1 [INFO] [stderr] | [INFO] [stderr] 4 | mod file; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/matcher/suffix_array/impls.rs:195:20 [INFO] [stderr] | [INFO] [stderr] 195 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 196 | | if value.is_empty() { [INFO] [stderr] 197 | | self.create_match_result(kvpair) [INFO] [stderr] 198 | | } else { [INFO] [stderr] 199 | | None [INFO] [stderr] 200 | | } [INFO] [stderr] 201 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 195 | } else if value.is_empty() { [INFO] [stderr] 196 | self.create_match_result(kvpair) [INFO] [stderr] 197 | } else { [INFO] [stderr] 198 | None [INFO] [stderr] 199 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: lint name `clippy` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/grammar/parser/mod.rs:7:9 [INFO] [stderr] | [INFO] [stderr] 7 | #[allow(clippy)] [INFO] [stderr] | ^^^^^^ help: change it to: `clippy::all` [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::hash::SipHasher': use `std::collections::hash_map::DefaultHasher` instead [INFO] [stderr] --> src/parsers/set.rs:3:17 [INFO] [stderr] | [INFO] [stderr] 3 | use std::hash::{SipHasher, Hash, Hasher}; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::hash::SipHasher': use `std::collections::hash_map::DefaultHasher` instead [INFO] [stderr] --> src/parsers/int.rs:1:17 [INFO] [stderr] | [INFO] [stderr] 1 | use std::hash::{SipHasher, Hash, Hasher}; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::hash::SipHasher': use `std::collections::hash_map::DefaultHasher` instead [INFO] [stderr] --> src/parsers/greedy.rs:1:17 [INFO] [stderr] | [INFO] [stderr] 1 | use std::hash::{SipHasher, Hash, Hasher}; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::hash::SipHasher': use `std::collections::hash_map::DefaultHasher` instead [INFO] [stderr] --> src/parsers/set.rs:103:26 [INFO] [stderr] | [INFO] [stderr] 103 | let mut hasher = SipHasher::new(); [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::hash::SipHasher': use `std::collections::hash_map::DefaultHasher` instead [INFO] [stderr] --> src/parsers/int.rs:62:26 [INFO] [stderr] | [INFO] [stderr] 62 | let mut hasher = SipHasher::new(); [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::hash::SipHasher': use `std::collections::hash_map::DefaultHasher` instead [INFO] [stderr] --> src/parsers/greedy.rs:45:26 [INFO] [stderr] | [INFO] [stderr] 45 | let mut hasher = SipHasher::new(); [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::hash::SipHasher::new': use `std::collections::hash_map::DefaultHasher` instead [INFO] [stderr] --> src/parsers/set.rs:103:26 [INFO] [stderr] | [INFO] [stderr] 103 | let mut hasher = SipHasher::new(); [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::hash::SipHasher::new': use `std::collections::hash_map::DefaultHasher` instead [INFO] [stderr] --> src/parsers/int.rs:62:26 [INFO] [stderr] | [INFO] [stderr] 62 | let mut hasher = SipHasher::new(); [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::hash::SipHasher::new': use `std::collections::hash_map::DefaultHasher` instead [INFO] [stderr] --> src/parsers/greedy.rs:45:26 [INFO] [stderr] | [INFO] [stderr] 45 | let mut hasher = SipHasher::new(); [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `LiteralEntry` [INFO] [stderr] --> src/matcher/trie/node/mod.rs:11:30 [INFO] [stderr] | [INFO] [stderr] 11 | use self::interface::{Entry, LiteralEntry, ParserEntry}; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `ParserEntry` [INFO] [stderr] --> src/matcher/trie/node/mod.rs:11:44 [INFO] [stderr] | [INFO] [stderr] 11 | use self::interface::{Entry, LiteralEntry, ParserEntry}; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `Parser` [INFO] [stderr] --> src/matcher/trie/node/mod.rs:323:19 [INFO] [stderr] | [INFO] [stderr] 323 | use parsers::{Parser, SetParser, IntParser, GreedyParser}; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `ObjectSafeHash` [INFO] [stderr] --> src/grammar/test.rs:2:34 [INFO] [stderr] | [INFO] [stderr] 2 | use parsers::{SetParser, Parser, ObjectSafeHash, IntParser, GreedyParser, HasLengthConstraint}; [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `utils::sortedvec::SortedVec` [INFO] [stderr] --> src/utils/sortedvec.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | / pub fn new() -> SortedVec { [INFO] [stderr] 10 | | SortedVec { array: vec![] } [INFO] [stderr] 11 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 4 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: re-implementing `PartialEq::ne` is unnecessary [INFO] [stderr] --> src/matcher/trie/node/literal.rs:135:5 [INFO] [stderr] | [INFO] [stderr] 135 | / fn ne(&self, other: &Self) -> bool { [INFO] [stderr] 136 | | self.compare_first_chars(other) != Ordering::Equal [INFO] [stderr] 137 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::partialeq_ne_impl)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/matcher/trie/node/interface.rs:34:25 [INFO] [stderr] | [INFO] [stderr] 34 | fn parser(&self) -> &Box; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `&Parser` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::borrowed_box)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/matcher/trie/node/mod.rs:151:16 [INFO] [stderr] | [INFO] [stderr] 151 | if let Some(_) = literal_node.node() { [INFO] [stderr] | _________- ^^^^^^^ [INFO] [stderr] 152 | | trace!("search(): literal len = {}", literal.len()); [INFO] [stderr] 153 | | trace!("search(): common_prefix_len = {}", common_prefix_len); [INFO] [stderr] 154 | | trace!("search(): going deeper"); [INFO] [stderr] ... | [INFO] [stderr] 157 | | unreachable!(); [INFO] [stderr] 158 | | } [INFO] [stderr] | |_________- help: try this: `if literal_node.node().is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: called `.get_mut().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/matcher/trie/node/mod.rs:279:13 [INFO] [stderr] | [INFO] [stderr] 279 | self.parser_children.get_mut(item).unwrap() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `self.parser_children[item]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `map_or(None, f)` on an Option value. This can be done more directly by calling `and_then(f)` instead [INFO] [stderr] --> src/matcher/pattern/pattern.rs:83:9 [INFO] [stderr] | [INFO] [stderr] 83 | self.test_messages.as_mut().map_or(None, |x| x.pop()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try using and_then instead: `self.test_messages.as_mut().and_then(|x| x.pop())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_or_none)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_or_none [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/matcher/pattern_source/mod.rs:56:39 [INFO] [stderr] | [INFO] [stderr] 56 | .ok_or(testmessage::Error::test_message_does_not_match(uuid, [INFO] [stderr] | _______________________________________^ [INFO] [stderr] 57 | | msg))); [INFO] [stderr] | |_________________________________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 56 | .ok_or_else(|| testmessage::Error::test_message_does_not_match(uuid, [INFO] [stderr] 57 | msg))); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/matcher/suffix_array/interface.rs:34:25 [INFO] [stderr] | [INFO] [stderr] 34 | fn parser(&self) -> &Box; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `&Parser` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/grammar/test.rs:162:45 [INFO] [stderr] | [INFO] [stderr] 162 | if let TokenType::Parser(ref parser) = *vec.get(1).unwrap() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try this: `&vec[1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> tests/file/mod.rs:6:20 [INFO] [stderr] | [INFO] [stderr] 6 | const DIR_PREFIX: &'static str = "tests/file"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> tests/file/mod.rs:13:16 [INFO] [stderr] | [INFO] [stderr] 13 | let file = PatternLoader::load_file(&file_name) [INFO] [stderr] | ________________^ [INFO] [stderr] 14 | | .ok() [INFO] [stderr] 15 | | .expect("Failed to load JSON serialized Pattern"); [INFO] [stderr] | |____________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ok_expect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> tests/file/mod.rs:46:16 [INFO] [stderr] | [INFO] [stderr] 46 | let file = PatternLoader::load_file("tests/file/ssh_ok.yaml") [INFO] [stderr] | ________________^ [INFO] [stderr] 47 | | .ok() [INFO] [stderr] 48 | | .expect("Failed to load YAML serialized pattern file"); [INFO] [stderr] | |_________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> tests/matcher/mod.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | matcher.ok().expect("Failed to create a Matched from a valid JSON pattern file"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> tests/matcher/mod.rs:37:5 [INFO] [stderr] | [INFO] [stderr] 37 | matcher.ok().expect("Failed to create a Matcher from a valid JSON pattern file"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> tests/matcher/mod.rs:63:5 [INFO] [stderr] | [INFO] [stderr] 63 | matcher.ok().expect("We should only check the expected tags"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> tests/matcher/mod.rs:79:13 [INFO] [stderr] | [INFO] [stderr] 79 | let _ = matcher.ok().expect("We should be able to create a Matcher when a pattern has a CR \ [INFO] [stderr] | _____________^ [INFO] [stderr] 80 | | characer in it"); [INFO] [stderr] | |_________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 6.58s [INFO] running `"docker" "inspect" "dbbd51baf67cd5a9288134bf0a2fe3ecb1531b86f2b2700bd64d2cffbf8a6a69"` [INFO] running `"docker" "rm" "-f" "dbbd51baf67cd5a9288134bf0a2fe3ecb1531b86f2b2700bd64d2cffbf8a6a69"` [INFO] [stdout] dbbd51baf67cd5a9288134bf0a2fe3ecb1531b86f2b2700bd64d2cffbf8a6a69