[INFO] crate act 0.1.1 is already in cache [INFO] extracting crate act 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/act/0.1.1 [INFO] extracting crate act 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/act/0.1.1 [INFO] validating manifest of act-0.1.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of act-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing act-0.1.1 [INFO] finished frobbing act-0.1.1 [INFO] frobbed toml for act-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/act/0.1.1/Cargo.toml [INFO] started frobbing act-0.1.1 [INFO] finished frobbing act-0.1.1 [INFO] frobbed toml for act-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/act/0.1.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting act-0.1.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/act/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 4a8f11847f58735395dc9f2ccfd6a72e30f8b88b279d302af3b11602afccc878 [INFO] running `"docker" "start" "-a" "4a8f11847f58735395dc9f2ccfd6a72e30f8b88b279d302af3b11602afccc878"` [INFO] [stderr] Checking act v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/lib.rs:159:9 [INFO] [stderr] | [INFO] [stderr] 159 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/lib.rs:163:9 [INFO] [stderr] | [INFO] [stderr] 163 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> src/lib.rs:173:9 [INFO] [stderr] | [INFO] [stderr] 173 | / print!(" [INFO] [stderr] 174 | | _/ _// _//! _//!//! [INFO] [stderr] 175 | | _/ // _// _// _// [INFO] [stderr] 176 | | _/ _// _// _// [INFO] [stderr] ... | [INFO] [stderr] 180 | | _// _// _//!/ _// [INFO] [stderr] 181 | | \n"); [INFO] [stderr] | |____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:241:17 [INFO] [stderr] | [INFO] [stderr] 241 | character: character [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `character` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/lib.rs:159:9 [INFO] [stderr] | [INFO] [stderr] 159 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/lib.rs:163:9 [INFO] [stderr] | [INFO] [stderr] 163 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> src/lib.rs:173:9 [INFO] [stderr] | [INFO] [stderr] 173 | / print!(" [INFO] [stderr] 174 | | _/ _// _//! _//!//! [INFO] [stderr] 175 | | _/ // _// _// _// [INFO] [stderr] 176 | | _/ _// _// _// [INFO] [stderr] ... | [INFO] [stderr] 180 | | _// _// _//!/ _// [INFO] [stderr] 181 | | \n"); [INFO] [stderr] | |____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:241:17 [INFO] [stderr] | [INFO] [stderr] 241 | character: character [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `character` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused macro definition [INFO] [stderr] --> src/lib.rs:82:1 [INFO] [stderr] | [INFO] [stderr] 82 | / macro_rules! try_opt_res { [INFO] [stderr] 83 | | ($o:expr) => { [INFO] [stderr] 84 | | match $o { [INFO] [stderr] 85 | | Ok(x) => x, [INFO] [stderr] ... | [INFO] [stderr] 88 | | } [INFO] [stderr] 89 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_macros)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::io` [INFO] [stderr] --> src/lib.rs:225:17 [INFO] [stderr] | [INFO] [stderr] 225 | use std::io; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/lib.rs:113:9 [INFO] [stderr] | [INFO] [stderr] 113 | / match &self { [INFO] [stderr] 114 | | &&Action::PickUp(ref s,_,_) => s.clone(), [INFO] [stderr] 115 | | &&Action::Move(ref s,_,_) => s.clone() [INFO] [stderr] 116 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 113 | match self { [INFO] [stderr] 114 | &Action::PickUp(ref s,_,_) => s.clone(), [INFO] [stderr] 115 | &Action::Move(ref s,_,_) => s.clone() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lib.rs:187:21 [INFO] [stderr] | [INFO] [stderr] 187 | let r = rooms.get(&self.character.room).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&rooms[&self.character.room]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.iter().nth()` on a Vec. Calling `.get()` is both faster and more readable [INFO] [stderr] --> src/lib.rs:195:35 [INFO] [stderr] | [INFO] [stderr] 195 | let a = match r.actions.iter().nth(u as usize) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::iter_nth)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_nth [INFO] [stderr] [INFO] [stderr] warning: unused macro definition [INFO] [stderr] --> src/lib.rs:82:1 [INFO] [stderr] | [INFO] [stderr] 82 | / macro_rules! try_opt_res { [INFO] [stderr] 83 | | ($o:expr) => { [INFO] [stderr] 84 | | match $o { [INFO] [stderr] 85 | | Ok(x) => x, [INFO] [stderr] ... | [INFO] [stderr] 88 | | } [INFO] [stderr] 89 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_macros)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::io` [INFO] [stderr] --> src/lib.rs:225:17 [INFO] [stderr] | [INFO] [stderr] 225 | use std::io; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/lib.rs:113:9 [INFO] [stderr] | [INFO] [stderr] 113 | / match &self { [INFO] [stderr] 114 | | &&Action::PickUp(ref s,_,_) => s.clone(), [INFO] [stderr] 115 | | &&Action::Move(ref s,_,_) => s.clone() [INFO] [stderr] 116 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 113 | match self { [INFO] [stderr] 114 | &Action::PickUp(ref s,_,_) => s.clone(), [INFO] [stderr] 115 | &Action::Move(ref s,_,_) => s.clone() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lib.rs:187:21 [INFO] [stderr] | [INFO] [stderr] 187 | let r = rooms.get(&self.character.room).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&rooms[&self.character.room]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.iter().nth()` on a Vec. Calling `.get()` is both faster and more readable [INFO] [stderr] --> src/lib.rs:195:35 [INFO] [stderr] | [INFO] [stderr] 195 | let a = match r.actions.iter().nth(u as usize) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::iter_nth)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_nth [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.82s [INFO] running `"docker" "inspect" "4a8f11847f58735395dc9f2ccfd6a72e30f8b88b279d302af3b11602afccc878"` [INFO] running `"docker" "rm" "-f" "4a8f11847f58735395dc9f2ccfd6a72e30f8b88b279d302af3b11602afccc878"` [INFO] [stdout] 4a8f11847f58735395dc9f2ccfd6a72e30f8b88b279d302af3b11602afccc878