[INFO] crate acetylene_parser 0.1.0 is already in cache [INFO] extracting crate acetylene_parser 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/acetylene_parser/0.1.0 [INFO] extracting crate acetylene_parser 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/acetylene_parser/0.1.0 [INFO] validating manifest of acetylene_parser-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of acetylene_parser-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing acetylene_parser-0.1.0 [INFO] finished frobbing acetylene_parser-0.1.0 [INFO] frobbed toml for acetylene_parser-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/acetylene_parser/0.1.0/Cargo.toml [INFO] started frobbing acetylene_parser-0.1.0 [INFO] finished frobbing acetylene_parser-0.1.0 [INFO] frobbed toml for acetylene_parser-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/acetylene_parser/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting acetylene_parser-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/acetylene_parser/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 2821aa787f5a21dd55833588bd9adaff535c9c1261c347952435817c17510e27 [INFO] running `"docker" "start" "-a" "2821aa787f5a21dd55833588bd9adaff535c9c1261c347952435817c17510e27"` [INFO] [stderr] Checking acetylene_parser v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused import: `smiles::tokenize_smiles_raw` [INFO] [stderr] --> src/smiles/mod.rs:466:7 [INFO] [stderr] | [INFO] [stderr] 466 | use smiles::tokenize_smiles_raw; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/formula/mod.rs:165:6 [INFO] [stderr] | [INFO] [stderr] 165 | if groups_vec.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!groups_vec.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/smiles/mod.rs:25:39 [INFO] [stderr] | [INFO] [stderr] 25 | fn closures_closed(closure_pos_queue: &Vec) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: change this to: `&[ClosureDict]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/smiles/mod.rs:39:22 [INFO] [stderr] | [INFO] [stderr] 39 | if chg.starts_with("+") { // positive charge case [INFO] [stderr] | ^^^ help: try using a char instead: `'+'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/smiles/mod.rs:40:22 [INFO] [stderr] | [INFO] [stderr] 40 | if chg.ends_with("+") { // case of a string of pluses [INFO] [stderr] | ^^^ help: try using a char instead: `'+'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/smiles/mod.rs:45:29 [INFO] [stderr] | [INFO] [stderr] 45 | } else if chg.starts_with("-") { // negative charge case [INFO] [stderr] | ^^^ help: try using a char instead: `'-'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/smiles/mod.rs:46:22 [INFO] [stderr] | [INFO] [stderr] 46 | if chg.ends_with("-") { // case of a string of minuses [INFO] [stderr] | ^^^ help: try using a char instead: `'-'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: Negation by multiplying with -1 [INFO] [stderr] --> src/smiles/mod.rs:47:7 [INFO] [stderr] | [INFO] [stderr] 47 | chg.len() as i32 * (-1) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::neg_multiply)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_multiply [INFO] [stderr] [INFO] [stderr] warning: Negation by multiplying with -1 [INFO] [stderr] --> src/smiles/mod.rs:49:7 [INFO] [stderr] | [INFO] [stderr] 49 | i32::from_str(&chg[1..chg.len()]).unwrap() * (-1) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_multiply [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/smiles/mod.rs:247:41 [INFO] [stderr] | [INFO] [stderr] 247 | let mut expected_states: &Vec<&str> = allowed_states.get("start").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&allowed_states["start"]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/smiles/mod.rs:340:5 [INFO] [stderr] | [INFO] [stderr] 340 | / let mut sub_charge = None; [INFO] [stderr] 341 | | if &earliest_capture.1.len() == &input.len(){ [INFO] [stderr] 342 | | // is length comparison faster than value comparison? [INFO] [stderr] 343 | | sub_charge = earliest_capture.3; [INFO] [stderr] 344 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let sub_charge = if &earliest_capture.1.len() == &input.len() { earliest_capture.3 } else { None };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/smiles/mod.rs:262:25 [INFO] [stderr] | [INFO] [stderr] 262 | let cur_regex_set = state_regex_dict.get(found_state).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&state_regex_dict[found_state]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/smiles/mod.rs:293:19 [INFO] [stderr] | [INFO] [stderr] 293 | let captures: Vec<((usize, usize), &str, &str, Option)> = ok_states.iter() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/smiles/mod.rs:306:11 [INFO] [stderr] | [INFO] [stderr] 306 | / let mut charge = None; [INFO] [stderr] 307 | | if state_name == "atom" { [INFO] [stderr] 308 | | charge = cur_captures.name("charge").and_then(|charge| { [INFO] [stderr] 309 | | Some(count_charges(charge)) [INFO] [stderr] 310 | | }); [INFO] [stderr] 311 | | } [INFO] [stderr] | |___________^ [INFO] [stderr] | [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] help: it is more idiomatic to write [INFO] [stderr] | [INFO] [stderr] 306 | let charge = if state_name == "atom" { cur_captures.name("charge").and_then(|charge| { [INFO] [stderr] 307 | Some(count_charges(charge)) [INFO] [stderr] 308 | }) } else { None }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/smiles/mod.rs:341:8 [INFO] [stderr] | [INFO] [stderr] 341 | if &earliest_capture.1.len() == &input.len(){ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 341 | if earliest_capture.1.len() == input.len(){ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/smiles/mod.rs:348:23 [INFO] [stderr] | [INFO] [stderr] 348 | expected_states = allowed_states.get(found_state).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&allowed_states[found_state]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/smiles/mod.rs:351:5 [INFO] [stderr] | [INFO] [stderr] 351 | cur_char_ind = (earliest_capture.0).1 + cur_char_ind; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `cur_char_ind += (earliest_capture.0).1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/smiles/mod.rs:377:13 [INFO] [stderr] | [INFO] [stderr] 377 | symbol: String::from(input[0].val.to_owned()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `input[0].val.to_owned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/smiles/mod.rs:399:12 [INFO] [stderr] | [INFO] [stderr] 399 | if closure_pos_queue.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!closure_pos_queue.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `Box>`. Consider using just `Vec` [INFO] [stderr] --> src/types/mod.rs:37:22 [INFO] [stderr] | [INFO] [stderr] 37 | pub groups: Option>> [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::box_vec)] on by default [INFO] [stderr] = help: `Vec` is already on the heap, `Box>` makes an extra allocation. [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#box_vec [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/formula/mod.rs:165:6 [INFO] [stderr] | [INFO] [stderr] 165 | if groups_vec.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!groups_vec.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/smiles/mod.rs:25:39 [INFO] [stderr] | [INFO] [stderr] 25 | fn closures_closed(closure_pos_queue: &Vec) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: change this to: `&[ClosureDict]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/smiles/mod.rs:39:22 [INFO] [stderr] | [INFO] [stderr] 39 | if chg.starts_with("+") { // positive charge case [INFO] [stderr] | ^^^ help: try using a char instead: `'+'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/smiles/mod.rs:40:22 [INFO] [stderr] | [INFO] [stderr] 40 | if chg.ends_with("+") { // case of a string of pluses [INFO] [stderr] | ^^^ help: try using a char instead: `'+'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/smiles/mod.rs:45:29 [INFO] [stderr] | [INFO] [stderr] 45 | } else if chg.starts_with("-") { // negative charge case [INFO] [stderr] | ^^^ help: try using a char instead: `'-'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/smiles/mod.rs:46:22 [INFO] [stderr] | [INFO] [stderr] 46 | if chg.ends_with("-") { // case of a string of minuses [INFO] [stderr] | ^^^ help: try using a char instead: `'-'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: Negation by multiplying with -1 [INFO] [stderr] --> src/smiles/mod.rs:47:7 [INFO] [stderr] | [INFO] [stderr] 47 | chg.len() as i32 * (-1) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::neg_multiply)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_multiply [INFO] [stderr] [INFO] [stderr] warning: Negation by multiplying with -1 [INFO] [stderr] --> src/smiles/mod.rs:49:7 [INFO] [stderr] | [INFO] [stderr] 49 | i32::from_str(&chg[1..chg.len()]).unwrap() * (-1) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_multiply [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/smiles/mod.rs:247:41 [INFO] [stderr] | [INFO] [stderr] 247 | let mut expected_states: &Vec<&str> = allowed_states.get("start").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&allowed_states["start"]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/smiles/mod.rs:340:5 [INFO] [stderr] | [INFO] [stderr] 340 | / let mut sub_charge = None; [INFO] [stderr] 341 | | if &earliest_capture.1.len() == &input.len(){ [INFO] [stderr] 342 | | // is length comparison faster than value comparison? [INFO] [stderr] 343 | | sub_charge = earliest_capture.3; [INFO] [stderr] 344 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let sub_charge = if &earliest_capture.1.len() == &input.len() { earliest_capture.3 } else { None };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/smiles/mod.rs:262:25 [INFO] [stderr] | [INFO] [stderr] 262 | let cur_regex_set = state_regex_dict.get(found_state).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&state_regex_dict[found_state]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/smiles/mod.rs:293:19 [INFO] [stderr] | [INFO] [stderr] 293 | let captures: Vec<((usize, usize), &str, &str, Option)> = ok_states.iter() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/smiles/mod.rs:306:11 [INFO] [stderr] | [INFO] [stderr] 306 | / let mut charge = None; [INFO] [stderr] 307 | | if state_name == "atom" { [INFO] [stderr] 308 | | charge = cur_captures.name("charge").and_then(|charge| { [INFO] [stderr] 309 | | Some(count_charges(charge)) [INFO] [stderr] 310 | | }); [INFO] [stderr] 311 | | } [INFO] [stderr] | |___________^ [INFO] [stderr] | [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] help: it is more idiomatic to write [INFO] [stderr] | [INFO] [stderr] 306 | let charge = if state_name == "atom" { cur_captures.name("charge").and_then(|charge| { [INFO] [stderr] 307 | Some(count_charges(charge)) [INFO] [stderr] 308 | }) } else { None }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/smiles/mod.rs:341:8 [INFO] [stderr] | [INFO] [stderr] 341 | if &earliest_capture.1.len() == &input.len(){ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 341 | if earliest_capture.1.len() == input.len(){ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/smiles/mod.rs:348:23 [INFO] [stderr] | [INFO] [stderr] 348 | expected_states = allowed_states.get(found_state).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&allowed_states[found_state]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/smiles/mod.rs:351:5 [INFO] [stderr] | [INFO] [stderr] 351 | cur_char_ind = (earliest_capture.0).1 + cur_char_ind; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `cur_char_ind += (earliest_capture.0).1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/smiles/mod.rs:377:13 [INFO] [stderr] | [INFO] [stderr] 377 | symbol: String::from(input[0].val.to_owned()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `input[0].val.to_owned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/smiles/mod.rs:399:12 [INFO] [stderr] | [INFO] [stderr] 399 | if closure_pos_queue.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!closure_pos_queue.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `Box>`. Consider using just `Vec` [INFO] [stderr] --> src/types/mod.rs:37:22 [INFO] [stderr] | [INFO] [stderr] 37 | pub groups: Option>> [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::box_vec)] on by default [INFO] [stderr] = help: `Vec` is already on the heap, `Box>` makes an extra allocation. [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#box_vec [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 6.49s [INFO] running `"docker" "inspect" "2821aa787f5a21dd55833588bd9adaff535c9c1261c347952435817c17510e27"` [INFO] running `"docker" "rm" "-f" "2821aa787f5a21dd55833588bd9adaff535c9c1261c347952435817c17510e27"` [INFO] [stdout] 2821aa787f5a21dd55833588bd9adaff535c9c1261c347952435817c17510e27