[INFO] crate accord 0.2.2 is already in cache [INFO] extracting crate accord 0.2.2 into work/ex/clippy-test-run/sources/stable/reg/accord/0.2.2 [INFO] extracting crate accord 0.2.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/accord/0.2.2 [INFO] validating manifest of accord-0.2.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of accord-0.2.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing accord-0.2.2 [INFO] finished frobbing accord-0.2.2 [INFO] frobbed toml for accord-0.2.2 written to work/ex/clippy-test-run/sources/stable/reg/accord/0.2.2/Cargo.toml [INFO] started frobbing accord-0.2.2 [INFO] finished frobbing accord-0.2.2 [INFO] frobbed toml for accord-0.2.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/accord/0.2.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting accord-0.2.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/accord/0.2.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 2dbcea4aa18be98993668ec6f7fbf8fc0ed4909c70632f56a817f55c048b60dd [INFO] running `"docker" "start" "-a" "2dbcea4aa18be98993668ec6f7fbf8fc0ed4909c70632f56a817f55c048b60dd"` [INFO] [stderr] Compiling accord v0.2.2 (/opt/crater/workdir) [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/validators.rs:152:12 [INFO] [stderr] | [INFO] [stderr] 152 | if r == true { [INFO] [stderr] | ^^^^^^^^^ help: try simplifying it as shown: `r` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1` [INFO] [stderr] --> /opt/crater/target/debug/build/accord-2048ce765e45ffe2/out/serde_types.rs:15:38 [INFO] [stderr] | [INFO] [stderr] 15 | "Invalid" , 0 + 1 + 1 )); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1` [INFO] [stderr] --> /opt/crater/target/debug/build/accord-2048ce765e45ffe2/out/serde_types.rs:40:46 [INFO] [stderr] | [INFO] [stderr] 40 | "MultipleInvalid" , 0 + 1 + 1 )); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/validators.rs:152:12 [INFO] [stderr] | [INFO] [stderr] 152 | if r == true { [INFO] [stderr] | ^^^^^^^^^ help: try simplifying it as shown: `r` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1` [INFO] [stderr] --> /opt/crater/target/debug/build/accord-2048ce765e45ffe2/out/serde_types.rs:15:38 [INFO] [stderr] | [INFO] [stderr] 15 | "Invalid" , 0 + 1 + 1 )); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1` [INFO] [stderr] --> /opt/crater/target/debug/build/accord-2048ce765e45ffe2/out/serde_types.rs:40:46 [INFO] [stderr] | [INFO] [stderr] 40 | "MultipleInvalid" , 0 + 1 + 1 )); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 6.98s [INFO] running `"docker" "inspect" "2dbcea4aa18be98993668ec6f7fbf8fc0ed4909c70632f56a817f55c048b60dd"` [INFO] running `"docker" "rm" "-f" "2dbcea4aa18be98993668ec6f7fbf8fc0ed4909c70632f56a817f55c048b60dd"` [INFO] [stdout] 2dbcea4aa18be98993668ec6f7fbf8fc0ed4909c70632f56a817f55c048b60dd