[INFO] crate acacia 0.1.2 is already in cache [INFO] extracting crate acacia 0.1.2 into work/ex/clippy-test-run/sources/stable/reg/acacia/0.1.2 [INFO] extracting crate acacia 0.1.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/acacia/0.1.2 [INFO] validating manifest of acacia-0.1.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of acacia-0.1.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing acacia-0.1.2 [INFO] finished frobbing acacia-0.1.2 [INFO] frobbed toml for acacia-0.1.2 written to work/ex/clippy-test-run/sources/stable/reg/acacia/0.1.2/Cargo.toml [INFO] started frobbing acacia-0.1.2 [INFO] finished frobbing acacia-0.1.2 [INFO] frobbed toml for acacia-0.1.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/acacia/0.1.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting acacia-0.1.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/acacia/0.1.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 419a28f7c61ea75c315003bf065ad6f18b019c5f0aa634f2d4fff1679b2e3123 [INFO] running `"docker" "start" "-a" "419a28f7c61ea75c315003bf065ad6f18b019c5f0aa634f2d4fff1679b2e3123"` [INFO] [stderr] Checking nalgebra v0.10.1 [INFO] [stderr] Checking acacia v0.1.2 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/partition/interval.rs:21:20 [INFO] [stderr] | [INFO] [stderr] 21 | Interval { start: start, end: end } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `start` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/partition/interval.rs:21:34 [INFO] [stderr] | [INFO] [stderr] 21 | Interval { start: start, end: end } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `end` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/partition/ncube.rs:23:17 [INFO] [stderr] | [INFO] [stderr] 23 | Ncube { center: center, width: width } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `center` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/partition/ncube.rs:23:33 [INFO] [stderr] | [INFO] [stderr] 23 | Ncube { center: center, width: width } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: consider choosing a more descriptive name [INFO] [stderr] --> src/partition/ncube.rs:42:13 [INFO] [stderr] | [INFO] [stderr] 42 | let _2 = NumCast::from(2.0f64).unwrap(); [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::just_underscores_and_digits)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stderr] [INFO] [stderr] warning: consider choosing a more descriptive name [INFO] [stderr] --> src/partition/ncube.rs:70:13 [INFO] [stderr] | [INFO] [stderr] 70 | let _2 = NumCast::from(2.0f64).unwrap(); [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/partition/unitquad.rs:23:20 [INFO] [stderr] | [INFO] [stderr] 23 | UnitQuad { scale: scale, offset: offset } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `scale` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/partition/unitquad.rs:23:34 [INFO] [stderr] | [INFO] [stderr] 23 | UnitQuad { scale: scale, offset: offset } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `offset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: consider choosing a more descriptive name [INFO] [stderr] --> src/partition/cubemap.rs:68:9 [INFO] [stderr] | [INFO] [stderr] 68 | let _0: T = zero(); [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stderr] [INFO] [stderr] warning: consider choosing a more descriptive name [INFO] [stderr] --> src/partition/cubemap.rs:109:13 [INFO] [stderr] | [INFO] [stderr] 109 | let _1: T = one(); [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stderr] [INFO] [stderr] warning: consider choosing a more descriptive name [INFO] [stderr] --> src/partition/cubemap.rs:110:13 [INFO] [stderr] | [INFO] [stderr] 110 | let _2: T = _1 + _1; [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stderr] [INFO] [stderr] warning: consider choosing a more descriptive name [INFO] [stderr] --> src/partition/cubemap.rs:141:13 [INFO] [stderr] | [INFO] [stderr] 141 | let _1: T = one(); [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stderr] [INFO] [stderr] warning: consider choosing a more descriptive name [INFO] [stderr] --> src/partition/cubemap.rs:142:13 [INFO] [stderr] | [INFO] [stderr] 142 | let _2: T = _1 + _1; [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pure_tree.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | partition: partition, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `partition` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/data_tree.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | partition: partition, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `partition` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/data_tree.rs:27:13 [INFO] [stderr] | [INFO] [stderr] 27 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/iter.rs:53:50 [INFO] [stderr] | [INFO] [stderr] 53 | RecurseObjects { nodes: vec![(0, tree)], recurse: recurse } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `recurse` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/iter.rs:95:50 [INFO] [stderr] | [INFO] [stderr] 95 | RecurseData { nodes: vec![(None, tree)], recurse: recurse } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `recurse` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/partition/interval.rs:21:20 [INFO] [stderr] | [INFO] [stderr] 21 | Interval { start: start, end: end } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `start` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/partition/interval.rs:21:34 [INFO] [stderr] | [INFO] [stderr] 21 | Interval { start: start, end: end } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `end` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/partition/ncube.rs:23:17 [INFO] [stderr] | [INFO] [stderr] 23 | Ncube { center: center, width: width } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `center` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/partition/ncube.rs:23:33 [INFO] [stderr] | [INFO] [stderr] 23 | Ncube { center: center, width: width } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: consider choosing a more descriptive name [INFO] [stderr] --> src/partition/ncube.rs:42:13 [INFO] [stderr] | [INFO] [stderr] 42 | let _2 = NumCast::from(2.0f64).unwrap(); [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::just_underscores_and_digits)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stderr] [INFO] [stderr] warning: consider choosing a more descriptive name [INFO] [stderr] --> src/partition/ncube.rs:70:13 [INFO] [stderr] | [INFO] [stderr] 70 | let _2 = NumCast::from(2.0f64).unwrap(); [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/partition/unitquad.rs:23:20 [INFO] [stderr] | [INFO] [stderr] 23 | UnitQuad { scale: scale, offset: offset } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `scale` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/partition/unitquad.rs:23:34 [INFO] [stderr] | [INFO] [stderr] 23 | UnitQuad { scale: scale, offset: offset } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `offset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: consider choosing a more descriptive name [INFO] [stderr] --> src/partition/cubemap.rs:68:9 [INFO] [stderr] | [INFO] [stderr] 68 | let _0: T = zero(); [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stderr] [INFO] [stderr] warning: consider choosing a more descriptive name [INFO] [stderr] --> src/partition/cubemap.rs:109:13 [INFO] [stderr] | [INFO] [stderr] 109 | let _1: T = one(); [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stderr] [INFO] [stderr] warning: consider choosing a more descriptive name [INFO] [stderr] --> src/partition/cubemap.rs:110:13 [INFO] [stderr] | [INFO] [stderr] 110 | let _2: T = _1 + _1; [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stderr] [INFO] [stderr] warning: consider choosing a more descriptive name [INFO] [stderr] --> src/partition/cubemap.rs:141:13 [INFO] [stderr] | [INFO] [stderr] 141 | let _1: T = one(); [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stderr] [INFO] [stderr] warning: consider choosing a more descriptive name [INFO] [stderr] --> src/partition/cubemap.rs:142:13 [INFO] [stderr] | [INFO] [stderr] 142 | let _2: T = _1 + _1; [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pure_tree.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | partition: partition, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `partition` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/data_tree.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | partition: partition, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `partition` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/data_tree.rs:27:13 [INFO] [stderr] | [INFO] [stderr] 27 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/iter.rs:53:50 [INFO] [stderr] | [INFO] [stderr] 53 | RecurseObjects { nodes: vec![(0, tree)], recurse: recurse } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `recurse` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/iter.rs:95:50 [INFO] [stderr] | [INFO] [stderr] 95 | RecurseData { nodes: vec![(None, tree)], recurse: recurse } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `recurse` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused macro definition [INFO] [stderr] --> src/partition/mod.rs:97:1 [INFO] [stderr] | [INFO] [stderr] 97 | / macro_rules! partition_quickcheck ( [INFO] [stderr] 98 | | ($testfn: ident, $p: ty, $t: ty) => ( [INFO] [stderr] 99 | | mod $testfn { [INFO] [stderr] 100 | | use $crate::partition::{ [INFO] [stderr] ... | [INFO] [stderr] 122 | | ) [INFO] [stderr] 123 | | ); [INFO] [stderr] | |__^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_macros)] on by default [INFO] [stderr] [INFO] [stderr] error[E0554]: #![feature] may not be used on the stable release channel [INFO] [stderr] --> src/lib.rs:4:19 [INFO] [stderr] | [INFO] [stderr] 4 | #![cfg_attr(test, feature(test))] [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0554`. [INFO] [stderr] error: Could not compile `acacia`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: the loop variable `i` is used to index `new_center` [INFO] [stderr] --> src/partition/ncube.rs:49:26 [INFO] [stderr] | [INFO] [stderr] 49 | for i in 0..dimension { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 49 | for (i, ) in new_center.iter_mut().enumerate().take(dimension) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/partition/ncube.rs:50:21 [INFO] [stderr] | [INFO] [stderr] 50 | / new_center[i] = new_center[i] + match n / 2.pow(i as u32) % 2 { [INFO] [stderr] 51 | | 0 => -dx, [INFO] [stderr] 52 | | 1 => dx, [INFO] [stderr] 53 | | _ => unreachable!(), [INFO] [stderr] 54 | | }; [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] help: replace it with [INFO] [stderr] | [INFO] [stderr] 50 | new_center[i] += match n / 2.pow(i as u32) % 2 { [INFO] [stderr] 51 | 0 => -dx, [INFO] [stderr] 52 | 1 => dx, [INFO] [stderr] 53 | _ => unreachable!(), [INFO] [stderr] 54 | }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/partition/ncube.rs:80:68 [INFO] [stderr] | [INFO] [stderr] 80 | .map(|k| if elem[k] < self.center[k] {0} else {1 << k}) [INFO] [stderr] | ____________________________________________________________________^ [INFO] [stderr] 81 | | .fold(0, |a, b| a + b) [INFO] [stderr] | |__________________________________^ help: try: `.sum()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_fold)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/partition/unitquad.rs:21:32 [INFO] [stderr] | [INFO] [stderr] 21 | let max_offset = 2.pow(scale as u32); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u32::from(scale)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/partition/unitquad.rs:50:57 [INFO] [stderr] | [INFO] [stderr] 50 | Float::powi(::from(0.5).unwrap(), self.scale as i32) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `i32::from(self.scale)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/partition/cubemap.rs:206:50 [INFO] [stderr] | [INFO] [stderr] 206 | quad.subdivide().into_iter().map(|q| CubeMap::Quad(q)).collect(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `CubeMap::Quad` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/pure_tree.rs:58:26 [INFO] [stderr] | [INFO] [stderr] 58 | .map(|p| PureTree::empty(p)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `PureTree::empty` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/traits.rs:80:5 [INFO] [stderr] | [INFO] [stderr] 80 | / fn query_objects<'a, R>(&'a self, recurse: R) -> RecurseObjects<'a, Self, R> [INFO] [stderr] 81 | | where R: Fn(&Self) -> bool; [INFO] [stderr] | |___________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/traits.rs:87:5 [INFO] [stderr] | [INFO] [stderr] 87 | / fn query_objects<'a, R>(&'a self, recurse: R) -> RecurseObjects<'a, Self, R> [INFO] [stderr] 88 | | where R: Fn(&T) -> bool [INFO] [stderr] 89 | | { [INFO] [stderr] 90 | | RecurseObjects::new(self, recurse) [INFO] [stderr] 91 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/traits.rs:124:5 [INFO] [stderr] | [INFO] [stderr] 124 | / fn query_data<'a, R>(&'a self, recurse: R) -> RecurseData<'a, Self, R> [INFO] [stderr] 125 | | where R: Fn(&Self) -> bool; [INFO] [stderr] | |___________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/traits.rs:131:5 [INFO] [stderr] | [INFO] [stderr] 131 | / fn query_data<'a, R>(&'a self, recurse: R) -> RecurseData<'a, T, R> [INFO] [stderr] 132 | | where R: Fn(&Self) -> bool [INFO] [stderr] 133 | | { [INFO] [stderr] 134 | | RecurseData::new(self, recurse) [INFO] [stderr] 135 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "419a28f7c61ea75c315003bf065ad6f18b019c5f0aa634f2d4fff1679b2e3123"` [INFO] running `"docker" "rm" "-f" "419a28f7c61ea75c315003bf065ad6f18b019c5f0aa634f2d4fff1679b2e3123"` [INFO] [stdout] 419a28f7c61ea75c315003bf065ad6f18b019c5f0aa634f2d4fff1679b2e3123