[INFO] crate abstract-ns 0.4.3 is already in cache
[INFO] extracting crate abstract-ns 0.4.3 into work/ex/clippy-test-run/sources/stable/reg/abstract-ns/0.4.3
[INFO] extracting crate abstract-ns 0.4.3 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/abstract-ns/0.4.3
[INFO] validating manifest of abstract-ns-0.4.3 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of abstract-ns-0.4.3 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing abstract-ns-0.4.3
[INFO] finished frobbing abstract-ns-0.4.3
[INFO] frobbed toml for abstract-ns-0.4.3 written to work/ex/clippy-test-run/sources/stable/reg/abstract-ns/0.4.3/Cargo.toml
[INFO] started frobbing abstract-ns-0.4.3
[INFO] finished frobbing abstract-ns-0.4.3
[INFO] frobbed toml for abstract-ns-0.4.3 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/abstract-ns/0.4.3/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting abstract-ns-0.4.3 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/abstract-ns/0.4.3:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] d3cf99835eb2779e311cc5587bf4b0d479d2d2e53d429f0df5e4d2914ac295ed
[INFO] running `"docker" "start" "-a" "d3cf99835eb2779e311cc5587bf4b0d479d2d2e53d429f0df5e4d2914ac295ed"`
[INFO] [stderr]     Checking abstract-ns v0.4.3 (/opt/crater/workdir)
[INFO] [stderr]     Checking tokio-core v0.1.17
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/addr.rs:146:9
[INFO] [stderr]     |
[INFO] [stderr] 146 | /         return Builder {
[INFO] [stderr] 147 | |             addresses: vec![Vec::new()],
[INFO] [stderr] 148 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]     |
[INFO] [stderr] 146 |         Builder {
[INFO] [stderr] 147 |             addresses: vec![Vec::new()],
[INFO] [stderr] 148 |         }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/addr.rs:301:9
[INFO] [stderr]     |
[INFO] [stderr] 301 |         return (old, new);
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(old, new)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/addr.rs:331:9
[INFO] [stderr]     |
[INFO] [stderr] 331 |         return true;
[INFO] [stderr]     |         ^^^^^^^^^^^^ help: remove `return` as shown: `true`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/addr.rs:348:5
[INFO] [stderr]     |
[INFO] [stderr] 348 |     return set.into_iter().collect();
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `set.into_iter().collect()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/combinators.rs:63:9
[INFO] [stderr]    |
[INFO] [stderr] 63 |         return Ok(Async::Ready(Some(result)));
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Async::Ready(Some(result)))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: use of deprecated item 'std::ascii::AsciiExt': use inherent methods instead
[INFO] [stderr]  --> src/name.rs:4:5
[INFO] [stderr]   |
[INFO] [stderr] 4 | use std::ascii::AsciiExt;
[INFO] [stderr]   |     ^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(deprecated)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `std::ascii::AsciiExt`
[INFO] [stderr]  --> src/name.rs:4:5
[INFO] [stderr]   |
[INFO] [stderr] 4 | use std::ascii::AsciiExt;
[INFO] [stderr]   |     ^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `addr::Builder`
[INFO] [stderr]    --> src/addr.rs:145:5
[INFO] [stderr]     |
[INFO] [stderr] 145 | /     pub fn new() -> Builder {
[INFO] [stderr] 146 | |         return Builder {
[INFO] [stderr] 147 | |             addresses: vec![Vec::new()],
[INFO] [stderr] 148 | |         }
[INFO] [stderr] 149 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 46  | #[derive(Default)]
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/addr.rs:168:31
[INFO] [stderr]     |
[INFO] [stderr] 168 |                 .filter(|vec| vec.len() > 0)
[INFO] [stderr]     |                               ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!vec.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: item `addr::WeightedSet<'a>` has a public `len` method but no corresponding `is_empty` method
[INFO] [stderr]    --> src/addr.rs:246:1
[INFO] [stderr]     |
[INFO] [stderr] 246 | / impl<'a> WeightedSet<'a> {
[INFO] [stderr] 247 | |     /// Select one random address to connect to
[INFO] [stderr] 248 | |     ///
[INFO] [stderr] 249 | |     /// This function selects a host according to the random distribution
[INFO] [stderr] ...   |
[INFO] [stderr] 307 | |     }
[INFO] [stderr] 308 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_without_is_empty)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/addr.rs:254:12
[INFO] [stderr]     |
[INFO] [stderr] 254 |         if self.addresses.len() == 0 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.addresses.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: this boolean expression can be simplified
[INFO] [stderr]    --> src/addr.rs:292:16
[INFO] [stderr]     |
[INFO] [stderr] 292 |             if !other.addresses.iter().find(|&&(_, a1)| a == a1).is_some() {
[INFO] [stderr]     |                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `other.addresses.iter().find(|&&(_, a1)| a == a1).is_none()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::nonminimal_bool)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stderr] 
[INFO] [stderr] warning: this boolean expression can be simplified
[INFO] [stderr]    --> src/addr.rs:297:16
[INFO] [stderr]     |
[INFO] [stderr] 297 |             if !self.addresses.iter().find(|&&(_, a1)| a == a1).is_some() {
[INFO] [stderr]     |                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.addresses.iter().find(|&&(_, a1)| a == a1).is_none()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stderr] 
[INFO] [stderr] warning: called `is_some()` after searching an `Iterator` with find. This is more succinctly expressed by calling `any()`.
[INFO] [stderr]    --> src/addr.rs:292:17
[INFO] [stderr]     |
[INFO] [stderr] 292 |             if !other.addresses.iter().find(|&&(_, a1)| a == a1).is_some() {
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::search_is_some)] on by default
[INFO] [stderr]     = note: replace `find(|&&(_, a1)| a == a1).is_some()` with `any(|&&(_, a1)| a == a1)`
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#search_is_some
[INFO] [stderr] 
[INFO] [stderr] warning: called `is_some()` after searching an `Iterator` with find. This is more succinctly expressed by calling `any()`.
[INFO] [stderr]    --> src/addr.rs:297:17
[INFO] [stderr]     |
[INFO] [stderr] 297 |             if !self.addresses.iter().find(|&&(_, a1)| a == a1).is_some() {
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: replace `find(|&&(_, a1)| a == a1).is_some()` with `any(|&&(_, a1)| a == a1)`
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#search_is_some
[INFO] [stderr] 
[INFO] [stderr] warning: this boolean expression can be simplified
[INFO] [stderr]    --> src/addr.rs:320:16
[INFO] [stderr]     |
[INFO] [stderr] 320 |             if !other.addresses.iter().find(|&&pair1| pair == pair1).is_some()
[INFO] [stderr]     |                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `other.addresses.iter().find(|&&pair1| pair == pair1).is_none()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stderr] 
[INFO] [stderr] warning: this boolean expression can be simplified
[INFO] [stderr]    --> src/addr.rs:326:16
[INFO] [stderr]     |
[INFO] [stderr] 326 |             if !self.addresses.iter().find(|&&pair1| pair == pair1).is_some()
[INFO] [stderr]     |                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.addresses.iter().find(|&&pair1| pair == pair1).is_none()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stderr] 
[INFO] [stderr] warning: called `is_some()` after searching an `Iterator` with find. This is more succinctly expressed by calling `any()`.
[INFO] [stderr]    --> src/addr.rs:320:17
[INFO] [stderr]     |
[INFO] [stderr] 320 |             if !other.addresses.iter().find(|&&pair1| pair == pair1).is_some()
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: replace `find(|&&pair1| pair == pair1).is_some()` with `any(|&&pair1| pair == pair1)`
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#search_is_some
[INFO] [stderr] 
[INFO] [stderr] warning: called `is_some()` after searching an `Iterator` with find. This is more succinctly expressed by calling `any()`.
[INFO] [stderr]    --> src/addr.rs:326:17
[INFO] [stderr]     |
[INFO] [stderr] 326 |             if !self.addresses.iter().find(|&&pair1| pair == pair1).is_some()
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: replace `find(|&&pair1| pair == pair1).is_some()` with `any(|&&pair1| pair == pair1)`
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#search_is_some
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/name.rs:78:12
[INFO] [stderr]    |
[INFO] [stderr] 78 |         if piece.len() == 0 {
[INFO] [stderr]    |            ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `piece.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/name.rs:87:30
[INFO] [stderr]    |
[INFO] [stderr] 87 |         if piece.starts_with("-") || piece.ends_with("-") {
[INFO] [stderr]    |                              ^^^ help: try using a char instead: `'-'`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/name.rs:87:54
[INFO] [stderr]    |
[INFO] [stderr] 87 |         if piece.starts_with("-") || piece.ends_with("-") {
[INFO] [stderr]    |                                                      ^^^ help: try using a char instead: `'-'`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]   --> src/ip_list.rs:33:9
[INFO] [stderr]    |
[INFO] [stderr] 33 |         thread_rng().choose(&self.0[..]).map(|&x| x)
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `thread_rng().choose(&self.0[..]).cloned()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::map_clone)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] 
[INFO] [stderr]     Checking domain v0.2.4
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/addr.rs:146:9
[INFO] [stderr]     |
[INFO] [stderr] 146 | /         return Builder {
[INFO] [stderr] 147 | |             addresses: vec![Vec::new()],
[INFO] [stderr] 148 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]     |
[INFO] [stderr] 146 |         Builder {
[INFO] [stderr] 147 |             addresses: vec![Vec::new()],
[INFO] [stderr] 148 |         }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/addr.rs:301:9
[INFO] [stderr]     |
[INFO] [stderr] 301 |         return (old, new);
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(old, new)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/addr.rs:331:9
[INFO] [stderr]     |
[INFO] [stderr] 331 |         return true;
[INFO] [stderr]     |         ^^^^^^^^^^^^ help: remove `return` as shown: `true`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/addr.rs:348:5
[INFO] [stderr]     |
[INFO] [stderr] 348 |     return set.into_iter().collect();
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `set.into_iter().collect()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/combinators.rs:63:9
[INFO] [stderr]    |
[INFO] [stderr] 63 |         return Ok(Async::Ready(Some(result)));
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Async::Ready(Some(result)))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: use of deprecated item 'std::ascii::AsciiExt': use inherent methods instead
[INFO] [stderr]  --> src/name.rs:4:5
[INFO] [stderr]   |
[INFO] [stderr] 4 | use std::ascii::AsciiExt;
[INFO] [stderr]   |     ^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(deprecated)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `std::ascii::AsciiExt`
[INFO] [stderr]  --> src/name.rs:4:5
[INFO] [stderr]   |
[INFO] [stderr] 4 | use std::ascii::AsciiExt;
[INFO] [stderr]   |     ^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `addr::Builder`
[INFO] [stderr]    --> src/addr.rs:145:5
[INFO] [stderr]     |
[INFO] [stderr] 145 | /     pub fn new() -> Builder {
[INFO] [stderr] 146 | |         return Builder {
[INFO] [stderr] 147 | |             addresses: vec![Vec::new()],
[INFO] [stderr] 148 | |         }
[INFO] [stderr] 149 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 46  | #[derive(Default)]
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/addr.rs:168:31
[INFO] [stderr]     |
[INFO] [stderr] 168 |                 .filter(|vec| vec.len() > 0)
[INFO] [stderr]     |                               ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!vec.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: item `addr::WeightedSet<'a>` has a public `len` method but no corresponding `is_empty` method
[INFO] [stderr]    --> src/addr.rs:246:1
[INFO] [stderr]     |
[INFO] [stderr] 246 | / impl<'a> WeightedSet<'a> {
[INFO] [stderr] 247 | |     /// Select one random address to connect to
[INFO] [stderr] 248 | |     ///
[INFO] [stderr] 249 | |     /// This function selects a host according to the random distribution
[INFO] [stderr] ...   |
[INFO] [stderr] 307 | |     }
[INFO] [stderr] 308 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_without_is_empty)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/addr.rs:254:12
[INFO] [stderr]     |
[INFO] [stderr] 254 |         if self.addresses.len() == 0 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.addresses.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: this boolean expression can be simplified
[INFO] [stderr]    --> src/addr.rs:292:16
[INFO] [stderr]     |
[INFO] [stderr] 292 |             if !other.addresses.iter().find(|&&(_, a1)| a == a1).is_some() {
[INFO] [stderr]     |                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `other.addresses.iter().find(|&&(_, a1)| a == a1).is_none()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::nonminimal_bool)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stderr] 
[INFO] [stderr] warning: this boolean expression can be simplified
[INFO] [stderr]    --> src/addr.rs:297:16
[INFO] [stderr]     |
[INFO] [stderr] 297 |             if !self.addresses.iter().find(|&&(_, a1)| a == a1).is_some() {
[INFO] [stderr]     |                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.addresses.iter().find(|&&(_, a1)| a == a1).is_none()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stderr] 
[INFO] [stderr] warning: called `is_some()` after searching an `Iterator` with find. This is more succinctly expressed by calling `any()`.
[INFO] [stderr]    --> src/addr.rs:292:17
[INFO] [stderr]     |
[INFO] [stderr] 292 |             if !other.addresses.iter().find(|&&(_, a1)| a == a1).is_some() {
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::search_is_some)] on by default
[INFO] [stderr]     = note: replace `find(|&&(_, a1)| a == a1).is_some()` with `any(|&&(_, a1)| a == a1)`
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#search_is_some
[INFO] [stderr] 
[INFO] [stderr] warning: called `is_some()` after searching an `Iterator` with find. This is more succinctly expressed by calling `any()`.
[INFO] [stderr]    --> src/addr.rs:297:17
[INFO] [stderr]     |
[INFO] [stderr] 297 |             if !self.addresses.iter().find(|&&(_, a1)| a == a1).is_some() {
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: replace `find(|&&(_, a1)| a == a1).is_some()` with `any(|&&(_, a1)| a == a1)`
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#search_is_some
[INFO] [stderr] 
[INFO] [stderr] warning: this boolean expression can be simplified
[INFO] [stderr]    --> src/addr.rs:320:16
[INFO] [stderr]     |
[INFO] [stderr] 320 |             if !other.addresses.iter().find(|&&pair1| pair == pair1).is_some()
[INFO] [stderr]     |                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `other.addresses.iter().find(|&&pair1| pair == pair1).is_none()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stderr] 
[INFO] [stderr] warning: this boolean expression can be simplified
[INFO] [stderr]    --> src/addr.rs:326:16
[INFO] [stderr]     |
[INFO] [stderr] 326 |             if !self.addresses.iter().find(|&&pair1| pair == pair1).is_some()
[INFO] [stderr]     |                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.addresses.iter().find(|&&pair1| pair == pair1).is_none()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stderr] 
[INFO] [stderr] warning: called `is_some()` after searching an `Iterator` with find. This is more succinctly expressed by calling `any()`.
[INFO] [stderr]    --> src/addr.rs:320:17
[INFO] [stderr]     |
[INFO] [stderr] 320 |             if !other.addresses.iter().find(|&&pair1| pair == pair1).is_some()
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: replace `find(|&&pair1| pair == pair1).is_some()` with `any(|&&pair1| pair == pair1)`
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#search_is_some
[INFO] [stderr] 
[INFO] [stderr] warning: called `is_some()` after searching an `Iterator` with find. This is more succinctly expressed by calling `any()`.
[INFO] [stderr]    --> src/addr.rs:326:17
[INFO] [stderr]     |
[INFO] [stderr] 326 |             if !self.addresses.iter().find(|&&pair1| pair == pair1).is_some()
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: replace `find(|&&pair1| pair == pair1).is_some()` with `any(|&&pair1| pair == pair1)`
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#search_is_some
[INFO] [stderr] 
[INFO] [stderr] warning: avoid using `collect()` when not needed
[INFO] [stderr]    --> src/addr.rs:476:39
[INFO] [stderr]     |
[INFO] [stderr] 476 |         assert_eq!(a.at(0).addresses().collect::<Vec<_>>().len(), 3);
[INFO] [stderr]     |                                       ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `.count()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_collect)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_collect
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/addr.rs:493:23
[INFO] [stderr]     |
[INFO] [stderr] 493 |             ).map(|a| a.into_iter().count())
[INFO] [stderr]     |                       ^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `a`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::identity_conversion)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/name.rs:78:12
[INFO] [stderr]    |
[INFO] [stderr] 78 |         if piece.len() == 0 {
[INFO] [stderr]    |            ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `piece.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/name.rs:87:30
[INFO] [stderr]    |
[INFO] [stderr] 87 |         if piece.starts_with("-") || piece.ends_with("-") {
[INFO] [stderr]    |                              ^^^ help: try using a char instead: `'-'`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/name.rs:87:54
[INFO] [stderr]    |
[INFO] [stderr] 87 |         if piece.starts_with("-") || piece.ends_with("-") {
[INFO] [stderr]    |                                                      ^^^ help: try using a char instead: `'-'`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]   --> src/ip_list.rs:33:9
[INFO] [stderr]    |
[INFO] [stderr] 33 |         thread_rng().choose(&self.0[..]).map(|&x| x)
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `thread_rng().choose(&self.0[..]).cloned()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::map_clone)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 19.02s
[INFO] running `"docker" "inspect" "d3cf99835eb2779e311cc5587bf4b0d479d2d2e53d429f0df5e4d2914ac295ed"`
[INFO] running `"docker" "rm" "-f" "d3cf99835eb2779e311cc5587bf4b0d479d2d2e53d429f0df5e4d2914ac295ed"`
[INFO] [stdout] d3cf99835eb2779e311cc5587bf4b0d479d2d2e53d429f0df5e4d2914ac295ed