[INFO] crate abstract-calculus 0.1.5 is already in cache
[INFO] extracting crate abstract-calculus 0.1.5 into work/ex/clippy-test-run/sources/stable/reg/abstract-calculus/0.1.5
[INFO] extracting crate abstract-calculus 0.1.5 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/abstract-calculus/0.1.5
[INFO] validating manifest of abstract-calculus-0.1.5 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of abstract-calculus-0.1.5 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing abstract-calculus-0.1.5
[INFO] finished frobbing abstract-calculus-0.1.5
[INFO] frobbed toml for abstract-calculus-0.1.5 written to work/ex/clippy-test-run/sources/stable/reg/abstract-calculus/0.1.5/Cargo.toml
[INFO] started frobbing abstract-calculus-0.1.5
[INFO] finished frobbing abstract-calculus-0.1.5
[INFO] frobbed toml for abstract-calculus-0.1.5 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/abstract-calculus/0.1.5/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting abstract-calculus-0.1.5 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/abstract-calculus/0.1.5:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 3a5d57b50d223b891205fc73af45c3a8b0bddbc826285d13c3fb8bd74f654c49
[INFO] running `"docker" "start" "-a" "3a5d57b50d223b891205fc73af45c3a8b0bddbc826285d13c3fb8bd74f654c49"`
[INFO] [stderr]     Checking abstract-calculus v0.1.5 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/term.rs:441:39
[INFO] [stderr]     |
[INFO] [stderr] 441 |                     let mut lam = Lam{nam: nam, bod: Box::new(bod)};
[INFO] [stderr]     |                                       ^^^^^^^^ help: replace it with: `nam`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: 5th binding whose name is just one char
[INFO] [stderr]    --> src/net.rs:122:13
[INFO] [stderr]     |
[INFO] [stderr] 122 |         let b = new_node(net, t);
[INFO] [stderr]     |             ^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::many_single_char_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/term.rs:441:39
[INFO] [stderr]     |
[INFO] [stderr] 441 |                     let mut lam = Lam{nam: nam, bod: Box::new(bod)};
[INFO] [stderr]     |                                       ^^^^^^^^ help: replace it with: `nam`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: 5th binding whose name is just one char
[INFO] [stderr]    --> src/net.rs:122:13
[INFO] [stderr]     |
[INFO] [stderr] 122 |         let b = new_node(net, t);
[INFO] [stderr]     |             ^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::many_single_char_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/term.rs:43:5
[INFO] [stderr]    |
[INFO] [stderr] 43 |     return name;
[INFO] [stderr]    |     ^^^^^^^^^^^^ help: remove `return` as shown: `name`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/term.rs:51:5
[INFO] [stderr]    |
[INFO] [stderr] 51 |     return idx;
[INFO] [stderr]    |     ^^^^^^^^^^^ help: remove `return` as shown: `idx`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/term.rs:279:5
[INFO] [stderr]     |
[INFO] [stderr] 279 |     return code;
[INFO] [stderr]     |     ^^^^^^^^^^^^ help: remove `return` as shown: `code`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]    --> src/term.rs:442:21
[INFO] [stderr]     |
[INFO] [stderr] 442 |                     lam
[INFO] [stderr]     |                     ^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]    --> src/term.rs:441:35
[INFO] [stderr]     |
[INFO] [stderr] 441 |                     let mut lam = Lam{nam: nam, bod: Box::new(bod)};
[INFO] [stderr]     |                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/net.rs:42:5
[INFO] [stderr]    |
[INFO] [stderr] 42 |     return node;
[INFO] [stderr]    |     ^^^^^^^^^^^^ help: remove `return` as shown: `node`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/term.rs:43:5
[INFO] [stderr]    |
[INFO] [stderr] 43 |     return name;
[INFO] [stderr]    |     ^^^^^^^^^^^^ help: remove `return` as shown: `name`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/term.rs:51:5
[INFO] [stderr]    |
[INFO] [stderr] 51 |     return idx;
[INFO] [stderr]    |     ^^^^^^^^^^^ help: remove `return` as shown: `idx`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/term.rs:279:5
[INFO] [stderr]     |
[INFO] [stderr] 279 |     return code;
[INFO] [stderr]     |     ^^^^^^^^^^^^ help: remove `return` as shown: `code`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]    --> src/term.rs:442:21
[INFO] [stderr]     |
[INFO] [stderr] 442 |                     lam
[INFO] [stderr]     |                     ^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]    --> src/term.rs:441:35
[INFO] [stderr]     |
[INFO] [stderr] 441 |                     let mut lam = Lam{nam: nam, bod: Box::new(bod)};
[INFO] [stderr]     |                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/net.rs:42:5
[INFO] [stderr]    |
[INFO] [stderr] 42 |     return node;
[INFO] [stderr]    |     ^^^^^^^^^^^^ help: remove `return` as shown: `node`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/term.rs:39:9
[INFO] [stderr]    |
[INFO] [stderr] 39 |         idx = idx - 1;
[INFO] [stderr]    |         ^^^^^^^^^^^^^ help: replace it with: `idx -= 1`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::assign_op_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/term.rs:41:9
[INFO] [stderr]    |
[INFO] [stderr] 41 |         idx = idx / 26;
[INFO] [stderr]    |         ^^^^^^^^^^^^^^ help: replace it with: `idx /= 26`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/term.rs:46:24
[INFO] [stderr]    |
[INFO] [stderr] 46 | pub fn name_idx(name : &Vec<Chr>) -> u32 {
[INFO] [stderr]    |                        ^^^^^^^^^ help: change this to: `&[Chr]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]   --> src/term.rs:49:29
[INFO] [stderr]    |
[INFO] [stderr] 49 |         idx = (idx * 26) + (*byte as u32 - 97) + 1;
[INFO] [stderr]    |                             ^^^^^^^^^^^^ help: try: `u32::from(*byte)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/term.rs:79:26
[INFO] [stderr]    |
[INFO] [stderr] 79 | pub fn namespace(space : &Vec<u8>, idx : u32, var : &Vec<u8>) -> Vec<u8> {
[INFO] [stderr]    |                          ^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] help: change this to
[INFO] [stderr]    |
[INFO] [stderr] 79 | pub fn namespace(space : &[u8], idx : u32, var : &Vec<u8>) -> Vec<u8> {
[INFO] [stderr]    |                          ^^^^^
[INFO] [stderr] help: change `space.clone()` to
[INFO] [stderr]    |
[INFO] [stderr] 81 |         let mut nam = space.to_owned();
[INFO] [stderr]    |                       ^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/term.rs:79:53
[INFO] [stderr]    |
[INFO] [stderr] 79 | pub fn namespace(space : &Vec<u8>, idx : u32, var : &Vec<u8>) -> Vec<u8> {
[INFO] [stderr]    |                                                     ^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] help: change this to
[INFO] [stderr]    |
[INFO] [stderr] 79 | pub fn namespace(space : &Vec<u8>, idx : u32, var : &[u8]) -> Vec<u8> {
[INFO] [stderr]    |                                                     ^^^^^
[INFO] [stderr] help: change `var.clone()` to
[INFO] [stderr]    |
[INFO] [stderr] 88 |         var.to_owned()
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/term.rs:93:21
[INFO] [stderr]    |
[INFO] [stderr] 93 | pub fn copy(space : &Vec<u8>, idx : u32, term : &Term) -> Term {
[INFO] [stderr]    |                     ^^^^^^^^ help: change this to: `&[u8]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type
[INFO] [stderr]    --> src/term.rs:208:48
[INFO] [stderr]     |
[INFO] [stderr] 208 |                                 let mut name = nam.clone().to_vec();
[INFO] [stderr]     |                                                ^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[deny(clippy::clone_double_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref
[INFO] [stderr] help: try dereferencing it
[INFO] [stderr]     |
[INFO] [stderr] 208 |                                 let mut name = &(*nam).clone().to_vec();
[INFO] [stderr]     |                                                ^^^^^^^^^^^^^^^
[INFO] [stderr] help: or try being explicit about what type to clone
[INFO] [stderr]     |
[INFO] [stderr] 208 |                                 let mut name = &[u8]::clone(nam).to_vec();
[INFO] [stderr]     |                                                ^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/term.rs:227:1
[INFO] [stderr]     |
[INFO] [stderr] 227 | / pub fn from_string<'a>(code : &'a Str) -> Term {
[INFO] [stderr] 228 | |     let mut ctx = Vec::new();
[INFO] [stderr] 229 | |     let mut idx = 0;
[INFO] [stderr] 230 | |     parse_term(code, &mut ctx, &mut idx, 0).1
[INFO] [stderr] 231 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_lifetimes)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/term.rs:236:9
[INFO] [stderr]     |
[INFO] [stderr] 236 | /         match term {
[INFO] [stderr] 237 | |             &Lam{ref nam, ref bod} => {
[INFO] [stderr] 238 | |                 code.extend_from_slice(b"#");
[INFO] [stderr] 239 | |                 code.append(&mut nam.clone());
[INFO] [stderr] ...   |
[INFO] [stderr] 274 | |             },
[INFO] [stderr] 275 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 236 |         match *term {
[INFO] [stderr] 237 |             Lam{ref nam, ref bod} => {
[INFO] [stderr] 238 |                 code.extend_from_slice(b"#");
[INFO] [stderr] 239 |                 code.append(&mut nam.clone());
[INFO] [stderr] 240 |                 code.extend_from_slice(b" ");
[INFO] [stderr] 241 |                 stringify_term(code, &bod);
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is only used to index `vars`.
[INFO] [stderr]    --> src/term.rs:387:14
[INFO] [stderr]     |
[INFO] [stderr] 387 |     for i in 0..vars.len() {
[INFO] [stderr]     |              ^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]     |
[INFO] [stderr] 387 |     for <item> in &vars {
[INFO] [stderr]     |         ^^^^^^    ^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap`
[INFO] [stderr]    --> src/term.rs:416:9
[INFO] [stderr]     |
[INFO] [stderr] 416 | /         if !var_name.contains_key(&var_port) {
[INFO] [stderr] 417 | |             let nam = new_name(var_name.len() as u32 + 1);
[INFO] [stderr] 418 | |             var_name.insert(var_port, nam.clone());
[INFO] [stderr] 419 | |         }
[INFO] [stderr]     | |_________^ help: consider using: `var_name.entry(var_port)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::map_entry)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/term.rs:496:11
[INFO] [stderr]     |
[INFO] [stderr] 496 |     while lets_vec.len() > 0 {
[INFO] [stderr]     |           ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!lets_vec.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/net.rs:87:23
[INFO] [stderr]    |
[INFO] [stderr] 87 |     while next > 0 || warp.len() > 0 {
[INFO] [stderr]    |                       ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!warp.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to previous error
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `abstract-calculus`.
[INFO] [stderr] warning: build failed, waiting for other jobs to finish...
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/term.rs:39:9
[INFO] [stderr]    |
[INFO] [stderr] 39 |         idx = idx - 1;
[INFO] [stderr]    |         ^^^^^^^^^^^^^ help: replace it with: `idx -= 1`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::assign_op_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/term.rs:41:9
[INFO] [stderr]    |
[INFO] [stderr] 41 |         idx = idx / 26;
[INFO] [stderr]    |         ^^^^^^^^^^^^^^ help: replace it with: `idx /= 26`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/term.rs:46:24
[INFO] [stderr]    |
[INFO] [stderr] 46 | pub fn name_idx(name : &Vec<Chr>) -> u32 {
[INFO] [stderr]    |                        ^^^^^^^^^ help: change this to: `&[Chr]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]   --> src/term.rs:49:29
[INFO] [stderr]    |
[INFO] [stderr] 49 |         idx = (idx * 26) + (*byte as u32 - 97) + 1;
[INFO] [stderr]    |                             ^^^^^^^^^^^^ help: try: `u32::from(*byte)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/term.rs:79:26
[INFO] [stderr]    |
[INFO] [stderr] 79 | pub fn namespace(space : &Vec<u8>, idx : u32, var : &Vec<u8>) -> Vec<u8> {
[INFO] [stderr]    |                          ^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] help: change this to
[INFO] [stderr]    |
[INFO] [stderr] 79 | pub fn namespace(space : &[u8], idx : u32, var : &Vec<u8>) -> Vec<u8> {
[INFO] [stderr]    |                          ^^^^^
[INFO] [stderr] help: change `space.clone()` to
[INFO] [stderr]    |
[INFO] [stderr] 81 |         let mut nam = space.to_owned();
[INFO] [stderr]    |                       ^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/term.rs:79:53
[INFO] [stderr]    |
[INFO] [stderr] 79 | pub fn namespace(space : &Vec<u8>, idx : u32, var : &Vec<u8>) -> Vec<u8> {
[INFO] [stderr]    |                                                     ^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] help: change this to
[INFO] [stderr]    |
[INFO] [stderr] 79 | pub fn namespace(space : &Vec<u8>, idx : u32, var : &[u8]) -> Vec<u8> {
[INFO] [stderr]    |                                                     ^^^^^
[INFO] [stderr] help: change `var.clone()` to
[INFO] [stderr]    |
[INFO] [stderr] 88 |         var.to_owned()
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/term.rs:93:21
[INFO] [stderr]    |
[INFO] [stderr] 93 | pub fn copy(space : &Vec<u8>, idx : u32, term : &Term) -> Term {
[INFO] [stderr]    |                     ^^^^^^^^ help: change this to: `&[u8]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type
[INFO] [stderr]    --> src/term.rs:208:48
[INFO] [stderr]     |
[INFO] [stderr] 208 |                                 let mut name = nam.clone().to_vec();
[INFO] [stderr]     |                                                ^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[deny(clippy::clone_double_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref
[INFO] [stderr] help: try dereferencing it
[INFO] [stderr]     |
[INFO] [stderr] 208 |                                 let mut name = &(*nam).clone().to_vec();
[INFO] [stderr]     |                                                ^^^^^^^^^^^^^^^
[INFO] [stderr] help: or try being explicit about what type to clone
[INFO] [stderr]     |
[INFO] [stderr] 208 |                                 let mut name = &[u8]::clone(nam).to_vec();
[INFO] [stderr]     |                                                ^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/term.rs:227:1
[INFO] [stderr]     |
[INFO] [stderr] 227 | / pub fn from_string<'a>(code : &'a Str) -> Term {
[INFO] [stderr] 228 | |     let mut ctx = Vec::new();
[INFO] [stderr] 229 | |     let mut idx = 0;
[INFO] [stderr] 230 | |     parse_term(code, &mut ctx, &mut idx, 0).1
[INFO] [stderr] 231 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_lifetimes)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/term.rs:236:9
[INFO] [stderr]     |
[INFO] [stderr] 236 | /         match term {
[INFO] [stderr] 237 | |             &Lam{ref nam, ref bod} => {
[INFO] [stderr] 238 | |                 code.extend_from_slice(b"#");
[INFO] [stderr] 239 | |                 code.append(&mut nam.clone());
[INFO] [stderr] ...   |
[INFO] [stderr] 274 | |             },
[INFO] [stderr] 275 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 236 |         match *term {
[INFO] [stderr] 237 |             Lam{ref nam, ref bod} => {
[INFO] [stderr] 238 |                 code.extend_from_slice(b"#");
[INFO] [stderr] 239 |                 code.append(&mut nam.clone());
[INFO] [stderr] 240 |                 code.extend_from_slice(b" ");
[INFO] [stderr] 241 |                 stringify_term(code, &bod);
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is only used to index `vars`.
[INFO] [stderr]    --> src/term.rs:387:14
[INFO] [stderr]     |
[INFO] [stderr] 387 |     for i in 0..vars.len() {
[INFO] [stderr]     |              ^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]     |
[INFO] [stderr] 387 |     for <item> in &vars {
[INFO] [stderr]     |         ^^^^^^    ^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap`
[INFO] [stderr]    --> src/term.rs:416:9
[INFO] [stderr]     |
[INFO] [stderr] 416 | /         if !var_name.contains_key(&var_port) {
[INFO] [stderr] 417 | |             let nam = new_name(var_name.len() as u32 + 1);
[INFO] [stderr] 418 | |             var_name.insert(var_port, nam.clone());
[INFO] [stderr] 419 | |         }
[INFO] [stderr]     | |_________^ help: consider using: `var_name.entry(var_port)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::map_entry)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/term.rs:496:11
[INFO] [stderr]     |
[INFO] [stderr] 496 |     while lets_vec.len() > 0 {
[INFO] [stderr]     |           ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!lets_vec.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/net.rs:87:23
[INFO] [stderr]    |
[INFO] [stderr] 87 |     while next > 0 || warp.len() > 0 {
[INFO] [stderr]    |                       ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!warp.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to previous error
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `abstract-calculus`.
[INFO] [stderr] 
[INFO] [stderr] To learn more, run the command again with --verbose.
[INFO] running `"docker" "inspect" "3a5d57b50d223b891205fc73af45c3a8b0bddbc826285d13c3fb8bd74f654c49"`
[INFO] running `"docker" "rm" "-f" "3a5d57b50d223b891205fc73af45c3a8b0bddbc826285d13c3fb8bd74f654c49"`
[INFO] [stdout] 3a5d57b50d223b891205fc73af45c3a8b0bddbc826285d13c3fb8bd74f654c49