[INFO] crate abra 0.0.1 is already in cache [INFO] extracting crate abra 0.0.1 into work/ex/clippy-test-run/sources/stable/reg/abra/0.0.1 [INFO] extracting crate abra 0.0.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/abra/0.0.1 [INFO] validating manifest of abra-0.0.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of abra-0.0.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing abra-0.0.1 [INFO] finished frobbing abra-0.0.1 [INFO] frobbed toml for abra-0.0.1 written to work/ex/clippy-test-run/sources/stable/reg/abra/0.0.1/Cargo.toml [INFO] started frobbing abra-0.0.1 [INFO] finished frobbing abra-0.0.1 [INFO] frobbed toml for abra-0.0.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/abra/0.0.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting abra-0.0.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/abra/0.0.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] be43c1be6209bec08e14c45703a1f77ff6649478e0ec9221fb61cd6be601d346 [INFO] running `"docker" "start" "-a" "be43c1be6209bec08e14c45703a1f77ff6649478e0ec9221fb61cd6be601d346"` [INFO] [stderr] Checking roaring v0.4.2 [INFO] [stderr] Checking abra v0.0.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/analysis/ngram_generator.rs:34:13 [INFO] [stderr] | [INFO] [stderr] 34 | word: word, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `word` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/analysis/ngram_generator.rs:35:13 [INFO] [stderr] | [INFO] [stderr] 35 | word_len: word_len, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `word_len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/analysis/ngram_generator.rs:36:13 [INFO] [stderr] | [INFO] [stderr] 36 | min_size: min_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `min_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/analysis/ngram_generator.rs:37:13 [INFO] [stderr] | [INFO] [stderr] 37 | max_size: max_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `max_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/analysis/ngram_generator.rs:38:13 [INFO] [stderr] | [INFO] [stderr] 38 | edge: edge, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `edge` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/analysis/tokenizers/ngram.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | min_size: min_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `min_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/analysis/tokenizers/ngram.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | max_size: max_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `max_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/analysis/tokenizers/ngram.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | edge: edge, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `edge` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/analysis/filters/lowercase.rs:13:13 [INFO] [stderr] | [INFO] [stderr] 13 | tokens: tokens, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `tokens` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/analysis/filters/ngram.rs:20:13 [INFO] [stderr] | [INFO] [stderr] 20 | tokens: tokens, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `tokens` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/analysis/filters/ngram.rs:21:13 [INFO] [stderr] | [INFO] [stderr] 21 | min_size: min_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `min_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/analysis/filters/ngram.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | max_size: max_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `max_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/analysis/filters/ngram.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | edge: edge, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `edge` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/analysis/filters/asciifolding.rs:14:13 [INFO] [stderr] | [INFO] [stderr] 14 | tokens: tokens, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `tokens` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/query/mod.rs:63:21 [INFO] [stderr] | [INFO] [stderr] 63 | queries: queries, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `queries` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/query/mod.rs:82:21 [INFO] [stderr] | [INFO] [stderr] 82 | queries: queries, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `queries` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/query/mod.rs:101:21 [INFO] [stderr] | [INFO] [stderr] 101 | queries: queries, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `queries` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/query/mod.rs:115:13 [INFO] [stderr] | [INFO] [stderr] 115 | boost: boost, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `boost` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/query_set.rs:233:33 [INFO] [stderr] | [INFO] [stderr] 233 | iter: iter, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/query_set.rs:270:41 [INFO] [stderr] | [INFO] [stderr] 270 | iter: iter, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/query_set.rs:286:45 [INFO] [stderr] | [INFO] [stderr] 286 | iter: iter, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/request.rs:28:25 [INFO] [stderr] | [INFO] [stderr] 28 | score: score, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `score` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/request.rs:45:13 [INFO] [stderr] | [INFO] [stderr] 45 | total_hits: total_hits, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `total_hits` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/request.rs:46:13 [INFO] [stderr] | [INFO] [stderr] 46 | hits: hits, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `hits` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/analysis/ngram_generator.rs:34:13 [INFO] [stderr] | [INFO] [stderr] 34 | word: word, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `word` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/analysis/ngram_generator.rs:35:13 [INFO] [stderr] | [INFO] [stderr] 35 | word_len: word_len, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `word_len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/analysis/ngram_generator.rs:36:13 [INFO] [stderr] | [INFO] [stderr] 36 | min_size: min_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `min_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/analysis/ngram_generator.rs:37:13 [INFO] [stderr] | [INFO] [stderr] 37 | max_size: max_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `max_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/analysis/ngram_generator.rs:38:13 [INFO] [stderr] | [INFO] [stderr] 38 | edge: edge, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `edge` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/analysis/tokenizers/ngram.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | min_size: min_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `min_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/analysis/tokenizers/ngram.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | max_size: max_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `max_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/analysis/tokenizers/ngram.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | edge: edge, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `edge` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/analysis/filters/lowercase.rs:13:13 [INFO] [stderr] | [INFO] [stderr] 13 | tokens: tokens, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `tokens` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/analysis/filters/ngram.rs:20:13 [INFO] [stderr] | [INFO] [stderr] 20 | tokens: tokens, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `tokens` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/analysis/filters/ngram.rs:21:13 [INFO] [stderr] | [INFO] [stderr] 21 | min_size: min_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `min_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/analysis/filters/ngram.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | max_size: max_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `max_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/analysis/filters/ngram.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | edge: edge, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `edge` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/analysis/filters/asciifolding.rs:14:13 [INFO] [stderr] | [INFO] [stderr] 14 | tokens: tokens, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `tokens` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/query/mod.rs:63:21 [INFO] [stderr] | [INFO] [stderr] 63 | queries: queries, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `queries` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/query/mod.rs:82:21 [INFO] [stderr] | [INFO] [stderr] 82 | queries: queries, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `queries` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/query/mod.rs:101:21 [INFO] [stderr] | [INFO] [stderr] 101 | queries: queries, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `queries` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/query/mod.rs:115:13 [INFO] [stderr] | [INFO] [stderr] 115 | boost: boost, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `boost` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/query_set.rs:233:33 [INFO] [stderr] | [INFO] [stderr] 233 | iter: iter, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/query_set.rs:270:41 [INFO] [stderr] | [INFO] [stderr] 270 | iter: iter, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/query_set.rs:286:45 [INFO] [stderr] | [INFO] [stderr] 286 | iter: iter, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/request.rs:28:25 [INFO] [stderr] | [INFO] [stderr] 28 | score: score, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `score` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/request.rs:45:13 [INFO] [stderr] | [INFO] [stderr] 45 | total_hits: total_hits, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `total_hits` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/request.rs:46:13 [INFO] [stderr] | [INFO] [stderr] 46 | hits: hits, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `hits` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/lib.rs:3:1 [INFO] [stderr] | [INFO] [stderr] 3 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/lib.rs:5:1 [INFO] [stderr] | [INFO] [stderr] 5 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/term.rs:74:57 [INFO] [stderr] | [INFO] [stderr] 74 | let timestamp_with_micros = timestamp * 1000000 + micros as i64; [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/query/mod.rs:141:17 [INFO] [stderr] | [INFO] [stderr] 141 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/query/mod.rs:150:17 [INFO] [stderr] | [INFO] [stderr] 150 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/query/mod.rs:165:17 [INFO] [stderr] | [INFO] [stderr] 165 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/query/mod.rs:174:17 [INFO] [stderr] | [INFO] [stderr] 174 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/query_set.rs:105:24 [INFO] [stderr] | [INFO] [stderr] 105 | } else { [INFO] [stderr] | ________________________^ [INFO] [stderr] 106 | | if let Some(doc_id_b) = *current_doc_b { [INFO] [stderr] 107 | | *current_doc_b = iter_b.next(); [INFO] [stderr] 108 | | Some(doc_id_b) [INFO] [stderr] ... | [INFO] [stderr] 111 | | } [INFO] [stderr] 112 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 105 | } else if let Some(doc_id_b) = *current_doc_b { [INFO] [stderr] 106 | *current_doc_b = iter_b.next(); [INFO] [stderr] 107 | Some(doc_id_b) [INFO] [stderr] 108 | } else { [INFO] [stderr] 109 | None [INFO] [stderr] 110 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/lib.rs:3:1 [INFO] [stderr] | [INFO] [stderr] 3 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/term.rs:74:57 [INFO] [stderr] | [INFO] [stderr] 74 | let timestamp_with_micros = timestamp * 1000000 + micros as i64; [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/term.rs:157:37 [INFO] [stderr] | [INFO] [stderr] 157 | date = date.with_nanosecond(123123123).unwrap(); [INFO] [stderr] | ^^^^^^^^^ help: consider: `123_123_123` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unused import: `term::Term` [INFO] [stderr] --> src/analysis/ngram_generator.rs:120:9 [INFO] [stderr] | [INFO] [stderr] 120 | use term::Term; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `token::Token` [INFO] [stderr] --> src/analysis/ngram_generator.rs:121:9 [INFO] [stderr] | [INFO] [stderr] 121 | use token::Token; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/analysis/tokenizers/standard.rs:50:18 [INFO] [stderr] | [INFO] [stderr] 50 | const TEXT: &'static str = "Up from the bowels of hell he sails, weilding a tankard of freshly brewed ale!"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around method argument [INFO] [stderr] --> src/analysis/filters/lowercase.rs:56:71 [INFO] [stderr] | [INFO] [stderr] 56 | let token_filter = LowercaseFilter::new(Box::new(tokens.drain((..)))); [INFO] [stderr] | ^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/analysis/filters/lowercase.rs:56:71 [INFO] [stderr] | [INFO] [stderr] 56 | let token_filter = LowercaseFilter::new(Box::new(tokens.drain((..)))); [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::double_parens)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around method argument [INFO] [stderr] --> src/analysis/filters/lowercase.rs:73:71 [INFO] [stderr] | [INFO] [stderr] 73 | let token_filter = LowercaseFilter::new(Box::new(tokens.drain((..)))); [INFO] [stderr] | ^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/analysis/filters/lowercase.rs:73:71 [INFO] [stderr] | [INFO] [stderr] 73 | let token_filter = LowercaseFilter::new(Box::new(tokens.drain((..)))); [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around method argument [INFO] [stderr] --> src/analysis/filters/ngram.rs:74:67 [INFO] [stderr] | [INFO] [stderr] 74 | let token_filter = NGramFilter::new(Box::new(tokens.drain((..))), 2, 3, Edge::Neither); [INFO] [stderr] | ^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/analysis/filters/ngram.rs:74:67 [INFO] [stderr] | [INFO] [stderr] 74 | let token_filter = NGramFilter::new(Box::new(tokens.drain((..))), 2, 3, Edge::Neither); [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around method argument [INFO] [stderr] --> src/analysis/filters/ngram.rs:95:67 [INFO] [stderr] | [INFO] [stderr] 95 | let token_filter = NGramFilter::new(Box::new(tokens.drain((..))), 2, 3, Edge::Left); [INFO] [stderr] | ^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/analysis/filters/ngram.rs:95:67 [INFO] [stderr] | [INFO] [stderr] 95 | let token_filter = NGramFilter::new(Box::new(tokens.drain((..))), 2, 3, Edge::Left); [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around method argument [INFO] [stderr] --> src/analysis/filters/ngram.rs:112:67 [INFO] [stderr] | [INFO] [stderr] 112 | let token_filter = NGramFilter::new(Box::new(tokens.drain((..))), 2, 1000, Edge::Left); [INFO] [stderr] | ^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/analysis/filters/ngram.rs:112:67 [INFO] [stderr] | [INFO] [stderr] 112 | let token_filter = NGramFilter::new(Box::new(tokens.drain((..))), 2, 1000, Edge::Left); [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around method argument [INFO] [stderr] --> src/analysis/filters/ngram.rs:130:67 [INFO] [stderr] | [INFO] [stderr] 130 | let token_filter = NGramFilter::new(Box::new(tokens.drain((..))), 2, 3, Edge::Right); [INFO] [stderr] | ^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/analysis/filters/ngram.rs:130:67 [INFO] [stderr] | [INFO] [stderr] 130 | let token_filter = NGramFilter::new(Box::new(tokens.drain((..))), 2, 3, Edge::Right); [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around method argument [INFO] [stderr] --> src/analysis/filters/asciifolding.rs:55:74 [INFO] [stderr] | [INFO] [stderr] 55 | let token_filter = ASCIIFoldingFilter::new(Box::new(tokens.drain((..)))); [INFO] [stderr] | ^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/analysis/filters/asciifolding.rs:55:74 [INFO] [stderr] | [INFO] [stderr] 55 | let token_filter = ASCIIFoldingFilter::new(Box::new(tokens.drain((..)))); [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around method argument [INFO] [stderr] --> src/analysis/filters/asciifolding.rs:70:74 [INFO] [stderr] | [INFO] [stderr] 70 | let token_filter = ASCIIFoldingFilter::new(Box::new(tokens.drain((..)))); [INFO] [stderr] | ^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/analysis/filters/asciifolding.rs:70:74 [INFO] [stderr] | [INFO] [stderr] 70 | let token_filter = ASCIIFoldingFilter::new(Box::new(tokens.drain((..)))); [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: unused import: `MemoryIndexStoreReader` [INFO] [stderr] --> src/store/memory.rs:237:35 [INFO] [stderr] | [INFO] [stderr] 237 | use super::{MemoryIndexStore, MemoryIndexStoreReader}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/query/mod.rs:141:17 [INFO] [stderr] | [INFO] [stderr] 141 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/query/mod.rs:150:17 [INFO] [stderr] | [INFO] [stderr] 150 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/query/mod.rs:165:17 [INFO] [stderr] | [INFO] [stderr] 165 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/query/mod.rs:174:17 [INFO] [stderr] | [INFO] [stderr] 174 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/query_set.rs:105:24 [INFO] [stderr] | [INFO] [stderr] 105 | } else { [INFO] [stderr] | ________________________^ [INFO] [stderr] 106 | | if let Some(doc_id_b) = *current_doc_b { [INFO] [stderr] 107 | | *current_doc_b = iter_b.next(); [INFO] [stderr] 108 | | Some(doc_id_b) [INFO] [stderr] ... | [INFO] [stderr] 111 | | } [INFO] [stderr] 112 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 105 | } else if let Some(doc_id_b) = *current_doc_b { [INFO] [stderr] 106 | *current_doc_b = iter_b.next(); [INFO] [stderr] 107 | Some(doc_id_b) [INFO] [stderr] 108 | } else { [INFO] [stderr] 109 | None [INFO] [stderr] 110 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unused variable: `scorer` [INFO] [stderr] --> src/query_set.rs:227:64 [INFO] [stderr] | [INFO] [stderr] 227 | Query::MatchTerm{ref field, ref term, ref matcher, ref scorer} => { [INFO] [stderr] | ^^^^^^ help: try ignoring the field: `scorer: _` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `queries` [INFO] [stderr] --> src/query_set.rs:320:33 [INFO] [stderr] | [INFO] [stderr] 320 | Query::NDisjunction{ref queries, minimum_should_match} => { [INFO] [stderr] | ^^^^^^^ help: try ignoring the field: `queries: _` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `minimum_should_match` [INFO] [stderr] --> src/query_set.rs:320:42 [INFO] [stderr] | [INFO] [stderr] 320 | Query::NDisjunction{ref queries, minimum_should_match} => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try ignoring the field: `minimum_should_match: _` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `boost` [INFO] [stderr] --> src/query_set.rs:351:33 [INFO] [stderr] | [INFO] [stderr] 351 | Query::Boost{ref query, boost} => { [INFO] [stderr] | ^^^^^ help: try ignoring the field: `boost: _` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `scorer` [INFO] [stderr] --> src/query/mod.rs:123:68 [INFO] [stderr] | [INFO] [stderr] 123 | Query::MatchTerm{ref field, ref term, ref matcher, ref scorer} => { [INFO] [stderr] | ^^^^^^ help: try ignoring the field: `scorer: _` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `boost` [INFO] [stderr] --> src/query/mod.rs:182:37 [INFO] [stderr] | [INFO] [stderr] 182 | Query::Boost{ref query, boost} => { [INFO] [stderr] | ^^^^^ help: try ignoring the field: `boost: _` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/analysis/tokenizers/standard.rs:28:18 [INFO] [stderr] | [INFO] [stderr] 28 | Some(mut word) => { [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/request.rs:21:13 [INFO] [stderr] | [INFO] [stderr] 21 | let mut iterator = build_iterator_from_query(index_reader, &self.query); [INFO] [stderr] | ----^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/term.rs:74:67 [INFO] [stderr] | [INFO] [stderr] 74 | let timestamp_with_micros = timestamp * 1000000 + micros as i64; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i64::from(micros)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `analysis::registry::AnalyzerRegistry` [INFO] [stderr] --> src/analysis/registry.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | / pub fn new() -> AnalyzerRegistry { [INFO] [stderr] 19 | | AnalyzerRegistry { [INFO] [stderr] 20 | | analyzers: HashMap::new(), [INFO] [stderr] 21 | | tokenizers: HashMap::new(), [INFO] [stderr] 22 | | filters: HashMap::new(), [INFO] [stderr] 23 | | } [INFO] [stderr] 24 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 10 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `store::memory::MemoryIndexStoreFieldTerm` [INFO] [stderr] --> src/store/memory.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | / pub fn new() -> MemoryIndexStoreFieldTerm { [INFO] [stderr] 18 | | MemoryIndexStoreFieldTerm { [INFO] [stderr] 19 | | docs: RoaringBitmap::new(), [INFO] [stderr] 20 | | } [INFO] [stderr] 21 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 16 | impl Default for store::memory::MemoryIndexStoreFieldTerm { [INFO] [stderr] 17 | fn default() -> Self { [INFO] [stderr] 18 | Self::new() [INFO] [stderr] 19 | } [INFO] [stderr] 20 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `store::memory::MemoryIndexStoreField` [INFO] [stderr] --> src/store/memory.rs:34:5 [INFO] [stderr] | [INFO] [stderr] 34 | / pub fn new() -> MemoryIndexStoreField { [INFO] [stderr] 35 | | MemoryIndexStoreField { [INFO] [stderr] 36 | | docs: RoaringBitmap::new(), [INFO] [stderr] 37 | | terms: BTreeMap::new(), [INFO] [stderr] 38 | | num_tokens: 0, [INFO] [stderr] 39 | | } [INFO] [stderr] 40 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 33 | impl Default for store::memory::MemoryIndexStoreField { [INFO] [stderr] 34 | fn default() -> Self { [INFO] [stderr] 35 | Self::new() [INFO] [stderr] 36 | } [INFO] [stderr] 37 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `store::memory::MemoryIndexStore` [INFO] [stderr] --> src/store/memory.rs:54:5 [INFO] [stderr] | [INFO] [stderr] 54 | / pub fn new() -> MemoryIndexStore { [INFO] [stderr] 55 | | MemoryIndexStore { [INFO] [stderr] 56 | | docs: BTreeMap::new(), [INFO] [stderr] 57 | | fields: BTreeMap::new(), [INFO] [stderr] ... | [INFO] [stderr] 60 | | } [INFO] [stderr] 61 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 45 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/store/mod.rs:11:42 [INFO] [stderr] | [INFO] [stderr] 11 | fn get_document_by_id(&self, doc_id: &u64) -> Option<&Document>; [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u64` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: variant `TF_IDF` should have a camel case name such as `TfIdf` [INFO] [stderr] --> src/similarity.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | TF_IDF, [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_camel_case_types)] on by default [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/similarity.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | (term_frequency as f64).ln() + 1.0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(term_frequency)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/similarity.rs:36:71 [INFO] [stderr] | [INFO] [stderr] 36 | idf * (k1 + 1.0) * (tf / (tf + (k1 * ((1.0 - b) + b * (length as f64).sqrt() / average_length.sqrt())))) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(length)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/query/mod.rs:55:17 [INFO] [stderr] | [INFO] [stderr] 55 | / for query in queries { [INFO] [stderr] 56 | | return query; [INFO] [stderr] 57 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::never_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/query/mod.rs:74:17 [INFO] [stderr] | [INFO] [stderr] 74 | / for query in queries { [INFO] [stderr] 75 | | return query; [INFO] [stderr] 76 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/query/mod.rs:93:17 [INFO] [stderr] | [INFO] [stderr] 93 | / for query in queries { [INFO] [stderr] 94 | | return query; [INFO] [stderr] 95 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/query/mod.rs:108:12 [INFO] [stderr] | [INFO] [stderr] 108 | if boost == 1.0f64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(boost - 1.0f64).abs() < error` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/query/mod.rs:108:12 [INFO] [stderr] | [INFO] [stderr] 108 | if boost == 1.0f64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/query_set.rs:148:8 [INFO] [stderr] | [INFO] [stderr] 148 | if iters.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `iters.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/query_set.rs:183:8 [INFO] [stderr] | [INFO] [stderr] 183 | if iters.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `iters.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/query_set.rs:252:58 [INFO] [stderr] | [INFO] [stderr] 252 | return Some(k.clone()); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::clone_double_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 252 | return Some(&(*k).clone()); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 252 | return Some(&[u8]::clone(k)); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a BTreeMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/response.rs:18:23 [INFO] [stderr] | [INFO] [stderr] 18 | pk_field.push(self.doc.fields.get("pk").unwrap()[0].term.as_json()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.doc.fields["pk"]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] error: aborting due to 5 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `abra`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: unused variable: `scorer` [INFO] [stderr] --> src/query_set.rs:227:64 [INFO] [stderr] | [INFO] [stderr] 227 | Query::MatchTerm{ref field, ref term, ref matcher, ref scorer} => { [INFO] [stderr] | ^^^^^^ help: try ignoring the field: `scorer: _` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `queries` [INFO] [stderr] --> src/query_set.rs:320:33 [INFO] [stderr] | [INFO] [stderr] 320 | Query::NDisjunction{ref queries, minimum_should_match} => { [INFO] [stderr] | ^^^^^^^ help: try ignoring the field: `queries: _` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `minimum_should_match` [INFO] [stderr] --> src/query_set.rs:320:42 [INFO] [stderr] | [INFO] [stderr] 320 | Query::NDisjunction{ref queries, minimum_should_match} => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try ignoring the field: `minimum_should_match: _` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `boost` [INFO] [stderr] --> src/query_set.rs:351:33 [INFO] [stderr] | [INFO] [stderr] 351 | Query::Boost{ref query, boost} => { [INFO] [stderr] | ^^^^^ help: try ignoring the field: `boost: _` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `scorer` [INFO] [stderr] --> src/query/mod.rs:123:68 [INFO] [stderr] | [INFO] [stderr] 123 | Query::MatchTerm{ref field, ref term, ref matcher, ref scorer} => { [INFO] [stderr] | ^^^^^^ help: try ignoring the field: `scorer: _` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `boost` [INFO] [stderr] --> src/query/mod.rs:182:37 [INFO] [stderr] | [INFO] [stderr] 182 | Query::Boost{ref query, boost} => { [INFO] [stderr] | ^^^^^ help: try ignoring the field: `boost: _` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/analysis/tokenizers/standard.rs:28:18 [INFO] [stderr] | [INFO] [stderr] 28 | Some(mut word) => { [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/request.rs:21:13 [INFO] [stderr] | [INFO] [stderr] 21 | let mut iterator = build_iterator_from_query(index_reader, &self.query); [INFO] [stderr] | ----^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/term.rs:74:67 [INFO] [stderr] | [INFO] [stderr] 74 | let timestamp_with_micros = timestamp * 1000000 + micros as i64; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i64::from(micros)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `analysis::registry::AnalyzerRegistry` [INFO] [stderr] --> src/analysis/registry.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | / pub fn new() -> AnalyzerRegistry { [INFO] [stderr] 19 | | AnalyzerRegistry { [INFO] [stderr] 20 | | analyzers: HashMap::new(), [INFO] [stderr] 21 | | tokenizers: HashMap::new(), [INFO] [stderr] 22 | | filters: HashMap::new(), [INFO] [stderr] 23 | | } [INFO] [stderr] 24 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 10 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `store::memory::MemoryIndexStoreFieldTerm` [INFO] [stderr] --> src/store/memory.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | / pub fn new() -> MemoryIndexStoreFieldTerm { [INFO] [stderr] 18 | | MemoryIndexStoreFieldTerm { [INFO] [stderr] 19 | | docs: RoaringBitmap::new(), [INFO] [stderr] 20 | | } [INFO] [stderr] 21 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 16 | impl Default for store::memory::MemoryIndexStoreFieldTerm { [INFO] [stderr] 17 | fn default() -> Self { [INFO] [stderr] 18 | Self::new() [INFO] [stderr] 19 | } [INFO] [stderr] 20 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `store::memory::MemoryIndexStoreField` [INFO] [stderr] --> src/store/memory.rs:34:5 [INFO] [stderr] | [INFO] [stderr] 34 | / pub fn new() -> MemoryIndexStoreField { [INFO] [stderr] 35 | | MemoryIndexStoreField { [INFO] [stderr] 36 | | docs: RoaringBitmap::new(), [INFO] [stderr] 37 | | terms: BTreeMap::new(), [INFO] [stderr] 38 | | num_tokens: 0, [INFO] [stderr] 39 | | } [INFO] [stderr] 40 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 33 | impl Default for store::memory::MemoryIndexStoreField { [INFO] [stderr] 34 | fn default() -> Self { [INFO] [stderr] 35 | Self::new() [INFO] [stderr] 36 | } [INFO] [stderr] 37 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `store::memory::MemoryIndexStore` [INFO] [stderr] --> src/store/memory.rs:54:5 [INFO] [stderr] | [INFO] [stderr] 54 | / pub fn new() -> MemoryIndexStore { [INFO] [stderr] 55 | | MemoryIndexStore { [INFO] [stderr] 56 | | docs: BTreeMap::new(), [INFO] [stderr] 57 | | fields: BTreeMap::new(), [INFO] [stderr] ... | [INFO] [stderr] 60 | | } [INFO] [stderr] 61 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 45 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/store/mod.rs:11:42 [INFO] [stderr] | [INFO] [stderr] 11 | fn get_document_by_id(&self, doc_id: &u64) -> Option<&Document>; [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u64` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: variant `TF_IDF` should have a camel case name such as `TfIdf` [INFO] [stderr] --> src/similarity.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | TF_IDF, [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_camel_case_types)] on by default [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/similarity.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | (term_frequency as f64).ln() + 1.0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(term_frequency)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/similarity.rs:36:71 [INFO] [stderr] | [INFO] [stderr] 36 | idf * (k1 + 1.0) * (tf / (tf + (k1 * ((1.0 - b) + b * (length as f64).sqrt() / average_length.sqrt())))) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(length)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/similarity.rs:65:17 [INFO] [stderr] | [INFO] [stderr] 65 | assert!(similarity.score(1, 100, 100, 20, 5) == similarity.score(1, 40, 100, 20, 5)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(similarity.score(1, 100, 100, 20, 5) - similarity.score(1, 40, 100, 20, 5)).abs() < error` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/similarity.rs:65:17 [INFO] [stderr] | [INFO] [stderr] 65 | assert!(similarity.score(1, 100, 100, 20, 5) == similarity.score(1, 40, 100, 20, 5)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/similarity.rs:72:17 [INFO] [stderr] | [INFO] [stderr] 72 | assert!(similarity.score(1, 40, 1000, 20, 5) == similarity.score(1, 40, 100, 20, 5)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(similarity.score(1, 40, 1000, 20, 5) - similarity.score(1, 40, 100, 20, 5)).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/similarity.rs:72:17 [INFO] [stderr] | [INFO] [stderr] 72 | assert!(similarity.score(1, 40, 1000, 20, 5) == similarity.score(1, 40, 100, 20, 5)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/query/mod.rs:55:17 [INFO] [stderr] | [INFO] [stderr] 55 | / for query in queries { [INFO] [stderr] 56 | | return query; [INFO] [stderr] 57 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::never_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/query/mod.rs:74:17 [INFO] [stderr] | [INFO] [stderr] 74 | / for query in queries { [INFO] [stderr] 75 | | return query; [INFO] [stderr] 76 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/query/mod.rs:93:17 [INFO] [stderr] | [INFO] [stderr] 93 | / for query in queries { [INFO] [stderr] 94 | | return query; [INFO] [stderr] 95 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/query/mod.rs:108:12 [INFO] [stderr] | [INFO] [stderr] 108 | if boost == 1.0f64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(boost - 1.0f64).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/query/mod.rs:108:12 [INFO] [stderr] | [INFO] [stderr] 108 | if boost == 1.0f64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/query_set.rs:148:8 [INFO] [stderr] | [INFO] [stderr] 148 | if iters.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `iters.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/query_set.rs:183:8 [INFO] [stderr] | [INFO] [stderr] 183 | if iters.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `iters.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/query_set.rs:252:58 [INFO] [stderr] | [INFO] [stderr] 252 | return Some(k.clone()); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::clone_double_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 252 | return Some(&(*k).clone()); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 252 | return Some(&[u8]::clone(k)); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a BTreeMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/response.rs:18:23 [INFO] [stderr] | [INFO] [stderr] 18 | pk_field.push(self.doc.fields.get("pk").unwrap()[0].term.as_json()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.doc.fields["pk"]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] error: aborting due to 7 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `abra`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "be43c1be6209bec08e14c45703a1f77ff6649478e0ec9221fb61cd6be601d346"` [INFO] running `"docker" "rm" "-f" "be43c1be6209bec08e14c45703a1f77ff6649478e0ec9221fb61cd6be601d346"` [INFO] [stdout] be43c1be6209bec08e14c45703a1f77ff6649478e0ec9221fb61cd6be601d346