[INFO] crate abc 0.2.3 is already in cache [INFO] extracting crate abc 0.2.3 into work/ex/clippy-test-run/sources/stable/reg/abc/0.2.3 [INFO] extracting crate abc 0.2.3 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/abc/0.2.3 [INFO] validating manifest of abc-0.2.3 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of abc-0.2.3 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing abc-0.2.3 [INFO] finished frobbing abc-0.2.3 [INFO] frobbed toml for abc-0.2.3 written to work/ex/clippy-test-run/sources/stable/reg/abc/0.2.3/Cargo.toml [INFO] started frobbing abc-0.2.3 [INFO] finished frobbing abc-0.2.3 [INFO] frobbed toml for abc-0.2.3 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/abc/0.2.3/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting abc-0.2.3 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/abc/0.2.3:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 6a650fcdfef36e455e4b11eea09b5c048295b0857fa36803ae7061fad632dc95 [INFO] running `"docker" "start" "-a" "6a650fcdfef36e455e4b11eea09b5c048295b0857fa36803ae7061fad632dc95"` [INFO] [stderr] Checking abc v0.2.3 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/task.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | workers: workers, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `workers` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/task.rs:27:13 [INFO] [stderr] | [INFO] [stderr] 27 | observers: observers, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `observers` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/candidate.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | solution: solution, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `solution` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/candidate.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | fitness: fitness, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `fitness` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/candidate.rs:44:13 [INFO] [stderr] | [INFO] [stderr] 44 | candidate: candidate, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `candidate` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/hive.rs:42:13 [INFO] [stderr] | [INFO] [stderr] 42 | workers: workers, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `workers` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/hive.rs:46:13 [INFO] [stderr] | [INFO] [stderr] 46 | context: context, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `context` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/hive.rs:161:13 [INFO] [stderr] | [INFO] [stderr] 161 | hive: hive, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `hive` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/hive.rs:162:13 [INFO] [stderr] | [INFO] [stderr] 162 | working: working, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `working` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/hive.rs:163:13 [INFO] [stderr] | [INFO] [stderr] 163 | best: best, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `best` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/task.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | workers: workers, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `workers` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/task.rs:27:13 [INFO] [stderr] | [INFO] [stderr] 27 | observers: observers, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `observers` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/candidate.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | solution: solution, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `solution` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/candidate.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | fitness: fitness, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `fitness` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/candidate.rs:44:13 [INFO] [stderr] | [INFO] [stderr] 44 | candidate: candidate, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `candidate` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/hive.rs:42:13 [INFO] [stderr] | [INFO] [stderr] 42 | workers: workers, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `workers` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/hive.rs:46:13 [INFO] [stderr] | [INFO] [stderr] 46 | context: context, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `context` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/hive.rs:161:13 [INFO] [stderr] | [INFO] [stderr] 161 | hive: hive, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `hive` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/hive.rs:162:13 [INFO] [stderr] | [INFO] [stderr] 162 | working: working, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `working` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/hive.rs:163:13 [INFO] [stderr] | [INFO] [stderr] 163 | best: best, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `best` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/hive.rs:205:24 [INFO] [stderr] | [INFO] [stderr] 205 | if let Err(_) = sender_guard.send(candidate.clone()) { [INFO] [stderr] | _________________- ^^^^^^ [INFO] [stderr] 206 | | try!(self.stop()); [INFO] [stderr] 207 | | } [INFO] [stderr] | |_________________- help: try this: `if sender_guard.send(candidate.clone()).is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/hive.rs:360:12 [INFO] [stderr] | [INFO] [stderr] 360 | Ok(tasks_guard.as_mut().map_or((), |t| t.stop())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 360 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/hive.rs:205:24 [INFO] [stderr] | [INFO] [stderr] 205 | if let Err(_) = sender_guard.send(candidate.clone()) { [INFO] [stderr] | _________________- ^^^^^^ [INFO] [stderr] 206 | | try!(self.stop()); [INFO] [stderr] 207 | | } [INFO] [stderr] | |_________________- help: try this: `if sender_guard.send(candidate.clone()).is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/hive.rs:360:12 [INFO] [stderr] | [INFO] [stderr] 360 | Ok(tasks_guard.as_mut().map_or((), |t| t.stop())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 360 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> examples/streaming.rs:23:9 [INFO] [stderr] | [INFO] [stderr] 23 | (x - x) as f64 + *solution as f64 [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(x - x)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: equal expressions as operands to `-` [INFO] [stderr] --> examples/streaming.rs:23:9 [INFO] [stderr] | [INFO] [stderr] 23 | (x - x) as f64 + *solution as f64 [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::eq_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eq_op [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> examples/streaming.rs:23:26 [INFO] [stderr] | [INFO] [stderr] 23 | (x - x) as f64 + *solution as f64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(*solution)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> examples/max_i32.rs:23:9 [INFO] [stderr] | [INFO] [stderr] 23 | (x - x) as f64 + *solution as f64 [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(x - x)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: equal expressions as operands to `-` [INFO] [stderr] --> examples/max_i32.rs:23:9 [INFO] [stderr] | [INFO] [stderr] 23 | (x - x) as f64 + *solution as f64 [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::eq_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eq_op [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> examples/max_i32.rs:23:26 [INFO] [stderr] | [INFO] [stderr] 23 | (x - x) as f64 + *solution as f64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(*solution)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: Could not compile `abc`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `abc`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "6a650fcdfef36e455e4b11eea09b5c048295b0857fa36803ae7061fad632dc95"` [INFO] running `"docker" "rm" "-f" "6a650fcdfef36e455e4b11eea09b5c048295b0857fa36803ae7061fad632dc95"` [INFO] [stdout] 6a650fcdfef36e455e4b11eea09b5c048295b0857fa36803ae7061fad632dc95