[INFO] crate a2 0.3.5 is already in cache [INFO] extracting crate a2 0.3.5 into work/ex/clippy-test-run/sources/stable/reg/a2/0.3.5 [INFO] extracting crate a2 0.3.5 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/a2/0.3.5 [INFO] validating manifest of a2-0.3.5 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of a2-0.3.5 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing a2-0.3.5 [INFO] finished frobbing a2-0.3.5 [INFO] frobbed toml for a2-0.3.5 written to work/ex/clippy-test-run/sources/stable/reg/a2/0.3.5/Cargo.toml [INFO] started frobbing a2-0.3.5 [INFO] finished frobbing a2-0.3.5 [INFO] frobbed toml for a2-0.3.5 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/a2/0.3.5/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting a2-0.3.5 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/a2/0.3.5:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 5d28ff8c2deb651dfb1afeb0940e0852595100d7b16f6f186fcd43fb72b1d14e [INFO] running `"docker" "start" "-a" "5d28ff8c2deb651dfb1afeb0940e0852595100d7b16f6f186fcd43fb72b1d14e"` [INFO] [stderr] Checking erased-serde v0.3.8 [INFO] [stderr] Checking error-chain v0.1.12 [INFO] [stderr] Compiling indoc-impl v0.2.8 [INFO] [stderr] Checking tokio-rustls v0.5.0 [INFO] [stderr] Checking pretty_env_logger v0.2.5 [INFO] [stderr] Checking trust-dns-proto v0.4.3 [INFO] [stderr] Checking indoc v0.2.8 [INFO] [stderr] Checking trust-dns-resolver v0.9.1 [INFO] [stderr] Checking hyper-alpn v0.1.4 [INFO] [stderr] Checking a2 v0.3.5 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/request/notification/localized.rs:90:17 [INFO] [stderr] | [INFO] [stderr] 90 | title: title, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `title` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/request/notification/localized.rs:91:17 [INFO] [stderr] | [INFO] [stderr] 91 | body: body, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `body` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/request/notification/localized.rs:370:13 [INFO] [stderr] | [INFO] [stderr] 370 | device_token: device_token, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `device_token` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/request/notification/localized.rs:371:13 [INFO] [stderr] | [INFO] [stderr] 371 | options: options, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `options` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/request/notification/plain.rs:48:13 [INFO] [stderr] | [INFO] [stderr] 48 | body: body, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `body` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/request/notification/plain.rs:138:13 [INFO] [stderr] | [INFO] [stderr] 138 | device_token: device_token, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `device_token` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/request/notification/plain.rs:139:13 [INFO] [stderr] | [INFO] [stderr] 139 | options: options, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `options` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/request/notification/silent.rs:70:13 [INFO] [stderr] | [INFO] [stderr] 70 | device_token: device_token, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `device_token` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/request/notification/silent.rs:71:13 [INFO] [stderr] | [INFO] [stderr] 71 | options: options, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `options` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/request/notification/options.rs:17:29 [INFO] [stderr] | [INFO] [stderr] 17 | Ok(CollapseId { value: value }) [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client.rs:80:13 [INFO] [stderr] | [INFO] [stderr] 80 | signer: signer, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `signer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client.rs:81:13 [INFO] [stderr] | [INFO] [stderr] 81 | endpoint: endpoint, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `endpoint` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client.rs:165:25 [INFO] [stderr] | [INFO] [stderr] 165 | apns_id: apns_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `apns_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client.rs:213:21 [INFO] [stderr] | [INFO] [stderr] 213 | apns_id: apns_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `apns_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/signer.rs:73:13 [INFO] [stderr] | [INFO] [stderr] 73 | issued_at: issued_at, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `issued_at` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/signer.rs:77:13 [INFO] [stderr] | [INFO] [stderr] 77 | signature: signature, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `signature` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/signer.rs:78:13 [INFO] [stderr] | [INFO] [stderr] 78 | key_id: key_id, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `key_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/signer.rs:79:13 [INFO] [stderr] | [INFO] [stderr] 79 | team_id: team_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `team_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/signer.rs:80:13 [INFO] [stderr] | [INFO] [stderr] 80 | secret: secret, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `secret` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/signer.rs:150:13 [INFO] [stderr] | [INFO] [stderr] 150 | issued_at: issued_at, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `issued_at` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/request/notification/localized.rs:90:17 [INFO] [stderr] | [INFO] [stderr] 90 | title: title, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `title` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/request/notification/localized.rs:91:17 [INFO] [stderr] | [INFO] [stderr] 91 | body: body, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `body` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/request/notification/localized.rs:370:13 [INFO] [stderr] | [INFO] [stderr] 370 | device_token: device_token, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `device_token` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/request/notification/localized.rs:371:13 [INFO] [stderr] | [INFO] [stderr] 371 | options: options, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `options` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/request/notification/plain.rs:48:13 [INFO] [stderr] | [INFO] [stderr] 48 | body: body, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `body` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/request/notification/plain.rs:138:13 [INFO] [stderr] | [INFO] [stderr] 138 | device_token: device_token, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `device_token` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/request/notification/plain.rs:139:13 [INFO] [stderr] | [INFO] [stderr] 139 | options: options, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `options` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/request/notification/silent.rs:70:13 [INFO] [stderr] | [INFO] [stderr] 70 | device_token: device_token, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `device_token` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/request/notification/silent.rs:71:13 [INFO] [stderr] | [INFO] [stderr] 71 | options: options, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `options` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/request/notification/options.rs:17:29 [INFO] [stderr] | [INFO] [stderr] 17 | Ok(CollapseId { value: value }) [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client.rs:80:13 [INFO] [stderr] | [INFO] [stderr] 80 | signer: signer, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `signer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client.rs:81:13 [INFO] [stderr] | [INFO] [stderr] 81 | endpoint: endpoint, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `endpoint` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client.rs:165:25 [INFO] [stderr] | [INFO] [stderr] 165 | apns_id: apns_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `apns_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client.rs:213:21 [INFO] [stderr] | [INFO] [stderr] 213 | apns_id: apns_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `apns_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/signer.rs:73:13 [INFO] [stderr] | [INFO] [stderr] 73 | issued_at: issued_at, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `issued_at` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/signer.rs:77:13 [INFO] [stderr] | [INFO] [stderr] 77 | signature: signature, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `signature` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/signer.rs:78:13 [INFO] [stderr] | [INFO] [stderr] 78 | key_id: key_id, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `key_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/signer.rs:79:13 [INFO] [stderr] | [INFO] [stderr] 79 | team_id: team_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `team_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/signer.rs:80:13 [INFO] [stderr] | [INFO] [stderr] 80 | secret: secret, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `secret` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/signer.rs:150:13 [INFO] [stderr] | [INFO] [stderr] 150 | issued_at: issued_at, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `issued_at` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/response.rs:227:22 [INFO] [stderr] | [INFO] [stderr] 227 | Some(1508249865488u64), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider: `1_508_249_865_488u64` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/client.rs:294:25 [INFO] [stderr] | [INFO] [stderr] 294 | const PRIVATE_KEY: &'static str = indoc!( [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/signer.rs:167:25 [INFO] [stderr] | [INFO] [stderr] 167 | const PRIVATE_KEY: &'static str = indoc!( [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/request/notification/localized.rs:172:30 [INFO] [stderr] | [INFO] [stderr] 172 | self.category = Some(category.into()); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider removing `.into()`: `category` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/request/notification/plain.rs:97:27 [INFO] [stderr] | [INFO] [stderr] 97 | self.sound = Some(sound.into()); [INFO] [stderr] | ^^^^^^^^^^^^ help: consider removing `.into()`: `sound` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `request::notification::silent::SilentNotificationBuilder` [INFO] [stderr] --> src/request/notification/silent.rs:51:5 [INFO] [stderr] | [INFO] [stderr] 51 | / pub fn new() -> SilentNotificationBuilder { [INFO] [stderr] 52 | | SilentNotificationBuilder { [INFO] [stderr] 53 | | content_available: 1, [INFO] [stderr] 54 | | } [INFO] [stderr] 55 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 30 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/request/notification/options.rs:94:24 [INFO] [stderr] | [INFO] [stderr] 94 | let priority = match self { [INFO] [stderr] | ________________________^ [INFO] [stderr] 95 | | &Priority::High => "10", [INFO] [stderr] 96 | | &Priority::Normal => "5", [INFO] [stderr] 97 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 94 | let priority = match *self { [INFO] [stderr] 95 | Priority::High => "10", [INFO] [stderr] 96 | Priority::Normal => "5", [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/request/payload.rs:90:27 [INFO] [stderr] | [INFO] [stderr] 90 | pub fn to_json_string(mut self) -> Result { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/error.rs:39:9 [INFO] [stderr] | [INFO] [stderr] 39 | / match self { [INFO] [stderr] 40 | | &Error::ResponseError(Response { error: Some(ErrorBody { ref reason, .. }), .. }) => { [INFO] [stderr] 41 | | write!(fmt, "{} (reason: {:?})", self.description(), reason) [INFO] [stderr] 42 | | }, [INFO] [stderr] 43 | | _ => write!(fmt, "{}", self.description()), [INFO] [stderr] 44 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 39 | match *self { [INFO] [stderr] 40 | Error::ResponseError(Response { error: Some(ErrorBody { ref reason, .. }), .. }) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/error.rs:50:9 [INFO] [stderr] | [INFO] [stderr] 50 | / match self { [INFO] [stderr] 51 | | &Error::SerializeError => "Error serializing to JSON", [INFO] [stderr] 52 | | &Error::ConnectionError => "Error connecting to APNs", [INFO] [stderr] 53 | | &Error::SignerError(_) => "Error creating a signature", [INFO] [stderr] ... | [INFO] [stderr] 58 | | &Error::TimeoutError => "Timeout in sending a push notification", [INFO] [stderr] 59 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 50 | match *self { [INFO] [stderr] 51 | Error::SerializeError => "Error serializing to JSON", [INFO] [stderr] 52 | Error::ConnectionError => "Error connecting to APNs", [INFO] [stderr] 53 | Error::SignerError(_) => "Error creating a signature", [INFO] [stderr] 54 | Error::ResponseError(_) => "Notification was not accepted by APNs", [INFO] [stderr] 55 | Error::InvalidOptions(_) => "Invalid options for APNs payload", [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/error.rs:81:28 [INFO] [stderr] | [INFO] [stderr] 81 | Error::SignerError(format!("{}", e.description())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `e.description().to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/error.rs:87:26 [INFO] [stderr] | [INFO] [stderr] 87 | Error::ReadError(format!("{}", e.description())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `e.description().to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/client.rs:43:20 [INFO] [stderr] | [INFO] [stderr] 43 | let host = match self { [INFO] [stderr] | ____________________^ [INFO] [stderr] 44 | | &Endpoint::Production => "api.push.apple.com", [INFO] [stderr] 45 | | &Endpoint::Sandbox => "api.development.push.apple.com", [INFO] [stderr] 46 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 43 | let host = match *self { [INFO] [stderr] 44 | Endpoint::Production => "api.push.apple.com", [INFO] [stderr] 45 | Endpoint::Sandbox => "api.development.push.apple.com", [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/client.rs:160:22 [INFO] [stderr] | [INFO] [stderr] 160 | .map(|id| String::from(id)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `String::from` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/client.rs:200:31 [INFO] [stderr] | [INFO] [stderr] 200 | let response_status = response.status().clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `response.status()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/client.rs:247:48 [INFO] [stderr] | [INFO] [stderr] 247 | builder.header("apns-collapse-id", format!("{}", apns_collapse_id.value).as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `apns_collapse_id.value.to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/signer.rs:106:12 [INFO] [stderr] | [INFO] [stderr] 106 | Ok(f(&signature.key)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 106 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/request/notification/localized.rs:172:30 [INFO] [stderr] | [INFO] [stderr] 172 | self.category = Some(category.into()); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider removing `.into()`: `category` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/request/notification/plain.rs:97:27 [INFO] [stderr] | [INFO] [stderr] 97 | self.sound = Some(sound.into()); [INFO] [stderr] | ^^^^^^^^^^^^ help: consider removing `.into()`: `sound` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `request::notification::silent::SilentNotificationBuilder` [INFO] [stderr] --> src/request/notification/silent.rs:51:5 [INFO] [stderr] | [INFO] [stderr] 51 | / pub fn new() -> SilentNotificationBuilder { [INFO] [stderr] 52 | | SilentNotificationBuilder { [INFO] [stderr] 53 | | content_available: 1, [INFO] [stderr] 54 | | } [INFO] [stderr] 55 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 30 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/request/notification/options.rs:94:24 [INFO] [stderr] | [INFO] [stderr] 94 | let priority = match self { [INFO] [stderr] | ________________________^ [INFO] [stderr] 95 | | &Priority::High => "10", [INFO] [stderr] 96 | | &Priority::Normal => "5", [INFO] [stderr] 97 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 94 | let priority = match *self { [INFO] [stderr] 95 | Priority::High => "10", [INFO] [stderr] 96 | Priority::Normal => "5", [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/request/payload.rs:90:27 [INFO] [stderr] | [INFO] [stderr] 90 | pub fn to_json_string(mut self) -> Result { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/error.rs:39:9 [INFO] [stderr] | [INFO] [stderr] 39 | / match self { [INFO] [stderr] 40 | | &Error::ResponseError(Response { error: Some(ErrorBody { ref reason, .. }), .. }) => { [INFO] [stderr] 41 | | write!(fmt, "{} (reason: {:?})", self.description(), reason) [INFO] [stderr] 42 | | }, [INFO] [stderr] 43 | | _ => write!(fmt, "{}", self.description()), [INFO] [stderr] 44 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 39 | match *self { [INFO] [stderr] 40 | Error::ResponseError(Response { error: Some(ErrorBody { ref reason, .. }), .. }) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/error.rs:50:9 [INFO] [stderr] | [INFO] [stderr] 50 | / match self { [INFO] [stderr] 51 | | &Error::SerializeError => "Error serializing to JSON", [INFO] [stderr] 52 | | &Error::ConnectionError => "Error connecting to APNs", [INFO] [stderr] 53 | | &Error::SignerError(_) => "Error creating a signature", [INFO] [stderr] ... | [INFO] [stderr] 58 | | &Error::TimeoutError => "Timeout in sending a push notification", [INFO] [stderr] 59 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 50 | match *self { [INFO] [stderr] 51 | Error::SerializeError => "Error serializing to JSON", [INFO] [stderr] 52 | Error::ConnectionError => "Error connecting to APNs", [INFO] [stderr] 53 | Error::SignerError(_) => "Error creating a signature", [INFO] [stderr] 54 | Error::ResponseError(_) => "Notification was not accepted by APNs", [INFO] [stderr] 55 | Error::InvalidOptions(_) => "Invalid options for APNs payload", [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/error.rs:81:28 [INFO] [stderr] | [INFO] [stderr] 81 | Error::SignerError(format!("{}", e.description())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `e.description().to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/error.rs:87:26 [INFO] [stderr] | [INFO] [stderr] 87 | Error::ReadError(format!("{}", e.description())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `e.description().to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/client.rs:43:20 [INFO] [stderr] | [INFO] [stderr] 43 | let host = match self { [INFO] [stderr] | ____________________^ [INFO] [stderr] 44 | | &Endpoint::Production => "api.push.apple.com", [INFO] [stderr] 45 | | &Endpoint::Sandbox => "api.development.push.apple.com", [INFO] [stderr] 46 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 43 | let host = match *self { [INFO] [stderr] 44 | Endpoint::Production => "api.push.apple.com", [INFO] [stderr] 45 | Endpoint::Sandbox => "api.development.push.apple.com", [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/client.rs:160:22 [INFO] [stderr] | [INFO] [stderr] 160 | .map(|id| String::from(id)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `String::from` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/client.rs:200:31 [INFO] [stderr] | [INFO] [stderr] 200 | let response_status = response.status().clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `response.status()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/client.rs:247:48 [INFO] [stderr] | [INFO] [stderr] 247 | builder.header("apns-collapse-id", format!("{}", apns_collapse_id.value).as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `apns_collapse_id.value.to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/signer.rs:106:12 [INFO] [stderr] | [INFO] [stderr] 106 | Ok(f(&signature.key)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 106 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 40.17s [INFO] running `"docker" "inspect" "5d28ff8c2deb651dfb1afeb0940e0852595100d7b16f6f186fcd43fb72b1d14e"` [INFO] running `"docker" "rm" "-f" "5d28ff8c2deb651dfb1afeb0940e0852595100d7b16f6f186fcd43fb72b1d14e"` [INFO] [stdout] 5d28ff8c2deb651dfb1afeb0940e0852595100d7b16f6f186fcd43fb72b1d14e