[INFO] crate RustyXML 0.1.1 is already in cache [INFO] extracting crate RustyXML 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/RustyXML/0.1.1 [INFO] extracting crate RustyXML 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/RustyXML/0.1.1 [INFO] validating manifest of RustyXML-0.1.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of RustyXML-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing RustyXML-0.1.1 [INFO] finished frobbing RustyXML-0.1.1 [INFO] frobbed toml for RustyXML-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/RustyXML/0.1.1/Cargo.toml [INFO] started frobbing RustyXML-0.1.1 [INFO] finished frobbing RustyXML-0.1.1 [INFO] frobbed toml for RustyXML-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/RustyXML/0.1.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting RustyXML-0.1.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/RustyXML/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 73fd464d3f35679217c9ddee0243b0e8e647c38ee09c5dcf7a02c5817f785b14 [INFO] running `"docker" "start" "-a" "73fd464d3f35679217c9ddee0243b0e8e647c38ee09c5dcf7a02c5817f785b14"` [INFO] [stderr] Checking RustyXML v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:207:59 [INFO] [stderr] | [INFO] [stderr] 207 | Err(ParserError { line: self.line, col: self.col, msg: msg }) [INFO] [stderr] | ^^^^^^^^ help: replace it with: `msg` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:318:21 [INFO] [stderr] | [INFO] [stderr] 318 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:319:21 [INFO] [stderr] | [INFO] [stderr] 319 | ns: ns, [INFO] [stderr] | ^^^^^^ help: replace it with: `ns` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:320:21 [INFO] [stderr] | [INFO] [stderr] 320 | prefix: prefix, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `prefix` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:366:52 [INFO] [stderr] | [INFO] [stderr] 366 | Ok(Some(Event::ElementEnd(EndTag { name: name, ns: ns, prefix: prefix }))) [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:366:64 [INFO] [stderr] | [INFO] [stderr] 366 | Ok(Some(Event::ElementEnd(EndTag { name: name, ns: ns, prefix: prefix }))) [INFO] [stderr] | ^^^^^^ help: replace it with: `ns` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:366:72 [INFO] [stderr] | [INFO] [stderr] 366 | Ok(Some(Event::ElementEnd(EndTag { name: name, ns: ns, prefix: prefix }))) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `prefix` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:418:21 [INFO] [stderr] | [INFO] [stderr] 418 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:419:21 [INFO] [stderr] | [INFO] [stderr] 419 | ns: ns, [INFO] [stderr] | ^^^^^^ help: replace it with: `ns` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:420:21 [INFO] [stderr] | [INFO] [stderr] 420 | prefix: prefix, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `prefix` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:522:52 [INFO] [stderr] | [INFO] [stderr] 522 | Ok(Some(Event::ElementEnd(EndTag { name: name, ns: ns, prefix: prefix }))) [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:522:64 [INFO] [stderr] | [INFO] [stderr] 522 | Ok(Some(Event::ElementEnd(EndTag { name: name, ns: ns, prefix: prefix }))) [INFO] [stderr] | ^^^^^^ help: replace it with: `ns` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:522:72 [INFO] [stderr] | [INFO] [stderr] 522 | Ok(Some(Event::ElementEnd(EndTag { name: name, ns: ns, prefix: prefix }))) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `prefix` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/element.rs:135:13 [INFO] [stderr] | [INFO] [stderr] 135 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/element.rs:138:13 [INFO] [stderr] | [INFO] [stderr] 138 | prefixes: prefixes, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `prefixes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/element.rs:139:13 [INFO] [stderr] | [INFO] [stderr] 139 | attributes: attributes, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `attributes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/element.rs:189:13 [INFO] [stderr] | [INFO] [stderr] 189 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/element.rs:190:13 [INFO] [stderr] | [INFO] [stderr] 190 | ns: ns [INFO] [stderr] | ^^^^^^ help: replace it with: `ns` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/element_builder.rs:83:13 [INFO] [stderr] | [INFO] [stderr] 83 | prefixes: prefixes [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `prefixes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/element_builder.rs:120:21 [INFO] [stderr] | [INFO] [stderr] 120 | attributes: attributes, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `attributes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:207:59 [INFO] [stderr] | [INFO] [stderr] 207 | Err(ParserError { line: self.line, col: self.col, msg: msg }) [INFO] [stderr] | ^^^^^^^^ help: replace it with: `msg` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:318:21 [INFO] [stderr] | [INFO] [stderr] 318 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:319:21 [INFO] [stderr] | [INFO] [stderr] 319 | ns: ns, [INFO] [stderr] | ^^^^^^ help: replace it with: `ns` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:320:21 [INFO] [stderr] | [INFO] [stderr] 320 | prefix: prefix, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `prefix` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:366:52 [INFO] [stderr] | [INFO] [stderr] 366 | Ok(Some(Event::ElementEnd(EndTag { name: name, ns: ns, prefix: prefix }))) [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:366:64 [INFO] [stderr] | [INFO] [stderr] 366 | Ok(Some(Event::ElementEnd(EndTag { name: name, ns: ns, prefix: prefix }))) [INFO] [stderr] | ^^^^^^ help: replace it with: `ns` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:366:72 [INFO] [stderr] | [INFO] [stderr] 366 | Ok(Some(Event::ElementEnd(EndTag { name: name, ns: ns, prefix: prefix }))) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `prefix` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:418:21 [INFO] [stderr] | [INFO] [stderr] 418 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:419:21 [INFO] [stderr] | [INFO] [stderr] 419 | ns: ns, [INFO] [stderr] | ^^^^^^ help: replace it with: `ns` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:420:21 [INFO] [stderr] | [INFO] [stderr] 420 | prefix: prefix, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `prefix` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:522:52 [INFO] [stderr] | [INFO] [stderr] 522 | Ok(Some(Event::ElementEnd(EndTag { name: name, ns: ns, prefix: prefix }))) [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:522:64 [INFO] [stderr] | [INFO] [stderr] 522 | Ok(Some(Event::ElementEnd(EndTag { name: name, ns: ns, prefix: prefix }))) [INFO] [stderr] | ^^^^^^ help: replace it with: `ns` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:522:72 [INFO] [stderr] | [INFO] [stderr] 522 | Ok(Some(Event::ElementEnd(EndTag { name: name, ns: ns, prefix: prefix }))) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `prefix` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/element.rs:135:13 [INFO] [stderr] | [INFO] [stderr] 135 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/element.rs:138:13 [INFO] [stderr] | [INFO] [stderr] 138 | prefixes: prefixes, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `prefixes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/element.rs:139:13 [INFO] [stderr] | [INFO] [stderr] 139 | attributes: attributes, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `attributes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/element.rs:189:13 [INFO] [stderr] | [INFO] [stderr] 189 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/element.rs:190:13 [INFO] [stderr] | [INFO] [stderr] 190 | ns: ns [INFO] [stderr] | ^^^^^^ help: replace it with: `ns` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/element_builder.rs:83:13 [INFO] [stderr] | [INFO] [stderr] 83 | prefixes: prefixes [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `prefixes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/element_builder.rs:120:21 [INFO] [stderr] | [INFO] [stderr] 120 | attributes: attributes, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `attributes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/element.rs:202:9 [INFO] [stderr] | [INFO] [stderr] 202 | elem [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/element.rs:198:20 [INFO] [stderr] | [INFO] [stderr] 198 | let elem = match self.children.last_mut().expect(error) { [INFO] [stderr] | ____________________^ [INFO] [stderr] 199 | | &mut Xml::ElementNode(ref mut elem) => elem, [INFO] [stderr] 200 | | _ => panic!(error) [INFO] [stderr] 201 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/element_builder.rs:114:54 [INFO] [stderr] | [INFO] [stderr] 114 | Event::ElementStart(StartTag { name, ns, prefix: _, attributes }) => { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unneeded_field_pattern)] on by default [INFO] [stderr] = help: Try with `StartTag { name, ns, attributes, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/element_builder.rs:147:50 [INFO] [stderr] | [INFO] [stderr] 147 | Event::ElementEnd(EndTag { name, ns, prefix: _ }) => { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `EndTag { name, ns, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] error[E0554]: #![feature] may not be used on the stable release channel [INFO] [stderr] --> src/lib.rs:13:19 [INFO] [stderr] | [INFO] [stderr] 13 | #![cfg_attr(test, feature(test))] [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0554`. [INFO] [stderr] error: Could not compile `RustyXML`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: you should consider adding a `Default` implementation for `parser::Parser` [INFO] [stderr] --> src/parser.rs:117:5 [INFO] [stderr] | [INFO] [stderr] 117 | / pub fn new() -> Parser { [INFO] [stderr] 118 | | let mut ns = HashMap::with_capacity(2); [INFO] [stderr] 119 | | // Add standard namespaces [INFO] [stderr] 120 | | ns.insert("xml".to_string(), "http://www.w3.org/XML/1998/namespace".to_string()); [INFO] [stderr] ... | [INFO] [stderr] 136 | | } [INFO] [stderr] 137 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 115 | impl Default for parser::Parser { [INFO] [stderr] 116 | fn default() -> Self { [INFO] [stderr] 117 | Self::new() [INFO] [stderr] 118 | } [INFO] [stderr] 119 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/parser.rs:197:20 [INFO] [stderr] | [INFO] [stderr] 197 | if namespace.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `namespace.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/parser.rs:238:20 [INFO] [stderr] | [INFO] [stderr] 238 | '<' if self.buf.len() > 0 => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.buf.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/element.rs:72:8 [INFO] [stderr] | [INFO] [stderr] 72 | if elem.children.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `elem.children.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/element.rs:198:20 [INFO] [stderr] | [INFO] [stderr] 198 | let elem = match self.children.last_mut().expect(error) { [INFO] [stderr] | ____________________^ [INFO] [stderr] 199 | | &mut Xml::ElementNode(ref mut elem) => elem, [INFO] [stderr] 200 | | _ => panic!(error) [INFO] [stderr] 201 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 198 | let elem = match *self.children.last_mut().expect(error) { [INFO] [stderr] 199 | Xml::ElementNode(ref mut elem) => elem, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/element.rs:244:9 [INFO] [stderr] | [INFO] [stderr] 244 | / for event in p.filter_map(|x| e.handle_event(x)) { [INFO] [stderr] 245 | | return event; [INFO] [stderr] 246 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::never_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `element_builder::ElementBuilder` [INFO] [stderr] --> src/element_builder.rs:76:5 [INFO] [stderr] | [INFO] [stderr] 76 | / pub fn new() -> ElementBuilder { [INFO] [stderr] 77 | | let mut prefixes = HashMap::with_capacity(2); [INFO] [stderr] 78 | | prefixes.insert("http://www.w3.org/XML/1998/namespace".to_string(), "xml".to_string()); [INFO] [stderr] 79 | | prefixes.insert("http://www.w3.org/2000/xmlns/".to_string(), "xmlns".to_string()); [INFO] [stderr] ... | [INFO] [stderr] 84 | | } [INFO] [stderr] 85 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 68 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/element_builder.rs:124:40 [INFO] [stderr] | [INFO] [stderr] 124 | if let Some(default) = self.default_ns.last().map(|x| x.clone()) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.default_ns.last().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/element_builder.rs:131:28 [INFO] [stderr] | [INFO] [stderr] 131 | if value.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `value.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:81:51 [INFO] [stderr] | [INFO] [stderr] 81 | } else if ent.starts_with("#") { [INFO] [stderr] | ^^^ help: try using a char instead: `'#'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `RustyXML`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "73fd464d3f35679217c9ddee0243b0e8e647c38ee09c5dcf7a02c5817f785b14"` [INFO] running `"docker" "rm" "-f" "73fd464d3f35679217c9ddee0243b0e8e647c38ee09c5dcf7a02c5817f785b14"` [INFO] [stdout] 73fd464d3f35679217c9ddee0243b0e8e647c38ee09c5dcf7a02c5817f785b14