[INFO] crate RustyEmitter 2.2.0 is already in cache [INFO] extracting crate RustyEmitter 2.2.0 into work/ex/clippy-test-run/sources/stable/reg/RustyEmitter/2.2.0 [INFO] extracting crate RustyEmitter 2.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/RustyEmitter/2.2.0 [INFO] validating manifest of RustyEmitter-2.2.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of RustyEmitter-2.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing RustyEmitter-2.2.0 [INFO] finished frobbing RustyEmitter-2.2.0 [INFO] frobbed toml for RustyEmitter-2.2.0 written to work/ex/clippy-test-run/sources/stable/reg/RustyEmitter/2.2.0/Cargo.toml [INFO] started frobbing RustyEmitter-2.2.0 [INFO] finished frobbing RustyEmitter-2.2.0 [INFO] frobbed toml for RustyEmitter-2.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/RustyEmitter/2.2.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting RustyEmitter-2.2.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/RustyEmitter/2.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 5be530be1bec9bef205e45b0b30580a40a9de94be2649bb585b725501bc3c84c [INFO] running `"docker" "start" "-a" "5be530be1bec9bef205e45b0b30580a40a9de94be2649bb585b725501bc3c84c"` [INFO] [stderr] warning: only one of `license` or `license-file` is necessary [INFO] [stderr] warning: unused manifest key: rust [INFO] [stderr] Checking RustyEmitter v2.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: crate `RustyEmitter` should have a snake case name such as `rusty_emitter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable `EventData` should have a snake case name such as `event_data` [INFO] [stderr] --> src/lib.rs:10:42 [INFO] [stderr] | [INFO] [stderr] 10 | fn emit(&mut self, event_name: String, EventData: & mut EventData); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `Emitter<'callback, T>` [INFO] [stderr] --> src/lib.rs:18:3 [INFO] [stderr] | [INFO] [stderr] 18 | / pub fn new() -> Emitter<'callback, T> { [INFO] [stderr] 19 | | Emitter { [INFO] [stderr] 20 | | events: HashMap::new() [INFO] [stderr] 21 | | } [INFO] [stderr] 22 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 13 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/lib.rs:27:5 [INFO] [stderr] | [INFO] [stderr] 27 | / if self.events.contains_key(&event_name) { [INFO] [stderr] 28 | | match self.events.get_mut(&event_name) { [INFO] [stderr] 29 | | Some(callbacks) => callbacks.push(callback), [INFO] [stderr] 30 | | None => (), [INFO] [stderr] ... | [INFO] [stderr] 34 | | self.events.insert(event_name, vec); [INFO] [stderr] 35 | | } [INFO] [stderr] | |_____^ help: consider using: `self.events.entry(event_name)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_entry)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:28:7 [INFO] [stderr] | [INFO] [stderr] 28 | / match self.events.get_mut(&event_name) { [INFO] [stderr] 29 | | Some(callbacks) => callbacks.push(callback), [INFO] [stderr] 30 | | None => (), [INFO] [stderr] 31 | | } [INFO] [stderr] | |_______^ help: try this: `if let Some(callbacks) = self.events.get_mut(&event_name) { callbacks.push(callback) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:42:5 [INFO] [stderr] | [INFO] [stderr] 42 | / match self.events.get_mut(&event_name) { [INFO] [stderr] 43 | | Some(callbacks) => { [INFO] [stderr] 44 | | for callback in callbacks.iter_mut() { [INFO] [stderr] 45 | | (*callback)(event_data); [INFO] [stderr] ... | [INFO] [stderr] 48 | | _ => {;} [INFO] [stderr] 49 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 42 | if let Some(callbacks) = self.events.get_mut(&event_name) { [INFO] [stderr] 43 | for callback in callbacks.iter_mut() { [INFO] [stderr] 44 | (*callback)(event_data); [INFO] [stderr] 45 | } [INFO] [stderr] 46 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: crate `RustyEmitter` should have a snake case name such as `rusty_emitter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable `EventData` should have a snake case name such as `event_data` [INFO] [stderr] --> src/lib.rs:10:42 [INFO] [stderr] | [INFO] [stderr] 10 | fn emit(&mut self, event_name: String, EventData: & mut EventData); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `Emitter<'callback, T>` [INFO] [stderr] --> src/lib.rs:18:3 [INFO] [stderr] | [INFO] [stderr] 18 | / pub fn new() -> Emitter<'callback, T> { [INFO] [stderr] 19 | | Emitter { [INFO] [stderr] 20 | | events: HashMap::new() [INFO] [stderr] 21 | | } [INFO] [stderr] 22 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 13 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/lib.rs:27:5 [INFO] [stderr] | [INFO] [stderr] 27 | / if self.events.contains_key(&event_name) { [INFO] [stderr] 28 | | match self.events.get_mut(&event_name) { [INFO] [stderr] 29 | | Some(callbacks) => callbacks.push(callback), [INFO] [stderr] 30 | | None => (), [INFO] [stderr] ... | [INFO] [stderr] 34 | | self.events.insert(event_name, vec); [INFO] [stderr] 35 | | } [INFO] [stderr] | |_____^ help: consider using: `self.events.entry(event_name)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_entry)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:28:7 [INFO] [stderr] | [INFO] [stderr] 28 | / match self.events.get_mut(&event_name) { [INFO] [stderr] 29 | | Some(callbacks) => callbacks.push(callback), [INFO] [stderr] 30 | | None => (), [INFO] [stderr] 31 | | } [INFO] [stderr] | |_______^ help: try this: `if let Some(callbacks) = self.events.get_mut(&event_name) { callbacks.push(callback) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:42:5 [INFO] [stderr] | [INFO] [stderr] 42 | / match self.events.get_mut(&event_name) { [INFO] [stderr] 43 | | Some(callbacks) => { [INFO] [stderr] 44 | | for callback in callbacks.iter_mut() { [INFO] [stderr] 45 | | (*callback)(event_data); [INFO] [stderr] ... | [INFO] [stderr] 48 | | _ => {;} [INFO] [stderr] 49 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 42 | if let Some(callbacks) = self.events.get_mut(&event_name) { [INFO] [stderr] 43 | for callback in callbacks.iter_mut() { [INFO] [stderr] 44 | (*callback)(event_data); [INFO] [stderr] 45 | } [INFO] [stderr] 46 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: variable `EventData` should have a snake case name such as `event_data` [INFO] [stderr] --> tests/../src/lib.rs:10:42 [INFO] [stderr] | [INFO] [stderr] 10 | fn emit(&mut self, event_name: String, EventData: & mut EventData); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> tests/../src/lib.rs:27:5 [INFO] [stderr] | [INFO] [stderr] 27 | / if self.events.contains_key(&event_name) { [INFO] [stderr] 28 | | match self.events.get_mut(&event_name) { [INFO] [stderr] 29 | | Some(callbacks) => callbacks.push(callback), [INFO] [stderr] 30 | | None => (), [INFO] [stderr] ... | [INFO] [stderr] 34 | | self.events.insert(event_name, vec); [INFO] [stderr] 35 | | } [INFO] [stderr] | |_____^ help: consider using: `self.events.entry(event_name)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_entry)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> tests/../src/lib.rs:28:7 [INFO] [stderr] | [INFO] [stderr] 28 | / match self.events.get_mut(&event_name) { [INFO] [stderr] 29 | | Some(callbacks) => callbacks.push(callback), [INFO] [stderr] 30 | | None => (), [INFO] [stderr] 31 | | } [INFO] [stderr] | |_______^ help: try this: `if let Some(callbacks) = self.events.get_mut(&event_name) { callbacks.push(callback) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> tests/../src/lib.rs:42:5 [INFO] [stderr] | [INFO] [stderr] 42 | / match self.events.get_mut(&event_name) { [INFO] [stderr] 43 | | Some(callbacks) => { [INFO] [stderr] 44 | | for callback in callbacks.iter_mut() { [INFO] [stderr] 45 | | (*callback)(event_data); [INFO] [stderr] ... | [INFO] [stderr] 48 | | _ => {;} [INFO] [stderr] 49 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 42 | if let Some(callbacks) = self.events.get_mut(&event_name) { [INFO] [stderr] 43 | for callback in callbacks.iter_mut() { [INFO] [stderr] 44 | (*callback)(event_data); [INFO] [stderr] 45 | } [INFO] [stderr] 46 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> tests/emitter.rs:125:28 [INFO] [stderr] | [INFO] [stderr] 125 | if data.bar != "HAHAHA".to_string() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `"HAHAHA"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cmp_owned)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.43s [INFO] running `"docker" "inspect" "5be530be1bec9bef205e45b0b30580a40a9de94be2649bb585b725501bc3c84c"` [INFO] running `"docker" "rm" "-f" "5be530be1bec9bef205e45b0b30580a40a9de94be2649bb585b725501bc3c84c"` [INFO] [stdout] 5be530be1bec9bef205e45b0b30580a40a9de94be2649bb585b725501bc3c84c