[INFO] crate MacTypes-sys 2.0.2 is already in cache [INFO] extracting crate MacTypes-sys 2.0.2 into work/ex/clippy-test-run/sources/stable/reg/MacTypes-sys/2.0.2 [INFO] extracting crate MacTypes-sys 2.0.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/MacTypes-sys/2.0.2 [INFO] validating manifest of MacTypes-sys-2.0.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of MacTypes-sys-2.0.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing MacTypes-sys-2.0.2 [INFO] finished frobbing MacTypes-sys-2.0.2 [INFO] frobbed toml for MacTypes-sys-2.0.2 written to work/ex/clippy-test-run/sources/stable/reg/MacTypes-sys/2.0.2/Cargo.toml [INFO] started frobbing MacTypes-sys-2.0.2 [INFO] finished frobbing MacTypes-sys-2.0.2 [INFO] frobbed toml for MacTypes-sys-2.0.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/MacTypes-sys/2.0.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting MacTypes-sys-2.0.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/MacTypes-sys/2.0.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 85299dcd72497ccf7815a94d67c79a19212ff847a3cf16d030cf663ff9554550 [INFO] running `"docker" "start" "-a" "85299dcd72497ccf7815a94d67c79a19212ff847a3cf16d030cf663ff9554550"` [INFO] [stderr] Checking MacTypes-sys v2.0.2 (/opt/crater/workdir) [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:310:34 [INFO] [stderr] | [INFO] [stderr] 310 | pub const kUnknownType: OSType = 0x3F3F3F3F; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x3F3F_3F3F` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:310:34 [INFO] [stderr] | [INFO] [stderr] 310 | pub const kUnknownType: OSType = 0x3F3F3F3F; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x3F3F_3F3F` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `random_string` [INFO] [stderr] --> src/lib.rs:714:18 [INFO] [stderr] | [INFO] [stderr] 714 | for i in 0..random_string.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 714 | for (i, ) in random_string.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/lib.rs:714:18 [INFO] [stderr] | [INFO] [stderr] 714 | for i in 0..random_string.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try replacing the loop by: `rec0.shortVersion[..random_string.len()].clone_from_slice(&random_string[..])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::manual_memcpy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:718:20 [INFO] [stderr] | [INFO] [stderr] 718 | let rec1 = rec0.clone(); [INFO] [stderr] | ^^^^^^^^^^^^ help: try removing the `clone` call: `rec0` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.13s [INFO] running `"docker" "inspect" "85299dcd72497ccf7815a94d67c79a19212ff847a3cf16d030cf663ff9554550"` [INFO] running `"docker" "rm" "-f" "85299dcd72497ccf7815a94d67c79a19212ff847a3cf16d030cf663ff9554550"` [INFO] [stdout] 85299dcd72497ccf7815a94d67c79a19212ff847a3cf16d030cf663ff9554550