[INFO] crate BuildEAR 3.1.0 is already in cache [INFO] extracting crate BuildEAR 3.1.0 into work/ex/clippy-test-run/sources/stable/reg/BuildEAR/3.1.0 [INFO] extracting crate BuildEAR 3.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/BuildEAR/3.1.0 [INFO] validating manifest of BuildEAR-3.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of BuildEAR-3.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing BuildEAR-3.1.0 [INFO] finished frobbing BuildEAR-3.1.0 [INFO] frobbed toml for BuildEAR-3.1.0 written to work/ex/clippy-test-run/sources/stable/reg/BuildEAR/3.1.0/Cargo.toml [INFO] started frobbing BuildEAR-3.1.0 [INFO] finished frobbing BuildEAR-3.1.0 [INFO] frobbed toml for BuildEAR-3.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/BuildEAR/3.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting BuildEAR-3.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/BuildEAR/3.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 0a079a586e1cb4f643428341144215d2481c1c076faebcf1597abec5d8b82750 [INFO] running `"docker" "start" "-a" "0a079a586e1cb4f643428341144215d2481c1c076faebcf1597abec5d8b82750"` [INFO] [stderr] Checking BuildEAR v3.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/trace.rs:39:17 [INFO] [stderr] | [INFO] [stderr] 39 | Trace { pid: pid, cwd: cwd, cmd: cmd } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pid` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/trace.rs:39:27 [INFO] [stderr] | [INFO] [stderr] 39 | Trace { pid: pid, cwd: cwd, cmd: cmd } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `cwd` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/trace.rs:39:37 [INFO] [stderr] | [INFO] [stderr] 39 | Trace { pid: pid, cwd: cwd, cmd: cmd } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `cmd` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/trace.rs:87:33 [INFO] [stderr] | [INFO] [stderr] 87 | Ok(TraceDirectory { input: input }) [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `input` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database.rs:42:13 [INFO] [stderr] | [INFO] [stderr] 42 | directory: directory, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `directory` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database.rs:43:13 [INFO] [stderr] | [INFO] [stderr] 43 | file: file, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `file` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database.rs:45:13 [INFO] [stderr] | [INFO] [stderr] 45 | output: output [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `output` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/trace.rs:39:17 [INFO] [stderr] | [INFO] [stderr] 39 | Trace { pid: pid, cwd: cwd, cmd: cmd } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pid` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/trace.rs:39:27 [INFO] [stderr] | [INFO] [stderr] 39 | Trace { pid: pid, cwd: cwd, cmd: cmd } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `cwd` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/trace.rs:39:37 [INFO] [stderr] | [INFO] [stderr] 39 | Trace { pid: pid, cwd: cwd, cmd: cmd } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `cmd` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/trace.rs:87:33 [INFO] [stderr] | [INFO] [stderr] 87 | Ok(TraceDirectory { input: input }) [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `input` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database.rs:42:13 [INFO] [stderr] | [INFO] [stderr] 42 | directory: directory, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `directory` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database.rs:43:13 [INFO] [stderr] | [INFO] [stderr] 43 | file: file, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `file` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database.rs:45:13 [INFO] [stderr] | [INFO] [stderr] 45 | output: output [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `output` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/trace.rs:94:27 [INFO] [stderr] | [INFO] [stderr] 94 | const EXTENSION: &'static str = ".process_start.json"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/parameters.rs:76:17 [INFO] [stderr] | [INFO] [stderr] 76 | const ENV_KEY: &'static str = "__BEAR"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/database.rs:98:47 [INFO] [stderr] | [INFO] [stderr] 98 | pub fn add_entry(&mut self, entry: Entry) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/database.rs:102:56 [INFO] [stderr] | [INFO] [stderr] 102 | pub fn add_entries(&mut self, entries: Vec) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/trace.rs:94:27 [INFO] [stderr] | [INFO] [stderr] 94 | const EXTENSION: &'static str = ".process_start.json"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/parameters.rs:76:17 [INFO] [stderr] | [INFO] [stderr] 76 | const ENV_KEY: &'static str = "__BEAR"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/database.rs:98:47 [INFO] [stderr] | [INFO] [stderr] 98 | pub fn add_entry(&mut self, entry: Entry) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/database.rs:102:56 [INFO] [stderr] | [INFO] [stderr] 102 | pub fn add_entries(&mut self, entries: Vec) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: field is never used: `compiler` [INFO] [stderr] --> src/compilation.rs:34:5 [INFO] [stderr] | [INFO] [stderr] 34 | compiler: path::PathBuf, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `phase` [INFO] [stderr] --> src/compilation.rs:35:5 [INFO] [stderr] | [INFO] [stderr] 35 | phase: CompilerPass, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `flags` [INFO] [stderr] --> src/compilation.rs:36:5 [INFO] [stderr] | [INFO] [stderr] 36 | flags: Vec, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `source` [INFO] [stderr] --> src/compilation.rs:37:5 [INFO] [stderr] | [INFO] [stderr] 37 | source: path::PathBuf, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `output` [INFO] [stderr] --> src/compilation.rs:38:5 [INFO] [stderr] | [INFO] [stderr] 38 | output: Option, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `cwd` [INFO] [stderr] --> src/compilation.rs:39:5 [INFO] [stderr] | [INFO] [stderr] 39 | cwd: path::PathBuf, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/trace.rs:56:25 [INFO] [stderr] | [INFO] [stderr] 56 | pub fn create(args: &Vec) -> Result { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 56 | pub fn create(args: &[String]) -> Result { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] help: change `args.clone()` to [INFO] [stderr] | [INFO] [stderr] 60 | Ok(Trace::new(pid, cwd, args.to_owned())) [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let result =` [INFO] [stderr] --> src/trace.rs:65:9 [INFO] [stderr] | [INFO] [stderr] 65 | let result = serde_json::to_writer(target, value)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/trace.rs:66:12 [INFO] [stderr] | [INFO] [stderr] 66 | Ok(result) [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 66 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] error: you are deriving `Hash` but have implemented `PartialEq` explicitly [INFO] [stderr] --> src/database.rs:28:10 [INFO] [stderr] | [INFO] [stderr] 28 | #[derive(Hash, Serialize, Deserialize)] [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::derive_hash_xor_eq)] on by default [INFO] [stderr] note: `PartialEq` implemented here [INFO] [stderr] --> src/database.rs:66:1 [INFO] [stderr] | [INFO] [stderr] 66 | / impl PartialEq for Entry { [INFO] [stderr] 67 | | fn eq(&self, other: &Entry) -> bool { [INFO] [stderr] 68 | | self.directory == other.directory && [INFO] [stderr] 69 | | self.file == other.file && [INFO] [stderr] 70 | | self.command == other.command [INFO] [stderr] 71 | | } [INFO] [stderr] 72 | | } [INFO] [stderr] | |_^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_hash_xor_eq [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `database::Database` [INFO] [stderr] --> src/database.rs:82:5 [INFO] [stderr] | [INFO] [stderr] 82 | / pub fn new() -> Database { [INFO] [stderr] 83 | | Database { entries: collections::HashSet::new() } [INFO] [stderr] 84 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 77 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let result =` [INFO] [stderr] --> src/database.rs:88:9 [INFO] [stderr] | [INFO] [stderr] 88 | let result = self.add_entries(entries); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/database.rs:89:12 [INFO] [stderr] | [INFO] [stderr] 89 | Ok(result) [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 89 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let result =` [INFO] [stderr] --> src/database.rs:94:9 [INFO] [stderr] | [INFO] [stderr] 94 | let result = serde_json::to_writer(target, &values)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/database.rs:95:12 [INFO] [stderr] | [INFO] [stderr] 95 | Ok(result) [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 95 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `BuildEAR`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: field is never used: `compiler` [INFO] [stderr] --> src/compilation.rs:34:5 [INFO] [stderr] | [INFO] [stderr] 34 | compiler: path::PathBuf, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `phase` [INFO] [stderr] --> src/compilation.rs:35:5 [INFO] [stderr] | [INFO] [stderr] 35 | phase: CompilerPass, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `flags` [INFO] [stderr] --> src/compilation.rs:36:5 [INFO] [stderr] | [INFO] [stderr] 36 | flags: Vec, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `source` [INFO] [stderr] --> src/compilation.rs:37:5 [INFO] [stderr] | [INFO] [stderr] 37 | source: path::PathBuf, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `output` [INFO] [stderr] --> src/compilation.rs:38:5 [INFO] [stderr] | [INFO] [stderr] 38 | output: Option, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `cwd` [INFO] [stderr] --> src/compilation.rs:39:5 [INFO] [stderr] | [INFO] [stderr] 39 | cwd: path::PathBuf, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/trace.rs:56:25 [INFO] [stderr] | [INFO] [stderr] 56 | pub fn create(args: &Vec) -> Result { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 56 | pub fn create(args: &[String]) -> Result { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] help: change `args.clone()` to [INFO] [stderr] | [INFO] [stderr] 60 | Ok(Trace::new(pid, cwd, args.to_owned())) [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let result =` [INFO] [stderr] --> src/trace.rs:65:9 [INFO] [stderr] | [INFO] [stderr] 65 | let result = serde_json::to_writer(target, value)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/trace.rs:66:12 [INFO] [stderr] | [INFO] [stderr] 66 | Ok(result) [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 66 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/trace.rs:135:24 [INFO] [stderr] | [INFO] [stderr] 135 | let mut data = r#"{ [INFO] [stderr] | ________________________^ [INFO] [stderr] 136 | | "pid": 12, [INFO] [stderr] 137 | | "ppid": 11, [INFO] [stderr] 138 | | "pppid": 10, [INFO] [stderr] ... | [INFO] [stderr] 144 | | ] [INFO] [stderr] 145 | | }"#.as_bytes(); [INFO] [stderr] | |________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::string_lit_as_bytes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] help: consider using a byte string literal instead [INFO] [stderr] | [INFO] [stderr] 135 | let mut data = br#"{ [INFO] [stderr] 136 | "pid": 12, [INFO] [stderr] 137 | "ppid": 11, [INFO] [stderr] 138 | "pppid": 10, [INFO] [stderr] 139 | "cwd": "/usr/home/user", [INFO] [stderr] 140 | "cmd": [ [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _result =` [INFO] [stderr] --> src/trace.rs:163:13 [INFO] [stderr] | [INFO] [stderr] 163 | let _result = Trace::write(&mut buffer, &expected).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] error: you are deriving `Hash` but have implemented `PartialEq` explicitly [INFO] [stderr] --> src/database.rs:28:10 [INFO] [stderr] | [INFO] [stderr] 28 | #[derive(Hash, Serialize, Deserialize)] [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::derive_hash_xor_eq)] on by default [INFO] [stderr] note: `PartialEq` implemented here [INFO] [stderr] --> src/database.rs:66:1 [INFO] [stderr] | [INFO] [stderr] 66 | / impl PartialEq for Entry { [INFO] [stderr] 67 | | fn eq(&self, other: &Entry) -> bool { [INFO] [stderr] 68 | | self.directory == other.directory && [INFO] [stderr] 69 | | self.file == other.file && [INFO] [stderr] 70 | | self.command == other.command [INFO] [stderr] 71 | | } [INFO] [stderr] 72 | | } [INFO] [stderr] | |_^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_hash_xor_eq [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `database::Database` [INFO] [stderr] --> src/database.rs:82:5 [INFO] [stderr] | [INFO] [stderr] 82 | / pub fn new() -> Database { [INFO] [stderr] 83 | | Database { entries: collections::HashSet::new() } [INFO] [stderr] 84 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 77 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let result =` [INFO] [stderr] --> src/database.rs:88:9 [INFO] [stderr] | [INFO] [stderr] 88 | let result = self.add_entries(entries); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/database.rs:89:12 [INFO] [stderr] | [INFO] [stderr] 89 | Ok(result) [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 89 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let result =` [INFO] [stderr] --> src/database.rs:94:9 [INFO] [stderr] | [INFO] [stderr] 94 | let result = serde_json::to_writer(target, &values)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/database.rs:95:12 [INFO] [stderr] | [INFO] [stderr] 95 | Ok(result) [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 95 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `BuildEAR`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "0a079a586e1cb4f643428341144215d2481c1c076faebcf1597abec5d8b82750"` [INFO] running `"docker" "rm" "-f" "0a079a586e1cb4f643428341144215d2481c1c076faebcf1597abec5d8b82750"` [INFO] [stdout] 0a079a586e1cb4f643428341144215d2481c1c076faebcf1597abec5d8b82750