[INFO] crate Boa 0.1.5 is already in cache [INFO] extracting crate Boa 0.1.5 into work/ex/clippy-test-run/sources/stable/reg/Boa/0.1.5 [INFO] extracting crate Boa 0.1.5 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/Boa/0.1.5 [INFO] validating manifest of Boa-0.1.5 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Boa-0.1.5 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Boa-0.1.5 [INFO] finished frobbing Boa-0.1.5 [INFO] frobbed toml for Boa-0.1.5 written to work/ex/clippy-test-run/sources/stable/reg/Boa/0.1.5/Cargo.toml [INFO] started frobbing Boa-0.1.5 [INFO] finished frobbing Boa-0.1.5 [INFO] frobbed toml for Boa-0.1.5 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/Boa/0.1.5/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Boa-0.1.5 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/Boa/0.1.5:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] dabf4b05e59ed43dbb333704a56963894161c817dfb08599290b1e518479309e [INFO] running `"docker" "start" "-a" "dabf4b05e59ed43dbb333704a56963894161c817dfb08599290b1e518479309e"` [INFO] [stderr] Checking gc v0.3.2 [INFO] [stderr] Compiling gc_derive v0.3.2 [INFO] [stderr] Checking Boa v0.1.5 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib/exec.rs:81:13 [INFO] [stderr] | [INFO] [stderr] 81 | this: this, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `this` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib/js/function.rs:43:13 [INFO] [stderr] | [INFO] [stderr] 43 | expr: expr, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `expr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib/js/function.rs:44:13 [INFO] [stderr] | [INFO] [stderr] 44 | args: args, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `args` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib/js/function.rs:63:13 [INFO] [stderr] | [INFO] [stderr] 63 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib/js/object.rs:36:13 [INFO] [stderr] | [INFO] [stderr] 36 | value: value, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/lib/js/value.rs:347:33 [INFO] [stderr] | [INFO] [stderr] 347 | write!(f, "{}", "}") [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/lib/js/value.rs:351:60 [INFO] [stderr] | [INFO] [stderr] 351 | Function::NativeFunc(_) => write!(f, "{}", "function() { [native code] }"), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib/syntax/ast/expr.rs:15:16 [INFO] [stderr] | [INFO] [stderr] 15 | Expr { def: def } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `def` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/lib/syntax/ast/expr.rs:116:33 [INFO] [stderr] | [INFO] [stderr] 116 | write!(f, "{}", "}") [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/lib/syntax/ast/expr.rs:186:58 [INFO] [stderr] | [INFO] [stderr] 186 | ExprDef::ReturnExpr(None) => write!(f, "{}", "return"), [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib/syntax/ast/pos.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | line_number: line_number, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `line_number` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib/syntax/ast/pos.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | column_number: column_number, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `column_number` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib/syntax/ast/token.rs:20:13 [INFO] [stderr] | [INFO] [stderr] 20 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib/syntax/parser.rs:46:13 [INFO] [stderr] | [INFO] [stderr] 46 | tokens: tokens, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `tokens` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib/exec.rs:81:13 [INFO] [stderr] | [INFO] [stderr] 81 | this: this, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `this` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib/js/function.rs:43:13 [INFO] [stderr] | [INFO] [stderr] 43 | expr: expr, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `expr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib/js/function.rs:44:13 [INFO] [stderr] | [INFO] [stderr] 44 | args: args, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `args` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib/js/function.rs:63:13 [INFO] [stderr] | [INFO] [stderr] 63 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib/js/object.rs:36:13 [INFO] [stderr] | [INFO] [stderr] 36 | value: value, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/lib/js/value.rs:347:33 [INFO] [stderr] | [INFO] [stderr] 347 | write!(f, "{}", "}") [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/lib/js/value.rs:351:60 [INFO] [stderr] | [INFO] [stderr] 351 | Function::NativeFunc(_) => write!(f, "{}", "function() { [native code] }"), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib/syntax/ast/expr.rs:15:16 [INFO] [stderr] | [INFO] [stderr] 15 | Expr { def: def } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `def` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/lib/syntax/ast/expr.rs:116:33 [INFO] [stderr] | [INFO] [stderr] 116 | write!(f, "{}", "}") [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/lib/syntax/ast/expr.rs:186:58 [INFO] [stderr] | [INFO] [stderr] 186 | ExprDef::ReturnExpr(None) => write!(f, "{}", "return"), [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib/syntax/ast/pos.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | line_number: line_number, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `line_number` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib/syntax/ast/pos.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | column_number: column_number, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `column_number` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib/syntax/ast/token.rs:20:13 [INFO] [stderr] | [INFO] [stderr] 20 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib/syntax/parser.rs:46:13 [INFO] [stderr] | [INFO] [stderr] 46 | tokens: tokens, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `tokens` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/lib/js/array.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | array [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/lib/js/array.rs:13:17 [INFO] [stderr] | [INFO] [stderr] 13 | let array = to_value(make_array as NativeFunctionData); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib/js/value.rs:386:9 [INFO] [stderr] | [INFO] [stderr] 386 | / return match (self.clone(), other.clone()) { [INFO] [stderr] 387 | | (ValueData::String(ref s), ref other) | (ref other, ValueData::String(ref s)) => { [INFO] [stderr] 388 | | ValueData::String(s.clone() + &other.to_string()) [INFO] [stderr] 389 | | } [INFO] [stderr] 390 | | (_, _) => ValueData::Number(self.to_num() + other.to_num()), [INFO] [stderr] 391 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 386 | match (self.clone(), other.clone()) { [INFO] [stderr] 387 | (ValueData::String(ref s), ref other) | (ref other, ValueData::String(ref s)) => { [INFO] [stderr] 388 | ValueData::String(s.clone() + &other.to_string()) [INFO] [stderr] 389 | } [INFO] [stderr] 390 | (_, _) => ValueData::Number(self.to_num() + other.to_num()), [INFO] [stderr] 391 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib/syntax/ast/constant.rs:24:9 [INFO] [stderr] | [INFO] [stderr] 24 | / return match *self { [INFO] [stderr] 25 | | Const::String(ref st) => write!(f, "\"{}\"", st), [INFO] [stderr] 26 | | Const::RegExp(ref reg, _, _) => write!(f, "~/{}/", reg), [INFO] [stderr] 27 | | Const::Num(num) => write!(f, "{}", num), [INFO] [stderr] ... | [INFO] [stderr] 31 | | Const::Undefined => write!(f, "undefined"), [INFO] [stderr] 32 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 24 | match *self { [INFO] [stderr] 25 | Const::String(ref st) => write!(f, "\"{}\"", st), [INFO] [stderr] 26 | Const::RegExp(ref reg, _, _) => write!(f, "~/{}/", reg), [INFO] [stderr] 27 | Const::Num(num) => write!(f, "{}", num), [INFO] [stderr] 28 | Const::Int(num) => write!(f, "{}", num), [INFO] [stderr] 29 | Const::Bool(v) => write!(f, "{}", v), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib/syntax/ast/expr.rs:109:9 [INFO] [stderr] | [INFO] [stderr] 109 | / return match *self { [INFO] [stderr] 110 | | ExprDef::ConstExpr(ref c) => write!(f, "{}", c), [INFO] [stderr] 111 | | ExprDef::BlockExpr(ref block) => { [INFO] [stderr] 112 | | try!(write!(f, "{}", "{")); [INFO] [stderr] ... | [INFO] [stderr] 199 | | ExprDef::TypeOfExpr(ref e) => write!(f, "typeof {}", e), [INFO] [stderr] 200 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 109 | match *self { [INFO] [stderr] 110 | ExprDef::ConstExpr(ref c) => write!(f, "{}", c), [INFO] [stderr] 111 | ExprDef::BlockExpr(ref block) => { [INFO] [stderr] 112 | try!(write!(f, "{}", "{")); [INFO] [stderr] 113 | for expr in block.iter() { [INFO] [stderr] 114 | try!(write!(f, "{};", expr)); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/lib/js/array.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | array [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/lib/js/array.rs:13:17 [INFO] [stderr] | [INFO] [stderr] 13 | let array = to_value(make_array as NativeFunctionData); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib/js/value.rs:386:9 [INFO] [stderr] | [INFO] [stderr] 386 | / return match (self.clone(), other.clone()) { [INFO] [stderr] 387 | | (ValueData::String(ref s), ref other) | (ref other, ValueData::String(ref s)) => { [INFO] [stderr] 388 | | ValueData::String(s.clone() + &other.to_string()) [INFO] [stderr] 389 | | } [INFO] [stderr] 390 | | (_, _) => ValueData::Number(self.to_num() + other.to_num()), [INFO] [stderr] 391 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 386 | match (self.clone(), other.clone()) { [INFO] [stderr] 387 | (ValueData::String(ref s), ref other) | (ref other, ValueData::String(ref s)) => { [INFO] [stderr] 388 | ValueData::String(s.clone() + &other.to_string()) [INFO] [stderr] 389 | } [INFO] [stderr] 390 | (_, _) => ValueData::Number(self.to_num() + other.to_num()), [INFO] [stderr] 391 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib/syntax/ast/constant.rs:24:9 [INFO] [stderr] | [INFO] [stderr] 24 | / return match *self { [INFO] [stderr] 25 | | Const::String(ref st) => write!(f, "\"{}\"", st), [INFO] [stderr] 26 | | Const::RegExp(ref reg, _, _) => write!(f, "~/{}/", reg), [INFO] [stderr] 27 | | Const::Num(num) => write!(f, "{}", num), [INFO] [stderr] ... | [INFO] [stderr] 31 | | Const::Undefined => write!(f, "undefined"), [INFO] [stderr] 32 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 24 | match *self { [INFO] [stderr] 25 | Const::String(ref st) => write!(f, "\"{}\"", st), [INFO] [stderr] 26 | Const::RegExp(ref reg, _, _) => write!(f, "~/{}/", reg), [INFO] [stderr] 27 | Const::Num(num) => write!(f, "{}", num), [INFO] [stderr] 28 | Const::Int(num) => write!(f, "{}", num), [INFO] [stderr] 29 | Const::Bool(v) => write!(f, "{}", v), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib/syntax/ast/expr.rs:109:9 [INFO] [stderr] | [INFO] [stderr] 109 | / return match *self { [INFO] [stderr] 110 | | ExprDef::ConstExpr(ref c) => write!(f, "{}", c), [INFO] [stderr] 111 | | ExprDef::BlockExpr(ref block) => { [INFO] [stderr] 112 | | try!(write!(f, "{}", "{")); [INFO] [stderr] ... | [INFO] [stderr] 199 | | ExprDef::TypeOfExpr(ref e) => write!(f, "typeof {}", e), [INFO] [stderr] 200 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 109 | match *self { [INFO] [stderr] 110 | ExprDef::ConstExpr(ref c) => write!(f, "{}", c), [INFO] [stderr] 111 | ExprDef::BlockExpr(ref block) => { [INFO] [stderr] 112 | try!(write!(f, "{}", "{")); [INFO] [stderr] 113 | for expr in block.iter() { [INFO] [stderr] 114 | try!(write!(f, "{};", expr)); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lib/exec.rs:48:9 [INFO] [stderr] | [INFO] [stderr] 48 | self.scopes.get(self.scopes.len() - 1).unwrap() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `self.scopes[self.scopes.len() - 1]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 40 [INFO] [stderr] --> src/lib/exec.rs:92:5 [INFO] [stderr] | [INFO] [stderr] 92 | / fn run(&mut self, expr: &Expr) -> ResultValue { [INFO] [stderr] 93 | | match expr.def { [INFO] [stderr] 94 | | ExprDef::ConstExpr(Const::Null) => Ok(to_value(None::<()>)), [INFO] [stderr] 95 | | ExprDef::ConstExpr(Const::Undefined) => Ok(Gc::new(ValueData::Undefined)), [INFO] [stderr] ... | [INFO] [stderr] 409 | | } [INFO] [stderr] 410 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib/exec.rs:120:55 [INFO] [stderr] | [INFO] [stderr] 120 | ValueData::Object(ref obj) => match obj.borrow().get(name) { [INFO] [stderr] | _______________________________________________________^ [INFO] [stderr] 121 | | Some(v) => { [INFO] [stderr] 122 | | val = v.value.clone(); [INFO] [stderr] 123 | | break; [INFO] [stderr] 124 | | } [INFO] [stderr] 125 | | None => (), [INFO] [stderr] 126 | | }, [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 120 | ValueData::Object(ref obj) => if let Some(v) = obj.borrow().get(name) { [INFO] [stderr] 121 | val = v.value.clone(); [INFO] [stderr] 122 | break; [INFO] [stderr] 123 | }, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lib/exec.rs:171:44 [INFO] [stderr] | [INFO] [stderr] 171 | let name = data.args.get(i).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `data.args[i]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lib/exec.rs:172:44 [INFO] [stderr] | [INFO] [stderr] 172 | let expr = v_args.get(i).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try this: `v_args[i]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lib/exec.rs:351:44 [INFO] [stderr] | [INFO] [stderr] 351 | let name = data.args.get(i).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `data.args[i]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lib/exec.rs:352:44 [INFO] [stderr] | [INFO] [stderr] 352 | let expr = v_args.get(i).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try this: `v_args[i]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/lib/js/error.rs:8:8 [INFO] [stderr] | [INFO] [stderr] 8 | if args.len() >= 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!args.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lib/js/error.rs:9:50 [INFO] [stderr] | [INFO] [stderr] 9 | this.set_field_slice("message", to_value(args.get(0).unwrap().to_string())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `&args[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lib/js/json.rs:10:46 [INFO] [stderr] | [INFO] [stderr] 10 | match serde_json::from_str::(&args.get(0).unwrap().clone().to_string()) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `&args[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lib/js/json.rs:17:15 [INFO] [stderr] | [INFO] [stderr] 17 | let obj = args.get(0).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `&args[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/lib/js/math.rs:8:20 [INFO] [stderr] | [INFO] [stderr] 8 | Ok(to_value(if args.len() >= 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!args.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lib/js/math.rs:9:27 [INFO] [stderr] | [INFO] [stderr] 9 | from_value::(args.get(0).unwrap().clone()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `&args[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/lib/js/math.rs:18:20 [INFO] [stderr] | [INFO] [stderr] 18 | Ok(to_value(if args.len() >= 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!args.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lib/js/math.rs:19:27 [INFO] [stderr] | [INFO] [stderr] 19 | from_value::(args.get(0).unwrap().clone()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `&args[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/lib/js/math.rs:28:20 [INFO] [stderr] | [INFO] [stderr] 28 | Ok(to_value(if args.len() >= 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!args.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lib/js/math.rs:29:27 [INFO] [stderr] | [INFO] [stderr] 29 | from_value::(args.get(0).unwrap().clone()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `&args[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/lib/js/math.rs:38:20 [INFO] [stderr] | [INFO] [stderr] 38 | Ok(to_value(if args.len() >= 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!args.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lib/js/math.rs:39:27 [INFO] [stderr] | [INFO] [stderr] 39 | from_value::(args.get(0).unwrap().clone()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `&args[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/lib/js/math.rs:48:20 [INFO] [stderr] | [INFO] [stderr] 48 | Ok(to_value(if args.len() >= 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!args.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lib/js/math.rs:49:27 [INFO] [stderr] | [INFO] [stderr] 49 | from_value::(args.get(0).unwrap().clone()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `&args[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lib/js/math.rs:51:20 [INFO] [stderr] | [INFO] [stderr] 51 | .atan2(args.get(1).unwrap().to_num()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `&args[1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/lib/js/math.rs:58:20 [INFO] [stderr] | [INFO] [stderr] 58 | Ok(to_value(if args.len() >= 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!args.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lib/js/math.rs:59:27 [INFO] [stderr] | [INFO] [stderr] 59 | from_value::(args.get(0).unwrap().clone()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `&args[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/lib/js/math.rs:68:20 [INFO] [stderr] | [INFO] [stderr] 68 | Ok(to_value(if args.len() >= 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!args.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lib/js/math.rs:69:27 [INFO] [stderr] | [INFO] [stderr] 69 | from_value::(args.get(0).unwrap().clone()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `&args[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/lib/js/math.rs:78:20 [INFO] [stderr] | [INFO] [stderr] 78 | Ok(to_value(if args.len() >= 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!args.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lib/js/math.rs:79:27 [INFO] [stderr] | [INFO] [stderr] 79 | from_value::(args.get(0).unwrap().clone()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `&args[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/lib/js/math.rs:88:20 [INFO] [stderr] | [INFO] [stderr] 88 | Ok(to_value(if args.len() >= 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!args.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lib/js/math.rs:89:27 [INFO] [stderr] | [INFO] [stderr] 89 | from_value::(args.get(0).unwrap().clone()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `&args[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/lib/js/math.rs:98:20 [INFO] [stderr] | [INFO] [stderr] 98 | Ok(to_value(if args.len() >= 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!args.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lib/js/math.rs:99:27 [INFO] [stderr] | [INFO] [stderr] 99 | from_value::(args.get(0).unwrap().clone()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `&args[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/lib/js/math.rs:108:20 [INFO] [stderr] | [INFO] [stderr] 108 | Ok(to_value(if args.len() >= 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!args.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lib/js/math.rs:109:27 [INFO] [stderr] | [INFO] [stderr] 109 | from_value::(args.get(0).unwrap().clone()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `&args[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lib/js/math.rs:137:35 [INFO] [stderr] | [INFO] [stderr] 137 | let num: f64 = from_value(args.get(0).unwrap().clone()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `&args[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lib/js/math.rs:138:37 [INFO] [stderr] | [INFO] [stderr] 138 | let power: f64 = from_value(args.get(1).unwrap().clone()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `&args[1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/lib/js/math.rs:150:20 [INFO] [stderr] | [INFO] [stderr] 150 | Ok(to_value(if args.len() >= 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!args.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lib/js/math.rs:151:27 [INFO] [stderr] | [INFO] [stderr] 151 | from_value::(args.get(0).unwrap().clone()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `&args[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/lib/js/math.rs:160:20 [INFO] [stderr] | [INFO] [stderr] 160 | Ok(to_value(if args.len() >= 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!args.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lib/js/math.rs:161:27 [INFO] [stderr] | [INFO] [stderr] 161 | from_value::(args.get(0).unwrap().clone()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `&args[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/lib/js/math.rs:170:20 [INFO] [stderr] | [INFO] [stderr] 170 | Ok(to_value(if args.len() >= 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!args.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lib/js/math.rs:171:27 [INFO] [stderr] | [INFO] [stderr] 171 | from_value::(args.get(0).unwrap().clone()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `&args[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/lib/js/math.rs:180:20 [INFO] [stderr] | [INFO] [stderr] 180 | Ok(to_value(if args.len() >= 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!args.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lib/js/math.rs:181:27 [INFO] [stderr] | [INFO] [stderr] 181 | from_value::(args.get(0).unwrap().clone()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `&args[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lib/js/object.rs:76:15 [INFO] [stderr] | [INFO] [stderr] 76 | let obj = args.get(0).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `&args[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lib/js/object.rs:82:15 [INFO] [stderr] | [INFO] [stderr] 82 | let obj = args.get(0).unwrap().clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `&args[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lib/js/object.rs:83:17 [INFO] [stderr] | [INFO] [stderr] 83 | let proto = args.get(1).unwrap().clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `&args[1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lib/js/object.rs:90:15 [INFO] [stderr] | [INFO] [stderr] 90 | let obj = args.get(0).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `&args[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lib/js/object.rs:91:37 [INFO] [stderr] | [INFO] [stderr] 91 | let prop = from_value::(args.get(1).unwrap().clone()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `&args[1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lib/js/object.rs:92:39 [INFO] [stderr] | [INFO] [stderr] 92 | let desc = from_value::(args.get(2).unwrap().clone()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `&args[2]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib/js/object.rs:104:19 [INFO] [stderr] | [INFO] [stderr] 104 | let prop = if args.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `args.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lib/js/object.rs:107:30 [INFO] [stderr] | [INFO] [stderr] 107 | from_value::(args.get(0).unwrap().clone()).ok() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `&args[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib/js/value.rs:137:40 [INFO] [stderr] | [INFO] [stderr] 137 | ValueData::Integer(num) => num as f64, [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(num)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib/js/value.rs:336:17 [INFO] [stderr] | [INFO] [stderr] 336 | / match v.borrow().iter().last() { [INFO] [stderr] 337 | | Some((last_key, _)) => { [INFO] [stderr] 338 | | for (key, val) in v.borrow().iter() { [INFO] [stderr] 339 | | try!(write!(f, "{}: {}", key, val.value.clone())); [INFO] [stderr] ... | [INFO] [stderr] 345 | | None => (), [INFO] [stderr] 346 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 336 | if let Some((last_key, _)) = v.borrow().iter().last() { [INFO] [stderr] 337 | for (key, val) in v.borrow().iter() { [INFO] [stderr] 338 | try!(write!(f, "{}: {}", key, val.value.clone())); [INFO] [stderr] 339 | if key != last_key { [INFO] [stderr] 340 | try!(write!(f, "{}", ", ")); [INFO] [stderr] 341 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: the variable `i` is used as a loop counter. Consider using `for (i, item) in self.iter().enumerate()` or similar iterators [INFO] [stderr] --> src/lib/js/value.rs:534:21 [INFO] [stderr] | [INFO] [stderr] 534 | for item in self.iter() { [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: the variable `i` is used as a loop counter. Consider using `for (i, item) in self.iter().enumerate()` or similar iterators [INFO] [stderr] --> src/lib/js/value.rs:545:21 [INFO] [stderr] | [INFO] [stderr] 545 | for item in self.iter() { [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 57 [INFO] [stderr] --> src/lib/syntax/ast/expr.rs:108:5 [INFO] [stderr] | [INFO] [stderr] 108 | / fn fmt(&self, f: &mut Formatter) -> Result { [INFO] [stderr] 109 | | return match *self { [INFO] [stderr] 110 | | ExprDef::ConstExpr(ref c) => write!(f, "{}", c), [INFO] [stderr] 111 | | ExprDef::BlockExpr(ref block) => { [INFO] [stderr] ... | [INFO] [stderr] 200 | | }; [INFO] [stderr] 201 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib/syntax/ast/expr.rs:205:39 [INFO] [stderr] | [INFO] [stderr] 205 | fn join_expr(f: &mut Formatter, expr: &Vec) -> Result { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[Expr]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 39 [INFO] [stderr] --> src/lib/syntax/lexer.rs:181:5 [INFO] [stderr] | [INFO] [stderr] 181 | / pub fn lex(&mut self) -> Result<(), LexerError> { [INFO] [stderr] 182 | | loop { [INFO] [stderr] 183 | | // Check if we've reached the end [INFO] [stderr] 184 | | match self.preview_next() { [INFO] [stderr] ... | [INFO] [stderr] 438 | | } [INFO] [stderr] 439 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lib/exec.rs:48:9 [INFO] [stderr] | [INFO] [stderr] 48 | self.scopes.get(self.scopes.len() - 1).unwrap() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `self.scopes[self.scopes.len() - 1]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 40 [INFO] [stderr] --> src/lib/exec.rs:92:5 [INFO] [stderr] | [INFO] [stderr] 92 | / fn run(&mut self, expr: &Expr) -> ResultValue { [INFO] [stderr] 93 | | match expr.def { [INFO] [stderr] 94 | | ExprDef::ConstExpr(Const::Null) => Ok(to_value(None::<()>)), [INFO] [stderr] 95 | | ExprDef::ConstExpr(Const::Undefined) => Ok(Gc::new(ValueData::Undefined)), [INFO] [stderr] ... | [INFO] [stderr] 409 | | } [INFO] [stderr] 410 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib/exec.rs:120:55 [INFO] [stderr] | [INFO] [stderr] 120 | ValueData::Object(ref obj) => match obj.borrow().get(name) { [INFO] [stderr] | _______________________________________________________^ [INFO] [stderr] 121 | | Some(v) => { [INFO] [stderr] 122 | | val = v.value.clone(); [INFO] [stderr] 123 | | break; [INFO] [stderr] 124 | | } [INFO] [stderr] 125 | | None => (), [INFO] [stderr] 126 | | }, [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 120 | ValueData::Object(ref obj) => if let Some(v) = obj.borrow().get(name) { [INFO] [stderr] 121 | val = v.value.clone(); [INFO] [stderr] 122 | break; [INFO] [stderr] 123 | }, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lib/exec.rs:171:44 [INFO] [stderr] | [INFO] [stderr] 171 | let name = data.args.get(i).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `data.args[i]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lib/exec.rs:172:44 [INFO] [stderr] | [INFO] [stderr] 172 | let expr = v_args.get(i).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try this: `v_args[i]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lib/exec.rs:351:44 [INFO] [stderr] | [INFO] [stderr] 351 | let name = data.args.get(i).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `data.args[i]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lib/exec.rs:352:44 [INFO] [stderr] | [INFO] [stderr] 352 | let expr = v_args.get(i).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try this: `v_args[i]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/lib/js/error.rs:8:8 [INFO] [stderr] | [INFO] [stderr] 8 | if args.len() >= 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!args.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lib/js/error.rs:9:50 [INFO] [stderr] | [INFO] [stderr] 9 | this.set_field_slice("message", to_value(args.get(0).unwrap().to_string())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `&args[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lib/js/json.rs:10:46 [INFO] [stderr] | [INFO] [stderr] 10 | match serde_json::from_str::(&args.get(0).unwrap().clone().to_string()) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `&args[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lib/js/json.rs:17:15 [INFO] [stderr] | [INFO] [stderr] 17 | let obj = args.get(0).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `&args[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/lib/js/math.rs:8:20 [INFO] [stderr] | [INFO] [stderr] 8 | Ok(to_value(if args.len() >= 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!args.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lib/js/math.rs:9:27 [INFO] [stderr] | [INFO] [stderr] 9 | from_value::(args.get(0).unwrap().clone()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `&args[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/lib/js/math.rs:18:20 [INFO] [stderr] | [INFO] [stderr] 18 | Ok(to_value(if args.len() >= 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!args.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lib/js/math.rs:19:27 [INFO] [stderr] | [INFO] [stderr] 19 | from_value::(args.get(0).unwrap().clone()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `&args[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/lib/js/math.rs:28:20 [INFO] [stderr] | [INFO] [stderr] 28 | Ok(to_value(if args.len() >= 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!args.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lib/js/math.rs:29:27 [INFO] [stderr] | [INFO] [stderr] 29 | from_value::(args.get(0).unwrap().clone()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `&args[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/lib/js/math.rs:38:20 [INFO] [stderr] | [INFO] [stderr] 38 | Ok(to_value(if args.len() >= 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!args.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lib/js/math.rs:39:27 [INFO] [stderr] | [INFO] [stderr] 39 | from_value::(args.get(0).unwrap().clone()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `&args[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/lib/js/math.rs:48:20 [INFO] [stderr] | [INFO] [stderr] 48 | Ok(to_value(if args.len() >= 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!args.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lib/js/math.rs:49:27 [INFO] [stderr] | [INFO] [stderr] 49 | from_value::(args.get(0).unwrap().clone()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `&args[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lib/js/math.rs:51:20 [INFO] [stderr] | [INFO] [stderr] 51 | .atan2(args.get(1).unwrap().to_num()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `&args[1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/lib/js/math.rs:58:20 [INFO] [stderr] | [INFO] [stderr] 58 | Ok(to_value(if args.len() >= 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!args.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lib/js/math.rs:59:27 [INFO] [stderr] | [INFO] [stderr] 59 | from_value::(args.get(0).unwrap().clone()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `&args[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/lib/js/math.rs:68:20 [INFO] [stderr] | [INFO] [stderr] 68 | Ok(to_value(if args.len() >= 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!args.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lib/js/math.rs:69:27 [INFO] [stderr] | [INFO] [stderr] 69 | from_value::(args.get(0).unwrap().clone()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `&args[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/lib/js/math.rs:78:20 [INFO] [stderr] | [INFO] [stderr] 78 | Ok(to_value(if args.len() >= 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!args.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lib/js/math.rs:79:27 [INFO] [stderr] | [INFO] [stderr] 79 | from_value::(args.get(0).unwrap().clone()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `&args[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/lib/js/math.rs:88:20 [INFO] [stderr] | [INFO] [stderr] 88 | Ok(to_value(if args.len() >= 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!args.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lib/js/math.rs:89:27 [INFO] [stderr] | [INFO] [stderr] 89 | from_value::(args.get(0).unwrap().clone()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `&args[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/lib/js/math.rs:98:20 [INFO] [stderr] | [INFO] [stderr] 98 | Ok(to_value(if args.len() >= 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!args.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lib/js/math.rs:99:27 [INFO] [stderr] | [INFO] [stderr] 99 | from_value::(args.get(0).unwrap().clone()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `&args[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/lib/js/math.rs:108:20 [INFO] [stderr] | [INFO] [stderr] 108 | Ok(to_value(if args.len() >= 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!args.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lib/js/math.rs:109:27 [INFO] [stderr] | [INFO] [stderr] 109 | from_value::(args.get(0).unwrap().clone()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `&args[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lib/js/math.rs:137:35 [INFO] [stderr] | [INFO] [stderr] 137 | let num: f64 = from_value(args.get(0).unwrap().clone()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `&args[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lib/js/math.rs:138:37 [INFO] [stderr] | [INFO] [stderr] 138 | let power: f64 = from_value(args.get(1).unwrap().clone()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `&args[1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/lib/js/math.rs:150:20 [INFO] [stderr] | [INFO] [stderr] 150 | Ok(to_value(if args.len() >= 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!args.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lib/js/math.rs:151:27 [INFO] [stderr] | [INFO] [stderr] 151 | from_value::(args.get(0).unwrap().clone()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `&args[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/lib/js/math.rs:160:20 [INFO] [stderr] | [INFO] [stderr] 160 | Ok(to_value(if args.len() >= 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!args.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lib/js/math.rs:161:27 [INFO] [stderr] | [INFO] [stderr] 161 | from_value::(args.get(0).unwrap().clone()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `&args[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/lib/js/math.rs:170:20 [INFO] [stderr] | [INFO] [stderr] 170 | Ok(to_value(if args.len() >= 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!args.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lib/js/math.rs:171:27 [INFO] [stderr] | [INFO] [stderr] 171 | from_value::(args.get(0).unwrap().clone()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `&args[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/lib/js/math.rs:180:20 [INFO] [stderr] | [INFO] [stderr] 180 | Ok(to_value(if args.len() >= 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!args.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lib/js/math.rs:181:27 [INFO] [stderr] | [INFO] [stderr] 181 | from_value::(args.get(0).unwrap().clone()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `&args[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lib/js/object.rs:76:15 [INFO] [stderr] | [INFO] [stderr] 76 | let obj = args.get(0).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `&args[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lib/js/object.rs:82:15 [INFO] [stderr] | [INFO] [stderr] 82 | let obj = args.get(0).unwrap().clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `&args[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lib/js/object.rs:83:17 [INFO] [stderr] | [INFO] [stderr] 83 | let proto = args.get(1).unwrap().clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `&args[1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lib/js/object.rs:90:15 [INFO] [stderr] | [INFO] [stderr] 90 | let obj = args.get(0).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `&args[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lib/js/object.rs:91:37 [INFO] [stderr] | [INFO] [stderr] 91 | let prop = from_value::(args.get(1).unwrap().clone()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `&args[1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lib/js/object.rs:92:39 [INFO] [stderr] | [INFO] [stderr] 92 | let desc = from_value::(args.get(2).unwrap().clone()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `&args[2]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib/js/object.rs:104:19 [INFO] [stderr] | [INFO] [stderr] 104 | let prop = if args.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `args.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lib/js/object.rs:107:30 [INFO] [stderr] | [INFO] [stderr] 107 | from_value::(args.get(0).unwrap().clone()).ok() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `&args[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib/js/value.rs:137:40 [INFO] [stderr] | [INFO] [stderr] 137 | ValueData::Integer(num) => num as f64, [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(num)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib/js/value.rs:336:17 [INFO] [stderr] | [INFO] [stderr] 336 | / match v.borrow().iter().last() { [INFO] [stderr] 337 | | Some((last_key, _)) => { [INFO] [stderr] 338 | | for (key, val) in v.borrow().iter() { [INFO] [stderr] 339 | | try!(write!(f, "{}: {}", key, val.value.clone())); [INFO] [stderr] ... | [INFO] [stderr] 345 | | None => (), [INFO] [stderr] 346 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 336 | if let Some((last_key, _)) = v.borrow().iter().last() { [INFO] [stderr] 337 | for (key, val) in v.borrow().iter() { [INFO] [stderr] 338 | try!(write!(f, "{}: {}", key, val.value.clone())); [INFO] [stderr] 339 | if key != last_key { [INFO] [stderr] 340 | try!(write!(f, "{}", ", ")); [INFO] [stderr] 341 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: the variable `i` is used as a loop counter. Consider using `for (i, item) in self.iter().enumerate()` or similar iterators [INFO] [stderr] --> src/lib/js/value.rs:534:21 [INFO] [stderr] | [INFO] [stderr] 534 | for item in self.iter() { [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: the variable `i` is used as a loop counter. Consider using `for (i, item) in self.iter().enumerate()` or similar iterators [INFO] [stderr] --> src/lib/js/value.rs:545:21 [INFO] [stderr] | [INFO] [stderr] 545 | for item in self.iter() { [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 57 [INFO] [stderr] --> src/lib/syntax/ast/expr.rs:108:5 [INFO] [stderr] | [INFO] [stderr] 108 | / fn fmt(&self, f: &mut Formatter) -> Result { [INFO] [stderr] 109 | | return match *self { [INFO] [stderr] 110 | | ExprDef::ConstExpr(ref c) => write!(f, "{}", c), [INFO] [stderr] 111 | | ExprDef::BlockExpr(ref block) => { [INFO] [stderr] ... | [INFO] [stderr] 200 | | }; [INFO] [stderr] 201 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib/syntax/ast/expr.rs:205:39 [INFO] [stderr] | [INFO] [stderr] 205 | fn join_expr(f: &mut Formatter, expr: &Vec) -> Result { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[Expr]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 39 [INFO] [stderr] --> src/lib/syntax/lexer.rs:181:5 [INFO] [stderr] | [INFO] [stderr] 181 | / pub fn lex(&mut self) -> Result<(), LexerError> { [INFO] [stderr] 182 | | loop { [INFO] [stderr] 183 | | // Check if we've reached the end [INFO] [stderr] 184 | | match self.preview_next() { [INFO] [stderr] ... | [INFO] [stderr] 438 | | } [INFO] [stderr] 439 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 6.39s [INFO] running `"docker" "inspect" "dabf4b05e59ed43dbb333704a56963894161c817dfb08599290b1e518479309e"` [INFO] running `"docker" "rm" "-f" "dabf4b05e59ed43dbb333704a56963894161c817dfb08599290b1e518479309e"` [INFO] [stdout] dabf4b05e59ed43dbb333704a56963894161c817dfb08599290b1e518479309e