[INFO] updating cached repository zzmp/serdwarf [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/zzmp/serdwarf [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/zzmp/serdwarf" "work/ex/clippy-test-run/sources/stable/gh/zzmp/serdwarf"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/zzmp/serdwarf'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/zzmp/serdwarf" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/zzmp/serdwarf"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/zzmp/serdwarf'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 9c2059934b858b93c4a3b6ef49c504fbb1bd097d [INFO] sha for GitHub repo zzmp/serdwarf: 9c2059934b858b93c4a3b6ef49c504fbb1bd097d [INFO] validating manifest of zzmp/serdwarf on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of zzmp/serdwarf on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing zzmp/serdwarf [INFO] finished frobbing zzmp/serdwarf [INFO] frobbed toml for zzmp/serdwarf written to work/ex/clippy-test-run/sources/stable/gh/zzmp/serdwarf/Cargo.toml [INFO] started frobbing zzmp/serdwarf [INFO] finished frobbing zzmp/serdwarf [INFO] frobbed toml for zzmp/serdwarf written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/zzmp/serdwarf/Cargo.toml [INFO] crate zzmp/serdwarf has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting zzmp/serdwarf against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/zzmp/serdwarf:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 5bd7517937c1511c65c3060fb63781dc925c556d94f92c60832164c3ef1aff05 [INFO] running `"docker" "start" "-a" "5bd7517937c1511c65c3060fb63781dc925c556d94f92c60832164c3ef1aff05"` [INFO] [stderr] Compiling winapi-build v0.1.1 [INFO] [stderr] Checking winapi v0.2.8 [INFO] [stderr] Checking odds v0.2.25 [INFO] [stderr] Checking zero v0.1.2 [INFO] [stderr] Checking libc v0.2.22 [INFO] [stderr] Checking byteorder v0.5.3 [INFO] [stderr] Checking leb128 v0.2.1 [INFO] [stderr] Checking fallible-iterator v0.1.3 [INFO] [stderr] Checking getopts v0.2.14 [INFO] [stderr] Checking xmas-elf v0.4.0 [INFO] [stderr] Compiling kernel32-sys v0.2.2 [INFO] [stderr] Checking nodrop v0.1.9 [INFO] [stderr] Checking arrayvec v0.3.23 [INFO] [stderr] Checking fs2 v0.2.5 [INFO] [stderr] Checking object v0.3.0 [INFO] [stderr] Checking memmap v0.4.0 [INFO] [stderr] Checking gimli v0.13.0 [INFO] [stderr] Checking dwarfdump v0.1.0 [INFO] [stderr] Checking serdwarf v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:73:21 [INFO] [stderr] | [INFO] [stderr] 73 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:73:21 [INFO] [stderr] | [INFO] [stderr] 73 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:110:32 [INFO] [stderr] | [INFO] [stderr] 110 | if symbol.contains("@") && !symbol.contains("@@") { [INFO] [stderr] | ^^^ help: try using a char instead: `'@'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:128:13 [INFO] [stderr] | [INFO] [stderr] 128 | / match name.find("@@") { [INFO] [stderr] 129 | | Some(i) => name.truncate(i), [INFO] [stderr] 130 | | None => () [INFO] [stderr] 131 | | } [INFO] [stderr] | |_____________^ help: try this: `if let Some(i) = name.find("@@") { name.truncate(i) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:134:58 [INFO] [stderr] | [INFO] [stderr] 134 | if !flags.print_reserved && name.starts_with("_") { [INFO] [stderr] | ^^^ help: try using a char instead: `'_'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:182:35 [INFO] [stderr] | [INFO] [stderr] 182 | let mut cols = line.split(" "); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:110:32 [INFO] [stderr] | [INFO] [stderr] 110 | if symbol.contains("@") && !symbol.contains("@@") { [INFO] [stderr] | ^^^ help: try using a char instead: `'@'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:128:13 [INFO] [stderr] | [INFO] [stderr] 128 | / match name.find("@@") { [INFO] [stderr] 129 | | Some(i) => name.truncate(i), [INFO] [stderr] 130 | | None => () [INFO] [stderr] 131 | | } [INFO] [stderr] | |_____________^ help: try this: `if let Some(i) = name.find("@@") { name.truncate(i) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:134:58 [INFO] [stderr] | [INFO] [stderr] 134 | if !flags.print_reserved && name.starts_with("_") { [INFO] [stderr] | ^^^ help: try using a char instead: `'_'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:182:35 [INFO] [stderr] | [INFO] [stderr] 182 | let mut cols = line.split(" "); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 10.18s [INFO] running `"docker" "inspect" "5bd7517937c1511c65c3060fb63781dc925c556d94f92c60832164c3ef1aff05"` [INFO] running `"docker" "rm" "-f" "5bd7517937c1511c65c3060fb63781dc925c556d94f92c60832164c3ef1aff05"` [INFO] [stdout] 5bd7517937c1511c65c3060fb63781dc925c556d94f92c60832164c3ef1aff05