[INFO] updating cached repository zzibert/rectangles [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/zzibert/rectangles [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/zzibert/rectangles" "work/ex/clippy-test-run/sources/stable/gh/zzibert/rectangles"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/zzibert/rectangles'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/zzibert/rectangles" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/zzibert/rectangles"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/zzibert/rectangles'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 9f7edcf3d27d08bacfa197658f2957bc7e944ac3 [INFO] sha for GitHub repo zzibert/rectangles: 9f7edcf3d27d08bacfa197658f2957bc7e944ac3 [INFO] validating manifest of zzibert/rectangles on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of zzibert/rectangles on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing zzibert/rectangles [INFO] finished frobbing zzibert/rectangles [INFO] frobbed toml for zzibert/rectangles written to work/ex/clippy-test-run/sources/stable/gh/zzibert/rectangles/Cargo.toml [INFO] started frobbing zzibert/rectangles [INFO] finished frobbing zzibert/rectangles [INFO] frobbed toml for zzibert/rectangles written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/zzibert/rectangles/Cargo.toml [INFO] crate zzibert/rectangles has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting zzibert/rectangles against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/zzibert/rectangles:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 9fffd55e9011711faae5a6df0b158e511db12f6a257ff4b968825d1de78b04bc [INFO] running `"docker" "start" "-a" "9fffd55e9011711faae5a6df0b158e511db12f6a257ff4b968825d1de78b04bc"` [INFO] [stderr] Checking rectangles v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:13:13 [INFO] [stderr] | [INFO] [stderr] 13 | return true [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:16:13 [INFO] [stderr] | [INFO] [stderr] 16 | return false [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:13:13 [INFO] [stderr] | [INFO] [stderr] 13 | return true [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:16:13 [INFO] [stderr] | [INFO] [stderr] 16 | return false [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: method is never used: `area` [INFO] [stderr] --> src/main.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | fn area(&self) -> u32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `square` [INFO] [stderr] --> src/main.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | fn square(size: u32) -> Rectangle { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/main.rs:12:9 [INFO] [stderr] | [INFO] [stderr] 12 | / if self.width >= rect.width && self.height >= rect.height { [INFO] [stderr] 13 | | return true [INFO] [stderr] 14 | | } [INFO] [stderr] 15 | | else{ [INFO] [stderr] 16 | | return false [INFO] [stderr] 17 | | } [INFO] [stderr] | |_________^ help: you can reduce it to: `return self.width >= rect.width && self.height >= rect.height` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: method is never used: `area` [INFO] [stderr] --> src/main.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | fn area(&self) -> u32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `square` [INFO] [stderr] --> src/main.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | fn square(size: u32) -> Rectangle { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/main.rs:12:9 [INFO] [stderr] | [INFO] [stderr] 12 | / if self.width >= rect.width && self.height >= rect.height { [INFO] [stderr] 13 | | return true [INFO] [stderr] 14 | | } [INFO] [stderr] 15 | | else{ [INFO] [stderr] 16 | | return false [INFO] [stderr] 17 | | } [INFO] [stderr] | |_________^ help: you can reduce it to: `return self.width >= rect.width && self.height >= rect.height` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.80s [INFO] running `"docker" "inspect" "9fffd55e9011711faae5a6df0b158e511db12f6a257ff4b968825d1de78b04bc"` [INFO] running `"docker" "rm" "-f" "9fffd55e9011711faae5a6df0b158e511db12f6a257ff4b968825d1de78b04bc"` [INFO] [stdout] 9fffd55e9011711faae5a6df0b158e511db12f6a257ff4b968825d1de78b04bc