[INFO] updating cached repository zyxw59/pingviz [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/zyxw59/pingviz [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/zyxw59/pingviz" "work/ex/clippy-test-run/sources/stable/gh/zyxw59/pingviz"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/zyxw59/pingviz'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/zyxw59/pingviz" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/zyxw59/pingviz"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/zyxw59/pingviz'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] b0858ba6c44ece45703a53fe8617d933ea3914f1 [INFO] sha for GitHub repo zyxw59/pingviz: b0858ba6c44ece45703a53fe8617d933ea3914f1 [INFO] validating manifest of zyxw59/pingviz on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of zyxw59/pingviz on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing zyxw59/pingviz [INFO] finished frobbing zyxw59/pingviz [INFO] frobbed toml for zyxw59/pingviz written to work/ex/clippy-test-run/sources/stable/gh/zyxw59/pingviz/Cargo.toml [INFO] started frobbing zyxw59/pingviz [INFO] finished frobbing zyxw59/pingviz [INFO] frobbed toml for zyxw59/pingviz written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/zyxw59/pingviz/Cargo.toml [INFO] crate zyxw59/pingviz has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting zyxw59/pingviz against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/zyxw59/pingviz:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ed85f8b896c2de867b9cc49f3bcf11fead758dd8954fbd3692933bc681b9cc02 [INFO] running `"docker" "start" "-a" "ed85f8b896c2de867b9cc49f3bcf11fead758dd8954fbd3692933bc681b9cc02"` [INFO] [stderr] Compiling pkg-config v0.3.9 [INFO] [stderr] Checking libc v0.2.36 [INFO] [stderr] Checking bitflags v1.0.1 [INFO] [stderr] Checking cfg-if v0.1.2 [INFO] [stderr] Checking byteorder v1.2.1 [INFO] [stderr] Checking lazy_static v1.0.0 [INFO] [stderr] Compiling gdk-pixbuf v0.3.0 [INFO] [stderr] Compiling cairo-rs v0.3.0 [INFO] [stderr] Compiling unicode-xid v0.0.4 [INFO] [stderr] Compiling gio v0.3.0 [INFO] [stderr] Checking futures v0.1.18 [INFO] [stderr] Compiling quote v0.3.15 [INFO] [stderr] Checking winapi v0.2.8 [INFO] [stderr] Checking slab v0.4.0 [INFO] [stderr] Checking c_vec v1.2.1 [INFO] [stderr] Compiling gdk v0.7.0 [INFO] [stderr] Compiling lazy_static v0.2.11 [INFO] [stderr] Compiling gtk v0.3.0 [INFO] [stderr] Checking log v0.4.1 [INFO] [stderr] Compiling synom v0.11.3 [INFO] [stderr] Compiling glib-sys v0.5.0 [INFO] [stderr] Compiling gobject-sys v0.5.0 [INFO] [stderr] Compiling gio-sys v0.5.0 [INFO] [stderr] Compiling pango-sys v0.5.0 [INFO] [stderr] Compiling cairo-sys-rs v0.5.0 [INFO] [stderr] Compiling gdk-pixbuf-sys v0.5.0 [INFO] [stderr] Compiling atk-sys v0.5.0 [INFO] [stderr] Compiling gdk-sys v0.5.0 [INFO] [stderr] Compiling gtk-sys v0.5.0 [INFO] [stderr] Checking iovec v0.1.2 [INFO] [stderr] Checking net2 v0.2.31 [INFO] [stderr] Checking rand v0.4.2 [INFO] [stderr] Checking log v0.3.9 [INFO] [stderr] Compiling syn v0.11.11 [INFO] [stderr] Checking bytes v0.4.6 [INFO] [stderr] Checking tokio-io v0.1.4 [INFO] [stderr] Checking futures-glib v0.3.2 [INFO] [stderr] Checking relm-core v0.11.0 [INFO] [stderr] Checking glib v0.4.1 [INFO] [stderr] Checking relm-state v0.11.0 [INFO] [stderr] Compiling relm-gen-widget v0.11.0 [INFO] [stderr] Checking pango v0.3.0 [INFO] [stderr] Compiling relm-derive-common v0.11.0 [INFO] [stderr] Compiling relm-derive v0.11.0 [INFO] [stderr] Checking relm v0.11.0 [INFO] [stderr] Checking pingviz v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: method is never used: `clear` [INFO] [stderr] --> src/util.rs:204:5 [INFO] [stderr] | [INFO] [stderr] 204 | pub fn clear(&mut self) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `cap` [INFO] [stderr] --> src/util.rs:210:5 [INFO] [stderr] | [INFO] [stderr] 210 | pub fn cap(&self) -> Option { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `start` [INFO] [stderr] --> src/util.rs:218:5 [INFO] [stderr] | [INFO] [stderr] 218 | pub fn start(&self) -> usize { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `clear` [INFO] [stderr] --> src/view.rs:40:5 [INFO] [stderr] | [INFO] [stderr] 40 | pub fn clear(&mut self) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `mean` [INFO] [stderr] --> src/view.rs:114:5 [INFO] [stderr] | [INFO] [stderr] 114 | pub fn mean(&self) -> f64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `var` [INFO] [stderr] --> src/view.rs:119:5 [INFO] [stderr] | [INFO] [stderr] 119 | pub fn var(&self) -> f64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `std` [INFO] [stderr] --> src/view.rs:125:5 [INFO] [stderr] | [INFO] [stderr] 125 | pub fn std(&self) -> f64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/util.rs:85:9 [INFO] [stderr] | [INFO] [stderr] 85 | iter.next().map(|(idx, &elem)| { [INFO] [stderr] | _________^ [INFO] [stderr] | |_________| [INFO] [stderr] | || [INFO] [stderr] 86 | || self.max = elem; [INFO] [stderr] 87 | || self.max_index = idx; [INFO] [stderr] 88 | || for (idx, &elem) in iter { [INFO] [stderr] 89 | || self.update_max(idx, elem); [INFO] [stderr] 90 | || } [INFO] [stderr] 91 | || }); [INFO] [stderr] | ||__________^- help: try this: `if let Some((idx, &elem)) = iter.next() { ... }` [INFO] [stderr] | |___________| [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/util.rs:101:9 [INFO] [stderr] | [INFO] [stderr] 101 | iter.next().map(|(idx, &elem)| { [INFO] [stderr] | _________^ [INFO] [stderr] | |_________| [INFO] [stderr] | || [INFO] [stderr] 102 | || self.min = elem; [INFO] [stderr] 103 | || self.min_index = idx; [INFO] [stderr] 104 | || for (idx, &elem) in iter { [INFO] [stderr] 105 | || self.update_min(idx, elem); [INFO] [stderr] 106 | || } [INFO] [stderr] 107 | || }); [INFO] [stderr] | ||__________^- help: try this: `if let Some((idx, &elem)) = iter.next() { ... }` [INFO] [stderr] | |___________| [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/util.rs:286:14 [INFO] [stderr] | [INFO] [stderr] 286 | .expect(format!("index out of bounds: the len is {} and the start is {} \ [INFO] [stderr] | ______________^ [INFO] [stderr] 287 | | but the index is {}", self.len(), self.start, index).as_ref()) [INFO] [stderr] | |__________________________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 286 | .unwrap_or_else(|| panic!("index out of bounds: the len is {} and the start is {} \ [INFO] [stderr] 287 | but the index is {}", self.len())) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: method is never used: `clear` [INFO] [stderr] --> src/util.rs:204:5 [INFO] [stderr] | [INFO] [stderr] 204 | pub fn clear(&mut self) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `cap` [INFO] [stderr] --> src/util.rs:210:5 [INFO] [stderr] | [INFO] [stderr] 210 | pub fn cap(&self) -> Option { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `start` [INFO] [stderr] --> src/util.rs:218:5 [INFO] [stderr] | [INFO] [stderr] 218 | pub fn start(&self) -> usize { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `clear` [INFO] [stderr] --> src/view.rs:40:5 [INFO] [stderr] | [INFO] [stderr] 40 | pub fn clear(&mut self) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `mean` [INFO] [stderr] --> src/view.rs:114:5 [INFO] [stderr] | [INFO] [stderr] 114 | pub fn mean(&self) -> f64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `var` [INFO] [stderr] --> src/view.rs:119:5 [INFO] [stderr] | [INFO] [stderr] 119 | pub fn var(&self) -> f64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `std` [INFO] [stderr] --> src/view.rs:125:5 [INFO] [stderr] | [INFO] [stderr] 125 | pub fn std(&self) -> f64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/util.rs:85:9 [INFO] [stderr] | [INFO] [stderr] 85 | iter.next().map(|(idx, &elem)| { [INFO] [stderr] | _________^ [INFO] [stderr] | |_________| [INFO] [stderr] | || [INFO] [stderr] 86 | || self.max = elem; [INFO] [stderr] 87 | || self.max_index = idx; [INFO] [stderr] 88 | || for (idx, &elem) in iter { [INFO] [stderr] 89 | || self.update_max(idx, elem); [INFO] [stderr] 90 | || } [INFO] [stderr] 91 | || }); [INFO] [stderr] | ||__________^- help: try this: `if let Some((idx, &elem)) = iter.next() { ... }` [INFO] [stderr] | |___________| [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/util.rs:101:9 [INFO] [stderr] | [INFO] [stderr] 101 | iter.next().map(|(idx, &elem)| { [INFO] [stderr] | _________^ [INFO] [stderr] | |_________| [INFO] [stderr] | || [INFO] [stderr] 102 | || self.min = elem; [INFO] [stderr] 103 | || self.min_index = idx; [INFO] [stderr] 104 | || for (idx, &elem) in iter { [INFO] [stderr] 105 | || self.update_min(idx, elem); [INFO] [stderr] 106 | || } [INFO] [stderr] 107 | || }); [INFO] [stderr] | ||__________^- help: try this: `if let Some((idx, &elem)) = iter.next() { ... }` [INFO] [stderr] | |___________| [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/util.rs:286:14 [INFO] [stderr] | [INFO] [stderr] 286 | .expect(format!("index out of bounds: the len is {} and the start is {} \ [INFO] [stderr] | ______________^ [INFO] [stderr] 287 | | but the index is {}", self.len(), self.start, index).as_ref()) [INFO] [stderr] | |__________________________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 286 | .unwrap_or_else(|| panic!("index out of bounds: the len is {} and the start is {} \ [INFO] [stderr] 287 | but the index is {}", self.len())) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 23s [INFO] running `"docker" "inspect" "ed85f8b896c2de867b9cc49f3bcf11fead758dd8954fbd3692933bc681b9cc02"` [INFO] running `"docker" "rm" "-f" "ed85f8b896c2de867b9cc49f3bcf11fead758dd8954fbd3692933bc681b9cc02"` [INFO] [stdout] ed85f8b896c2de867b9cc49f3bcf11fead758dd8954fbd3692933bc681b9cc02