[INFO] updating cached repository zyxw59/formatting [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/zyxw59/formatting [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/zyxw59/formatting" "work/ex/clippy-test-run/sources/stable/gh/zyxw59/formatting"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/zyxw59/formatting'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/zyxw59/formatting" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/zyxw59/formatting"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/zyxw59/formatting'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 201fdeb35234149de913dc022610b556cbe79666 [INFO] sha for GitHub repo zyxw59/formatting: 201fdeb35234149de913dc022610b556cbe79666 [INFO] validating manifest of zyxw59/formatting on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of zyxw59/formatting on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing zyxw59/formatting [INFO] finished frobbing zyxw59/formatting [INFO] frobbed toml for zyxw59/formatting written to work/ex/clippy-test-run/sources/stable/gh/zyxw59/formatting/Cargo.toml [INFO] started frobbing zyxw59/formatting [INFO] finished frobbing zyxw59/formatting [INFO] frobbed toml for zyxw59/formatting written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/zyxw59/formatting/Cargo.toml [INFO] crate zyxw59/formatting has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting zyxw59/formatting against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/zyxw59/formatting:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 29d21c9eec9b23467d8963a6b80209ab4f72e387fd61916385559857a715483e [INFO] running `"docker" "start" "-a" "29d21c9eec9b23467d8963a6b80209ab4f72e387fd61916385559857a715483e"` [INFO] [stderr] Compiling cc v1.0.13 [INFO] [stderr] Compiling unicode-xid v0.0.4 [INFO] [stderr] Compiling quote v0.3.15 [INFO] [stderr] Checking libc v0.2.40 [INFO] [stderr] Checking rustc-demangle v0.1.7 [INFO] [stderr] Checking cfg-if v0.1.2 [INFO] [stderr] Compiling synom v0.11.3 [INFO] [stderr] Compiling syn v0.11.11 [INFO] [stderr] Compiling backtrace-sys v0.1.16 [INFO] [stderr] Compiling synstructure v0.6.1 [INFO] [stderr] Compiling failure_derive v0.1.1 [INFO] [stderr] Checking backtrace v0.3.6 [INFO] [stderr] Checking failure v0.1.1 [INFO] [stderr] Checking formatting v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/main.rs:2:1 [INFO] [stderr] | [INFO] [stderr] 2 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused imports: `Backtrace`, `Context`, `Fail`, `ResultExt` [INFO] [stderr] --> src/parser/mod.rs:1:15 [INFO] [stderr] | [INFO] [stderr] 1 | use failure::{Backtrace, Context, Fail, ResultExt}; [INFO] [stderr] | ^^^^^^^^^ ^^^^^^^ ^^^^ ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused imports: `ErrorKind`, `Error` [INFO] [stderr] --> src/parser/mod.rs:3:14 [INFO] [stderr] | [INFO] [stderr] 3 | use errors::{Error, ErrorKind}; [INFO] [stderr] | ^^^^^ ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused imports: `Backtrace`, `Context`, `Fail` [INFO] [stderr] --> src/parser/bufread.rs:3:15 [INFO] [stderr] | [INFO] [stderr] 3 | use failure::{Backtrace, Context, Fail, ResultExt}; [INFO] [stderr] | ^^^^^^^^^ ^^^^^^^ ^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/main.rs:2:1 [INFO] [stderr] | [INFO] [stderr] 2 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused imports: `Backtrace`, `Context`, `Fail`, `ResultExt` [INFO] [stderr] --> src/parser/mod.rs:1:15 [INFO] [stderr] | [INFO] [stderr] 1 | use failure::{Backtrace, Context, Fail, ResultExt}; [INFO] [stderr] | ^^^^^^^^^ ^^^^^^^ ^^^^ ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused imports: `ErrorKind`, `Error` [INFO] [stderr] --> src/parser/mod.rs:3:14 [INFO] [stderr] | [INFO] [stderr] 3 | use errors::{Error, ErrorKind}; [INFO] [stderr] | ^^^^^ ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused imports: `Backtrace`, `Context`, `Fail` [INFO] [stderr] --> src/parser/bufread.rs:3:15 [INFO] [stderr] | [INFO] [stderr] 3 | use failure::{Backtrace, Context, Fail, ResultExt}; [INFO] [stderr] | ^^^^^^^^^ ^^^^^^^ ^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `kind` [INFO] [stderr] --> src/errors.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | pub fn kind(&self) -> ErrorKind { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `EndOfInput` [INFO] [stderr] --> src/errors.rs:50:5 [INFO] [stderr] | [INFO] [stderr] 50 | EndOfInput, [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `UnclosedVerbatim` [INFO] [stderr] --> src/errors.rs:52:5 [INFO] [stderr] | [INFO] [stderr] 52 | UnclosedVerbatim(usize, usize), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Unicode` [INFO] [stderr] --> src/errors.rs:54:5 [INFO] [stderr] | [INFO] [stderr] 54 | Unicode(usize), [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Io` [INFO] [stderr] --> src/errors.rs:56:5 [INFO] [stderr] | [INFO] [stderr] 56 | Io(usize), [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `from_io` [INFO] [stderr] --> src/errors.rs:60:5 [INFO] [stderr] | [INFO] [stderr] 60 | pub fn from_io(err: &io::Error, line: usize) -> ErrorKind { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `BufReadIter` [INFO] [stderr] --> src/parser/bufread.rs:12:1 [INFO] [stderr] | [INFO] [stderr] 12 | pub struct BufReadIter { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/parser/bufread.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | pub fn new(input: R) -> BufReadIter { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `column` [INFO] [stderr] --> src/parser/bufread.rs:33:5 [INFO] [stderr] | [INFO] [stderr] 33 | pub fn column(&self) -> usize { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `line` [INFO] [stderr] --> src/parser/bufread.rs:38:5 [INFO] [stderr] | [INFO] [stderr] 38 | pub fn line(&self) -> usize { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `fill_buffer` [INFO] [stderr] --> src/parser/bufread.rs:43:5 [INFO] [stderr] | [INFO] [stderr] 43 | fn fill_buffer(&mut self) -> Result<(), Error> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `next` [INFO] [stderr] --> src/parser/bufread.rs:55:5 [INFO] [stderr] | [INFO] [stderr] 55 | pub fn next(&mut self) -> Result, Error> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `expect_next` [INFO] [stderr] --> src/parser/bufread.rs:66:5 [INFO] [stderr] | [INFO] [stderr] 66 | pub fn expect_next(&mut self) -> Result { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `current` [INFO] [stderr] --> src/parser/bufread.rs:72:5 [INFO] [stderr] | [INFO] [stderr] 72 | pub fn current(&self) -> Option<&char> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `peek` [INFO] [stderr] --> src/parser/bufread.rs:78:5 [INFO] [stderr] | [INFO] [stderr] 78 | pub fn peek(&self) -> Option<&char> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `Parser` [INFO] [stderr] --> src/parser/mod.rs:10:1 [INFO] [stderr] | [INFO] [stderr] 10 | pub struct Parser { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `kind` [INFO] [stderr] --> src/errors.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | pub fn kind(&self) -> ErrorKind { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `EndOfInput` [INFO] [stderr] --> src/errors.rs:50:5 [INFO] [stderr] | [INFO] [stderr] 50 | EndOfInput, [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `UnclosedVerbatim` [INFO] [stderr] --> src/errors.rs:52:5 [INFO] [stderr] | [INFO] [stderr] 52 | UnclosedVerbatim(usize, usize), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Unicode` [INFO] [stderr] --> src/errors.rs:54:5 [INFO] [stderr] | [INFO] [stderr] 54 | Unicode(usize), [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Io` [INFO] [stderr] --> src/errors.rs:56:5 [INFO] [stderr] | [INFO] [stderr] 56 | Io(usize), [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `from_io` [INFO] [stderr] --> src/errors.rs:60:5 [INFO] [stderr] | [INFO] [stderr] 60 | pub fn from_io(err: &io::Error, line: usize) -> ErrorKind { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `BufReadIter` [INFO] [stderr] --> src/parser/bufread.rs:12:1 [INFO] [stderr] | [INFO] [stderr] 12 | pub struct BufReadIter { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/parser/bufread.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | pub fn new(input: R) -> BufReadIter { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `column` [INFO] [stderr] --> src/parser/bufread.rs:33:5 [INFO] [stderr] | [INFO] [stderr] 33 | pub fn column(&self) -> usize { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `line` [INFO] [stderr] --> src/parser/bufread.rs:38:5 [INFO] [stderr] | [INFO] [stderr] 38 | pub fn line(&self) -> usize { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `fill_buffer` [INFO] [stderr] --> src/parser/bufread.rs:43:5 [INFO] [stderr] | [INFO] [stderr] 43 | fn fill_buffer(&mut self) -> Result<(), Error> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `next` [INFO] [stderr] --> src/parser/bufread.rs:55:5 [INFO] [stderr] | [INFO] [stderr] 55 | pub fn next(&mut self) -> Result, Error> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `expect_next` [INFO] [stderr] --> src/parser/bufread.rs:66:5 [INFO] [stderr] | [INFO] [stderr] 66 | pub fn expect_next(&mut self) -> Result { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `current` [INFO] [stderr] --> src/parser/bufread.rs:72:5 [INFO] [stderr] | [INFO] [stderr] 72 | pub fn current(&self) -> Option<&char> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `peek` [INFO] [stderr] --> src/parser/bufread.rs:78:5 [INFO] [stderr] | [INFO] [stderr] 78 | pub fn peek(&self) -> Option<&char> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `Parser` [INFO] [stderr] --> src/parser/mod.rs:10:1 [INFO] [stderr] | [INFO] [stderr] 10 | pub struct Parser { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/parser/bufread.rs:60:27 [INFO] [stderr] | [INFO] [stderr] 60 | .map(|()| self.vec_buf.get(self.column).map(|&c| c)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.vec_buf.get(self.column).cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/parser/bufread.rs:67:22 [INFO] [stderr] | [INFO] [stderr] 67 | self.next()?.ok_or(ErrorKind::EndOfInput.into()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| ErrorKind::EndOfInput.into())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/parser/bufread.rs:60:27 [INFO] [stderr] | [INFO] [stderr] 60 | .map(|()| self.vec_buf.get(self.column).map(|&c| c)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.vec_buf.get(self.column).cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/parser/bufread.rs:67:22 [INFO] [stderr] | [INFO] [stderr] 67 | self.next()?.ok_or(ErrorKind::EndOfInput.into()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| ErrorKind::EndOfInput.into())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 22.81s [INFO] running `"docker" "inspect" "29d21c9eec9b23467d8963a6b80209ab4f72e387fd61916385559857a715483e"` [INFO] running `"docker" "rm" "-f" "29d21c9eec9b23467d8963a6b80209ab4f72e387fd61916385559857a715483e"` [INFO] [stdout] 29d21c9eec9b23467d8963a6b80209ab4f72e387fd61916385559857a715483e