[INFO] updating cached repository zyphrus/bf-rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/zyphrus/bf-rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/zyphrus/bf-rs" "work/ex/clippy-test-run/sources/stable/gh/zyphrus/bf-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/zyphrus/bf-rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/zyphrus/bf-rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/zyphrus/bf-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/zyphrus/bf-rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] d61a8132b1c67cdcfab582f2f57d41ca5e428e02 [INFO] sha for GitHub repo zyphrus/bf-rs: d61a8132b1c67cdcfab582f2f57d41ca5e428e02 [INFO] validating manifest of zyphrus/bf-rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of zyphrus/bf-rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing zyphrus/bf-rs [INFO] finished frobbing zyphrus/bf-rs [INFO] frobbed toml for zyphrus/bf-rs written to work/ex/clippy-test-run/sources/stable/gh/zyphrus/bf-rs/Cargo.toml [INFO] started frobbing zyphrus/bf-rs [INFO] finished frobbing zyphrus/bf-rs [INFO] frobbed toml for zyphrus/bf-rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/zyphrus/bf-rs/Cargo.toml [INFO] crate zyphrus/bf-rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting zyphrus/bf-rs against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/zyphrus/bf-rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 718b371db73bdf146bb8659107c87ac54eadf5d9ce472ec74ee2902a8090b1c8 [INFO] running `"docker" "start" "-a" "718b371db73bdf146bb8659107c87ac54eadf5d9ce472ec74ee2902a8090b1c8"` [INFO] [stderr] Checking strsim v0.4.1 [INFO] [stderr] Checking ansi_term v0.7.5 [INFO] [stderr] Checking vec_map v0.4.0 [INFO] [stderr] Checking bitflags v0.4.0 [INFO] [stderr] Checking clap v1.5.6 [INFO] [stderr] Checking bf v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused import: `super::Symbol::*` [INFO] [stderr] --> src/lib.rs:176:9 [INFO] [stderr] | [INFO] [stderr] 176 | use super::Symbol::*; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:121:46 [INFO] [stderr] | [INFO] [stderr] 121 | code: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[Symbol]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:121:46 [INFO] [stderr] | [INFO] [stderr] 121 | code: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[Symbol]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:30:12 [INFO] [stderr] | [INFO] [stderr] 30 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 31 | | if let Some(f) = matches.value_of("FILE") { [INFO] [stderr] 32 | | let mut s = String::new(); [INFO] [stderr] 33 | | let mut file = match File::open(f) { [INFO] [stderr] ... | [INFO] [stderr] 48 | | } [INFO] [stderr] 49 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 30 | } else if let Some(f) = matches.value_of("FILE") { [INFO] [stderr] 31 | let mut s = String::new(); [INFO] [stderr] 32 | let mut file = match File::open(f) { [INFO] [stderr] 33 | Ok(fi) => fi, [INFO] [stderr] 34 | Err(e) => { [INFO] [stderr] 35 | println!("Error while opening file `{}`: {}", f, e); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:30:12 [INFO] [stderr] | [INFO] [stderr] 30 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 31 | | if let Some(f) = matches.value_of("FILE") { [INFO] [stderr] 32 | | let mut s = String::new(); [INFO] [stderr] 33 | | let mut file = match File::open(f) { [INFO] [stderr] ... | [INFO] [stderr] 48 | | } [INFO] [stderr] 49 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 30 | } else if let Some(f) = matches.value_of("FILE") { [INFO] [stderr] 31 | let mut s = String::new(); [INFO] [stderr] 32 | let mut file = match File::open(f) { [INFO] [stderr] 33 | Ok(fi) => fi, [INFO] [stderr] 34 | Err(e) => { [INFO] [stderr] 35 | println!("Error while opening file `{}`: {}", f, e); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 6.02s [INFO] running `"docker" "inspect" "718b371db73bdf146bb8659107c87ac54eadf5d9ce472ec74ee2902a8090b1c8"` [INFO] running `"docker" "rm" "-f" "718b371db73bdf146bb8659107c87ac54eadf5d9ce472ec74ee2902a8090b1c8"` [INFO] [stdout] 718b371db73bdf146bb8659107c87ac54eadf5d9ce472ec74ee2902a8090b1c8