[INFO] updating cached repository zwparchman/rlua-table-derive [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/zwparchman/rlua-table-derive [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/zwparchman/rlua-table-derive" "work/ex/clippy-test-run/sources/stable/gh/zwparchman/rlua-table-derive"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/zwparchman/rlua-table-derive'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/zwparchman/rlua-table-derive" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/zwparchman/rlua-table-derive"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/zwparchman/rlua-table-derive'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 53c23fd43a9b7cbf65682386c38483978c4827f6 [INFO] sha for GitHub repo zwparchman/rlua-table-derive: 53c23fd43a9b7cbf65682386c38483978c4827f6 [INFO] validating manifest of zwparchman/rlua-table-derive on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of zwparchman/rlua-table-derive on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing zwparchman/rlua-table-derive [INFO] finished frobbing zwparchman/rlua-table-derive [INFO] frobbed toml for zwparchman/rlua-table-derive written to work/ex/clippy-test-run/sources/stable/gh/zwparchman/rlua-table-derive/Cargo.toml [INFO] started frobbing zwparchman/rlua-table-derive [INFO] finished frobbing zwparchman/rlua-table-derive [INFO] frobbed toml for zwparchman/rlua-table-derive written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/zwparchman/rlua-table-derive/Cargo.toml [INFO] crate zwparchman/rlua-table-derive has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting zwparchman/rlua-table-derive against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/zwparchman/rlua-table-derive:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f0fb16b204ff5db7f3e27467393853af7d04d317b362cebaea103040438b6aea [INFO] running `"docker" "start" "-a" "f0fb16b204ff5db7f3e27467393853af7d04d317b362cebaea103040438b6aea"` [INFO] [stderr] Compiling gcc v0.3.54 [INFO] [stderr] Checking unicode-xid v0.0.4 [INFO] [stderr] Checking libc v0.2.34 [INFO] [stderr] Checking quote v0.3.15 [INFO] [stderr] Checking synom v0.11.3 [INFO] [stderr] Checking syn v0.11.11 [INFO] [stderr] Compiling rlua v0.10.2 [INFO] [stderr] Checking rlua-table-derive v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/lib.rs:25:25 [INFO] [stderr] | [INFO] [stderr] 25 | for ref field in fields.iter() { [INFO] [stderr] | ^^^^^^^^^ ------------- help: try: `let field = &fields.iter();` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/lib.rs:26:25 [INFO] [stderr] | [INFO] [stderr] 26 | / match &field.ident { [INFO] [stderr] 27 | | &Some(ref ident) => { [INFO] [stderr] 28 | | idents.push(ident.clone()); [INFO] [stderr] 29 | | }, [INFO] [stderr] 30 | | &None => panic!("The structure is missing a field identity"), [INFO] [stderr] 31 | | } [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 26 | match field.ident { [INFO] [stderr] 27 | Some(ref ident) => { [INFO] [stderr] 28 | idents.push(ident.clone()); [INFO] [stderr] 29 | }, [INFO] [stderr] 30 | None => panic!("The structure is missing a field identity"), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/lib.rs:25:25 [INFO] [stderr] | [INFO] [stderr] 25 | for ref field in fields.iter() { [INFO] [stderr] | ^^^^^^^^^ ------------- help: try: `let field = &fields.iter();` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/lib.rs:26:25 [INFO] [stderr] | [INFO] [stderr] 26 | / match &field.ident { [INFO] [stderr] 27 | | &Some(ref ident) => { [INFO] [stderr] 28 | | idents.push(ident.clone()); [INFO] [stderr] 29 | | }, [INFO] [stderr] 30 | | &None => panic!("The structure is missing a field identity"), [INFO] [stderr] 31 | | } [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 26 | match field.ident { [INFO] [stderr] 27 | Some(ref ident) => { [INFO] [stderr] 28 | idents.push(ident.clone()); [INFO] [stderr] 29 | }, [INFO] [stderr] 30 | None => panic!("The structure is missing a field identity"), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 15.00s [INFO] running `"docker" "inspect" "f0fb16b204ff5db7f3e27467393853af7d04d317b362cebaea103040438b6aea"` [INFO] running `"docker" "rm" "-f" "f0fb16b204ff5db7f3e27467393853af7d04d317b362cebaea103040438b6aea"` [INFO] [stdout] f0fb16b204ff5db7f3e27467393853af7d04d317b362cebaea103040438b6aea