[INFO] updating cached repository zwirec/http_server [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/zwirec/http_server [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/zwirec/http_server" "work/ex/clippy-test-run/sources/stable/gh/zwirec/http_server"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/zwirec/http_server'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/zwirec/http_server" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/zwirec/http_server"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/zwirec/http_server'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 3c0c350bb618b6238b1f3f6d08bff449b67a42f4 [INFO] sha for GitHub repo zwirec/http_server: 3c0c350bb618b6238b1f3f6d08bff449b67a42f4 [INFO] validating manifest of zwirec/http_server on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of zwirec/http_server on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing zwirec/http_server [INFO] finished frobbing zwirec/http_server [INFO] frobbed toml for zwirec/http_server written to work/ex/clippy-test-run/sources/stable/gh/zwirec/http_server/Cargo.toml [INFO] started frobbing zwirec/http_server [INFO] finished frobbing zwirec/http_server [INFO] frobbed toml for zwirec/http_server written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/zwirec/http_server/Cargo.toml [INFO] crate zwirec/http_server has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting zwirec/http_server against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/zwirec/http_server:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 37dfae4958027c7287ba4d503d1623c4b58af86b97b832f50fd0a0d0db7d384a [INFO] running `"docker" "start" "-a" "37dfae4958027c7287ba4d503d1623c4b58af86b97b832f50fd0a0d0db7d384a"` [INFO] [stderr] Checking num-traits v0.2.1 [INFO] [stderr] Checking void v1.0.2 [INFO] [stderr] Checking libc v0.2.38 [INFO] [stderr] Compiling unicode-xid v0.0.4 [INFO] [stderr] Compiling quote v0.3.15 [INFO] [stderr] Checking lazy_static v1.0.0 [INFO] [stderr] Checking regex-syntax v0.4.2 [INFO] [stderr] Checking utf8-ranges v1.0.0 [INFO] [stderr] Checking strum v0.8.0 [INFO] [stderr] Checking percent-encoding v1.0.1 [INFO] [stderr] Checking unreachable v1.0.0 [INFO] [stderr] Compiling synom v0.11.3 [INFO] [stderr] Checking thread_local v0.3.5 [INFO] [stderr] Compiling syn v0.11.11 [INFO] [stderr] Checking memchr v2.0.1 [INFO] [stderr] Checking time v0.1.39 [INFO] [stderr] Checking num-integer v0.1.36 [INFO] [stderr] Checking aho-corasick v0.6.4 [INFO] [stderr] Checking num-iter v0.1.35 [INFO] [stderr] Checking num v0.1.42 [INFO] [stderr] Checking regex v0.2.6 [INFO] [stderr] Checking chrono v0.4.0 [INFO] [stderr] Compiling strum_macros v0.8.0 [INFO] [stderr] Checking http_server v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/server/mod.rs:4:1 [INFO] [stderr] | [INFO] [stderr] 4 | pub mod server; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::thread` [INFO] [stderr] --> src/server/server.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | use std::thread; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::io::SeekFrom` [INFO] [stderr] --> src/server/server.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | use std::io::SeekFrom; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `Task` [INFO] [stderr] --> src/server/thread_pool.rs:1:32 [INFO] [stderr] | [INFO] [stderr] 1 | use ::server::worker::{Worker, Task}; [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/server/request.rs:85:9 [INFO] [stderr] | [INFO] [stderr] 85 | / return Some(Request { [INFO] [stderr] 86 | | method, [INFO] [stderr] 87 | | path: path.map(|v| String::from(v)), [INFO] [stderr] 88 | | proto, [INFO] [stderr] 89 | | }); [INFO] [stderr] | |___________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 85 | Some(Request { [INFO] [stderr] 86 | method, [INFO] [stderr] 87 | path: path.map(|v| String::from(v)), [INFO] [stderr] 88 | proto, [INFO] [stderr] 89 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unused import: `self::chrono::prelude::*` [INFO] [stderr] --> src/server/response.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | use self::chrono::prelude::*; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `EnumProperty` [INFO] [stderr] --> src/server/response.rs:4:13 [INFO] [stderr] | [INFO] [stderr] 4 | use strum::{EnumProperty, EnumMessage}; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::fmt` [INFO] [stderr] --> src/server/response.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | use std::fmt; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::string::ToString` [INFO] [stderr] --> src/server/response.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | use std::string::ToString; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/config/mod.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | pub mod config; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/server/mod.rs:4:1 [INFO] [stderr] | [INFO] [stderr] 4 | pub mod server; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::thread` [INFO] [stderr] --> src/server/server.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | use std::thread; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::io::SeekFrom` [INFO] [stderr] --> src/server/server.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | use std::io::SeekFrom; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `Task` [INFO] [stderr] --> src/server/thread_pool.rs:1:32 [INFO] [stderr] | [INFO] [stderr] 1 | use ::server::worker::{Worker, Task}; [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/server/request.rs:85:9 [INFO] [stderr] | [INFO] [stderr] 85 | / return Some(Request { [INFO] [stderr] 86 | | method, [INFO] [stderr] 87 | | path: path.map(|v| String::from(v)), [INFO] [stderr] 88 | | proto, [INFO] [stderr] 89 | | }); [INFO] [stderr] | |___________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 85 | Some(Request { [INFO] [stderr] 86 | method, [INFO] [stderr] 87 | path: path.map(|v| String::from(v)), [INFO] [stderr] 88 | proto, [INFO] [stderr] 89 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unused import: `self::chrono::prelude::*` [INFO] [stderr] --> src/server/response.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | use self::chrono::prelude::*; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `EnumProperty` [INFO] [stderr] --> src/server/response.rs:4:13 [INFO] [stderr] | [INFO] [stderr] 4 | use strum::{EnumProperty, EnumMessage}; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::fmt` [INFO] [stderr] --> src/server/response.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | use std::fmt; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::string::ToString` [INFO] [stderr] --> src/server/response.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | use std::string::ToString; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/config/mod.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | pub mod config; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: unused variable: `len` [INFO] [stderr] --> src/server/request.rs:127:13 [INFO] [stderr] | [INFO] [stderr] 127 | let len = p.len(); [INFO] [stderr] | ^^^ help: consider using `_len` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: value assigned to `sub_path` is never read [INFO] [stderr] --> src/server/request.rs:186:17 [INFO] [stderr] | [INFO] [stderr] 186 | let mut sub_path = String::from(""); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_assignments)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `workers` [INFO] [stderr] --> src/server/thread_pool.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | workers: Vec, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused attribute [INFO] [stderr] --> src/server/server.rs:16:1 [INFO] [stderr] | [INFO] [stderr] 16 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_attributes)] on by default [INFO] [stderr] [INFO] [stderr] warning: The function/method `::parse` doesn't need a mutable reference [INFO] [stderr] --> src/server/server.rs:61:36 [INFO] [stderr] | [INFO] [stderr] 61 | let req = match Request::parse(&mut buffer) { [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/server/server.rs:102:29 [INFO] [stderr] | [INFO] [stderr] 102 | unwrap_or(MimeTypes::Other("application/octet-stream".to_owned())). [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| MimeTypes::Other("application/octet-stream".to_owned()))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/server/server.rs:117:13 [INFO] [stderr] | [INFO] [stderr] 117 | / match p.exists() { [INFO] [stderr] 118 | | true => { [INFO] [stderr] 119 | | resp.headers. [INFO] [stderr] 120 | | push(Headers::ContentType( [INFO] [stderr] ... | [INFO] [stderr] 135 | | } [INFO] [stderr] 136 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 117 | if p.exists() { [INFO] [stderr] 118 | resp.headers. [INFO] [stderr] 119 | push(Headers::ContentType( [INFO] [stderr] 120 | MimeTypes::from_str(p. [INFO] [stderr] 121 | extension(). [INFO] [stderr] 122 | unwrap_or_else(|| panic!("extension panic")). [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/server/server.rs:126:33 [INFO] [stderr] | [INFO] [stderr] 126 | unwrap_or(MimeTypes::Other("application/octet-stream".to_owned())). [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| MimeTypes::Other("application/octet-stream".to_owned()))` [INFO] [stderr] warning: unused variable: `len` [INFO] [stderr] --> src/server/request.rs:127:13 [INFO] [stderr] | [INFO] [stderr] 127 | let len = p.len(); [INFO] [stderr] | ^^^ help: consider using `_len` instead [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: value assigned to `sub_path` is never read [INFO] [stderr] --> src/server/request.rs:186:17 [INFO] [stderr] | [INFO] [stderr] 186 | let mut sub_path = String::from(""); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_assignments)] on by default [INFO] [stderr] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `server::request::Request` [INFO] [stderr] --> src/server/request.rs:54:5 [INFO] [stderr] | [INFO] [stderr] 54 | / pub fn new() -> Request { [INFO] [stderr] 55 | | Request { [INFO] [stderr] 56 | | proto: None, [INFO] [stderr] 57 | | method: None, [INFO] [stderr] 58 | | path: None, [INFO] [stderr] 59 | | } [INFO] [stderr] 60 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 47 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/server/request.rs:83:17 [INFO] [stderr] | [INFO] [stderr] 83 | map(|v| add_index(v)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove closure as shown: `add_index` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/server/request.rs:87:28 [INFO] [stderr] | [INFO] [stderr] 87 | path: path.map(|v| String::from(v)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `String::from` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/server/request.rs:87:32 [INFO] [stderr] | [INFO] [stderr] 87 | path: path.map(|v| String::from(v)), [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `v` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/server/request.rs:108:19 [INFO] [stderr] | [INFO] [stderr] 108 | let mut out = String::from(path.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `path.clone()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/server/request.rs:110:48 [INFO] [stderr] | [INFO] [stderr] 110 | match path.split("/").last().unwrap().find(".") { [INFO] [stderr] | ^^^ help: try using a char instead: `'.'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/server/request.rs:110:22 [INFO] [stderr] | [INFO] [stderr] 110 | match path.split("/").last().unwrap().find(".") { [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/server/request.rs:134:9 [INFO] [stderr] | [INFO] [stderr] 134 | / match path.find("./") { [INFO] [stderr] 135 | | Some(i) => { [INFO] [stderr] 136 | | if i == 0 { [INFO] [stderr] 137 | | path = p.drain(2..).collect(); [INFO] [stderr] ... | [INFO] [stderr] 142 | | None => {} [INFO] [stderr] 143 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 134 | if let Some(i) = path.find("./") { [INFO] [stderr] 135 | if i == 0 { [INFO] [stderr] 136 | path = p.drain(2..).collect(); [INFO] [stderr] 137 | continue; [INFO] [stderr] 138 | ; [INFO] [stderr] 139 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/server/request.rs:145:9 [INFO] [stderr] | [INFO] [stderr] 145 | / match path.find("../") { [INFO] [stderr] 146 | | Some(i) => { [INFO] [stderr] 147 | | if i == 0 { [INFO] [stderr] 148 | | path = p.drain(3..).collect(); [INFO] [stderr] ... | [INFO] [stderr] 152 | | None => {} [INFO] [stderr] 153 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 145 | if let Some(i) = path.find("../") { [INFO] [stderr] 146 | if i == 0 { [INFO] [stderr] 147 | path = p.drain(3..).collect(); [INFO] [stderr] 148 | continue; [INFO] [stderr] 149 | } [INFO] [stderr] 150 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/server/request.rs:197:29 [INFO] [stderr] | [INFO] [stderr] 197 | match sub_path.find("/") { [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/server/request.rs:203:39 [INFO] [stderr] | [INFO] [stderr] 203 | let s = &path.clone()[0..i + 1]; [INFO] [stderr] | ^^^^^^^^ help: use: `0..=i` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: this call to `as_ref` does nothing [INFO] [stderr] --> src/server/request.rs:204:33 [INFO] [stderr] | [INFO] [stderr] 204 | output.push_str(s.as_ref()); [INFO] [stderr] | ^^^^^^^^^^ help: try this: `s` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_asref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `server::response::Response` [INFO] [stderr] --> src/server/response.rs:95:5 [INFO] [stderr] | [INFO] [stderr] 95 | / pub fn new() -> Response { [INFO] [stderr] 96 | | Response { [INFO] [stderr] 97 | | headers: vec![], [INFO] [stderr] 98 | | status: None, [INFO] [stderr] 99 | | file: None, [INFO] [stderr] 100 | | } [INFO] [stderr] 101 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 87 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `ref` directly on a function argument is ignored. Consider using a reference type instead. [INFO] [stderr] --> src/server/response.rs:103:23 [INFO] [stderr] | [INFO] [stderr] 103 | pub fn send(self, ref mut stream: &mut TcpStream) { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/server/response.rs:110:27 [INFO] [stderr] | [INFO] [stderr] 110 | let h_value = match &h { [INFO] [stderr] | ___________________________^ [INFO] [stderr] 111 | | &Headers::ContentLength(ref v) => &v, [INFO] [stderr] 112 | | &Headers::ContentType(ref v) => &v, [INFO] [stderr] 113 | | &Headers::Date(ref v) => &v, [INFO] [stderr] 114 | | &Headers::Connection(ref v) => &v, [INFO] [stderr] 115 | | &Headers::Server(_) => "RST", [INFO] [stderr] 116 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 110 | let h_value = match h { [INFO] [stderr] 111 | Headers::ContentLength(ref v) => &v, [INFO] [stderr] 112 | Headers::ContentType(ref v) => &v, [INFO] [stderr] 113 | Headers::Date(ref v) => &v, [INFO] [stderr] 114 | Headers::Connection(ref v) => &v, [INFO] [stderr] 115 | Headers::Server(_) => "RST", [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/server/response.rs:121:9 [INFO] [stderr] | [INFO] [stderr] 121 | stream.write(buf.as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/server/response.rs:122:9 [INFO] [stderr] | [INFO] [stderr] 122 | / match self.file { [INFO] [stderr] 123 | | Some(mut f) => { [INFO] [stderr] 124 | | // buf.push_str(CRLF); [INFO] [stderr] 125 | | let mut buf = [0; 1024 * 1024]; [INFO] [stderr] ... | [INFO] [stderr] 139 | | None => {} [INFO] [stderr] 140 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 122 | if let Some(mut f) = self.file { [INFO] [stderr] 123 | // buf.push_str(CRLF); [INFO] [stderr] 124 | let mut buf = [0; 1024 * 1024]; [INFO] [stderr] 125 | let mut n: u64 = 0; [INFO] [stderr] 126 | loop { [INFO] [stderr] 127 | match f.read(&mut buf).unwrap() { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/server/response.rs:133:29 [INFO] [stderr] | [INFO] [stderr] 133 | stream.write(&buf[..i]).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/server/response.rs:134:29 [INFO] [stderr] | [INFO] [stderr] 134 | f.seek(SeekFrom::Start(n as u64)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/config/config.rs:25:68 [INFO] [stderr] | [INFO] [stderr] 25 | params.insert(l.next().unwrap_or_default().to_owned(), l.next().clone().unwrap_or_default().to_owned()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `l.next()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/config/config.rs:30:21 [INFO] [stderr] | [INFO] [stderr] 30 | unwrap_or(DEFAULT_DOC_ROOT.to_owned().borrow()).clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| DEFAULT_DOC_ROOT.to_owned().borrow())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/config/config.rs:32:21 [INFO] [stderr] | [INFO] [stderr] 32 | unwrap_or(DEFAULT_NUM_THREADS.to_string().borrow()).parse().unwrap(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| DEFAULT_NUM_THREADS.to_string().borrow())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/config/config.rs:34:21 [INFO] [stderr] | [INFO] [stderr] 34 | unwrap_or(DEFAULT_PORT.to_string().borrow()).parse().unwrap(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| DEFAULT_PORT.to_string().borrow())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `http_server`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: field is never used: `workers` [INFO] [stderr] --> src/server/thread_pool.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | workers: Vec, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused attribute [INFO] [stderr] --> src/server/server.rs:16:1 [INFO] [stderr] | [INFO] [stderr] 16 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_attributes)] on by default [INFO] [stderr] [INFO] [stderr] warning: The function/method `::parse` doesn't need a mutable reference [INFO] [stderr] --> src/server/server.rs:61:36 [INFO] [stderr] | [INFO] [stderr] 61 | let req = match Request::parse(&mut buffer) { [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/server/server.rs:102:29 [INFO] [stderr] | [INFO] [stderr] 102 | unwrap_or(MimeTypes::Other("application/octet-stream".to_owned())). [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| MimeTypes::Other("application/octet-stream".to_owned()))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/server/server.rs:117:13 [INFO] [stderr] | [INFO] [stderr] 117 | / match p.exists() { [INFO] [stderr] 118 | | true => { [INFO] [stderr] 119 | | resp.headers. [INFO] [stderr] 120 | | push(Headers::ContentType( [INFO] [stderr] ... | [INFO] [stderr] 135 | | } [INFO] [stderr] 136 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 117 | if p.exists() { [INFO] [stderr] 118 | resp.headers. [INFO] [stderr] 119 | push(Headers::ContentType( [INFO] [stderr] 120 | MimeTypes::from_str(p. [INFO] [stderr] 121 | extension(). [INFO] [stderr] 122 | unwrap_or_else(|| panic!("extension panic")). [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/server/server.rs:126:33 [INFO] [stderr] | [INFO] [stderr] 126 | unwrap_or(MimeTypes::Other("application/octet-stream".to_owned())). [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| MimeTypes::Other("application/octet-stream".to_owned()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `server::request::Request` [INFO] [stderr] --> src/server/request.rs:54:5 [INFO] [stderr] | [INFO] [stderr] 54 | / pub fn new() -> Request { [INFO] [stderr] 55 | | Request { [INFO] [stderr] 56 | | proto: None, [INFO] [stderr] 57 | | method: None, [INFO] [stderr] 58 | | path: None, [INFO] [stderr] 59 | | } [INFO] [stderr] 60 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 47 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/server/request.rs:83:17 [INFO] [stderr] | [INFO] [stderr] 83 | map(|v| add_index(v)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove closure as shown: `add_index` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/server/request.rs:87:28 [INFO] [stderr] | [INFO] [stderr] 87 | path: path.map(|v| String::from(v)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `String::from` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/server/request.rs:87:32 [INFO] [stderr] | [INFO] [stderr] 87 | path: path.map(|v| String::from(v)), [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `v` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/server/request.rs:108:19 [INFO] [stderr] | [INFO] [stderr] 108 | let mut out = String::from(path.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `path.clone()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/server/request.rs:110:48 [INFO] [stderr] | [INFO] [stderr] 110 | match path.split("/").last().unwrap().find(".") { [INFO] [stderr] | ^^^ help: try using a char instead: `'.'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/server/request.rs:110:22 [INFO] [stderr] | [INFO] [stderr] 110 | match path.split("/").last().unwrap().find(".") { [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/server/request.rs:134:9 [INFO] [stderr] | [INFO] [stderr] 134 | / match path.find("./") { [INFO] [stderr] 135 | | Some(i) => { [INFO] [stderr] 136 | | if i == 0 { [INFO] [stderr] 137 | | path = p.drain(2..).collect(); [INFO] [stderr] ... | [INFO] [stderr] 142 | | None => {} [INFO] [stderr] 143 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 134 | if let Some(i) = path.find("./") { [INFO] [stderr] 135 | if i == 0 { [INFO] [stderr] 136 | path = p.drain(2..).collect(); [INFO] [stderr] 137 | continue; [INFO] [stderr] 138 | ; [INFO] [stderr] 139 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/server/request.rs:145:9 [INFO] [stderr] | [INFO] [stderr] 145 | / match path.find("../") { [INFO] [stderr] 146 | | Some(i) => { [INFO] [stderr] 147 | | if i == 0 { [INFO] [stderr] 148 | | path = p.drain(3..).collect(); [INFO] [stderr] ... | [INFO] [stderr] 152 | | None => {} [INFO] [stderr] 153 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 145 | if let Some(i) = path.find("../") { [INFO] [stderr] 146 | if i == 0 { [INFO] [stderr] 147 | path = p.drain(3..).collect(); [INFO] [stderr] 148 | continue; [INFO] [stderr] 149 | } [INFO] [stderr] 150 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/server/request.rs:197:29 [INFO] [stderr] | [INFO] [stderr] 197 | match sub_path.find("/") { [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/server/request.rs:203:39 [INFO] [stderr] | [INFO] [stderr] 203 | let s = &path.clone()[0..i + 1]; [INFO] [stderr] | ^^^^^^^^ help: use: `0..=i` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: this call to `as_ref` does nothing [INFO] [stderr] --> src/server/request.rs:204:33 [INFO] [stderr] | [INFO] [stderr] 204 | output.push_str(s.as_ref()); [INFO] [stderr] | ^^^^^^^^^^ help: try this: `s` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_asref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `server::response::Response` [INFO] [stderr] --> src/server/response.rs:95:5 [INFO] [stderr] | [INFO] [stderr] 95 | / pub fn new() -> Response { [INFO] [stderr] 96 | | Response { [INFO] [stderr] 97 | | headers: vec![], [INFO] [stderr] 98 | | status: None, [INFO] [stderr] 99 | | file: None, [INFO] [stderr] 100 | | } [INFO] [stderr] 101 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 87 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `ref` directly on a function argument is ignored. Consider using a reference type instead. [INFO] [stderr] --> src/server/response.rs:103:23 [INFO] [stderr] | [INFO] [stderr] 103 | pub fn send(self, ref mut stream: &mut TcpStream) { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/server/response.rs:110:27 [INFO] [stderr] | [INFO] [stderr] 110 | let h_value = match &h { [INFO] [stderr] | ___________________________^ [INFO] [stderr] 111 | | &Headers::ContentLength(ref v) => &v, [INFO] [stderr] 112 | | &Headers::ContentType(ref v) => &v, [INFO] [stderr] 113 | | &Headers::Date(ref v) => &v, [INFO] [stderr] 114 | | &Headers::Connection(ref v) => &v, [INFO] [stderr] 115 | | &Headers::Server(_) => "RST", [INFO] [stderr] 116 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 110 | let h_value = match h { [INFO] [stderr] 111 | Headers::ContentLength(ref v) => &v, [INFO] [stderr] 112 | Headers::ContentType(ref v) => &v, [INFO] [stderr] 113 | Headers::Date(ref v) => &v, [INFO] [stderr] 114 | Headers::Connection(ref v) => &v, [INFO] [stderr] 115 | Headers::Server(_) => "RST", [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/server/response.rs:121:9 [INFO] [stderr] | [INFO] [stderr] 121 | stream.write(buf.as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/server/response.rs:122:9 [INFO] [stderr] | [INFO] [stderr] 122 | / match self.file { [INFO] [stderr] 123 | | Some(mut f) => { [INFO] [stderr] 124 | | // buf.push_str(CRLF); [INFO] [stderr] 125 | | let mut buf = [0; 1024 * 1024]; [INFO] [stderr] ... | [INFO] [stderr] 139 | | None => {} [INFO] [stderr] 140 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 122 | if let Some(mut f) = self.file { [INFO] [stderr] 123 | // buf.push_str(CRLF); [INFO] [stderr] 124 | let mut buf = [0; 1024 * 1024]; [INFO] [stderr] 125 | let mut n: u64 = 0; [INFO] [stderr] 126 | loop { [INFO] [stderr] 127 | match f.read(&mut buf).unwrap() { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/server/response.rs:133:29 [INFO] [stderr] | [INFO] [stderr] 133 | stream.write(&buf[..i]).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/server/response.rs:134:29 [INFO] [stderr] | [INFO] [stderr] 134 | f.seek(SeekFrom::Start(n as u64)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/config/config.rs:25:68 [INFO] [stderr] | [INFO] [stderr] 25 | params.insert(l.next().unwrap_or_default().to_owned(), l.next().clone().unwrap_or_default().to_owned()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `l.next()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/config/config.rs:30:21 [INFO] [stderr] | [INFO] [stderr] 30 | unwrap_or(DEFAULT_DOC_ROOT.to_owned().borrow()).clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| DEFAULT_DOC_ROOT.to_owned().borrow())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/config/config.rs:32:21 [INFO] [stderr] | [INFO] [stderr] 32 | unwrap_or(DEFAULT_NUM_THREADS.to_string().borrow()).parse().unwrap(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| DEFAULT_NUM_THREADS.to_string().borrow())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/config/config.rs:34:21 [INFO] [stderr] | [INFO] [stderr] 34 | unwrap_or(DEFAULT_PORT.to_string().borrow()).parse().unwrap(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| DEFAULT_PORT.to_string().borrow())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `http_server`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "37dfae4958027c7287ba4d503d1623c4b58af86b97b832f50fd0a0d0db7d384a"` [INFO] running `"docker" "rm" "-f" "37dfae4958027c7287ba4d503d1623c4b58af86b97b832f50fd0a0d0db7d384a"` [INFO] [stdout] 37dfae4958027c7287ba4d503d1623c4b58af86b97b832f50fd0a0d0db7d384a