[INFO] updating cached repository zukonake/boids [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/zukonake/boids [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/zukonake/boids" "work/ex/clippy-test-run/sources/stable/gh/zukonake/boids"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/zukonake/boids'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/zukonake/boids" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/zukonake/boids"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/zukonake/boids'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 29e428fe5ca5cb5097598780c363523eee26929c [INFO] sha for GitHub repo zukonake/boids: 29e428fe5ca5cb5097598780c363523eee26929c [INFO] validating manifest of zukonake/boids on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of zukonake/boids on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing zukonake/boids [INFO] finished frobbing zukonake/boids [INFO] frobbed toml for zukonake/boids written to work/ex/clippy-test-run/sources/stable/gh/zukonake/boids/Cargo.toml [INFO] started frobbing zukonake/boids [INFO] finished frobbing zukonake/boids [INFO] frobbed toml for zukonake/boids written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/zukonake/boids/Cargo.toml [INFO] crate zukonake/boids has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting zukonake/boids against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/zukonake/boids:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] fcb80f03c995786cf0499d2835e94e689cfe4651d7cd787250cfc9564d522b4f [INFO] running `"docker" "start" "-a" "fcb80f03c995786cf0499d2835e94e689cfe4651d7cd787250cfc9564d522b4f"` [INFO] [stderr] Compiling libc v0.2.33 [INFO] [stderr] Compiling num-traits v0.1.40 [INFO] [stderr] Compiling dtoa v0.4.2 [INFO] [stderr] Compiling serde v0.9.15 [INFO] [stderr] Compiling itoa v0.3.4 [INFO] [stderr] Compiling bitflags v0.9.1 [INFO] [stderr] Checking lazy_static v0.2.9 [INFO] [stderr] Compiling khronos_api v1.0.1 [INFO] [stderr] Compiling log v0.3.8 [INFO] [stderr] Compiling cc v1.0.3 [INFO] [stderr] Checking byteorder v1.1.0 [INFO] [stderr] Checking rustc-demangle v0.1.5 [INFO] [stderr] Checking cfg-if v0.1.2 [INFO] [stderr] Checking fnv v1.0.5 [INFO] [stderr] Checking approx v0.1.1 [INFO] [stderr] Checking smallvec v0.4.4 [INFO] [stderr] Compiling x11-dl v2.16.0 [INFO] [stderr] Compiling xml-rs v0.6.1 [INFO] [stderr] Checking rand v0.3.17 [INFO] [stderr] Checking shared_library v0.1.7 [INFO] [stderr] Checking osmesa-sys v0.1.2 [INFO] [stderr] Compiling backtrace-sys v0.1.16 [INFO] [stderr] Checking fs2 v0.2.5 [INFO] [stderr] Checking memmap v0.4.0 [INFO] [stderr] Checking tempfile v2.2.0 [INFO] [stderr] Checking cgmath v0.15.0 [INFO] [stderr] Compiling wayland-scanner v0.9.10 [INFO] [stderr] Compiling gl_generator v0.5.5 [INFO] [stderr] Compiling phf_generator v0.7.21 [INFO] [stderr] Compiling phf_codegen v0.7.21 [INFO] [stderr] Compiling target_build_utils v0.3.1 [INFO] [stderr] Compiling wayland-client v0.9.10 [INFO] [stderr] Compiling wayland-protocols v0.9.10 [INFO] [stderr] Compiling glutin v0.10.0 [INFO] [stderr] Compiling glium v0.18.0 [INFO] [stderr] Compiling serde_json v0.9.10 [INFO] [stderr] Checking backtrace v0.3.3 [INFO] [stderr] Compiling libloading v0.3.4 [INFO] [stderr] Checking dlib v0.3.1 [INFO] [stderr] Checking wayland-sys v0.9.10 [INFO] [stderr] Checking wayland-kbd v0.9.1 [INFO] [stderr] Checking wayland-window v0.8.0 [INFO] [stderr] Checking winit v0.8.3 [INFO] [stderr] Checking boids-rs v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:197:9 [INFO] [stderr] | [INFO] [stderr] 197 | x: x, [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:198:9 [INFO] [stderr] | [INFO] [stderr] 198 | y: y, [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:197:9 [INFO] [stderr] | [INFO] [stderr] 197 | x: x, [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:198:9 [INFO] [stderr] | [INFO] [stderr] 198 | y: y, [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/main.rs:84:49 [INFO] [stderr] | [INFO] [stderr] 84 | fn separation(boids: &mut [Boid; BOIDS_NUMBER]) -> () [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/main.rs:111:47 [INFO] [stderr] | [INFO] [stderr] 111 | fn cohesion(boids: &mut [Boid; BOIDS_NUMBER]) -> () [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/main.rs:134:48 [INFO] [stderr] | [INFO] [stderr] 134 | fn alignment(boids: &mut [Boid; BOIDS_NUMBER]) -> () [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/main.rs:157:72 [INFO] [stderr] | [INFO] [stderr] 157 | fn simulate(boids: &mut [Boid; BOIDS_NUMBER], map_size: &Vector2) -> () [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/main.rs:202:75 [INFO] [stderr] | [INFO] [stderr] 202 | fn update_vertices(boids: &[Boid; BOIDS_NUMBER], vertices: &mut [Vertex]) -> () [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> src/main.rs:211:62 [INFO] [stderr] | [INFO] [stderr] 211 | let vertex2 = i.position + Vector2::new(-BOIDS_SIZE, (BOIDS_SIZE / 2.0)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/main.rs:84:49 [INFO] [stderr] | [INFO] [stderr] 84 | fn separation(boids: &mut [Boid; BOIDS_NUMBER]) -> () [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/main.rs:111:47 [INFO] [stderr] | [INFO] [stderr] 111 | fn cohesion(boids: &mut [Boid; BOIDS_NUMBER]) -> () [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/main.rs:134:48 [INFO] [stderr] | [INFO] [stderr] 134 | fn alignment(boids: &mut [Boid; BOIDS_NUMBER]) -> () [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/main.rs:157:72 [INFO] [stderr] | [INFO] [stderr] 157 | fn simulate(boids: &mut [Boid; BOIDS_NUMBER], map_size: &Vector2) -> () [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/main.rs:202:75 [INFO] [stderr] | [INFO] [stderr] 202 | fn update_vertices(boids: &[Boid; BOIDS_NUMBER], vertices: &mut [Vertex]) -> () [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> src/main.rs:211:62 [INFO] [stderr] | [INFO] [stderr] 211 | let vertex2 = i.position + Vector2::new(-BOIDS_SIZE, (BOIDS_SIZE / 2.0)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:157:57 [INFO] [stderr] | [INFO] [stderr] 157 | fn simulate(boids: &mut [Boid; BOIDS_NUMBER], map_size: &Vector2) -> () [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider passing by value instead: `Vector2` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: unused return value of `cgmath::InnerSpace::normalize` that must be used [INFO] [stderr] --> src/main.rs:164:9 [INFO] [stderr] | [INFO] [stderr] 164 | new_boids[i].direction.normalize(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `boids`. [INFO] [stderr] --> src/main.rs:168:14 [INFO] [stderr] | [INFO] [stderr] 168 | for i in 0..BOIDS_NUMBER [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 168 | for in boids.iter_mut().take(BOIDS_NUMBER) [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the variable `iv` is used as a loop counter. Consider using `for (iv, item) in boids.iter().enumerate()` or similar iterators [INFO] [stderr] --> src/main.rs:205:14 [INFO] [stderr] | [INFO] [stderr] 205 | for i in boids.iter() [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `boids`. [INFO] [stderr] --> src/main.rs:239:14 [INFO] [stderr] | [INFO] [stderr] 239 | for i in 0..BOIDS_NUMBER [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 239 | for in boids.iter_mut().take(BOIDS_NUMBER) [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:290:13 [INFO] [stderr] | [INFO] [stderr] 290 | / match event [INFO] [stderr] 291 | | { [INFO] [stderr] 292 | | Event::WindowEvent{event: WindowEvent::Closed, ..} => window_open = false, [INFO] [stderr] 293 | | _ => (), [INFO] [stderr] 294 | | } [INFO] [stderr] | |_____________^ help: try this: `if let Event::WindowEvent{event: WindowEvent::Closed, ..} = event { window_open = false }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:157:57 [INFO] [stderr] | [INFO] [stderr] 157 | fn simulate(boids: &mut [Boid; BOIDS_NUMBER], map_size: &Vector2) -> () [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider passing by value instead: `Vector2` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: unused return value of `cgmath::InnerSpace::normalize` that must be used [INFO] [stderr] --> src/main.rs:164:9 [INFO] [stderr] | [INFO] [stderr] 164 | new_boids[i].direction.normalize(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `boids`. [INFO] [stderr] --> src/main.rs:168:14 [INFO] [stderr] | [INFO] [stderr] 168 | for i in 0..BOIDS_NUMBER [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 168 | for in boids.iter_mut().take(BOIDS_NUMBER) [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the variable `iv` is used as a loop counter. Consider using `for (iv, item) in boids.iter().enumerate()` or similar iterators [INFO] [stderr] --> src/main.rs:205:14 [INFO] [stderr] | [INFO] [stderr] 205 | for i in boids.iter() [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `boids`. [INFO] [stderr] --> src/main.rs:239:14 [INFO] [stderr] | [INFO] [stderr] 239 | for i in 0..BOIDS_NUMBER [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 239 | for in boids.iter_mut().take(BOIDS_NUMBER) [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:290:13 [INFO] [stderr] | [INFO] [stderr] 290 | / match event [INFO] [stderr] 291 | | { [INFO] [stderr] 292 | | Event::WindowEvent{event: WindowEvent::Closed, ..} => window_open = false, [INFO] [stderr] 293 | | _ => (), [INFO] [stderr] 294 | | } [INFO] [stderr] | |_____________^ help: try this: `if let Event::WindowEvent{event: WindowEvent::Closed, ..} = event { window_open = false }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 52s [INFO] running `"docker" "inspect" "fcb80f03c995786cf0499d2835e94e689cfe4651d7cd787250cfc9564d522b4f"` [INFO] running `"docker" "rm" "-f" "fcb80f03c995786cf0499d2835e94e689cfe4651d7cd787250cfc9564d522b4f"` [INFO] [stdout] fcb80f03c995786cf0499d2835e94e689cfe4651d7cd787250cfc9564d522b4f