[INFO] updating cached repository ztulloch/time-tracker [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/ztulloch/time-tracker [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/ztulloch/time-tracker" "work/ex/clippy-test-run/sources/stable/gh/ztulloch/time-tracker"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ztulloch/time-tracker'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/ztulloch/time-tracker" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ztulloch/time-tracker"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ztulloch/time-tracker'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 60649179c004e624a5587d9980d8ba939fad4318 [INFO] sha for GitHub repo ztulloch/time-tracker: 60649179c004e624a5587d9980d8ba939fad4318 [INFO] validating manifest of ztulloch/time-tracker on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ztulloch/time-tracker on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ztulloch/time-tracker [INFO] finished frobbing ztulloch/time-tracker [INFO] frobbed toml for ztulloch/time-tracker written to work/ex/clippy-test-run/sources/stable/gh/ztulloch/time-tracker/Cargo.toml [INFO] started frobbing ztulloch/time-tracker [INFO] finished frobbing ztulloch/time-tracker [INFO] frobbed toml for ztulloch/time-tracker written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ztulloch/time-tracker/Cargo.toml [INFO] crate ztulloch/time-tracker has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ztulloch/time-tracker against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/ztulloch/time-tracker:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] bfdc8f80c76e50e88362a6eee1e7f712dabbce5c2546c79f43e0e4ecb15440ef [INFO] running `"docker" "start" "-a" "bfdc8f80c76e50e88362a6eee1e7f712dabbce5c2546c79f43e0e4ecb15440ef"` [INFO] [stderr] Compiling cc v1.0.18 [INFO] [stderr] Compiling libc v0.2.42 [INFO] [stderr] Compiling serde v1.0.66 [INFO] [stderr] Compiling rustc-demangle v0.1.9 [INFO] [stderr] Compiling cfg-if v0.1.4 [INFO] [stderr] Compiling dtoa v0.4.3 [INFO] [stderr] Compiling semver-parser v0.7.0 [INFO] [stderr] Compiling pulldown-cmark v0.1.2 [INFO] [stderr] Compiling itoa v0.4.2 [INFO] [stderr] Compiling remove_dir_all v0.5.1 [INFO] [stderr] Compiling same-file v1.0.2 [INFO] [stderr] Compiling bitflags v0.9.1 [INFO] [stderr] Compiling glob v0.2.11 [INFO] [stderr] Compiling bytecount v0.3.1 [INFO] [stderr] Compiling num-traits v0.2.5 [INFO] [stderr] Compiling num-integer v0.1.39 [INFO] [stderr] Checking lazy_static v1.0.2 [INFO] [stderr] Checking environment v0.1.1 [INFO] [stderr] Checking difference v1.0.0 [INFO] [stderr] Checking getopts v0.2.17 [INFO] [stderr] Compiling proc-macro2 v0.4.6 [INFO] [stderr] Compiling walkdir v2.1.4 [INFO] [stderr] Compiling rand v0.4.2 [INFO] [stderr] Checking colored v1.6.1 [INFO] [stderr] Checking memchr v2.0.1 [INFO] [stderr] Checking time v0.1.40 [INFO] [stderr] Compiling quote v0.6.3 [INFO] [stderr] Compiling tempdir v0.3.7 [INFO] [stderr] Compiling backtrace-sys v0.1.23 [INFO] [stderr] Checking csv-core v0.1.4 [INFO] [stderr] Compiling syn v0.14.2 [INFO] [stderr] Checking chrono v0.4.4 [INFO] [stderr] Compiling backtrace v0.3.9 [INFO] [stderr] Checking error-chain v0.11.0 [INFO] [stderr] Compiling serde_derive v1.0.66 [INFO] [stderr] Compiling serde_json v1.0.24 [INFO] [stderr] Compiling semver v0.9.0 [INFO] [stderr] Checking csv v1.0.0 [INFO] [stderr] Compiling cargo_metadata v0.5.8 [INFO] [stderr] Checking time-tracker v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:495:9 [INFO] [stderr] | [INFO] [stderr] 495 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:39:9 [INFO] [stderr] | [INFO] [stderr] 39 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:41:9 [INFO] [stderr] | [INFO] [stderr] 41 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:83:12 [INFO] [stderr] | [INFO] [stderr] 83 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 84 | | if !quick { [INFO] [stderr] 85 | | println!("There is no timer running"); [INFO] [stderr] 86 | | } else { [INFO] [stderr] 87 | | println!("None"); [INFO] [stderr] 88 | | } [INFO] [stderr] 89 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 83 | } else if !quick { [INFO] [stderr] 84 | println!("There is no timer running"); [INFO] [stderr] 85 | } else { [INFO] [stderr] 86 | println!("None"); [INFO] [stderr] 87 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/main.rs:38:5 [INFO] [stderr] | [INFO] [stderr] 38 | / if Path::new(filename).exists() { [INFO] [stderr] 39 | | return true; [INFO] [stderr] 40 | | } else { [INFO] [stderr] 41 | | return false; [INFO] [stderr] 42 | | } [INFO] [stderr] | |_____^ help: you can reduce it to: `return Path::new(filename).exists()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 27 [INFO] [stderr] --> src/main.rs:333:1 [INFO] [stderr] | [INFO] [stderr] 333 | / fn main() { [INFO] [stderr] 334 | | // parse program arguments using getopts crate [INFO] [stderr] 335 | | let args: Vec = env::args().collect(); [INFO] [stderr] 336 | | let program = args[0].clone(); [INFO] [stderr] ... | [INFO] [stderr] 497 | | }; [INFO] [stderr] 498 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:452:30 [INFO] [stderr] | [INFO] [stderr] 452 | if task.contains(",") { [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:472:38 [INFO] [stderr] | [INFO] [stderr] 472 | if project_code.contains(",") { [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] Compiling skeptic v0.13.3 [INFO] [stderr] Compiling assert_cli v0.5.4 [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:495:9 [INFO] [stderr] | [INFO] [stderr] 495 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:39:9 [INFO] [stderr] | [INFO] [stderr] 39 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:41:9 [INFO] [stderr] | [INFO] [stderr] 41 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:83:12 [INFO] [stderr] | [INFO] [stderr] 83 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 84 | | if !quick { [INFO] [stderr] 85 | | println!("There is no timer running"); [INFO] [stderr] 86 | | } else { [INFO] [stderr] 87 | | println!("None"); [INFO] [stderr] 88 | | } [INFO] [stderr] 89 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 83 | } else if !quick { [INFO] [stderr] 84 | println!("There is no timer running"); [INFO] [stderr] 85 | } else { [INFO] [stderr] 86 | println!("None"); [INFO] [stderr] 87 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/main.rs:38:5 [INFO] [stderr] | [INFO] [stderr] 38 | / if Path::new(filename).exists() { [INFO] [stderr] 39 | | return true; [INFO] [stderr] 40 | | } else { [INFO] [stderr] 41 | | return false; [INFO] [stderr] 42 | | } [INFO] [stderr] | |_____^ help: you can reduce it to: `return Path::new(filename).exists()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 27 [INFO] [stderr] --> src/main.rs:333:1 [INFO] [stderr] | [INFO] [stderr] 333 | / fn main() { [INFO] [stderr] 334 | | // parse program arguments using getopts crate [INFO] [stderr] 335 | | let args: Vec = env::args().collect(); [INFO] [stderr] 336 | | let program = args[0].clone(); [INFO] [stderr] ... | [INFO] [stderr] 497 | | }; [INFO] [stderr] 498 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:452:30 [INFO] [stderr] | [INFO] [stderr] 452 | if task.contains(",") { [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:472:38 [INFO] [stderr] | [INFO] [stderr] 472 | if project_code.contains(",") { [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 31s [INFO] running `"docker" "inspect" "bfdc8f80c76e50e88362a6eee1e7f712dabbce5c2546c79f43e0e4ecb15440ef"` [INFO] running `"docker" "rm" "-f" "bfdc8f80c76e50e88362a6eee1e7f712dabbce5c2546c79f43e0e4ecb15440ef"` [INFO] [stdout] bfdc8f80c76e50e88362a6eee1e7f712dabbce5c2546c79f43e0e4ecb15440ef