[INFO] updating cached repository zsiciarz/pixeldabble [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/zsiciarz/pixeldabble [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/zsiciarz/pixeldabble" "work/ex/clippy-test-run/sources/stable/gh/zsiciarz/pixeldabble"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/zsiciarz/pixeldabble'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/zsiciarz/pixeldabble" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/zsiciarz/pixeldabble"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/zsiciarz/pixeldabble'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] b50639db16521d9e2e7967c4f0d61a0ad77e37e1 [INFO] sha for GitHub repo zsiciarz/pixeldabble: b50639db16521d9e2e7967c4f0d61a0ad77e37e1 [INFO] validating manifest of zsiciarz/pixeldabble on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of zsiciarz/pixeldabble on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing zsiciarz/pixeldabble [INFO] finished frobbing zsiciarz/pixeldabble [INFO] frobbed toml for zsiciarz/pixeldabble written to work/ex/clippy-test-run/sources/stable/gh/zsiciarz/pixeldabble/Cargo.toml [INFO] started frobbing zsiciarz/pixeldabble [INFO] finished frobbing zsiciarz/pixeldabble [INFO] frobbed toml for zsiciarz/pixeldabble written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/zsiciarz/pixeldabble/Cargo.toml [INFO] crate zsiciarz/pixeldabble has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting zsiciarz/pixeldabble against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/zsiciarz/pixeldabble:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 0526a4ca7c60abc403724fa8529e0bc3dd995ab2e698ea0cbad7569f0d4d129c [INFO] running `"docker" "start" "-a" "0526a4ca7c60abc403724fa8529e0bc3dd995ab2e698ea0cbad7569f0d4d129c"` [INFO] [stderr] Checking cfg-if v0.1.3 [INFO] [stderr] Checking nodrop v0.1.12 [INFO] [stderr] Compiling num-traits v0.2.4 [INFO] [stderr] Checking scopeguard v0.3.3 [INFO] [stderr] Checking lazy_static v1.0.1 [INFO] [stderr] Checking memoffset v0.2.1 [INFO] [stderr] Compiling rayon-core v1.4.0 [INFO] [stderr] Compiling cc v1.0.17 [INFO] [stderr] Compiling num-integer v0.1.38 [INFO] [stderr] Checking libc v0.2.41 [INFO] [stderr] Compiling num-iter v0.1.37 [INFO] [stderr] Checking byteorder v1.2.3 [INFO] [stderr] Checking either v1.5.0 [INFO] [stderr] Checking adler32 v1.0.2 [INFO] [stderr] Checking color_quant v1.0.0 [INFO] [stderr] Checking lzw v0.10.0 [INFO] [stderr] Checking rustc-demangle v0.1.8 [INFO] [stderr] Checking bitflags v1.0.3 [INFO] [stderr] Checking scoped_threadpool v0.1.9 [INFO] [stderr] Compiling proc-macro2 v0.4.4 [INFO] [stderr] Checking crossbeam-utils v0.2.2 [INFO] [stderr] Checking arrayvec v0.4.7 [INFO] [stderr] Checking inflate v0.4.2 [INFO] [stderr] Checking itertools v0.7.8 [INFO] [stderr] Checking deflate v0.7.18 [INFO] [stderr] Checking term v0.5.1 [INFO] [stderr] Checking gif v0.10.0 [INFO] [stderr] Checking num_cpus v1.8.0 [INFO] [stderr] Checking rand v0.4.2 [INFO] [stderr] Checking crossbeam-epoch v0.3.1 [INFO] [stderr] Compiling quote v0.6.3 [INFO] [stderr] Compiling syn v0.14.1 [INFO] [stderr] Compiling backtrace-sys v0.1.23 [INFO] [stderr] Checking crossbeam-deque v0.2.0 [INFO] [stderr] Checking backtrace v0.3.8 [INFO] [stderr] Checking num-rational v0.1.42 [INFO] [stderr] Checking error-chain v0.11.0 [INFO] [stderr] Checking png v0.12.0 [INFO] [stderr] Checking rayon v1.0.1 [INFO] [stderr] Compiling num-derive v0.2.2 [INFO] [stderr] Checking jpeg-decoder v0.1.14 [INFO] [stderr] Checking image v0.19.0 [INFO] [stderr] Checking pixeldabble v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:55:16 [INFO] [stderr] | [INFO] [stderr] 55 | for row in 0..HISTOGRAM_HEIGHT + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: use: `0..=HISTOGRAM_HEIGHT` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `bar` [INFO] [stderr] --> src/lib.rs:57:13 [INFO] [stderr] | [INFO] [stderr] 57 | for bar in &bars { [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::blacklisted_name)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `bar` [INFO] [stderr] --> src/lib.rs:66:17 [INFO] [stderr] | [INFO] [stderr] 66 | fn to_character(bar: f32, row: i32) -> char { [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:55:16 [INFO] [stderr] | [INFO] [stderr] 55 | for row in 0..HISTOGRAM_HEIGHT + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: use: `0..=HISTOGRAM_HEIGHT` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `bar` [INFO] [stderr] --> src/lib.rs:57:13 [INFO] [stderr] | [INFO] [stderr] 57 | for bar in &bars { [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::blacklisted_name)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `bar` [INFO] [stderr] --> src/lib.rs:66:17 [INFO] [stderr] | [INFO] [stderr] 66 | fn to_character(bar: f32, row: i32) -> char { [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 53.52s [INFO] running `"docker" "inspect" "0526a4ca7c60abc403724fa8529e0bc3dd995ab2e698ea0cbad7569f0d4d129c"` [INFO] running `"docker" "rm" "-f" "0526a4ca7c60abc403724fa8529e0bc3dd995ab2e698ea0cbad7569f0d4d129c"` [INFO] [stdout] 0526a4ca7c60abc403724fa8529e0bc3dd995ab2e698ea0cbad7569f0d4d129c