[INFO] updating cached repository zofrex/better-than-basic [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/zofrex/better-than-basic [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/zofrex/better-than-basic" "work/ex/clippy-test-run/sources/stable/gh/zofrex/better-than-basic"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/zofrex/better-than-basic'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/zofrex/better-than-basic" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/zofrex/better-than-basic"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/zofrex/better-than-basic'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] cdcf8589b0d5efdd96bafefe757e687e685837fb [INFO] sha for GitHub repo zofrex/better-than-basic: cdcf8589b0d5efdd96bafefe757e687e685837fb [INFO] validating manifest of zofrex/better-than-basic on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of zofrex/better-than-basic on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing zofrex/better-than-basic [INFO] finished frobbing zofrex/better-than-basic [INFO] frobbed toml for zofrex/better-than-basic written to work/ex/clippy-test-run/sources/stable/gh/zofrex/better-than-basic/Cargo.toml [INFO] started frobbing zofrex/better-than-basic [INFO] finished frobbing zofrex/better-than-basic [INFO] frobbed toml for zofrex/better-than-basic written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/zofrex/better-than-basic/Cargo.toml [INFO] crate zofrex/better-than-basic has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting zofrex/better-than-basic against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/zofrex/better-than-basic:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] fffda4c2031cb0749885381ebb681996a1cc4db873bf0d5b4b7cad43b4c9e89f [INFO] running `"docker" "start" "-a" "fffda4c2031cb0749885381ebb681996a1cc4db873bf0d5b4b7cad43b4c9e89f"` [INFO] [stderr] Checking matches v0.1.4 [INFO] [stderr] Checking unicode-normalization v0.1.4 [INFO] [stderr] Checking traitobject v0.1.0 [INFO] [stderr] Checking libc v0.2.22 [INFO] [stderr] Checking log v0.3.7 [INFO] [stderr] Checking typeable v0.1.2 [INFO] [stderr] Checking httparse v1.2.2 [INFO] [stderr] Checking void v1.0.2 [INFO] [stderr] Checking rustc-serialize v0.3.24 [INFO] [stderr] Compiling gcc v0.3.49 [INFO] [stderr] Checking modifier v0.1.0 [INFO] [stderr] Checking serde v1.0.6 [INFO] [stderr] Checking num-traits v0.1.37 [INFO] [stderr] Checking utf8-ranges v1.0.0 [INFO] [stderr] Checking itoa v0.3.1 [INFO] [stderr] Checking dtoa v0.2.2 [INFO] [stderr] Checking regex-syntax v0.4.0 [INFO] [stderr] Checking dtoa v0.4.1 [INFO] [stderr] Checking serde v0.8.23 [INFO] [stderr] Checking itoa v0.1.1 [INFO] [stderr] Checking cfg-if v0.1.0 [INFO] [stderr] Checking sequence_trie v0.2.1 [INFO] [stderr] Checking quick-error v1.2.0 [INFO] [stderr] Checking pest v0.3.3 [INFO] [stderr] Checking same-file v0.1.3 [INFO] [stderr] Checking route-recognizer v0.1.12 [INFO] [stderr] Checking linked-hash-map v0.4.2 [INFO] [stderr] Checking base64 v0.5.2 [INFO] [stderr] Checking unsafe-any v0.4.1 [INFO] [stderr] Checking unicode-bidi v0.2.6 [INFO] [stderr] Checking unreachable v0.1.1 [INFO] [stderr] Checking error v0.1.9 [INFO] [stderr] Checking mime v0.2.4 [INFO] [stderr] Checking num_cpus v1.4.0 [INFO] [stderr] Checking time v0.1.37 [INFO] [stderr] Checking memchr v1.0.1 [INFO] [stderr] Checking thread-id v3.1.0 [INFO] [stderr] Checking rand v0.3.15 [INFO] [stderr] Compiling rust-crypto v0.2.36 [INFO] [stderr] Checking unix_socket v0.5.0 [INFO] [stderr] Compiling unicase v1.4.0 [INFO] [stderr] Compiling hyper v0.10.10 [INFO] [stderr] Checking walkdir v1.0.7 [INFO] [stderr] Checking typemap v0.3.3 [INFO] [stderr] Checking lru-cache v0.1.1 [INFO] [stderr] Checking idna v0.1.1 [INFO] [stderr] Checking aho-corasick v0.6.3 [INFO] [stderr] Checking thread_local v0.3.3 [INFO] [stderr] Checking cookie v0.8.1 [INFO] [stderr] Compiling serde_derive_internals v0.15.0 [INFO] [stderr] Checking plugin v0.2.6 [INFO] [stderr] Checking regex v0.2.1 [INFO] [stderr] Checking conduit-mime-types v0.7.3 [INFO] [stderr] Compiling serde_derive v1.0.7 [INFO] [stderr] Checking url v1.4.0 [INFO] [stderr] Checking serde_json v0.8.6 [INFO] [stderr] Checking serde_json v1.0.2 [INFO] [stderr] Checking toml v0.4.1 [INFO] [stderr] Checking handlebars v0.26.2 [INFO] [stderr] Checking iron v0.5.1 [INFO] [stderr] Checking hyperlocal v0.3.0 [INFO] [stderr] Checking bcrypt v0.1.3 [INFO] [stderr] Checking persistent v0.3.0 [INFO] [stderr] Checking mount v0.3.0 [INFO] [stderr] Checking router v0.5.1 [INFO] [stderr] Checking bodyparser v0.5.0 [INFO] [stderr] Checking staticfile v0.4.0 [INFO] [stderr] Checking urlencoded v0.5.0 [INFO] [stderr] Checking handlebars-iron v0.24.1 [INFO] [stderr] Checking better-than-basic v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/users.rs:49:17 [INFO] [stderr] | [INFO] [stderr] 49 | Users { users: users } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `users` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:27:13 [INFO] [stderr] | [INFO] [stderr] 27 | socket_mode: socket_mode, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `socket_mode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/i18n.rs:43:13 [INFO] [stderr] | [INFO] [stderr] 43 | strings: strings, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `strings` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/i18n.rs:44:13 [INFO] [stderr] | [INFO] [stderr] 44 | errors: errors, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `errors` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/i18n.rs:59:13 [INFO] [stderr] | [INFO] [stderr] 59 | form_data: form_data, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `form_data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/users.rs:49:17 [INFO] [stderr] | [INFO] [stderr] 49 | Users { users: users } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `users` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:27:13 [INFO] [stderr] | [INFO] [stderr] 27 | socket_mode: socket_mode, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `socket_mode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/i18n.rs:43:13 [INFO] [stderr] | [INFO] [stderr] 43 | strings: strings, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `strings` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/i18n.rs:44:13 [INFO] [stderr] | [INFO] [stderr] 44 | errors: errors, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `errors` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/i18n.rs:59:13 [INFO] [stderr] | [INFO] [stderr] 59 | form_data: form_data, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `form_data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:159:13 [INFO] [stderr] | [INFO] [stderr] 159 | / return redirect_with_errors(request, [INFO] [stderr] 160 | | vec![LoginError::UsernameMissing, [INFO] [stderr] 161 | | LoginError::PasswordMissing], [INFO] [stderr] 162 | | redirect) [INFO] [stderr] | |_________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 159 | redirect_with_errors(request, [INFO] [stderr] 160 | vec![LoginError::UsernameMissing, [INFO] [stderr] 161 | LoginError::PasswordMissing], [INFO] [stderr] 162 | redirect) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:165:13 [INFO] [stderr] | [INFO] [stderr] 165 | return redirect_with_errors(request, vec![LoginError::UsernameMissing], redirect) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `redirect_with_errors(request, vec![LoginError::UsernameMissing], redirect)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:168:13 [INFO] [stderr] | [INFO] [stderr] 168 | return redirect_with_errors(request, vec![LoginError::PasswordMissing], redirect) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `redirect_with_errors(request, vec![LoginError::PasswordMissing], redirect)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:175:21 [INFO] [stderr] | [INFO] [stderr] 175 | / return redirect_with_errors(request, [INFO] [stderr] 176 | | vec![LoginError::UsernameNotFound], [INFO] [stderr] 177 | | redirect) [INFO] [stderr] | |_________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 175 | redirect_with_errors(request, [INFO] [stderr] 176 | vec![LoginError::UsernameNotFound], [INFO] [stderr] 177 | redirect) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:180:21 [INFO] [stderr] | [INFO] [stderr] 180 | / return redirect_with_errors(request, [INFO] [stderr] 181 | | vec![LoginError::PasswordIncorrect], [INFO] [stderr] 182 | | redirect) [INFO] [stderr] | |_________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 180 | redirect_with_errors(request, [INFO] [stderr] 181 | vec![LoginError::PasswordIncorrect], [INFO] [stderr] 182 | redirect) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:192:21 [INFO] [stderr] | [INFO] [stderr] 192 | / return match redirect { [INFO] [stderr] 193 | | Some(redirect) => { [INFO] [stderr] 194 | | Ok(Response::with((iron::status::Found, [INFO] [stderr] 195 | | RedirectRaw(redirect), [INFO] [stderr] ... | [INFO] [stderr] 203 | | } [INFO] [stderr] 204 | | }; [INFO] [stderr] | |______________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 192 | match redirect { [INFO] [stderr] 193 | Some(redirect) => { [INFO] [stderr] 194 | Ok(Response::with((iron::status::Found, [INFO] [stderr] 195 | RedirectRaw(redirect), [INFO] [stderr] 196 | Header(SetCookie(vec![cookie]))))) [INFO] [stderr] 197 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:159:13 [INFO] [stderr] | [INFO] [stderr] 159 | / return redirect_with_errors(request, [INFO] [stderr] 160 | | vec![LoginError::UsernameMissing, [INFO] [stderr] 161 | | LoginError::PasswordMissing], [INFO] [stderr] 162 | | redirect) [INFO] [stderr] | |_________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 159 | redirect_with_errors(request, [INFO] [stderr] 160 | vec![LoginError::UsernameMissing, [INFO] [stderr] 161 | LoginError::PasswordMissing], [INFO] [stderr] 162 | redirect) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:165:13 [INFO] [stderr] | [INFO] [stderr] 165 | return redirect_with_errors(request, vec![LoginError::UsernameMissing], redirect) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `redirect_with_errors(request, vec![LoginError::UsernameMissing], redirect)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:168:13 [INFO] [stderr] | [INFO] [stderr] 168 | return redirect_with_errors(request, vec![LoginError::PasswordMissing], redirect) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `redirect_with_errors(request, vec![LoginError::PasswordMissing], redirect)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:175:21 [INFO] [stderr] | [INFO] [stderr] 175 | / return redirect_with_errors(request, [INFO] [stderr] 176 | | vec![LoginError::UsernameNotFound], [INFO] [stderr] 177 | | redirect) [INFO] [stderr] | |_________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 175 | redirect_with_errors(request, [INFO] [stderr] 176 | vec![LoginError::UsernameNotFound], [INFO] [stderr] 177 | redirect) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:180:21 [INFO] [stderr] | [INFO] [stderr] 180 | / return redirect_with_errors(request, [INFO] [stderr] 181 | | vec![LoginError::PasswordIncorrect], [INFO] [stderr] 182 | | redirect) [INFO] [stderr] | |_________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 180 | redirect_with_errors(request, [INFO] [stderr] 181 | vec![LoginError::PasswordIncorrect], [INFO] [stderr] 182 | redirect) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:192:21 [INFO] [stderr] | [INFO] [stderr] 192 | / return match redirect { [INFO] [stderr] 193 | | Some(redirect) => { [INFO] [stderr] 194 | | Ok(Response::with((iron::status::Found, [INFO] [stderr] 195 | | RedirectRaw(redirect), [INFO] [stderr] ... | [INFO] [stderr] 203 | | } [INFO] [stderr] 204 | | }; [INFO] [stderr] | |______________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 192 | match redirect { [INFO] [stderr] 193 | Some(redirect) => { [INFO] [stderr] 194 | Ok(Response::with((iron::status::Found, [INFO] [stderr] 195 | RedirectRaw(redirect), [INFO] [stderr] 196 | Header(SetCookie(vec![cookie]))))) [INFO] [stderr] 197 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a BTreeMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/i18n.rs:53:39 [INFO] [stderr] | [INFO] [stderr] 53 | .map(|e| (e.get_field(), *self.errors.get(&e).unwrap())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.errors[&e]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/errors.rs:25:33 [INFO] [stderr] | [INFO] [stderr] 25 | pub fn from_strings(errors: &Vec) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/errors.rs:29:21 [INFO] [stderr] | [INFO] [stderr] 29 | pub fn to_query(errors: Vec) -> String { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/listener.rs:24:29 [INFO] [stderr] | [INFO] [stderr] 24 | if path.starts_with("/") { [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: this pattern takes a reference on something that is being de-referenced [INFO] [stderr] --> src/main.rs:70:14 [INFO] [stderr] | [INFO] [stderr] 70 | Some(&ref cookie_header) => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try removing the `&ref` part and just keep: `cookie_header` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_borrowed_reference)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:131:23 [INFO] [stderr] | [INFO] [stderr] 131 | fn one_or_none(value: &Vec) -> Option { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a BTreeMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/i18n.rs:53:39 [INFO] [stderr] | [INFO] [stderr] 53 | .map(|e| (e.get_field(), *self.errors.get(&e).unwrap())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.errors[&e]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/errors.rs:25:33 [INFO] [stderr] | [INFO] [stderr] 25 | pub fn from_strings(errors: &Vec) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/errors.rs:29:21 [INFO] [stderr] | [INFO] [stderr] 29 | pub fn to_query(errors: Vec) -> String { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/listener.rs:24:29 [INFO] [stderr] | [INFO] [stderr] 24 | if path.starts_with("/") { [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: this pattern takes a reference on something that is being de-referenced [INFO] [stderr] --> src/main.rs:70:14 [INFO] [stderr] | [INFO] [stderr] 70 | Some(&ref cookie_header) => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try removing the `&ref` part and just keep: `cookie_header` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_borrowed_reference)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:131:23 [INFO] [stderr] | [INFO] [stderr] 131 | fn one_or_none(value: &Vec) -> Option { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 51.61s [INFO] running `"docker" "inspect" "fffda4c2031cb0749885381ebb681996a1cc4db873bf0d5b4b7cad43b4c9e89f"` [INFO] running `"docker" "rm" "-f" "fffda4c2031cb0749885381ebb681996a1cc4db873bf0d5b4b7cad43b4c9e89f"` [INFO] [stdout] fffda4c2031cb0749885381ebb681996a1cc4db873bf0d5b4b7cad43b4c9e89f