[INFO] updating cached repository zhenhuanlee/ha
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/zhenhuanlee/ha
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/zhenhuanlee/ha" "work/ex/clippy-test-run/sources/stable/gh/zhenhuanlee/ha"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/zhenhuanlee/ha'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/zhenhuanlee/ha" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/zhenhuanlee/ha"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/zhenhuanlee/ha'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 3361d4e9a7b1b8a6c7e410c9c40e7b0bcdbfd31e
[INFO] sha for GitHub repo zhenhuanlee/ha: 3361d4e9a7b1b8a6c7e410c9c40e7b0bcdbfd31e
[INFO] validating manifest of zhenhuanlee/ha on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of zhenhuanlee/ha on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing zhenhuanlee/ha
[INFO] finished frobbing zhenhuanlee/ha
[INFO] frobbed toml for zhenhuanlee/ha written to work/ex/clippy-test-run/sources/stable/gh/zhenhuanlee/ha/Cargo.toml
[INFO] started frobbing zhenhuanlee/ha
[INFO] finished frobbing zhenhuanlee/ha
[INFO] frobbed toml for zhenhuanlee/ha written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/zhenhuanlee/ha/Cargo.toml
[INFO] crate zhenhuanlee/ha has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting zhenhuanlee/ha against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/zhenhuanlee/ha:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 7c9a1aa167c60e0590c815ac2cfb8c9fa0b837109ebb8e2e9a583e58e5c87f88
[INFO] running `"docker" "start" "-a" "7c9a1aa167c60e0590c815ac2cfb8c9fa0b837109ebb8e2e9a583e58e5c87f88"`
[INFO] [stderr]    Compiling version_check v0.1.4
[INFO] [stderr]     Checking cfg-if v0.1.5
[INFO] [stderr]     Checking byteorder v1.2.4
[INFO] [stderr]     Checking futures v0.1.23
[INFO] [stderr]    Compiling cc v1.0.19
[INFO] [stderr]     Checking lazycell v0.6.0
[INFO] [stderr]    Compiling pkg-config v0.3.13
[INFO] [stderr]    Compiling string_cache_shared v0.3.0
[INFO] [stderr]    Compiling openssl v0.9.24
[INFO] [stderr]    Compiling serde v1.0.72
[INFO] [stderr]    Compiling unicode-xid v0.0.4
[INFO] [stderr]    Compiling httparse v1.3.2
[INFO] [stderr]     Checking matches v0.1.7
[INFO] [stderr]    Compiling rustc-serialize v0.3.24
[INFO] [stderr]    Compiling quote v0.3.15
[INFO] [stderr]     Checking mac v0.1.1
[INFO] [stderr]     Checking try-lock v0.1.0
[INFO] [stderr]    Compiling ryu v0.2.4
[INFO] [stderr]     Checking safemem v0.2.0
[INFO] [stderr]     Checking lazy_static v0.2.11
[INFO] [stderr]     Checking precomputed-hash v0.1.1
[INFO] [stderr]     Checking utf-8 v0.7.4
[INFO] [stderr]     Checking scoped-tls v0.1.2
[INFO] [stderr]     Checking bit-vec v0.4.4
[INFO] [stderr]     Checking itoa v0.4.2
[INFO] [stderr]    Compiling rand v0.4.3
[INFO] [stderr]     Checking unreachable v0.1.1
[INFO] [stderr]     Checking crossbeam-utils v0.3.2
[INFO] [stderr]     Checking net2 v0.2.33
[INFO] [stderr]     Checking log v0.4.4
[INFO] [stderr]     Checking encoding_rs v0.8.6
[INFO] [stderr]    Compiling unicase v1.4.2
[INFO] [stderr]    Compiling lazy_static v1.1.0
[INFO] [stderr]    Compiling unicase v2.1.0
[INFO] [stderr]     Checking unicode-bidi v0.3.4
[INFO] [stderr]    Compiling synom v0.11.3
[INFO] [stderr]     Checking base64 v0.9.2
[INFO] [stderr]     Checking bytes v0.4.9
[INFO] [stderr]     Checking uuid v0.6.5
[INFO] [stderr]     Checking new_debug_unreachable v1.0.1
[INFO] [stderr]     Checking debug_unreachable v0.1.1
[INFO] [stderr]     Checking bit-set v0.4.0
[INFO] [stderr]    Compiling openssl-sys v0.9.35
[INFO] [stderr]     Checking log v0.3.9
[INFO] [stderr]     Checking mio v0.6.15
[INFO] [stderr]     Checking tokio-executor v0.1.3
[INFO] [stderr]     Checking relay v0.1.1
[INFO] [stderr]     Checking futures-cpupool v0.1.8
[INFO] [stderr]     Checking tokio-service v0.1.0
[INFO] [stderr]     Checking want v0.0.4
[INFO] [stderr]     Checking futf v0.1.4
[INFO] [stderr]     Checking idna v0.1.5
[INFO] [stderr]    Compiling syn v0.11.11
[INFO] [stderr]     Checking tokio-io v0.1.7
[INFO] [stderr]     Checking tokio-timer v0.2.5
[INFO] [stderr]     Checking tendril v0.3.1
[INFO] [stderr]     Checking phf_shared v0.7.22
[INFO] [stderr]     Checking libflate v0.1.16
[INFO] [stderr]     Checking crossbeam-epoch v0.4.3
[INFO] [stderr]     Checking url v1.7.1
[INFO] [stderr]     Checking phf v0.7.22
[INFO] [stderr]    Compiling phf_generator v0.7.22
[INFO] [stderr]     Checking tokio-codec v0.1.0
[INFO] [stderr]     Checking tokio-reactor v0.1.3
[INFO] [stderr]     Checking crossbeam-deque v0.3.1
[INFO] [stderr]    Compiling string_cache_codegen v0.4.1
[INFO] [stderr]    Compiling phf_codegen v0.7.22
[INFO] [stderr]     Checking mime v0.3.9
[INFO] [stderr]    Compiling mime_guess v2.0.0-alpha.6
[INFO] [stderr]     Checking tokio-threadpool v0.1.5
[INFO] [stderr]     Checking tokio-tcp v0.1.1
[INFO] [stderr]     Checking tokio-udp v0.1.1
[INFO] [stderr]    Compiling string_cache v0.6.2
[INFO] [stderr]    Compiling markup5ever v0.3.2
[INFO] [stderr]     Checking tokio-fs v0.1.3
[INFO] [stderr]     Checking tokio v0.1.7
[INFO] [stderr]    Compiling html5ever v0.18.0
[INFO] [stderr]     Checking tokio-core v0.1.17
[INFO] [stderr]     Checking native-tls v0.1.5
[INFO] [stderr]     Checking tokio-tls v0.1.4
[INFO] [stderr]     Checking hyper v0.11.27
[INFO] [stderr]     Checking serde_json v1.0.26
[INFO] [stderr]     Checking serde_urlencoded v0.5.3
[INFO] [stderr]     Checking hyper-tls v0.1.4
[INFO] [stderr]     Checking reqwest v0.8.8
[INFO] [stderr]     Checking select v0.4.2
[INFO] [stderr]     Checking hi1024 v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/thread_pool/lib.rs:34:7
[INFO] [stderr]    |
[INFO] [stderr] 34 |       sender: sender,
[INFO] [stderr]    |       ^^^^^^^^^^^^^^ help: replace it with: `sender`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/thread_pool/lib.rs:74:7
[INFO] [stderr]    |
[INFO] [stderr] 74 |       id: id,
[INFO] [stderr]    |       ^^^^^^ help: replace it with: `id`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/thread_pool/lib.rs:75:7
[INFO] [stderr]    |
[INFO] [stderr] 75 |       thread: thread,
[INFO] [stderr]    |       ^^^^^^^^^^^^^^ help: replace it with: `thread`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/thread_pool/lib.rs:34:7
[INFO] [stderr]    |
[INFO] [stderr] 34 |       sender: sender,
[INFO] [stderr]    |       ^^^^^^^^^^^^^^ help: replace it with: `sender`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/thread_pool/lib.rs:74:7
[INFO] [stderr]    |
[INFO] [stderr] 74 |       id: id,
[INFO] [stderr]    |       ^^^^^^ help: replace it with: `id`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/thread_pool/lib.rs:75:7
[INFO] [stderr]    |
[INFO] [stderr] 75 |       thread: thread,
[INFO] [stderr]    |       ^^^^^^^^^^^^^^ help: replace it with: `thread`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `PoisonError`
[INFO] [stderr]  --> src/thread_pool/lib.rs:5:29
[INFO] [stderr]   |
[INFO] [stderr] 5 | use std::sync::{Mutex, Arc, PoisonError, mpsc};
[INFO] [stderr]   |                             ^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `PoisonError`
[INFO] [stderr]  --> src/thread_pool/lib.rs:5:29
[INFO] [stderr]   |
[INFO] [stderr] 5 | use std::sync::{Mutex, Arc, PoisonError, mpsc};
[INFO] [stderr]   |                             ^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]   --> src/thread_pool/lib.rs:45:9
[INFO] [stderr]    |
[INFO] [stderr] 45 |     let mut is_working = Box::new(false);
[INFO] [stderr]    |         ----^^^^^^^^^^
[INFO] [stderr]    |         |
[INFO] [stderr]    |         help: remove this `mut`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_mut)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]   --> src/thread_pool/lib.rs:45:9
[INFO] [stderr]    |
[INFO] [stderr] 45 |     let mut is_working = Box::new(false);
[INFO] [stderr]    |         ----^^^^^^^^^^
[INFO] [stderr]    |         |
[INFO] [stderr]    |         help: remove this `mut`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_mut)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/thread_pool/lib.rs:82:20
[INFO] [stderr]    |
[INFO] [stderr] 82 | fn save_image(src: &String) -> Result<(), Box<Error>> {
[INFO] [stderr]    |                    ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/thread_pool/lib.rs:82:20
[INFO] [stderr]    |
[INFO] [stderr] 82 | fn save_image(src: &String) -> Result<(), Box<Error>> {
[INFO] [stderr]    |                    ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/thread_pool/lib.rs:96:27
[INFO] [stderr]    |
[INFO] [stderr] 96 |     let fname = src.split("/").last().unwrap();
[INFO] [stderr]    |                           ^^^ help: try using a char instead: `'/'`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: The function/method `write_all` doesn't need a mutable reference
[INFO] [stderr]    --> src/thread_pool/lib.rs:100:20
[INFO] [stderr]     |
[INFO] [stderr] 100 |     file.write_all(&mut buff)?;
[INFO] [stderr]     |                    ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unnecessary_mut_passed)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/thread_pool/lib.rs:96:27
[INFO] [stderr]    |
[INFO] [stderr] 96 |     let fname = src.split("/").last().unwrap();
[INFO] [stderr]    |                           ^^^ help: try using a char instead: `'/'`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: The function/method `write_all` doesn't need a mutable reference
[INFO] [stderr]    --> src/thread_pool/lib.rs:100:20
[INFO] [stderr]     |
[INFO] [stderr] 100 |     file.write_all(&mut buff)?;
[INFO] [stderr]     |                    ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unnecessary_mut_passed)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/main.rs:19:28
[INFO] [stderr]    |
[INFO] [stderr] 19 |     let arr = config.split(";").collect::<Vec<&str>>();
[INFO] [stderr]    |                            ^^^ help: try using a char instead: `';'`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: use of a blacklisted/placeholder name `foo`
[INFO] [stderr]   --> src/main.rs:33:17
[INFO] [stderr]    |
[INFO] [stderr] 33 |             let foo = format!("{}&page={}", url, i);
[INFO] [stderr]    |                 ^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::blacklisted_name)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/main.rs:19:28
[INFO] [stderr]    |
[INFO] [stderr] 19 |     let arr = config.split(";").collect::<Vec<&str>>();
[INFO] [stderr]    |                            ^^^ help: try using a char instead: `';'`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: use of a blacklisted/placeholder name `foo`
[INFO] [stderr]   --> src/main.rs:33:17
[INFO] [stderr]    |
[INFO] [stderr] 33 |             let foo = format!("{}&page={}", url, i);
[INFO] [stderr]    |                 ^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::blacklisted_name)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 1m 09s
[INFO] running `"docker" "inspect" "7c9a1aa167c60e0590c815ac2cfb8c9fa0b837109ebb8e2e9a583e58e5c87f88"`
[INFO] running `"docker" "rm" "-f" "7c9a1aa167c60e0590c815ac2cfb8c9fa0b837109ebb8e2e9a583e58e5c87f88"`
[INFO] [stdout] 7c9a1aa167c60e0590c815ac2cfb8c9fa0b837109ebb8e2e9a583e58e5c87f88