[INFO] updating cached repository zhangsoledad/lmdb_test [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/zhangsoledad/lmdb_test [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/zhangsoledad/lmdb_test" "work/ex/clippy-test-run/sources/stable/gh/zhangsoledad/lmdb_test"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/zhangsoledad/lmdb_test'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/zhangsoledad/lmdb_test" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/zhangsoledad/lmdb_test"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/zhangsoledad/lmdb_test'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 8269d7b73a989da8ccdcbebb734cd51f372b037f [INFO] sha for GitHub repo zhangsoledad/lmdb_test: 8269d7b73a989da8ccdcbebb734cd51f372b037f [INFO] validating manifest of zhangsoledad/lmdb_test on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of zhangsoledad/lmdb_test on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing zhangsoledad/lmdb_test [INFO] finished frobbing zhangsoledad/lmdb_test [INFO] frobbed toml for zhangsoledad/lmdb_test written to work/ex/clippy-test-run/sources/stable/gh/zhangsoledad/lmdb_test/Cargo.toml [INFO] started frobbing zhangsoledad/lmdb_test [INFO] finished frobbing zhangsoledad/lmdb_test [INFO] frobbed toml for zhangsoledad/lmdb_test written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/zhangsoledad/lmdb_test/Cargo.toml [INFO] crate zhangsoledad/lmdb_test has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting zhangsoledad/lmdb_test against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/zhangsoledad/lmdb_test:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 8a99db9e85a11ba7f7d0827e72b9dc0cd394d317d805d88c944fa4520879ff0f [INFO] running `"docker" "start" "-a" "8a99db9e85a11ba7f7d0827e72b9dc0cd394d317d805d88c944fa4520879ff0f"` [INFO] [stderr] Compiling pkg-config v0.3.9 [INFO] [stderr] Compiling gcc v0.3.53 [INFO] [stderr] Compiling rayon-core v1.2.1 [INFO] [stderr] Checking either v1.1.0 [INFO] [stderr] Checking scopeguard v0.3.2 [INFO] [stderr] Checking libc v0.2.30 [INFO] [stderr] Checking futures v0.1.15 [INFO] [stderr] Checking lazy_static v0.2.8 [INFO] [stderr] Checking num-traits v0.1.40 [INFO] [stderr] Checking byteorder v1.1.0 [INFO] [stderr] Checking bitflags v0.9.1 [INFO] [stderr] Checking serde v1.0.11 [INFO] [stderr] Checking coco v0.1.1 [INFO] [stderr] Checking rand v0.3.16 [INFO] [stderr] Checking num_cpus v1.6.2 [INFO] [stderr] Compiling serde_derive v1.0.11 [INFO] [stderr] Compiling lmdb-sys v0.7.1 [INFO] [stderr] Checking tempdir v0.3.5 [INFO] [stderr] Checking lmdb v0.7.1 [INFO] [stderr] Checking rayon v0.8.2 [INFO] [stderr] Checking bincode v0.8.0 [INFO] [stderr] Checking lmdb_test v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lmdb.rs:45:13 [INFO] [stderr] | [INFO] [stderr] 45 | env: env, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `env` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lmdb.rs:46:13 [INFO] [stderr] | [INFO] [stderr] 46 | main: main, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `main` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lmdb.rs:47:13 [INFO] [stderr] | [INFO] [stderr] 47 | index: index, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lmdb.rs:45:13 [INFO] [stderr] | [INFO] [stderr] 45 | env: env, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `env` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lmdb.rs:46:13 [INFO] [stderr] | [INFO] [stderr] 46 | main: main, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `main` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lmdb.rs:47:13 [INFO] [stderr] | [INFO] [stderr] 47 | index: index, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:20:30 [INFO] [stderr] | [INFO] [stderr] 20 | let height: Vec<_> = (1..100000).collect(); [INFO] [stderr] | ^^^^^^ help: consider: `100_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:20:30 [INFO] [stderr] | [INFO] [stderr] 20 | let height: Vec<_> = (1..100000).collect(); [INFO] [stderr] | ^^^^^^ help: consider: `100_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unused import: `Cursor` [INFO] [stderr] --> src/lmdb.rs:3:14 [INFO] [stderr] | [INFO] [stderr] 3 | use libmdb::{Cursor, Database, DatabaseFlags, Environment, Transaction, WriteFlags}; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `rayon::prelude` [INFO] [stderr] --> src/main.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | use rayon::prelude::*; [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant `height_key` should have an upper case name such as `HEIGHT_KEY` [INFO] [stderr] --> src/lmdb.rs:6:1 [INFO] [stderr] | [INFO] [stderr] 6 | const height_key: [u8; 1] = [104]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_upper_case_globals)] on by default [INFO] [stderr] [INFO] [stderr] warning: constant `head_key` should have an upper case name such as `HEAD_KEY` [INFO] [stderr] --> src/lmdb.rs:7:1 [INFO] [stderr] | [INFO] [stderr] 7 | const head_key: [u8; 1] = [105]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant `tail_key` should have an upper case name such as `TAIL_KEY` [INFO] [stderr] --> src/lmdb.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | const tail_key: [u8; 1] = [116]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `Cursor` [INFO] [stderr] --> src/lmdb.rs:3:14 [INFO] [stderr] | [INFO] [stderr] 3 | use libmdb::{Cursor, Database, DatabaseFlags, Environment, Transaction, WriteFlags}; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `rayon::prelude` [INFO] [stderr] --> src/main.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | use rayon::prelude::*; [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | db.clear(); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused return value of `std::iter::Iterator::collect` that must be used [INFO] [stderr] --> src/main.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | / height [INFO] [stderr] 23 | | .iter() [INFO] [stderr] 24 | | .map(|height| { db.save_height(*height); }) [INFO] [stderr] 25 | | .collect::>(); [INFO] [stderr] | |______________________________^ [INFO] [stderr] | [INFO] [stderr] = note: if you really need to exhaust the iterator, consider `.for_each(drop)` instead [INFO] [stderr] [INFO] [stderr] warning: you are collect()ing an iterator and throwing away the result. Consider using an explicit for loop to exhaust the iterator [INFO] [stderr] --> src/main.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | / height [INFO] [stderr] 23 | | .iter() [INFO] [stderr] 24 | | .map(|height| { db.save_height(*height); }) [INFO] [stderr] 25 | | .collect::>(); [INFO] [stderr] | |_____________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_collect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_collect [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:24:25 [INFO] [stderr] | [INFO] [stderr] 24 | .map(|height| { db.save_height(*height); }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: constant `height_key` should have an upper case name such as `HEIGHT_KEY` [INFO] [stderr] --> src/lmdb.rs:6:1 [INFO] [stderr] | [INFO] [stderr] 6 | const height_key: [u8; 1] = [104]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_upper_case_globals)] on by default [INFO] [stderr] [INFO] [stderr] warning: constant `head_key` should have an upper case name such as `HEAD_KEY` [INFO] [stderr] --> src/lmdb.rs:7:1 [INFO] [stderr] | [INFO] [stderr] 7 | const head_key: [u8; 1] = [105]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant `tail_key` should have an upper case name such as `TAIL_KEY` [INFO] [stderr] --> src/lmdb.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | const tail_key: [u8; 1] = [116]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | db.clear(); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused return value of `std::iter::Iterator::collect` that must be used [INFO] [stderr] --> src/main.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | / height [INFO] [stderr] 23 | | .iter() [INFO] [stderr] 24 | | .map(|height| { db.save_height(*height); }) [INFO] [stderr] 25 | | .collect::>(); [INFO] [stderr] | |______________________________^ [INFO] [stderr] | [INFO] [stderr] = note: if you really need to exhaust the iterator, consider `.for_each(drop)` instead [INFO] [stderr] [INFO] [stderr] warning: you are collect()ing an iterator and throwing away the result. Consider using an explicit for loop to exhaust the iterator [INFO] [stderr] --> src/main.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | / height [INFO] [stderr] 23 | | .iter() [INFO] [stderr] 24 | | .map(|height| { db.save_height(*height); }) [INFO] [stderr] 25 | | .collect::>(); [INFO] [stderr] | |_____________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_collect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_collect [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:24:25 [INFO] [stderr] | [INFO] [stderr] 24 | .map(|height| { db.save_height(*height); }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 28.58s [INFO] running `"docker" "inspect" "8a99db9e85a11ba7f7d0827e72b9dc0cd394d317d805d88c944fa4520879ff0f"` [INFO] running `"docker" "rm" "-f" "8a99db9e85a11ba7f7d0827e72b9dc0cd394d317d805d88c944fa4520879ff0f"` [INFO] [stdout] 8a99db9e85a11ba7f7d0827e72b9dc0cd394d317d805d88c944fa4520879ff0f