[INFO] updating cached repository zhangkaizhao/repos
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/zhangkaizhao/repos
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/zhangkaizhao/repos" "work/ex/clippy-test-run/sources/stable/gh/zhangkaizhao/repos"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/zhangkaizhao/repos'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/zhangkaizhao/repos" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/zhangkaizhao/repos"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/zhangkaizhao/repos'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 6164b25c81b4cf4a134c356cd7b200dab4369573
[INFO] sha for GitHub repo zhangkaizhao/repos: 6164b25c81b4cf4a134c356cd7b200dab4369573
[INFO] validating manifest of zhangkaizhao/repos on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of zhangkaizhao/repos on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing zhangkaizhao/repos
[INFO] finished frobbing zhangkaizhao/repos
[INFO] frobbed toml for zhangkaizhao/repos written to work/ex/clippy-test-run/sources/stable/gh/zhangkaizhao/repos/Cargo.toml
[INFO] started frobbing zhangkaizhao/repos
[INFO] finished frobbing zhangkaizhao/repos
[INFO] frobbed toml for zhangkaizhao/repos written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/zhangkaizhao/repos/Cargo.toml
[INFO] crate zhangkaizhao/repos has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting zhangkaizhao/repos against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/zhangkaizhao/repos:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 8bce14860c68bafe87d8bc24e44598a0e3a759003e4c4586c34edca342baf630
[INFO] running `"docker" "start" "-a" "8bce14860c68bafe87d8bc24e44598a0e3a759003e4c4586c34edca342baf630"`
[INFO] [stderr]    Compiling proc-macro2 v0.4.13
[INFO] [stderr]    Compiling serde v1.0.71
[INFO] [stderr]     Checking matches v0.1.7
[INFO] [stderr]     Checking unicode-width v0.1.5
[INFO] [stderr]     Checking bitflags v1.0.3
[INFO] [stderr]     Checking strsim v0.7.0
[INFO] [stderr]     Checking vec_map v0.8.1
[INFO] [stderr]     Checking ansi_term v0.11.0
[INFO] [stderr]     Checking rand_core v0.2.1
[INFO] [stderr]     Checking remove_empty_subdirs v0.1.0
[INFO] [stderr]     Checking remove_dir_all v0.5.1
[INFO] [stderr]     Checking atty v0.2.11
[INFO] [stderr]     Checking unicode-bidi v0.3.4
[INFO] [stderr]     Checking textwrap v0.10.0
[INFO] [stderr]     Checking rand v0.5.5
[INFO] [stderr]     Checking clap v2.32.0
[INFO] [stderr]     Checking idna v0.1.5
[INFO] [stderr]    Compiling quote v0.6.6
[INFO] [stderr]    Compiling syn v0.14.8
[INFO] [stderr]     Checking url v1.7.1
[INFO] [stderr]     Checking tempfile v3.0.3
[INFO] [stderr]    Compiling serde_derive v1.0.71
[INFO] [stderr]     Checking toml v0.4.6
[INFO] [stderr]     Checking repos-tool v0.1.4 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/manager.rs:36:21
[INFO] [stderr]    |
[INFO] [stderr] 36 |                     root_dir: root_dir,
[INFO] [stderr]    |                     ^^^^^^^^^^^^^^^^^^ help: replace it with: `root_dir`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/manager.rs:36:21
[INFO] [stderr]    |
[INFO] [stderr] 36 |                     root_dir: root_dir,
[INFO] [stderr]    |                     ^^^^^^^^^^^^^^^^^^ help: replace it with: `root_dir`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded `()`
[INFO] [stderr]   --> src/manager.rs:54:20
[INFO] [stderr]    |
[INFO] [stderr] 54 |             return ();
[INFO] [stderr]    |                    ^^ help: remove the `()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unused_unit)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded `()`
[INFO] [stderr]   --> src/manager.rs:92:28
[INFO] [stderr]    |
[INFO] [stderr] 92 |                     return ();
[INFO] [stderr]    |                            ^^ help: remove the `()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/util.rs:15:21
[INFO] [stderr]    |
[INFO] [stderr] 15 |         Err(err) => return Err(format!("{}", err.to_string())),
[INFO] [stderr]    |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(format!("{}", err.to_string()))`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded `()`
[INFO] [stderr]   --> src/manager.rs:54:20
[INFO] [stderr]    |
[INFO] [stderr] 54 |             return ();
[INFO] [stderr]    |                    ^^ help: remove the `()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unused_unit)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded `()`
[INFO] [stderr]   --> src/manager.rs:92:28
[INFO] [stderr]    |
[INFO] [stderr] 92 |                     return ();
[INFO] [stderr]    |                            ^^ help: remove the `()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/util.rs:15:21
[INFO] [stderr]    |
[INFO] [stderr] 15 |         Err(err) => return Err(format!("{}", err.to_string())),
[INFO] [stderr]    |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(format!("{}", err.to_string()))`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]   --> src/manager.rs:62:21
[INFO] [stderr]    |
[INFO] [stderr] 62 |           let proxy = match use_proxy {
[INFO] [stderr]    |  _____________________^
[INFO] [stderr] 63 | |             true => Some(&self.metadata.proxy),
[INFO] [stderr] 64 | |             false => None,
[INFO] [stderr] 65 | |         };
[INFO] [stderr]    | |_________^ help: consider using an if/else expression: `if use_proxy { Some(&self.metadata.proxy) } else { None }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_bool)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to want to iterate on a map's values
[INFO] [stderr]    --> src/manager.rs:133:26
[INFO] [stderr]     |
[INFO] [stderr] 133 |         for (_, repo) in &self.metadata.repos {
[INFO] [stderr]     |                          ^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::for_kv_map)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map
[INFO] [stderr] help: use the corresponding method
[INFO] [stderr]     |
[INFO] [stderr] 133 |         for repo in self.metadata.repos.values() {
[INFO] [stderr]     |             ^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: use of `or_insert` followed by a function call
[INFO] [stderr]    --> src/manager.rs:266:65
[INFO] [stderr]     |
[INFO] [stderr] 266 |                     let mut _topics = urls_by_topic.entry(&url).or_insert(Vec::new());
[INFO] [stderr]     |                                                                 ^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Vec::new)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]   --> src/manager.rs:62:21
[INFO] [stderr]    |
[INFO] [stderr] 62 |           let proxy = match use_proxy {
[INFO] [stderr]    |  _____________________^
[INFO] [stderr] 63 | |             true => Some(&self.metadata.proxy),
[INFO] [stderr] 64 | |             false => None,
[INFO] [stderr] 65 | |         };
[INFO] [stderr]    | |_________^ help: consider using an if/else expression: `if use_proxy { Some(&self.metadata.proxy) } else { None }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_bool)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to want to iterate on a map's values
[INFO] [stderr]    --> src/manager.rs:133:26
[INFO] [stderr]     |
[INFO] [stderr] 133 |         for (_, repo) in &self.metadata.repos {
[INFO] [stderr]     |                          ^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::for_kv_map)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map
[INFO] [stderr] help: use the corresponding method
[INFO] [stderr]     |
[INFO] [stderr] 133 |         for repo in self.metadata.repos.values() {
[INFO] [stderr]     |             ^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/metadata.rs:76:9
[INFO] [stderr]    |
[INFO] [stderr] 76 | /         match util::validate_repo_url(url) {
[INFO] [stderr] 77 | |             Err(err) => {
[INFO] [stderr] 78 | |                 urls_errors.insert(url.to_string(), err.to_string());
[INFO] [stderr] 79 | |             }
[INFO] [stderr] 80 | |             Ok(_) => {}
[INFO] [stderr] 81 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 76 |         if let Err(err) = util::validate_repo_url(url) {
[INFO] [stderr] 77 |     urls_errors.insert(url.to_string(), err.to_string());
[INFO] [stderr] 78 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]   --> src/util.rs:15:32
[INFO] [stderr]    |
[INFO] [stderr] 15 |         Err(err) => return Err(format!("{}", err.to_string())),
[INFO] [stderr]    |                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: `to_string()` is enough: `err.to_string()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_format)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr]    = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]   --> src/util.rs:23:32
[INFO] [stderr]    |
[INFO] [stderr] 23 |         Err(err) => return Err(format!("{}", err.to_string())),
[INFO] [stderr]    |                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: `to_string()` is enough: `err.to_string()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr]    = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]   --> src/util.rs:39:32
[INFO] [stderr]    |
[INFO] [stderr] 39 |         Err(err) => return Err(format!("{}", err.to_string())),
[INFO] [stderr]    |                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: `to_string()` is enough: `err.to_string()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr]    = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: use of `or_insert` followed by a function call
[INFO] [stderr]    --> src/manager.rs:266:65
[INFO] [stderr]     |
[INFO] [stderr] 266 |                     let mut _topics = urls_by_topic.entry(&url).or_insert(Vec::new());
[INFO] [stderr]     |                                                                 ^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Vec::new)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `vcs::git::Git`
[INFO] [stderr]   --> src/vcs/git.rs:12:5
[INFO] [stderr]    |
[INFO] [stderr] 12 | /     pub fn new() -> Self {
[INFO] [stderr] 13 | |         Git
[INFO] [stderr] 14 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 8  | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `vcs::hg::Hg`
[INFO] [stderr]   --> src/vcs/hg.rs:12:5
[INFO] [stderr]    |
[INFO] [stderr] 12 | /     pub fn new() -> Self {
[INFO] [stderr] 13 | |         Hg
[INFO] [stderr] 14 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 8  | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/vcs/util.rs:9:5
[INFO] [stderr]    |
[INFO] [stderr] 9  | /     match proxy {
[INFO] [stderr] 10 | |         Some(_proxy) => {
[INFO] [stderr] 11 | |             let http_proxy = gen_proxy_url(&_proxy.scheme, &_proxy.host, _proxy.port);
[INFO] [stderr] 12 | |             env_vars.insert("http_proxy".to_string(), http_proxy.clone());
[INFO] [stderr] ...  |
[INFO] [stderr] 15 | |         None => {}
[INFO] [stderr] 16 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 9  |     if let Some(_proxy) = proxy {
[INFO] [stderr] 10 |     let http_proxy = gen_proxy_url(&_proxy.scheme, &_proxy.host, _proxy.port);
[INFO] [stderr] 11 |     env_vars.insert("http_proxy".to_string(), http_proxy.clone());
[INFO] [stderr] 12 |     env_vars.insert("https_proxy".to_string(), http_proxy.clone());
[INFO] [stderr] 13 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/metadata.rs:76:9
[INFO] [stderr]    |
[INFO] [stderr] 76 | /         match util::validate_repo_url(url) {
[INFO] [stderr] 77 | |             Err(err) => {
[INFO] [stderr] 78 | |                 urls_errors.insert(url.to_string(), err.to_string());
[INFO] [stderr] 79 | |             }
[INFO] [stderr] 80 | |             Ok(_) => {}
[INFO] [stderr] 81 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 76 |         if let Err(err) = util::validate_repo_url(url) {
[INFO] [stderr] 77 |     urls_errors.insert(url.to_string(), err.to_string());
[INFO] [stderr] 78 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]   --> src/util.rs:15:32
[INFO] [stderr]    |
[INFO] [stderr] 15 |         Err(err) => return Err(format!("{}", err.to_string())),
[INFO] [stderr]    |                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: `to_string()` is enough: `err.to_string()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_format)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr]    = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]   --> src/util.rs:23:32
[INFO] [stderr]    |
[INFO] [stderr] 23 |         Err(err) => return Err(format!("{}", err.to_string())),
[INFO] [stderr]    |                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: `to_string()` is enough: `err.to_string()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr]    = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]   --> src/util.rs:39:32
[INFO] [stderr]    |
[INFO] [stderr] 39 |         Err(err) => return Err(format!("{}", err.to_string())),
[INFO] [stderr]    |                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: `to_string()` is enough: `err.to_string()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr]    = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `vcs::git::Git`
[INFO] [stderr]   --> src/vcs/git.rs:12:5
[INFO] [stderr]    |
[INFO] [stderr] 12 | /     pub fn new() -> Self {
[INFO] [stderr] 13 | |         Git
[INFO] [stderr] 14 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 8  | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `vcs::hg::Hg`
[INFO] [stderr]   --> src/vcs/hg.rs:12:5
[INFO] [stderr]    |
[INFO] [stderr] 12 | /     pub fn new() -> Self {
[INFO] [stderr] 13 | |         Hg
[INFO] [stderr] 14 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 8  | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/vcs/util.rs:9:5
[INFO] [stderr]    |
[INFO] [stderr] 9  | /     match proxy {
[INFO] [stderr] 10 | |         Some(_proxy) => {
[INFO] [stderr] 11 | |             let http_proxy = gen_proxy_url(&_proxy.scheme, &_proxy.host, _proxy.port);
[INFO] [stderr] 12 | |             env_vars.insert("http_proxy".to_string(), http_proxy.clone());
[INFO] [stderr] ...  |
[INFO] [stderr] 15 | |         None => {}
[INFO] [stderr] 16 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 9  |     if let Some(_proxy) = proxy {
[INFO] [stderr] 10 |     let http_proxy = gen_proxy_url(&_proxy.scheme, &_proxy.host, _proxy.port);
[INFO] [stderr] 11 |     env_vars.insert("http_proxy".to_string(), http_proxy.clone());
[INFO] [stderr] 12 |     env_vars.insert("https_proxy".to_string(), http_proxy.clone());
[INFO] [stderr] 13 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded `()`
[INFO] [stderr]   --> src/bin/cli.rs:69:20
[INFO] [stderr]    |
[INFO] [stderr] 69 |             return ();
[INFO] [stderr]    |                    ^^ help: remove the `()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unused_unit)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded `()`
[INFO] [stderr]   --> src/bin/cli.rs:69:20
[INFO] [stderr]    |
[INFO] [stderr] 69 |             return ();
[INFO] [stderr]    |                    ^^ help: remove the `()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unused_unit)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 40.56s
[INFO] running `"docker" "inspect" "8bce14860c68bafe87d8bc24e44598a0e3a759003e4c4586c34edca342baf630"`
[INFO] running `"docker" "rm" "-f" "8bce14860c68bafe87d8bc24e44598a0e3a759003e4c4586c34edca342baf630"`
[INFO] [stdout] 8bce14860c68bafe87d8bc24e44598a0e3a759003e4c4586c34edca342baf630