[INFO] updating cached repository zgotsch/rs-blockchain [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/zgotsch/rs-blockchain [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/zgotsch/rs-blockchain" "work/ex/clippy-test-run/sources/stable/gh/zgotsch/rs-blockchain"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/zgotsch/rs-blockchain'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/zgotsch/rs-blockchain" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/zgotsch/rs-blockchain"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/zgotsch/rs-blockchain'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 4bea80ea6cb34595ba47d68f2ce429b15334fa96 [INFO] sha for GitHub repo zgotsch/rs-blockchain: 4bea80ea6cb34595ba47d68f2ce429b15334fa96 [INFO] validating manifest of zgotsch/rs-blockchain on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of zgotsch/rs-blockchain on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing zgotsch/rs-blockchain [INFO] finished frobbing zgotsch/rs-blockchain [INFO] frobbed toml for zgotsch/rs-blockchain written to work/ex/clippy-test-run/sources/stable/gh/zgotsch/rs-blockchain/Cargo.toml [INFO] started frobbing zgotsch/rs-blockchain [INFO] finished frobbing zgotsch/rs-blockchain [INFO] frobbed toml for zgotsch/rs-blockchain written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/zgotsch/rs-blockchain/Cargo.toml [INFO] crate zgotsch/rs-blockchain has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting zgotsch/rs-blockchain against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/zgotsch/rs-blockchain:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] cb78dc76f203c07bcf332e43b7c9a628a9a09c46eb807940ed8294bd4bae213c [INFO] running `"docker" "start" "-a" "cb78dc76f203c07bcf332e43b7c9a628a9a09c46eb807940ed8294bd4bae213c"` [INFO] [stderr] Compiling unicode-xid v0.0.4 [INFO] [stderr] Compiling quote v0.3.15 [INFO] [stderr] Compiling gcc v0.3.50 [INFO] [stderr] Checking serde v1.0.8 [INFO] [stderr] Checking byteorder v1.0.0 [INFO] [stderr] Checking num-traits v0.1.37 [INFO] [stderr] Checking getopts v0.2.14 [INFO] [stderr] Checking time v0.1.37 [INFO] [stderr] Compiling synom v0.11.3 [INFO] [stderr] Compiling syn v0.11.11 [INFO] [stderr] Checking base64 v0.5.2 [INFO] [stderr] Compiling rust-crypto v0.2.36 [INFO] [stderr] Compiling serde_derive_internals v0.15.1 [INFO] [stderr] Compiling serde_derive v1.0.8 [INFO] [stderr] Checking bincode v0.8.0 [INFO] [stderr] Checking naivechain-rs v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/connection.rs:19:13 [INFO] [stderr] | [INFO] [stderr] 19 | stream: stream, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `stream` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/block.rs:150:13 [INFO] [stderr] | [INFO] [stderr] 150 | block_num: block_num, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `block_num` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/connection.rs:19:13 [INFO] [stderr] | [INFO] [stderr] 19 | stream: stream, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `stream` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/block.rs:150:13 [INFO] [stderr] | [INFO] [stderr] 150 | block_num: block_num, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `block_num` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/connection.rs:49:13 [INFO] [stderr] | [INFO] [stderr] 49 | return Err(io::Error::new(io::ErrorKind::InvalidData, "Invalid message length")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(io::Error::new(io::ErrorKind::InvalidData, "Invalid message length"))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/connection.rs:58:13 [INFO] [stderr] | [INFO] [stderr] 58 | return Ok(Some(message)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Some(message))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/block.rs:29:9 [INFO] [stderr] | [INFO] [stderr] 29 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/block.rs:40:9 [INFO] [stderr] | [INFO] [stderr] 40 | return BlockData(copy); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `BlockData(copy)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/block.rs:135:5 [INFO] [stderr] | [INFO] [stderr] 135 | return Hash32Byte(output); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Hash32Byte(output)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/block.rs:140:5 [INFO] [stderr] | [INFO] [stderr] 140 | return (spec.sec * 1_000_000_000 + (spec.nsec as i64)) as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(spec.sec * 1_000_000_000 + (spec.nsec as i64)) as u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/connection.rs:49:13 [INFO] [stderr] | [INFO] [stderr] 49 | return Err(io::Error::new(io::ErrorKind::InvalidData, "Invalid message length")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(io::Error::new(io::ErrorKind::InvalidData, "Invalid message length"))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/connection.rs:58:13 [INFO] [stderr] | [INFO] [stderr] 58 | return Ok(Some(message)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Some(message))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/block.rs:29:9 [INFO] [stderr] | [INFO] [stderr] 29 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/block.rs:40:9 [INFO] [stderr] | [INFO] [stderr] 40 | return BlockData(copy); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `BlockData(copy)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/block.rs:135:5 [INFO] [stderr] | [INFO] [stderr] 135 | return Hash32Byte(output); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Hash32Byte(output)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/block.rs:140:5 [INFO] [stderr] | [INFO] [stderr] 140 | return (spec.sec * 1_000_000_000 + (spec.nsec as i64)) as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(spec.sec * 1_000_000_000 + (spec.nsec as i64)) as u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/block.rs:120:9 [INFO] [stderr] | [INFO] [stderr] 120 | let mut buf = &mut [0; 8]; [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `next_message_size` [INFO] [stderr] --> src/connection.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | next_message_size: Option, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/connection.rs:33:9 [INFO] [stderr] | [INFO] [stderr] 33 | self.stream.write(&size_buf)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/connection.rs:36:9 [INFO] [stderr] | [INFO] [stderr] 36 | self.stream.write(&serialized)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: slow zero-filling initialization [INFO] [stderr] --> src/connection.rs:54:13 [INFO] [stderr] | [INFO] [stderr] 53 | let mut msg_buf = Vec::with_capacity(size as usize); [INFO] [stderr] | --------------------------------- help: consider replace allocation with: `vec![0; size as usize]` [INFO] [stderr] 54 | msg_buf.resize(size as usize, 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::slow_vector_initialization)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#slow_vector_initialization [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/message.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | NewBlock(Block), [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::large_enum_variant)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] | [INFO] [stderr] 7 | NewBlock(Box), [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `copy` [INFO] [stderr] --> src/block.rs:37:18 [INFO] [stderr] | [INFO] [stderr] 37 | for i in 0..1024 { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 37 | for (i, ) in copy.iter_mut().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/block.rs:37:18 [INFO] [stderr] | [INFO] [stderr] 37 | for i in 0..1024 { [INFO] [stderr] | ^^^^^^^ help: try replacing the loop by: `copy[..1024].clone_from_slice(&self.0[..1024])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::manual_memcpy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/block.rs:82:26 [INFO] [stderr] | [INFO] [stderr] 82 | for i in 0..1024 { [INFO] [stderr] | ^^^^^^^ help: try replacing the loop by: `data[..1024].clone_from_slice(&v[..1024])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/block.rs:120:9 [INFO] [stderr] | [INFO] [stderr] 120 | let mut buf = &mut [0; 8]; [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `next_message_size` [INFO] [stderr] --> src/connection.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | next_message_size: Option, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/block.rs:140:40 [INFO] [stderr] | [INFO] [stderr] 140 | return (spec.sec * 1_000_000_000 + (spec.nsec as i64)) as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `i64::from(spec.nsec)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/connection.rs:33:9 [INFO] [stderr] | [INFO] [stderr] 33 | self.stream.write(&size_buf)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/connection.rs:36:9 [INFO] [stderr] | [INFO] [stderr] 36 | self.stream.write(&serialized)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/block.rs:188:20 [INFO] [stderr] | [INFO] [stderr] 188 | pub fn check_chain<'a>(chain: &[Block]) -> bool { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: slow zero-filling initialization [INFO] [stderr] --> src/connection.rs:54:13 [INFO] [stderr] | [INFO] [stderr] 53 | let mut msg_buf = Vec::with_capacity(size as usize); [INFO] [stderr] | --------------------------------- help: consider replace allocation with: `vec![0; size as usize]` [INFO] [stderr] 54 | msg_buf.resize(size as usize, 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::slow_vector_initialization)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#slow_vector_initialization [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/message.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | NewBlock(Block), [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::large_enum_variant)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] | [INFO] [stderr] 7 | NewBlock(Box), [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `naivechain-rs`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: the loop variable `i` is used to index `copy` [INFO] [stderr] --> src/block.rs:37:18 [INFO] [stderr] | [INFO] [stderr] 37 | for i in 0..1024 { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 37 | for (i, ) in copy.iter_mut().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/block.rs:37:18 [INFO] [stderr] | [INFO] [stderr] 37 | for i in 0..1024 { [INFO] [stderr] | ^^^^^^^ help: try replacing the loop by: `copy[..1024].clone_from_slice(&self.0[..1024])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::manual_memcpy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/block.rs:82:26 [INFO] [stderr] | [INFO] [stderr] 82 | for i in 0..1024 { [INFO] [stderr] | ^^^^^^^ help: try replacing the loop by: `data[..1024].clone_from_slice(&v[..1024])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/block.rs:140:40 [INFO] [stderr] | [INFO] [stderr] 140 | return (spec.sec * 1_000_000_000 + (spec.nsec as i64)) as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `i64::from(spec.nsec)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/block.rs:188:20 [INFO] [stderr] | [INFO] [stderr] 188 | pub fn check_chain<'a>(chain: &[Block]) -> bool { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `naivechain-rs`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "cb78dc76f203c07bcf332e43b7c9a628a9a09c46eb807940ed8294bd4bae213c"` [INFO] running `"docker" "rm" "-f" "cb78dc76f203c07bcf332e43b7c9a628a9a09c46eb807940ed8294bd4bae213c"` [INFO] [stdout] cb78dc76f203c07bcf332e43b7c9a628a9a09c46eb807940ed8294bd4bae213c