[INFO] updating cached repository zerovolts/rust-chat [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/zerovolts/rust-chat [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/zerovolts/rust-chat" "work/ex/clippy-test-run/sources/stable/gh/zerovolts/rust-chat"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/zerovolts/rust-chat'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/zerovolts/rust-chat" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/zerovolts/rust-chat"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/zerovolts/rust-chat'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 334cd14c9719c6d039b62c9c6285564237769ad3 [INFO] sha for GitHub repo zerovolts/rust-chat: 334cd14c9719c6d039b62c9c6285564237769ad3 [INFO] validating manifest of zerovolts/rust-chat on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of zerovolts/rust-chat on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing zerovolts/rust-chat [INFO] finished frobbing zerovolts/rust-chat [INFO] frobbed toml for zerovolts/rust-chat written to work/ex/clippy-test-run/sources/stable/gh/zerovolts/rust-chat/Cargo.toml [INFO] started frobbing zerovolts/rust-chat [INFO] finished frobbing zerovolts/rust-chat [INFO] frobbed toml for zerovolts/rust-chat written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/zerovolts/rust-chat/Cargo.toml [INFO] crate zerovolts/rust-chat has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting zerovolts/rust-chat against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/zerovolts/rust-chat:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 91b89a5d37324379ae6134a041141fb0f685d4054b8862045895c6e646396a14 [INFO] running `"docker" "start" "-a" "91b89a5d37324379ae6134a041141fb0f685d4054b8862045895c6e646396a14"` [INFO] [stderr] Checking rust-chat v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused import: `Write` [INFO] [stderr] --> src/server.rs:3:21 [INFO] [stderr] | [INFO] [stderr] 3 | use std::io::{Read, Write}; [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `TcpListener` [INFO] [stderr] --> src/client.rs:1:16 [INFO] [stderr] | [INFO] [stderr] 1 | use std::net::{TcpListener, TcpStream}; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused imports: `Arc`, `Mutex` [INFO] [stderr] --> src/client.rs:2:17 [INFO] [stderr] | [INFO] [stderr] 2 | use std::sync::{Arc, Mutex}; [INFO] [stderr] | ^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `Read` [INFO] [stderr] --> src/client.rs:3:15 [INFO] [stderr] | [INFO] [stderr] 3 | use std::io::{Read, Write}; [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused imports: `thread`, `time` [INFO] [stderr] --> src/client.rs:4:11 [INFO] [stderr] | [INFO] [stderr] 4 | use std::{thread, time}; [INFO] [stderr] | ^^^^^^ ^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `e` [INFO] [stderr] --> src/server.rs:32:21 [INFO] [stderr] | [INFO] [stderr] 32 | Err(e) => () [INFO] [stderr] | ^ help: consider using `_e` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/server.rs:37:22 [INFO] [stderr] | [INFO] [stderr] 37 | fn handle_client(mut stream: Arc>) { [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `address` [INFO] [stderr] --> src/server.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | address: String, [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `messages` [INFO] [stderr] --> src/server.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | messages: Vec [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `address` [INFO] [stderr] --> src/client.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | address: String, [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `Write` [INFO] [stderr] --> src/server.rs:3:21 [INFO] [stderr] | [INFO] [stderr] 3 | use std::io::{Read, Write}; [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `TcpListener` [INFO] [stderr] --> src/client.rs:1:16 [INFO] [stderr] | [INFO] [stderr] 1 | use std::net::{TcpListener, TcpStream}; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused imports: `Arc`, `Mutex` [INFO] [stderr] --> src/client.rs:2:17 [INFO] [stderr] | [INFO] [stderr] 2 | use std::sync::{Arc, Mutex}; [INFO] [stderr] | ^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `Read` [INFO] [stderr] --> src/client.rs:3:15 [INFO] [stderr] | [INFO] [stderr] 3 | use std::io::{Read, Write}; [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused imports: `thread`, `time` [INFO] [stderr] --> src/client.rs:4:11 [INFO] [stderr] | [INFO] [stderr] 4 | use std::{thread, time}; [INFO] [stderr] | ^^^^^^ ^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/server.rs:39:9 [INFO] [stderr] | [INFO] [stderr] 39 | stream.lock().unwrap().read_to_string(&mut buffer); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/client.rs:25:9 [INFO] [stderr] | [INFO] [stderr] 25 | self.stream.write(String::from(message).as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused variable: `e` [INFO] [stderr] --> src/server.rs:32:21 [INFO] [stderr] | [INFO] [stderr] 32 | Err(e) => () [INFO] [stderr] | ^ help: consider using `_e` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/server.rs:37:22 [INFO] [stderr] | [INFO] [stderr] 37 | fn handle_client(mut stream: Arc>) { [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `address` [INFO] [stderr] --> src/server.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | address: String, [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `messages` [INFO] [stderr] --> src/server.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | messages: Vec [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `address` [INFO] [stderr] --> src/client.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | address: String, [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/server.rs:39:9 [INFO] [stderr] | [INFO] [stderr] 39 | stream.lock().unwrap().read_to_string(&mut buffer); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/client.rs:25:9 [INFO] [stderr] | [INFO] [stderr] 25 | self.stream.write(String::from(message).as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.40s [INFO] running `"docker" "inspect" "91b89a5d37324379ae6134a041141fb0f685d4054b8862045895c6e646396a14"` [INFO] running `"docker" "rm" "-f" "91b89a5d37324379ae6134a041141fb0f685d4054b8862045895c6e646396a14"` [INFO] [stdout] 91b89a5d37324379ae6134a041141fb0f685d4054b8862045895c6e646396a14